What steps will reproduce the problem?
1. simple case: create ICE session between hosts with same local IPs, but in different networks
1. real case: router return ICMP error packets when we try establish direct connection

What is the expected result?
established connection by p2p or relay

What do you see instead?
relay phase not work properly after errors in direct stage.
stun packets delivered to viewer and remote host application layer, but not processed.

What version of the product are you using? On what operating system? windows


Please provide any additional information below.

Attached icmp_problem.7z file contain: 
1. wireshark log for problem session.
2. host side log with errors corresponding to ICMP  
... ERROR:chromium_socket_factory.cc(xxx)] Received error when reading from UDP socket: -101

problem:
ICMP packet on direct phase disables UdpPacketSocket::OnReadCompleted handler. 
In the next stages we can only send packets, but can not dispatch/read packets

possible fix:

...\chromium\src\remoting\protocol\chromium_socket_factory.cc

void UdpPacketSocket::OnReadCompleted(int result) {
  HandleReadResult(result);
  if (result >= 0) {
    DoRead();
  }
  // Fix UDP, ICMP error packets (Destination Unreachable,  Time Exceeded) 
  // Ignore this errors for UDP
  //    WSAECONNRESET: (10054) Port Unreachable
  //    WSAENETRESET: (10052)  Related to keep-alive (TTL)
  if (result == net::ERR_CONNECTION_RESET) {
    //LOG(ERROR) << "===> [Error] skip, Received error when reading from UDP socket ERR_CONNECTION_RESET (re call DoRead): " << result << " , local addr:" << GetLocalAddress().ToString();
    DoRead();
  }
}
 

Deleted: icmp_problem.7z 2.5 MB

icmp_problem.7z 2.5 MB Download