New issue
Advanced search Search tips

Issue 845667 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 848345
issue 848346



Sign in to add a comment

Change "luci is prod" to "make luci prod" and automatically set next safe build num

Project Member Reported by hinoka@chromium.org, May 22 2018

Issue description

It'd be easier if luci-migration automatically sets next safe build when flipping luci to prod.



 

Comment 1 by no...@chromium.org, May 22 2018

Cc: no...@chromium.org jchin...@chromium.org

Comment 2 by efoo@chromium.org, May 22 2018

It would be good to add a tooltip or comment next to the label to detail what happens when "Make LUCI prod" is checked. 

Comment 3 by efoo@chromium.org, May 22 2018

Labels: LUCI-Backlog

Comment 4 by hinoka@chromium.org, May 29 2018

Owner: hinoka@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6fcefb7833bff21dad7ad5c8a8eba6a3fdbadf2a

commit 6fcefb7833bff21dad7ad5c8a8eba6a3fdbadf2a
Author: Ryan Tseng <hinoka@google.com>
Date: Wed May 30 18:26:57 2018

[luci-migration] Set next build number when flipping luci to prod

Also:
* Add a basic Makefile

Bug:  845667 
Change-Id: Iba08dddf6e22ede21d0ce06f98dcda63d68c103f
Reviewed-on: https://chromium-review.googlesource.com/1077196
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[add] https://crrev.com/6fcefb7833bff21dad7ad5c8a8eba6a3fdbadf2a/go/src/infra/appengine/luci-migration/Makefile
[modify] https://crrev.com/6fcefb7833bff21dad7ad5c8a8eba6a3fdbadf2a/go/src/infra/appengine/luci-migration/app/builder.go

Project Member

Comment 6 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/512a50442703af7dbec098cc8b097c89f9425875

commit 512a50442703af7dbec098cc8b097c89f9425875
Author: Ryan Tseng <hinoka@google.com>
Date: Wed May 30 19:08:14 2018

[cr-buildbucket] Grant WRITER role to luci-migration

To allow bumping next safe build number.
luci-migration doesn't know which builders use build numbers,
so it bumps the build number regardless of whether or not it is used.

Bug:  845667 
Change-Id: I3f03e42add1fe8329ded0f628cee2d014f61f552
Reviewed-on: https://chromium-review.googlesource.com/1079627
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562947}
[modify] https://crrev.com/512a50442703af7dbec098cc8b097c89f9425875/infra/config/global/cr-buildbucket.cfg

Comment 7 by hinoka@chromium.org, May 30 2018

Status: Fixed (was: Assigned)

Comment 8 by no...@chromium.org, May 30 2018

thank you Ryan!

Comment 9 by hinoka@chromium.org, May 31 2018

Blockedon: 848346 848345
Status: Started (was: Fixed)
There are 3 bugs with this:

* luci-migration's urlfetch request to Milo uses a 5s context timeout, when it should be 55s.
* luci-milo's request contains limit=1, but still asks buildbucket for max_builds=100
* cr-buildbucket took 19s to service https://cr-buildbucket.appspot.com/api/buildbucket/v1/search?alt=json&bucket=luci.chromium.try&fields=%2Cnext_cursor&max_builds=100&tag=builder%3Awin7_chromium_rel_ng which is excessively long.
Project Member

Comment 10 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d3cecc9da98af430f2bd41d8a94f2787ea594563

commit d3cecc9da98af430f2bd41d8a94f2787ea594563
Author: Ryan Tseng <hinoka@google.com>
Date: Thu May 31 20:18:32 2018

[luci-migration] Fix deadline context to Milo

The deadline context which is used by urlfetch is set when the roundtripper is
instantiated, not when the call is made.

Bug:  845667 
Change-Id: Ic590f1f23df4fa1b5411292942bfcc30a8d77147
Reviewed-on: https://chromium-review.googlesource.com/1081097
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/d3cecc9da98af430f2bd41d8a94f2787ea594563/go/src/infra/appengine/luci-migration/app/builder.go

Project Member

Comment 11 by bugdroid1@chromium.org, May 31 2018

Labels: merge-merged-config
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9b024c46798481b3627ee23bd904e96eeea930b3

commit 9b024c46798481b3627ee23bd904e96eeea930b3
Author: Ryan Tseng <hinoka@google.com>
Date: Thu May 31 23:19:51 2018

[cr-buildbucket] Grant WRITER to luci-migration

To allow setting next_safe

Bug:  845667 
Change-Id: Ibb6c4174490509fed5a78f7852a7e49eb2096f29
Reviewed-on: https://chromium-review.googlesource.com/1081566
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/9b024c46798481b3627ee23bd904e96eeea930b3/cr-buildbucket.cfg

Comment 12 by no...@chromium.org, Jun 15 2018

Cc: tandrii@chromium.org
 Issue 833924  has been merged into this issue.

Comment 13 by no...@chromium.org, Jun 15 2018

Status: Fixed (was: Started)

Sign in to add a comment