New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845661 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"FakeVideoCaptureDeviceDescriptorTest.CanUseSecondRequestedProxy" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 22 2018

Issue description

"FakeVideoCaptureDeviceDescriptorTest.CanUseSecondRequestedProxy" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySgsSBUZsYWtlIj9GYWtlVmlkZW9DYXB0dXJlRGV2aWNlRGVzY3JpcHRvclRlc3QuQ2FuVXNlU2Vjb25kUmVxdWVzdGVkUHJveHkM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by yutak@chromium.org, May 23 2018

Output:

[ RUN      ] FakeVideoCaptureDeviceDescriptorTest.CanUseSecondRequestedProxy
[28985:29091:0522/165926.724317:19978245035:INFO:service_process_launcher.cc(199)] Launched child process pid=29100, instance=, name=video_capture, user_id=15d77904-2505-43d1-89db-e1d279a1b374
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: OnStarted()
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
Fontconfig warning: "/etc/fonts/fonts.conf", line 146: blank doesn't take any effect anymore. please remove it from your fonts.conf
GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: OnLog(@0x7ffdade3cb18 "Pixel format: PIXEL_FORMAT_I420")
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
../../services/video_capture/test/fake_device_descriptor_unittest.cc:118: Failure
Mock function called more times than expected - returning directly.
    Function call: DoOnNewBuffer(1, 0x7ffdade3cb50)
         Expected: to be called once
           Actual: called twice - over-saturated and active
Stack trace:
#0 0x000003b6319f (/b/s/w/ir/out/Release/services_unittests+0x3b6319e)
<snip -- the stack trace is not symbolized for some reason; not very useful>

Comment 2 by yutak@chromium.org, May 23 2018

Cc: emir...@chromium.org mcasas@chromium.org chfremer@chromium.org
Components: Blink>GetUserMedia

Comment 3 by yutak@chromium.org, May 23 2018

I'm going to disable this test for now.
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f3582d67cd15896e0ca6e5385da7972b21b2e95

commit 7f3582d67cd15896e0ca6e5385da7972b21b2e95
Author: Yuta Kitamura <yutak@chromium.org>
Date: Wed May 23 06:42:25 2018

Disable flaky test FakeVideoCaptureDeviceDescriptorTest.CanUseSecondRequestedProxy.

TBR=jbroman@chromium.org

Bug:  845661 
Change-Id: Ief62b072b1b27213d3402afcf9f47a6cfc9b5aea
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1070012
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560971}
[modify] https://crrev.com/7f3582d67cd15896e0ca6e5385da7972b21b2e95/services/video_capture/test/fake_device_descriptor_unittest.cc

Comment 5 by yutak@chromium.org, May 23 2018

Labels: -Pri-1 Pri-2
The test is disabled. Now we want to find the owner of this.

CCed folks, can anyone own this?

Comment 6 by gab@chromium.org, May 23 2018

Owner: roc...@chromium.org
Status: Assigned (was: Untriaged)
@rockot for triage (per TODO(rockot) on test description)

Comment 7 by gab@chromium.org, May 23 2018

Labels: -Sheriff-Chromium
-Sheriff-Chromium
Project Member

Comment 8 by chromium...@appspot.gserviceaccount.com, May 23 2018

Labels: Sheriff-Chromium
Detected 4 new flakes for test/step "FakeVideoCaptureDeviceDescriptorTest.CanUseSecondRequestedProxy". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySgsSBUZsYWtlIj9GYWtlVmlkZW9DYXB0dXJlRGV2aWNlRGVzY3JpcHRvclRlc3QuQ2FuVXNlU2Vjb25kUmVxdWVzdGVkUHJveHkM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 9 by gab@chromium.org, May 24 2018

Labels: -Sheriff-Chromium
Test is disabled, dropping from sheriffs queue
Project Member

Comment 10 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f91054938f6b323f97bdd910599268cefcd2500

commit 7f91054938f6b323f97bdd910599268cefcd2500
Author: Christian Fremerey <chfremer@chromium.org>
Date: Wed May 30 18:44:06 2018

[Video capture] Fix and re-enable flaky test FakeVideoCaptureDeviceDescriptorTest.CanUseSecondRequestedProxy

Cause for the flakiness was an overly restrictive expectation on a mock.

Bug:  845661 
Change-Id: I17708f956c1b201a5d08593d50bea71282944653
Reviewed-on: https://chromium-review.googlesource.com/1079322
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562932}
[modify] https://crrev.com/7f91054938f6b323f97bdd910599268cefcd2500/services/video_capture/test/fake_device_descriptor_unittest.cc

Status: Fixed (was: Assigned)
[bulk-edit: disregard if N/A] Can the owner please set milestone to this bug if applicable?

Sign in to add a comment