New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845649 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Extensions WebUI toolbar shim needs updating after MD Refresh.

Project Member Reported by dpa...@chromium.org, May 22 2018

Issue description

Repro steps (also see screencast):
1) Go to chrome://extensions,
2) Turn on developer mode.
3) refresh the page.

A blue toolbar is flashing, before the actual content loads, which has a half-blue, half-white toolbar.

This happens because the toolbar shim used at [1] while the page is still loading has not been updated after latest toolbar updates (and assumes a fully blue toolbar).

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/md_extensions/extensions.html?l=20-23
 
toolbar_shim.mp4
374 KB View Download

Comment 1 by aee@chromium.org, Jun 4 2018

Cc: -aee@chromium.org
Owner: aee@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/493a70a7eafa9b766ad6f80ee7ce769f00ee3611

commit 493a70a7eafa9b766ad6f80ee7ce769f00ee3611
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Tue Jun 05 18:31:32 2018

Extensions: while loading show toolbar colors

Bug:  845649 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I428ad217cd4475b89c8941a32ff60a6ca16cdb52
Reviewed-on: https://chromium-review.googlesource.com/1086277
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564588}
[modify] https://crrev.com/493a70a7eafa9b766ad6f80ee7ce769f00ee3611/chrome/browser/resources/md_extensions/extensions.html
[modify] https://crrev.com/493a70a7eafa9b766ad6f80ee7ce769f00ee3611/chrome/browser/resources/md_extensions/toolbar.html

Comment 3 by aee@chromium.org, Jun 5 2018

Status: Fixed (was: Started)

Sign in to add a comment