Loading indicator on-content refinement |
||||||||
Issue descriptionM-68 as of May 22: The on-content loading indicator has landed. In testing on a standalone, the following could use attention: 1. The bar is thin (vertically). The bar height matches corner radius of content, but it might benefit from being thicker. 2. The GVR quad-layer approach for content appears to misalign the bottom edges of content and the indicator. A sliver of content is visible under the bar. It might be good to apply a miniscule -Y offset to the indicator, to have it cover that gap. 3. A UX spec for the colors is needed. Currently, the background track is semi transparent. 4. If the background is indeed semi-transparent, then the proposed offset in (2) may instead show a sliver of background.
,
May 22 2018
Actually, even without the thickness bump, the shift works wonders.
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4068942fe6061b56e270d74ee5284f1c069e018d commit 4068942fe6061b56e270d74ee5284f1c069e018d Author: Christopher Grant <cjgrant@chromium.org> Date: Wed May 23 15:20:40 2018 VR: Apply a tiny vertical offset to the loading indicator This change gets rid of visual artifacts between content and the loading indicator, which are drawn on different layers. In a standalone headset, sometimes, a thin sliver of content would be visible under the bar, which is very distracting. This offset eliminates that effect. BUG= 845644 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Id247e50620d9e9fb6ddde221dc69dfbbbf24eeeb Reviewed-on: https://chromium-review.googlesource.com/1069605 Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#561090} [modify] https://crrev.com/4068942fe6061b56e270d74ee5284f1c069e018d/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/4068942fe6061b56e270d74ee5284f1c069e018d/chrome/browser/vr/ui_scene_creator.cc
,
May 23 2018
I'll assign this to Gordon once the results are in Canary.
,
May 23 2018
Also of note - chromatic aberration also creates blue (and other colored) artifacts around the bottom edges of elements. This can look like the loading indicator, and vice-versa.
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e919e58b0f122f2a46ce0eec23525e2abadbdccb commit e919e58b0f122f2a46ce0eec23525e2abadbdccb Author: Christopher Grant <cjgrant@chromium.org> Date: Fri Jun 01 22:40:46 2018 VR: Incorporate new spec for loading bar size and color BUG= 845644 R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I18251087fb978ebe7c04485e14c48ec7d8696602 Reviewed-on: https://chromium-review.googlesource.com/1083342 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#563839} [modify] https://crrev.com/e919e58b0f122f2a46ce0eec23525e2abadbdccb/chrome/browser/vr/model/color_scheme.cc [modify] https://crrev.com/e919e58b0f122f2a46ce0eec23525e2abadbdccb/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/e919e58b0f122f2a46ce0eec23525e2abadbdccb/chrome/browser/vr/ui_scene_creator.cc
,
Jun 4 2018
,
Jun 4 2018
Please mark impacted OS's.
,
Jun 4 2018
,
Jun 5 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/322a4db8b3a6d43fe8f2270e2bfebcd39439a7cb commit 322a4db8b3a6d43fe8f2270e2bfebcd39439a7cb Author: Christopher Grant <cjgrant@chromium.org> Date: Tue Jun 05 13:18:09 2018 VR: Incorporate new spec for loading bar size and color BUG= 845644 R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I18251087fb978ebe7c04485e14c48ec7d8696602 Reviewed-on: https://chromium-review.googlesource.com/1083342 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563839}(cherry picked from commit e919e58b0f122f2a46ce0eec23525e2abadbdccb) Reviewed-on: https://chromium-review.googlesource.com/1086773 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#185} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/322a4db8b3a6d43fe8f2270e2bfebcd39439a7cb/chrome/browser/vr/model/color_scheme.cc [modify] https://crrev.com/322a4db8b3a6d43fe8f2270e2bfebcd39439a7cb/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/322a4db8b3a6d43fe8f2270e2bfebcd39439a7cb/chrome/browser/vr/ui_scene_creator.cc
,
Jun 5 2018
,
Jun 13 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by cjgrant@chromium.org
, May 22 2018