New issue
Advanced search Search tips

Issue 845635 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 840017



Sign in to add a comment

[BlinkGenPropertyTrees] fast/events/scroll-visual-viewport-send-boundary-events.html failing

Project Member Reported by smcgruer@chromium.org, May 22 2018

Issue description

Newly added test that crashes under BlinkGenPropertyTrees:

STDERR: [1:1:0522/164021.217571:FATAL:layer_tree_impl.cc(852)] Check failed: layer_list_.empty() || *page_scale_factor == 1. 
STDERR: #0 0x7f8c6dae8b7c base::debug::StackTrace::StackTrace()
STDERR: #1 0x7f8c6da296db logging::LogMessage::~LogMessage()
STDERR: #2 0x7f8c6b66c0b9 cc::LayerTreeImpl::PushPageScaleFactorAndLimits()
STDERR: #3 0x7f8c6b66e74c cc::LayerTreeImpl::PushPageScaleFromMainThread()
STDERR: #4 0x7f8c6b6452d8 cc::LayerTreeHost::PushLayerTreePropertiesTo()
STDERR: #5 0x7f8c6b6449c4 cc::LayerTreeHost::FinishCommitOnImplThread()
STDERR: #6 0x7f8c6b6a060b cc::SingleThreadProxy::DoCommit()
STDERR: #7 0x7f8c6b6a2a32 cc::SingleThreadProxy::CompositeImmediately()
STDERR: #8 0x7f8c6b646f8a cc::LayerTreeHost::Composite()


Assign to pdr@ to triage, probably part of another existing BlinkGenPropertyTrees bug.

 

Comment 1 by pdr@chromium.org, May 22 2018

Blocking: 836910
Cc: bokan@chromium.org pdr@chromium.org
Owner: ----
Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30059b3ff300383194f4b5cebcc11a3bf27c8142

commit 30059b3ff300383194f4b5cebcc11a3bf27c8142
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Tue May 22 21:17:32 2018

Mark new crashing LayoutTest for BlinkGenPropertyTrees

Bug:  845635 
Change-Id: Icba301d9411ebd5d74033c20dcbf8f46108b8342
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees
Reviewed-on: https://chromium-review.googlesource.com/1067648
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560779}
[modify] https://crrev.com/30059b3ff300383194f4b5cebcc11a3bf27c8142/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees

Comment 3 by bokan@chromium.org, Jun 11 2018

Summary: [BlinkGenPropertyTrees] fast/events/scroll-visual-viewport-send-boundary-events.html failing (was: [BlinkGenPropertyTrees] fast/events/scroll-visual-viewport-send-boundary-events.html crashes)
The crash is due to the fact that the visual viewport layers aren't hooked up yet. My patch fixes the crash but the test still fails :(

Lets use this bug to track fixing it once the visual viewport patch lands.

Comment 4 by bokan@chromium.org, Jun 19 2018

Blocking: -836910

Comment 5 by bokan@chromium.org, Jun 19 2018

Blocking: 840017
Status: WontFix (was: Available)
Test seems to be passing now, expectation was removed in: https://crrev.com/d4f1fbf316863b208c474624e02c16d989dbef26

Sign in to add a comment