New issue
Advanced search Search tips

Issue 845614 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Distinguish between payload_signature and metadata_signature

Project Member Reported by ahass...@chromium.org, May 22 2018

Issue description

Currently in some places 'signature' is used instead of 'payload_signature'. Clean them up.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7f6749d371858cb146e502480e5ce43c513e7c4b

commit 7f6749d371858cb146e502480e5ce43c513e7c4b
Author: Amin Hassani <ahassani@chromium.org>
Date: Tue Jun 05 00:23:28 2018

paygen: Rename signature variables

Rename '-signature_file' flag sent to delta_generator to
'-payload_signature_file' to know exactly this is intended for the payload and
not the metadata.

BUG= chromium:845614 
TEST=paygen tryjobs
CQ-DEPEND=CL:1069527

Change-Id: I2f3ab3a89cbd021bced335a8e84be8bdf339b087
Reviewed-on: https://chromium-review.googlesource.com/1069530
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/7f6749d371858cb146e502480e5ce43c513e7c4b/lib/paygen/paygen_payload_lib_unittest.py
[modify] https://crrev.com/7f6749d371858cb146e502480e5ce43c513e7c4b/lib/paygen/paygen_payload_lib.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/b4778293c31e2e16f60c245e2a2cf3f63151d52d

commit b4778293c31e2e16f60c245e2a2cf3f63151d52d
Author: Amin Hassani <ahassani@chromium.org>
Date: Tue Jun 05 00:23:28 2018

update_engine: Rename signing variables.

Rename 'signatures' to 'payload_signatures' so there is a clear distinction
between metadata and payload signatures and their input files.

BUG= chromium:845614 
TEST=payload tryjobs
CQ-DEPEND=CL:1069530

Change-Id: Ic2e924871611af1b1f0ee2f1dfd7c6b9f52decc8
Reviewed-on: https://chromium-review.googlesource.com/1069527
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>

[modify] https://crrev.com/b4778293c31e2e16f60c245e2a2cf3f63151d52d/payload_consumer/delta_performer_integration_test.cc
[modify] https://crrev.com/b4778293c31e2e16f60c245e2a2cf3f63151d52d/payload_generator/generate_delta_main.cc
[modify] https://crrev.com/b4778293c31e2e16f60c245e2a2cf3f63151d52d/scripts/brillo_update_payload

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cc6e786d406aea1df1526cbe9c65b4e15afb8a7

commit 7cc6e786d406aea1df1526cbe9c65b4e15afb8a7
Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jun 05 01:55:33 2018

Roll src/third_party/chromite 9665e37..84e4547 (6 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/9665e37..84e4547


git log 9665e37..84e4547 --date=short --no-merges --format='%ad %ae %s'
2018-06-05 dhanyaganesh@google.com 'tar: file changed as we read it' fix
2018-06-05 ayatane@chromium.org chromeos-infra-go-pre-cq: New build config
2018-06-05 dgarrett@google.com config_stages: Handle multiple config locations.
2018-06-05 ahassani@chromium.org paygen: Rename signature variables
2018-06-05 bmgordon@chromium.org cros_sdk: Remove unused toolchain overlay support
2018-06-05 dats@google.com cros-disks: FUSE daemons are not in chronos-access anymore.


Created with:
  gclient setdep -r src/third_party/chromite@84e4547

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:547055,chromium:845337, chromium:848020 , chromium:845614 ,chromium:845174, chromium:841119 
TBR=chrome-os-gardeners@chromium.org

Change-Id: I04ea4de88cd62923087594cce649f787b3b251b4
Reviewed-on: https://chromium-review.googlesource.com/1086328
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#564344}
[modify] https://crrev.com/7cc6e786d406aea1df1526cbe9c65b4e15afb8a7/DEPS

Status: Fixed (was: Started)

Sign in to add a comment