New issue
Advanced search Search tips

Issue 845613 link

Starred by 2 users
Status: Fixed
Owner:
smcgruer@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 836897



Sign in to add a comment

[BlinkGenPropertyTrees] DocumentAnimations::UpdateAnimations is called twice

Project Member Reported by smcgruer@chromium.org, May 22 2018 
Currently for BlinkGenPropertyTrees, we call DocumentAnimations::UpdateAnimations in two places:

LocalFrameView::UpdateLifecyclePhasesInternal
  PaintLayerCompositor::UpdateIfNeededRecursive
    PaintLayerCompositor::UpdateIfNeededRecursiveInternal
      DocumentAnimations::UpdateAnimations

LocalFrameView::UpdateLifecyclePhasesInternal
  DocumentAnimations::UpdateAnimations 

The first is from the SPv1 days, the latter is SPv2. From a discussion with chrishtr@ and pdr@, we should be following the SPv2 model for BlinKGenPropertyTrees since it also does non-drawable layer culling.
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d4b496fb58d979f8b511519e93f8c6284f7bf25

commit 5d4b496fb58d979f8b511519e93f8c6284f7bf25
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Wed May 23 17:09:47 2018

BlinkGenPropertyTrees: Only call DocumentAnimations::UpdateAnimations once

Before this CL we were calling DocumentAnimations::UpdateAnimations
twice for BlinkGenPropertyTrees; once during compositing and once during
paint. Because BlinkGenPropertyTrees uses the same non-drawable layer
elimination as SPv2, it should use the latter callsite.

Bug: 836897,  845613 
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia9a725285f14cc5e0b085d83ebb047d4d96d16bb
Reviewed-on: https://chromium-review.googlesource.com/1068626
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561129}
[modify] https://crrev.com/5d4b496fb58d979f8b511519e93f8c6284f7bf25/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/5d4b496fb58d979f8b511519e93f8c6284f7bf25/third_party/blink/renderer/core/animation/animation.cc
[modify] https://crrev.com/5d4b496fb58d979f8b511519e93f8c6284f7bf25/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc

Comment 2 by smcgruer@chromium.org, May 23 2018

Status: Fixed (was: Started)
►

Sign in to add a comment