New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845605 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

2% regression in smoothness.tough_scrolling_cases at 558208:558310

Project Member Reported by ajuma@chromium.org, May 22 2018

Issue description

mean_pixels_checkerboarded regressed by ~2% on Nexus 5:
https://chromeperf.appspot.com/report?sid=8207bc3e5f1bcf5128baf7e64bf8b857005049e14707bbface31f4999289710d

Kicking off a bisect.

 
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, May 23 2018

Cc: yiyix@chromium.org
Owner: yiyix@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12d4bbec240000

Fix Regression: Black patch is seen while opening new page by yiyix@chromium.org
https://chromium.googlesource.com/chromium/src/+/6a4ede3e8b19101ba5b1735e0a2178b9541a21a3

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 3 by ajuma@chromium.org, May 23 2018

Components: Internals>Compositing
Labels: -Type-Bug -Pri-3 ReleaseBlock-Stable M-67 OS-Android Pri-1 Type-Bug-Regression
There's also a regression in UMA in Compositing.RenderPass.AppendQuadData.CheckerboardedNeedRasterContentArea in Android Canary around the same time period.
Cc: fsam...@chromium.org
yiyix@ is OOO right now, cc'ing fsamuel@ for probably knowing best of what happened in that CL.

Comment 5 by yiyix@chromium.org, May 24 2018

this bug is fixed in this patch: https://chromium-review.googlesource.com/c/chromium/src/+/1067147

Could you let me know if it is still an issue? Thank you.

Comment 6 by cma...@chromium.org, May 24 2018

Please verify and confirm as soon as possible

Comment 7 by ajuma@chromium.org, May 24 2018

Status: Fixed (was: Assigned)
It looks like performance improved with the fix in #5, but there might have been a second regression in the meanwhile (from some other CL). I'll open another bug to bisect that.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-67; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-67 label, otherwise remove Merge-TBD label. Thanks.

Comment 9 by ajuma@chromium.org, May 24 2018

Status: Assigned (was: Fixed)
The regression happened in M67 and the fix landed in M68, so this does need a merge. yiyix@, please make sure this gets merged either on this bug or on one of the other bugs associated with the CL from #5.

Comment 10 by yiyix@chromium.org, May 25 2018

The problematic cl, Fix Regression: Black patch is seen while opening new page, is landed on May 14th and the branch cut date for M67 is April 12th. Could you double check if this regression happened in M67? If that is the case, other cl may have cause the regression.

Comment 11 by ajuma@chromium.org, May 25 2018

Labels: -Merge-TBD -M-67 M-68
Status: Fixed (was: Assigned)
I'm so sorry, I somehow misread the branch date calendar and thought May 14 was still during M67!
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.

Comment 13 by ajuma@chromium.org, May 25 2018

Labels: -Merge-TBD

Sign in to add a comment