New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845598 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 843511



Sign in to add a comment

vr_common_unittests fail on msan due to reading uninit memory

Project Member Reported by thakis@chromium.org, May 22 2018

Issue description

will happen on try runs for https://chromium-review.googlesource.com/c/chromium/src/+/1069228 (feel free to take over that cl and land it!), but here's a preview of what will happen: 
https://ci.chromium.org/buildbot/chromium.clang/ToTLinuxMSan/2557

failures:
UiTest.VoiceSearchHiddenWhenCantAskForPermission
UiTest.VoiceSearchHiddenInIncognito
UiTest.ControllerLabels
UiTest.UiModeVoiceSearchFromOmnibox
UiTest.OmniboxSuggestionBindings
UiTest.UiModeOmniboxEditing
UiTest.VoiceSearchHiddenWhenContentCapturingAudio
UiTest.OmniboxSuggestionNavigates



[ RUN      ] UiTest.ControllerLabels
==25149==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x194c953 in operator== chrome/browser/vr/model/color_scheme.cc:280:33
    #1 0x194c953 in vr::TextSelectionColors::operator!=(vr::TextSelectionColors const&) const chrome/browser/vr/model/color_scheme.cc:285:0
    #2 0x191ffd2 in SetAndDirty<vr::TextSelectionColors> chrome/browser/vr/elements/ui_texture.h:56:17
    #3 0x191ffd2 in SetSelectionColors chrome/browser/vr/elements/text.cc:273:0
    #4 0x191ffd2 in vr::Text::SetSelectionColors(vr::TextSelectionColors const&) chrome/browser/vr/elements/text.cc:391:0
    #5 0x1a51ae0 in Run base/callback.h:125:12
    #6 0x1a51ae0 in vr::Binding<vr::TextSelectionColors>::Update() chrome/browser/vr/databinding/binding.h:67:0
    #7 0x193a1b0 in vr::UiElement::UpdateBindings() chrome/browser/vr/elements/ui_element.cc:697:18
    #8 0x193a3cb in vr::UiElement::UpdateBindings() chrome/browser/vr/elements/ui_element.cc:707:12
    #9 0x193a3cb in vr::UiElement::UpdateBindings() chrome/browser/vr/elements/ui_element.cc:707:12
    #10 0x193a3cb in vr::UiElement::UpdateBindings() chrome/browser/vr/elements/ui_element.cc:707:12
    #11 0x193a3cb in vr::UiElement::UpdateBindings() chrome/browser/vr/elements/ui_element.cc:707:12
    #12 0x193a3cb in vr::UiElement::UpdateBindings() chrome/browser/vr/elements/ui_element.cc:707:12
    #13 0x193a3cb in vr::UiElement::UpdateBindings() chrome/browser/vr/elements/ui_element.cc:707:12
    #14 0x193a3cb in vr::UiElement::UpdateBindings() chrome/browser/vr/elements/ui_element.cc:707:12
    #15 0x193a3cb in vr::UiElement::UpdateBindings() chrome/browser/vr/elements/ui_element.cc:707:12
    #16 0x19a6785 in vr::UiScene::OnBeginFrame(base::TimeTicks const&, gfx::Transform const&) chrome/browser/vr/ui_scene.cc:149:20
    #17 0x7d0b6e in OnBeginFrame chrome/browser/vr/test/ui_test.cc:225:22
    #18 0x7d0b6e in vr::UiTest::IsVisible(vr::UiElementName) const chrome/browser/vr/test/ui_test.cc:119:0
    #19 0x8c85ff in vr::UiTest_ControllerLabels_Test::TestBody() chrome/browser/vr/ui_unittest.cc:1185:3
    #20 0x182e804 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:0:0
    #21 0x18320f3 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #22 0x1833b39 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #23 0x186ad74 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #24 0x1869627 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:0:0
    #25 0x2da2850 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #26 0x2da2850 in base::TestSuite::Run() base/test/test_suite.cc:275:0
    #27 0x2dacae1 in Run base/callback.h:96:12
    #28 0x2dacae1 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225:0
    #29 0x2dac28e in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #30 0x7cf72e in main chrome/browser/vr/test/run_all_unittests.cc:12:10
    #31 0x7fce35a01f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287:0
    #32 0x519029 in _start ??:0:0
  Uninitialized value was created by a heap allocation
    #0 0x5a94a0 in operator new(unsigned long) /b/c/b/ToTLinuxMSan/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cc:45:0
    #1 0x191f44f in make_unique<vr::TextTexture, vr::Text *> buildtools/third_party/libc++/trunk/include/memory:3114:28
    #2 0x191f44f in vr::Text::Text(float) chrome/browser/vr/elements/text.cc:367:0
    #3 0x192a306 in make_unique<vr::Text, float &> buildtools/third_party/libc++/trunk/include/memory:3114:32
    #4 0x192a306 in vr::TextInput::TextInput(float, base::RepeatingCallback<void (vr::EditedText const&)>) chrome/browser/vr/elements/text_input.cc:36:0
    #5 0x1910c8a in vr::OmniboxTextField::OmniboxTextField(float, base::RepeatingCallback<void (vr::EditedText const&)>, base::RepeatingCallback<void (vr::AutocompleteRequest const&)>, base::RepeatingCallback<void ()>) chrome/browser/vr/elements/omnibox_text_field.cc:15:7
    #6 0x19dfcfe in make_unique<vr::OmniboxTextField, const float &, base::RepeatingCallback<void (const vr::EditedText &)>, base::RepeatingCallback<void (const vr::AutocompleteRequest &)>, base::RepeatingCallback<void ()> > buildtools/third_party/libc++/trunk/include/memory:3114:32
    #7 0x19dfcfe in Create<vr::OmniboxTextField, const float &, base::RepeatingCallback<void (const vr::EditedText &)>, base::RepeatingCallback<void (const vr::AutocompleteRequest &)>, base::RepeatingCallback<void ()> > chrome/browser/vr/ui_scene_creator.cc:137:0
    #8 0x19dfcfe in vr::UiSceneCreator::CreateOmnibox() chrome/browser/vr/ui_scene_creator.cc:2547:0
    #9 0x19af646 in vr::UiSceneCreator::CreateScene() chrome/browser/vr/ui_scene_creator.cc:1061:3
    #10 0x1981391 in vr::Ui::Ui(vr::UiBrowserInterface*, std::__1::unique_ptr<vr::ContentInputDelegate, std::__1::default_delete<vr::ContentInputDelegate> >, vr::KeyboardDelegate*, vr::TextInputDelegate*, vr::AudioDelegate*, vr::UiInitialState const&) chrome/browser/vr/ui.cc:76:8
    #11 0x7cffe5 in make_unique<vr::Ui, vr::MockUiBrowserInterface *, std::__1::unique_ptr<vr::MockContentInputDelegate, std::__1::default_delete<vr::MockContentInputDelegate> >, nullptr_t, nullptr_t, nullptr_t, const vr::UiInitialState &> buildtools/third_party/libc++/trunk/include/memory:3114:32
    #12 0x7cffe5 in vr::UiTest::CreateSceneInternal(vr::UiInitialState const&, std::__1::unique_ptr<vr::MockContentInputDelegate, std::__1::default_delete<vr::MockContentInputDelegate> >) chrome/browser/vr/test/ui_test.cc:84:0
    #13 0x7d07db in vr::UiTest::CreateScene(vr::UiInitialState const&) chrome/browser/vr/test/ui_test.cc:97:3
    #14 0x7d09ac in vr::UiTest::CreateScene(vr::UiTest::InCct, vr::UiTest::InWebVr) chrome/browser/vr/test/ui_test.cc:104:3
    #15 0x8c39a2 in vr::UiTest_ControllerLabels_Test::TestBody() chrome/browser/vr/ui_unittest.cc:1159:3
    #16 0x182e804 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:0:0
    #17 0x18320f3 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2667:11
    #18 0x1833b39 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2785:28
    #19 0x186ad74 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5047:43
    #20 0x1869627 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:0:0
    #21 0x2da2850 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2329:46
    #22 0x2da2850 in base::TestSuite::Run() base/test/test_suite.cc:275:0
    #23 0x2dacae1 in Run base/callback.h:96:12
    #24 0x2dacae1 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:225:0
    #25 0x2dac28e in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:576:10
    #26 0x7cf72e in main chrome/browser/vr/test/run_all_unittests.cc:12:10
SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/vr_common_unittests+0x194c953)
Exiting
 
Cc: -vollick@chromium.org
Owner: vollick@chromium.org
Status: Started (was: Unconfirmed)
I can take a look.
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef8023c1afff76ebedd7e6f1a914eb2f746bd3bc

commit ef8023c1afff76ebedd7e6f1a914eb2f746bd3bc
Author: Ian Vollick <vollick@chromium.org>
Date: Tue May 22 22:08:41 2018

[vr] Initialize some default colors

This CL sets default text colors

Bug:  845598 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Icede912c9fd697341d96a3f99425dc8cf5eb7497
Reviewed-on: https://chromium-review.googlesource.com/1069593
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560805}
[modify] https://crrev.com/ef8023c1afff76ebedd7e6f1a914eb2f746bd3bc/chrome/browser/vr/model/color_scheme.h

Cc: thakis@chromium.org
I've confirmed that the CL in #2 fixes vr_common_unittests under msan. I expect you'll be able to land your CL now. I've kicked off another dry run to be sure.
Project Member

Comment 4 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b91b8360bc71a66c470cbb17dba3b343e88c9f38

commit b91b8360bc71a66c470cbb17dba3b343e88c9f38
Author: Nico Weber <thakis@chromium.org>
Date: Tue May 29 19:37:39 2018

run vr_cmmon_unittests, vr_pixeltests on memory bots

Bug: 843511, 845598 
Change-Id: I17b82fb59da08c5522148d5bf57d8c8bbad9b6d6
Reviewed-on: https://chromium-review.googlesource.com/1069228
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562552}
[modify] https://crrev.com/b91b8360bc71a66c470cbb17dba3b343e88c9f38/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/b91b8360bc71a66c470cbb17dba3b343e88c9f38/testing/buildbot/test_suites.pyl

Status: Fixed (was: Started)

Sign in to add a comment