New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845590 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 809150
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 844597



Sign in to add a comment

Coverage: missing coverage for code that only runs on Windows

Project Member Reported by gab@chromium.org, May 22 2018

Issue description

e.g. https://chromium-coverage.appspot.com/reports/560344/linux/chromium/src/base/task_scheduler/scheduler_worker.cc.html

150 22.6k   if (static_cast<int>(priority_hint_) <
151 22.6k           static_cast<int>(ThreadPriority::NORMAL) &&
152 22.6k       (task_tracker_->HasShutdownStarted() ||
153 0            !PlatformThread::CanIncreaseCurrentThreadPriority())) {
154 0         return ThreadPriority::NORMAL;
155 0       }

We have a test that exercises exactly this : TaskSchedulerWorkerTest.BumpPriorityOfAliveThreadDuringShutdown

but it's only truly exercising the above bits on Windows because the pools are not using ThreadPriority::BACKGROUND priority on POSIX (for other reasons).
 
Mergedinto: 809150
Status: Duplicate (was: Untriaged)
Windows platform support is not started yet, best to track it as part of bug 809150.

Sign in to add a comment