New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 845581 link

Starred by 2 users
Status: Fixed
Owner:
liaoyuke@chromium.org
Closed: Jul 17
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 846469
issue 846487
issue 849462
issue 849826
Blocking:
issue 837855



Sign in to add a comment

Implement the MVP version of the new flake detection

Project Member Reported by liaoyuke@chromium.org, May 22 2018 
the mvp should be capable of:

1. Correctly detection flaky tests using bigquery on CQ.
2. Correctly file bugs to monorail staging.
3. UI to show all detected flaky tests.
4. UI to show flake occurrences for a specific test.
5. UI to search for a specific flaky test.

Comment 1 by liaoyuke@chromium.org, May 24 2018

Blockedon: 846469

Comment 2 by liaoyuke@chromium.org, May 24 2018

Blockedon: 846487
Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2a5f6bd2123732c0074845b306c93e041030f6c1

commit 2a5f6bd2123732c0074845b306c93e041030f6c1
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed May 30 18:56:28 2018

[Findit] Rename a few things in flake detection for clarification.

This CL renames a few things in flake detection to clarify that right
now, the logics only deal with flakes that happened on CQ and caused
false rejections.

Bug:  845581 
Change-Id: I88f63d88502f6ad73fce34ba08b1f1287788cbdf
Reviewed-on: https://chromium-review.googlesource.com/1079528
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/2a5f6bd2123732c0074845b306c93e041030f6c1/appengine/findit/main.py
[modify] https://crrev.com/2a5f6bd2123732c0074845b306c93e041030f6c1/appengine/findit/cron.yaml
[rename] https://crrev.com/2a5f6bd2123732c0074845b306c93e041030f6c1/appengine/findit/handlers/flake/detection/detect_flakes.py

Comment 5 by liaoyuke@chromium.org, Jun 4 2018

Blockedon: 849462

Comment 7 by liaoyuke@chromium.org, Jun 5 2018

Blockedon: 846470

Comment 8 by liaoyuke@chromium.org, Jun 5 2018

Blockedon: 849826
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ac1fff0091ed91205a8709b220a11f8f1140b9c0

commit ac1fff0091ed91205a8709b220a11f8f1140b9c0
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Jun 06 16:01:33 2018

[Findit] Derive normalized_step_name directly from step_name

This CL drives normalized_step_name directly from step_name instead of
relying on test_type.

Running the following query returns 0 proves that deriving
normalized_step_name from step_name is equivalent to deriving from
test_type.

WITH
  step_name_to_test_type AS (
  SELECT
    step_name,
    test_type
  FROM
    `test-results-hrd.events.test_results`
  WHERE
    _PARTITIONTIME >= TIMESTAMP_SUB(CURRENT_TIMESTAMP(), INTERVAL 7 day)
  GROUP BY
    step_name,
    test_type
  ORDER BY
    step_name),

  normalized_step_name_to_test_type AS(
  SELECT
    SPLIT(step_name, " ")[ORDINAL(1)] AS normalized_step_name,
    test_type
  FROM
    step_name_to_test_type)
SELECT
  COUNT(*)
FROM
  normalized_step_name_to_test_type
WHERE
  test_type != normalized_step_name
  AND test_type != CONCAT(normalized_step_name, ' (with patch)')

Bug:  845581 
Change-Id: Ie2e493b2ab6dbd26083f0d68dcd038ff1db1a3dc
Reviewed-on: https://chromium-review.googlesource.com/1087296
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>

[modify] https://crrev.com/ac1fff0091ed91205a8709b220a11f8f1140b9c0/appengine/findit/model/flake/detection/test/flake_occurrence_test.py
[modify] https://crrev.com/ac1fff0091ed91205a8709b220a11f8f1140b9c0/appengine/findit/model/flake/detection/flake.py
[modify] https://crrev.com/ac1fff0091ed91205a8709b220a11f8f1140b9c0/appengine/findit/model/flake/detection/test/flake_test.py
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/712b4e71a9d6072ea9688b4c11fc3e5758120f3a

commit 712b4e71a9d6072ea9688b4c11fc3e5758120f3a
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jun 07 16:25:16 2018

[Findit] Adjust flake detection data models.

This CL makes the following changes to the data models:
1. Move the step_name and test_name to the flake occurrence model, and
   make step_name, test_name, build_id the key of the flake occurrence
   model.
2. Make luci_project, normalized_step_name and normalized_test_name the
   key of the flake model.

The main reason for this change is that it makes it easier to map a
Flake entity to a monorail issue. In the old design, multiple Flake
entities map to one monorail issue, so when decide whether to
create/update bugs, it requires quering mutiple Flake entities and
aggregating the information from all of their children Flake Occurrence
entities, which is expensive and complicate.

In the new design, it's a one-on-one mapping between Flake entity and
monorail issue.

The reason why I didn't go with this approach at first place is that I
thought it's hard to query the ocurrences of a specific pair of
step_name, test_name. After moving step_name and test_name to the
flake occurrence model, it turns out it's easy to do, and it even
allows querying flake occurrences grouping by step_name and test_name.

Bug:  849462 ,  845581 
Change-Id: I91ce0ea3f45a4f23ab073edbe3b90adf5619216c
Reviewed-on: https://chromium-review.googlesource.com/1089115
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/712b4e71a9d6072ea9688b4c11fc3e5758120f3a/appengine/findit/model/flake/detection/test/flake_occurrence_test.py
[modify] https://crrev.com/712b4e71a9d6072ea9688b4c11fc3e5758120f3a/appengine/findit/model/flake/detection/flake.py
[modify] https://crrev.com/712b4e71a9d6072ea9688b4c11fc3e5758120f3a/appengine/findit/model/flake/detection/flake_occurrence.py
[modify] https://crrev.com/712b4e71a9d6072ea9688b4c11fc3e5758120f3a/appengine/findit/model/flake/detection/test/flake_test.py
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6365a870210bc917e8448bf4029a53ba0f104d36

commit 6365a870210bc917e8448bf4029a53ba0f104d36
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jun 07 19:08:18 2018

[Findit] Add timestamp conversion function to bigquery_helper.

This CL adds a timestamp conversion function to the bigquery_helper to
teach it to parse TIMESTAMP type returned from BQ.

Bug:  845581 
Change-Id: Icfc1df3b4d496c16cb2513e24fa6b0e18036f48d
Reviewed-on: https://chromium-review.googlesource.com/1091225
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>

[modify] https://crrev.com/6365a870210bc917e8448bf4029a53ba0f104d36/appengine/findit/services/test/bigquery_helper_test.py
[modify] https://crrev.com/6365a870210bc917e8448bf4029a53ba0f104d36/appengine/findit/services/bigquery_helper.py
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d6955ee602c67a6a232441ce25c68360596c50bb

commit d6955ee602c67a6a232441ce25c68360596c50bb
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Jun 12 05:35:07 2018

[Findit] Add service to detect and store cq false rejection flakes.

This CL adds a service to detect and store cq false rejection flakes.

Bug:  845581 
Change-Id: If1733aa92b32dd439e0132566bcb5b916f77ed8e
Reviewed-on: https://chromium-review.googlesource.com/1094756
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>

[add] https://crrev.com/d6955ee602c67a6a232441ce25c68360596c50bb/appengine/findit/services/flake_detection/test/detect_cq_false_rejection_flakes_test.py
[add] https://crrev.com/d6955ee602c67a6a232441ce25c68360596c50bb/appengine/findit/services/flake_detection/detect_cq_false_rejection_flakes.py
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fd5411c189444fcbd5b6d4a8beb4ce25b93539ec

commit fd5411c189444fcbd5b6d4a8beb4ce25b93539ec
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Jun 12 06:40:17 2018

[Findit] Set up cron jobs for detecting cq false rejection flakes.

This CL sets up cron jobs to trigger tasks for detecting cq false
rejection flakes.

Bug:  845581 
Change-Id: I88191039ac8b5445871dcfac8e593a1f7753ff55
Reviewed-on: https://chromium-review.googlesource.com/1095058
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>

[add] https://crrev.com/fd5411c189444fcbd5b6d4a8beb4ce25b93539ec/appengine/findit/handlers/flake/detection/test/detect_flakes_test.py
[modify] https://crrev.com/fd5411c189444fcbd5b6d4a8beb4ce25b93539ec/appengine/findit/handlers/flake/detection/detect_flakes.py
[modify] https://crrev.com/fd5411c189444fcbd5b6d4a8beb4ce25b93539ec/appengine/findit/module-flake-detection-backend.yaml
[modify] https://crrev.com/fd5411c189444fcbd5b6d4a8beb4ce25b93539ec/appengine/findit/main.py
[modify] https://crrev.com/fd5411c189444fcbd5b6d4a8beb4ce25b93539ec/appengine/findit/queue.yaml
[modify] https://crrev.com/fd5411c189444fcbd5b6d4a8beb4ce25b93539ec/appengine/findit/common/constants.py
[modify] https://crrev.com/fd5411c189444fcbd5b6d4a8beb4ce25b93539ec/appengine/findit/cron.yaml
[modify] https://crrev.com/fd5411c189444fcbd5b6d4a8beb4ce25b93539ec/appengine/findit/services/flake_detection/detect_cq_false_rejection_flakes.py
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/06b3b4e124f123aa1de0329b43e47e5b3c81a719

commit 06b3b4e124f123aa1de0329b43e47e5b3c81a719
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Jun 19 00:03:04 2018

[Findit] Add retry_parameters and update comments.

This CL adds task_retry_limit: 0 to the flake-detection-queue, and
update comments to explain why a task queue is used to detect flakes
instead of just cron jobs.

Bug:  845581 
Change-Id: I3b8e7ef1d9aa1cb8aae4c85349ea296403cf7960
Reviewed-on: https://chromium-review.googlesource.com/1102292
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/06b3b4e124f123aa1de0329b43e47e5b3c81a719/appengine/findit/queue.yaml
[modify] https://crrev.com/06b3b4e124f123aa1de0329b43e47e5b3c81a719/appengine/findit/cron.yaml
[modify] https://crrev.com/06b3b4e124f123aa1de0329b43e47e5b3c81a719/appengine/findit/handlers/flake/detection/detect_flakes.py
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/267c3b4f64e92e4aeb3da8655ead7394a27a281c

commit 267c3b4f64e92e4aeb3da8655ead7394a27a281c
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Wed Jun 20 02:29:22 2018

[Findit] Change test results partition time to 2 days

According to the documentation:
https://cloud.google.com/bigquery/docs/partitioned-tables, partition
time is always the start of each day. So, to make sure we include all
data within the past 24 hours, we should set the partition time to be
greater than the utc timestamp of 48 hours ago. Otherwise, for example,
say right now it's 6-10 5:00AM UTC time, and if we use
'_PARTITIONTIME >= TIMESTAMP_SUB(CURRENT_TIMESTAMP(), INTERVAL 1 day)',
then only the data between 6-10 12:00AM to 6-10 5:00AM is included.

Bug:  845581 
Change-Id: I632d171d237f4e9467a6be748fd061b3780d4c52
Reviewed-on: https://chromium-review.googlesource.com/1100610
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/267c3b4f64e92e4aeb3da8655ead7394a27a281c/appengine/findit/services/flake_detection/flaky_tests.cq_false_rejection.sql
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2b2f2b7eb435229a9a1b7f290fc475a3d2b61cc8

commit 2b2f2b7eb435229a9a1b7f290fc475a3d2b61cc8
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Jun 26 04:38:06 2018

[Findit] Implement rules to create or update bugs.

This CL implements the basic rules to create or update bugs:
1. At most 10 issue in any 24h window.
2. An issue can be created or updated at most once every 24h.
3. At least 3 unreported occurrences with different changes within the past 24h.
4. At least 1 occurrence happened within the past 6h.

Note that this CL doesn't implement any code to actually file the bugs,
it just sets the rules. Code to create or update bugs will be in a
separate CL.

There are other advanced features such as PING the bug, re-open a
closed bug and automatically close a bug. They will be implemented in
separate CLs.

Bug:  845581 
Change-Id: Iaadce06e03443b66e73264d733b3c8f91f1c9a61
Reviewed-on: https://chromium-review.googlesource.com/1105683
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/2b2f2b7eb435229a9a1b7f290fc475a3d2b61cc8/appengine/findit/model/flake/detection/test/flake_occurrence_test.py
[add] https://crrev.com/2b2f2b7eb435229a9a1b7f290fc475a3d2b61cc8/appengine/findit/model/flake/detection/test/flake_issue_test.py
[modify] https://crrev.com/2b2f2b7eb435229a9a1b7f290fc475a3d2b61cc8/appengine/findit/services/flake_detection/flaky_tests.cq_false_rejection.sql
[modify] https://crrev.com/2b2f2b7eb435229a9a1b7f290fc475a3d2b61cc8/appengine/findit/model/flake/detection/flake.py
[modify] https://crrev.com/2b2f2b7eb435229a9a1b7f290fc475a3d2b61cc8/appengine/findit/services/flake_detection/test/detect_cq_false_rejection_flakes_test.py
[add] https://crrev.com/2b2f2b7eb435229a9a1b7f290fc475a3d2b61cc8/appengine/findit/model/flake/detection/flake_issue.py
[modify] https://crrev.com/2b2f2b7eb435229a9a1b7f290fc475a3d2b61cc8/appengine/findit/index.yaml
[add] https://crrev.com/2b2f2b7eb435229a9a1b7f290fc475a3d2b61cc8/appengine/findit/services/flake_detection/test/flake_report_util_test.py
[modify] https://crrev.com/2b2f2b7eb435229a9a1b7f290fc475a3d2b61cc8/appengine/findit/model/flake/detection/flake_occurrence.py
[add] https://crrev.com/2b2f2b7eb435229a9a1b7f290fc475a3d2b61cc8/appengine/findit/services/flake_detection/flake_report_util.py
[modify] https://crrev.com/2b2f2b7eb435229a9a1b7f290fc475a3d2b61cc8/appengine/findit/services/flake_detection/detect_cq_false_rejection_flakes.py

Comment 18 by liaoyuke@chromium.org, Jun 27 2018

Blockedon: 857086
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/67fe8187b430a9d571253d9f6bb5fc4eaee1cc1a

commit 67fe8187b430a9d571253d9f6bb5fc4eaee1cc1a
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Thu Jun 28 13:07:27 2018

[Findit] Add issue tracking services for flake detection.

This CL adds issue tracking services to create and update a bug for
flake detection.

Bug:  845581 
Change-Id: I2d5ba2f372d6784fd7d02b317bedd7bb89b765cf
Reviewed-on: https://chromium-review.googlesource.com/1114939
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/67fe8187b430a9d571253d9f6bb5fc4eaee1cc1a/appengine/findit/services/test/issue_tracking_service_test.py
[modify] https://crrev.com/67fe8187b430a9d571253d9f6bb5fc4eaee1cc1a/appengine/findit/services/issue_tracking_service.py
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8bf57d39ce6154943f2c6c9d8bed17b3737c760e

commit 8bf57d39ce6154943f2c6c9d8bed17b3737c760e
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Mon Jul 02 01:54:30 2018

[Findit] Run flake detection continously on staging.

This CL runs Flake Detection continuously on staging and automatically
files bugs to monorail staging.

Bug:  845581 
Change-Id: If1f6ef0a0b63b2168d6b79340aba2e9af0643654
Reviewed-on: https://chromium-review.googlesource.com/1118399
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>

[modify] https://crrev.com/8bf57d39ce6154943f2c6c9d8bed17b3737c760e/appengine/findit/cron.yaml
[modify] https://crrev.com/8bf57d39ce6154943f2c6c9d8bed17b3737c760e/appengine/findit/handlers/flake/detection/detect_flakes.py
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/76e4cef52e9e16c8ed6fafd88f2632cbe81d1672

commit 76e4cef52e9e16c8ed6fafd88f2632cbe81d1672
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Jul 03 02:22:39 2018

[Findit] Fix app start error in flake detection backend.

This CL is a follow-up to the main split CL to fix typos.
THis CL also adds the numpy library because Flake Detection and Flake
Analyzer share a lot of code and Flake Analyzer depends on numpy.

Bug:  845581 
Change-Id: I45f11f1eca3635d0db8c18d19c6e1a90db23ef28
Reviewed-on: https://chromium-review.googlesource.com/1122031
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>

[modify] https://crrev.com/76e4cef52e9e16c8ed6fafd88f2632cbe81d1672/appengine/findit/module-flake-detection-backend.yaml
Project Member

Comment 24 by bugdroid1@chromium.org, Jul 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bd0f9a60ea9b069159ea31e608c452dedc658981

commit bd0f9a60ea9b069159ea31e608c452dedc658981
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Sun Jul 15 13:27:24 2018

[Findit] Add basic frontend for flake detection MVP.

This CL reuses the previous flake detection UI and makes necessary
changes for the new backend models.

Note that this UI is only for the MVP prototyping. Here is a demo:
https://16459-b0fa349-tainted-liaoyuke-dot-findit-for-me-staging.appspot.com/ui/elements/flake_detection/flake-demo.html

Bug:  845581 
Change-Id: Ief9fbcbdd8ed57fd02d30cd7509aed08d28f4a81
Reviewed-on: https://chromium-review.googlesource.com/1135112
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[add] https://crrev.com/bd0f9a60ea9b069159ea31e608c452dedc658981/appengine/findit/handlers/flake/detection/show_flake.py
[modify] https://crrev.com/bd0f9a60ea9b069159ea31e608c452dedc658981/appengine/findit/dispatch.yaml
[add] https://crrev.com/bd0f9a60ea9b069159ea31e608c452dedc658981/appengine/findit/module-flake-detection-frontend.yaml
[rename] https://crrev.com/bd0f9a60ea9b069159ea31e608c452dedc658981/appengine/findit/templates/flake/detection/show_flake.html
[delete] https://crrev.com/5efe37b7c1bdec59394388fed6f4b3b7af383b08/appengine/findit/ui/elements/detection/flaky-test-demo.html
[delete] https://crrev.com/5efe37b7c1bdec59394388fed6f4b3b7af383b08/appengine/findit/ui/elements/detection/flake-occurrence-demo.html
[rename] https://crrev.com/bd0f9a60ea9b069159ea31e608c452dedc658981/appengine/findit/ui/elements/flake_detection/flake-occurrence.html
[add] https://crrev.com/bd0f9a60ea9b069159ea31e608c452dedc658981/appengine/findit/ui/elements/flake_detection/flake-occurrence-demo.html
[modify] https://crrev.com/bd0f9a60ea9b069159ea31e608c452dedc658981/appengine/findit/frontend_main.py
[add] https://crrev.com/bd0f9a60ea9b069159ea31e608c452dedc658981/appengine/findit/ui/elements/flake_detection/flake-demo.html
[rename] https://crrev.com/bd0f9a60ea9b069159ea31e608c452dedc658981/appengine/findit/ui/elements/flake_detection/flake.html
[add] https://crrev.com/bd0f9a60ea9b069159ea31e608c452dedc658981/appengine/findit/handlers/flake/detection/test/show_flake_test.py
Project Member

Comment 25 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e08aa7af714bbe0cf54d57bdb4e25b8bff0e91d2

commit e08aa7af714bbe0cf54d57bdb4e25b8bff0e91d2
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Jul 17 03:30:57 2018

[Findit] Add index for flake detection frontend.

The flake detection frontend queries CQFalseRejectionFlakeOccurrence
occurrences of a specific flake, so this CL adds corresponding index.

Bug:  845581 
Change-Id: Id7b0cf95ded2cb02a7bd905bd06b9438e3a60008
Reviewed-on: https://chromium-review.googlesource.com/1138593
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>

[modify] https://crrev.com/e08aa7af714bbe0cf54d57bdb4e25b8bff0e91d2/appengine/findit/index.yaml
Project Member

Comment 26 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e9b28f5eb0dd8b7bc98ab330ff6f06f3cd6428db

commit e9b28f5eb0dd8b7bc98ab330ff6f06f3cd6428db
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Jul 17 05:49:08 2018

[Findit] Fix ui element names in show_flake html template file

This CL fixes a naming issue in show_flake html template.

Bug:  845581 
Change-Id: I7ea1a59d32cf39b4fa8760d81d1598009f85ee09
Reviewed-on: https://chromium-review.googlesource.com/1139841
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>

[modify] https://crrev.com/e9b28f5eb0dd8b7bc98ab330ff6f06f3cd6428db/appengine/findit/templates/flake/detection/show_flake.html
Project Member

Comment 27 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8e8e693012350f78294acacdf02c641e7d3a16f2

commit 8e8e693012350f78294acacdf02c641e7d3a16f2
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Jul 17 10:11:18 2018

[Findit] Fix links to issues

This CL fixes links to the created or updated issues.

Bug:  845581 
Change-Id: I732600b225ae746741a9a664cb2bfdc052bf11d8
Reviewed-on: https://chromium-review.googlesource.com/1137799
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/8e8e693012350f78294acacdf02c641e7d3a16f2/appengine/findit/handlers/flake/detection/show_flake.py
[modify] https://crrev.com/8e8e693012350f78294acacdf02c641e7d3a16f2/appengine/findit/model/flake/detection/test/flake_issue_test.py
[modify] https://crrev.com/8e8e693012350f78294acacdf02c641e7d3a16f2/appengine/findit/model/flake/detection/flake_issue.py
[modify] https://crrev.com/8e8e693012350f78294acacdf02c641e7d3a16f2/appengine/findit/ui/elements/flake_detection/flake-demo.html
[modify] https://crrev.com/8e8e693012350f78294acacdf02c641e7d3a16f2/appengine/findit/ui/elements/flake_detection/flake.html
[modify] https://crrev.com/8e8e693012350f78294acacdf02c641e7d3a16f2/appengine/findit/services/flake_detection/flake_report_util.py
[modify] https://crrev.com/8e8e693012350f78294acacdf02c641e7d3a16f2/appengine/findit/handlers/flake/detection/test/show_flake_test.py

Comment 28 by liaoyuke@chromium.org, Jul 17

Blockedon: -846470

Comment 29 by liaoyuke@chromium.org, Jul 17

Blockedon: -857086

Comment 30 by liaoyuke@chromium.org, Jul 17

Status: Fixed (was: Started)
Project Member

Comment 31 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/826cd8e457c8d68eeea6c078126a220b5279cb1c

commit 826cd8e457c8d68eeea6c078126a220b5279cb1c
Author: Yuke Liao <liaoyuke@chromium.org>
Date: Tue Jul 17 14:27:16 2018

[Findit] Convert build id from type int64 to string.

Polymer renders int64 type to a random number in html template variable
replacement, and this is causing all the link on flake detection
frontend page to point to 404, so convert int64 to str to work this
around.

Following version verifies this fixes the build links:
https://16565-e9b28f5-tainted-liaoyuke-dot-findit-for-me-staging.appspot.com/flake/detection/show-flake?key=ahdzfmZpbmRpdC1mb3ItbWUtc3RhZ2luZ3JTCxIFRmxha2UiSGNocm9taXVtQGludGVyYWN0aXZlX3VpX3Rlc3RzQEF1dG9maWxsSW50ZXJhY3RpdmVUZXN0Lk1vZGlmeUZpZWxkQW5kRmlsbAw

Bug:  864426 ,  845581 
Change-Id: I36ef1075e0642a1e77b61b0babe17548e7641f21
Reviewed-on: https://chromium-review.googlesource.com/1140101
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>

[modify] https://crrev.com/826cd8e457c8d68eeea6c078126a220b5279cb1c/appengine/findit/handlers/flake/detection/show_flake.py
[modify] https://crrev.com/826cd8e457c8d68eeea6c078126a220b5279cb1c/appengine/findit/handlers/flake/detection/test/show_flake_test.py
►

Sign in to add a comment