MD referesh: Manage people dialog |
|||||||
Issue description1. New background color 2. New buttons styles 3. Card radius and elevation
,
Jun 1 2018
,
Jun 1 2018
,
Jun 1 2018
Here are the screenshots for https://chromium-review.googlesource.com/c/chromium/src/+/1083625
,
Jun 1 2018
bettes@, namratakannan@: I have a couple questions. Is the existing elevation of the selection profile still okay? I did my best with coming up with color styling for the remove button, does it look okay, or do we need an explicit spec for it?
,
Jun 5 2018
Opting for simpler styling for the remove button until I get guidance how the button should be styled. This follows the error button style in extensions. It's the default button style with --google-red-700 text color.
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464 commit dd6a1c05d08ccb6e44ef144007d4a4167a3b8464 Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed Jun 06 18:43:32 2018 MD User Manager WebUI: change elevation, border-radius and button styles Bug: 845576 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I013e873ac05616d6470282e71767f30eb1eee0ea Reviewed-on: https://chromium-review.googlesource.com/1083625 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#564980} [modify] https://crrev.com/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464/chrome/browser/resources/md_user_manager/control_bar.html [modify] https://crrev.com/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464/chrome/browser/resources/md_user_manager/create_profile.html [modify] https://crrev.com/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464/chrome/browser/resources/md_user_manager/shared_styles.html [modify] https://crrev.com/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464/chrome/browser/resources/md_user_manager/user_manager.html [modify] https://crrev.com/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464/chrome/browser/resources/md_user_manager/user_manager_tutorial.html [modify] https://crrev.com/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html [modify] https://crrev.com/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464/ui/webui/resources/cr_elements/paper_button_style_css.html
,
Jun 6 2018
,
Jun 22 2018
Can we update the buttons styles used here 1.For the Remove button, use a primary filled button, GB600 https://docs.google.com/presentation/d/1kXbnGrFln4CapA0bavU5zjZLALqeD4aQikVVKSJ0zFg/edit#slide=id.g321c13f39e_0_101 2. For hairline buttons such as Browser as Guest and Add Person , can the background be white (and not transparent)
,
Jun 22 2018
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cc030a7e6c0ede4496bcfcc514d5d3fa8c50c1c commit 6cc030a7e6c0ede4496bcfcc514d5d3fa8c50c1c Author: Esmael El-Moslimany <aee@chromium.org> Date: Fri Jun 22 23:55:56 2018 WebUI: update button styles in the user manager Bug: 845576 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I57ccafda9dc31d616f4e94c1d9077cdbc951ae28 Reviewed-on: https://chromium-review.googlesource.com/1112631 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#569846} [modify] https://crrev.com/6cc030a7e6c0ede4496bcfcc514d5d3fa8c50c1c/chrome/browser/resources/md_user_manager/user_manager.html [modify] https://crrev.com/6cc030a7e6c0ede4496bcfcc514d5d3fa8c50c1c/ui/login/account_picker/md_user_pod_template.html [modify] https://crrev.com/6cc030a7e6c0ede4496bcfcc514d5d3fa8c50c1c/ui/login/account_picker/user_pod_template.html [modify] https://crrev.com/6cc030a7e6c0ede4496bcfcc514d5d3fa8c50c1c/ui/webui/resources/cr_elements/paper_button_style_css.html
,
Jun 25 2018
,
Jun 25 2018
,
Jun 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b5461604098b1b8387ce6475b5ed4ec2c042753 commit 4b5461604098b1b8387ce6475b5ed4ec2c042753 Author: Esmael El-Moslimany <aee@chromium.org> Date: Fri Jun 29 05:53:55 2018 WebUI: fix paper-button bg-color for cr-toast and user-manager Changing the paper-button bg-color to white was too big of a change and would require reviewing all usages of paper-button to ensure that style bugs similar to the one found in cr-toast do not occur. The default paper-button bg-color will not be set. The bg-color of paper-button in the user-manager will be set to white. And for cr-toast, the bg-color will be set to transparent (including the hover state). Bug: 845576 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I5b7a513012c43e2da0163555c1a5d25e69cf8328 Reviewed-on: https://chromium-review.googlesource.com/1115354 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#571400} [modify] https://crrev.com/4b5461604098b1b8387ce6475b5ed4ec2c042753/chrome/browser/resources/md_user_manager/shared_styles.html [modify] https://crrev.com/4b5461604098b1b8387ce6475b5ed4ec2c042753/ui/webui/resources/cr_elements/cr_toast/cr_toast.html [modify] https://crrev.com/4b5461604098b1b8387ce6475b5ed4ec2c042753/ui/webui/resources/cr_elements/paper_button_style_css.html
,
Jul 10
Please update the background to be white: https://screenshot.googleplex.com/kKwRQ8LPCLW
,
Jul 10
The background change is tracked by issue 862273 . |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, May 24 2018