New issue
Advanced search Search tips

Issue 845576 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
M69



Sign in to add a comment

MD referesh: Manage people dialog

Project Member Reported by namratakannan@chromium.org, May 22 2018

Issue description

1. New background color
2. New buttons styles
3. Card radius and elevation
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2018

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/bcb2f4a3fafd7dde7351b65e7f670667af1d9d23

commit bcb2f4a3fafd7dde7351b65e7f670667af1d9d23
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu May 24 07:22:57 2018

UPSTREAM: KVM: MMU: try to fix up page faults before giving up

The vGPU folks would like to trap the first access to a BAR by setting
vm_ops on the VMAs produced by mmap-ing a VFIO device.  The fault handler
then can use remap_pfn_range to place some non-reserved pages in the VMA.

This kind of VM_PFNMAP mapping is not handled by KVM, but follow_pfn
and fixup_user_fault together help supporting it.  The patch also supports
VM_MIXEDMAP vmas where the pfns are not reserved and thus subject to
reference counting.

BUG= chromium:845576 
TEST=run kvm with wayland dmabuf on kevin, no crashes

Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Radim Krm <rkrcmar@redhat.com>
Tested-by: Neo Jia <cjia@nvidia.com>
Reported-by: Kirti Wankhede <kwankhede@nvidia.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit add6a0cd1c5ba51b201e1361b05a5df817083618)
Signed-off-by: Sonny Rao <sonnyrao@chromium.org>

Change-Id: I6d28ebd115ba07b0ec017a7c59eb815c0a6ed5e6
Reviewed-on: https://chromium-review.googlesource.com/1069945
Commit-Ready: David Reveman <reveman@chromium.org>
Tested-by: David Reveman <reveman@chromium.org>
Tested-by: Sonny Rao <sonnyrao@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/bcb2f4a3fafd7dde7351b65e7f670667af1d9d23/virt/kvm/kvm_main.c
[modify] https://crrev.com/bcb2f4a3fafd7dde7351b65e7f670667af1d9d23/mm/gup.c

Comment 2 by aee@chromium.org, Jun 1 2018

Owner: aee@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by aee@chromium.org, Jun 1 2018

Status: Started (was: Assigned)

Comment 4 by aee@chromium.org, Jun 1 2018

Here are the screenshots for https://chromium-review.googlesource.com/c/chromium/src/+/1083625
user_manager.png
81.5 KB View Download
card_selection_elevation.png
87.8 KB View Download
action_menu.png
18.2 KB View Download
action_menu_remove_confirm.png
18.7 KB View Download
add_person.png
57.7 KB View Download
tutorial.png
73.2 KB View Download
tutorial_2.png
27.0 KB View Download
tutorial_3.png
41.9 KB View Download

Comment 5 by aee@chromium.org, Jun 1 2018

Cc: namratakannan@chromium.org bettes@chromium.org
bettes@, namratakannan@: I have a couple questions.

Is the existing elevation of the selection profile still okay?

I did my best with coming up with color styling for the remove button, does it look okay, or do we need an explicit spec for it?



Comment 6 by aee@chromium.org, Jun 5 2018

Opting for simpler styling for the remove button until I get guidance how the button should be styled. This follows the error button style in extensions. It's the default button style with --google-red-700 text color.
remove_warning.png
109 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464

commit dd6a1c05d08ccb6e44ef144007d4a4167a3b8464
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed Jun 06 18:43:32 2018

MD User Manager WebUI: change elevation, border-radius and button styles

Bug:  845576 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I013e873ac05616d6470282e71767f30eb1eee0ea
Reviewed-on: https://chromium-review.googlesource.com/1083625
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564980}
[modify] https://crrev.com/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464/chrome/browser/resources/md_user_manager/control_bar.html
[modify] https://crrev.com/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464/chrome/browser/resources/md_user_manager/create_profile.html
[modify] https://crrev.com/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464/chrome/browser/resources/md_user_manager/shared_styles.html
[modify] https://crrev.com/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464/chrome/browser/resources/md_user_manager/user_manager.html
[modify] https://crrev.com/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464/chrome/browser/resources/md_user_manager/user_manager_tutorial.html
[modify] https://crrev.com/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464/ui/webui/resources/cr_elements/cr_profile_avatar_selector/cr_profile_avatar_selector.html
[modify] https://crrev.com/dd6a1c05d08ccb6e44ef144007d4a4167a3b8464/ui/webui/resources/cr_elements/paper_button_style_css.html

Comment 8 by aee@chromium.org, Jun 6 2018

Status: Fixed (was: Started)
Can we update the buttons styles used here

1.For the Remove button, use a primary filled button, GB600
https://docs.google.com/presentation/d/1kXbnGrFln4CapA0bavU5zjZLALqeD4aQikVVKSJ0zFg/edit#slide=id.g321c13f39e_0_101

2. For hairline buttons such as Browser as Guest and Add Person , can the background be white (and not transparent)

Comment 10 by aee@chromium.org, Jun 22 2018

Status: Started (was: Fixed)
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cc030a7e6c0ede4496bcfcc514d5d3fa8c50c1c

commit 6cc030a7e6c0ede4496bcfcc514d5d3fa8c50c1c
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Jun 22 23:55:56 2018

WebUI: update button styles in the user manager

Bug:  845576 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I57ccafda9dc31d616f4e94c1d9077cdbc951ae28
Reviewed-on: https://chromium-review.googlesource.com/1112631
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569846}
[modify] https://crrev.com/6cc030a7e6c0ede4496bcfcc514d5d3fa8c50c1c/chrome/browser/resources/md_user_manager/user_manager.html
[modify] https://crrev.com/6cc030a7e6c0ede4496bcfcc514d5d3fa8c50c1c/ui/login/account_picker/md_user_pod_template.html
[modify] https://crrev.com/6cc030a7e6c0ede4496bcfcc514d5d3fa8c50c1c/ui/login/account_picker/user_pod_template.html
[modify] https://crrev.com/6cc030a7e6c0ede4496bcfcc514d5d3fa8c50c1c/ui/webui/resources/cr_elements/paper_button_style_css.html

Comment 12 by aee@chromium.org, Jun 25 2018

Status: Fixed (was: Started)

Comment 13 by aee@chromium.org, Jun 25 2018

Cc: aee@chromium.org
 Issue 842015  has been merged into this issue.
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b5461604098b1b8387ce6475b5ed4ec2c042753

commit 4b5461604098b1b8387ce6475b5ed4ec2c042753
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri Jun 29 05:53:55 2018

WebUI: fix paper-button bg-color for cr-toast and user-manager

Changing the paper-button bg-color to white was too big of a change
and would require reviewing all usages of paper-button to ensure that
style bugs similar to the one found in cr-toast do not occur.

The default paper-button bg-color will not be set. The bg-color of
paper-button in the user-manager will be set to white. And for
cr-toast, the bg-color will be set to transparent (including the hover
state).

Bug:  845576 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I5b7a513012c43e2da0163555c1a5d25e69cf8328
Reviewed-on: https://chromium-review.googlesource.com/1115354
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571400}
[modify] https://crrev.com/4b5461604098b1b8387ce6475b5ed4ec2c042753/chrome/browser/resources/md_user_manager/shared_styles.html
[modify] https://crrev.com/4b5461604098b1b8387ce6475b5ed4ec2c042753/ui/webui/resources/cr_elements/cr_toast/cr_toast.html
[modify] https://crrev.com/4b5461604098b1b8387ce6475b5ed4ec2c042753/ui/webui/resources/cr_elements/paper_button_style_css.html

Please update the background to be white: https://screenshot.googleplex.com/kKwRQ8LPCLW
The background change is tracked by  issue 862273 .

Sign in to add a comment