Make "Open In..." feature more discoverable |
||||||||||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): All iOS Version: All Device: All Steps to reproduce: 0.) Make sure that UI-refresh flag is not enabled (crbug.com/833177) 1.) Load a PDF page (e.g. https://www.irs.gov/pub/irs-pdf/fw4.pdf) 3.) Tap on PDF page Observed behavior: Open In... toolbar is shown after tapping on PDF page, which is not very discoverable Expected behavior: Always keep Open In... toolbar on PDF page
,
May 23 2018
Agreed. We should just implement this for M69. Thanks.
,
May 23 2018
We should ensure that "always keeping Open In ... toolbar on PDF Page" work smoothly with the show/hide of our bottom toolbar on scroll.
,
May 23 2018
,
May 25 2018
,
May 25 2018
Assigning to Mark to distribute UI-refresh work.
,
May 29 2018
,
Jun 6 2018
Gauthier: would this be something you'd take on given it's blocking issue 833177 ?
,
Jun 13 2018
,
Jun 17 2018
,
Jun 18 2018
,
Jun 26 2018
,
Aug 31
From mardini@ in issue 833177 "Please note that we'd like to change the behaviour slightly to make that "Open In ..." toolbar a bit more discoverable. So we should show it on loading the PDF and on scroll away. I don't think we should have it "always on"."
,
Aug 31
I think that a nice behaviour would be: - Show it after the PDF loads, no time out. Keep it visible on scroll. - Hide it when pressing anywhere on the PDF. (Exception: When Tools menu is visible, and user dismisses tools menu, open in should stay visible) - Show it again when pressing anywhere on the pdf.
,
Aug 31
That sounds reasonable to me. Thank you. Updating milestone and priority. I'm assuming it's too late for M70.
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3d123417511dd0f812f50e0440da26de0742f6b commit f3d123417511dd0f812f50e0440da26de0742f6b Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Aug 31 15:49:37 2018 [iOS] Increase visibility of OpenIn for pdfs This CL increases the visibility of the OpenIn toolbar in the pdf pages. The toolbar is now visible when the page is loaded and stays visible until the user interacts with the page (tap, scroll...). It is also appearing when the user scrolls up (same as the bottom toolbar behavior). Bug: 845563 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I27b2018288c11cc4500a5f48ed47be4bad1d3848 Reviewed-on: https://chromium-review.googlesource.com/1198770 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#588034} [modify] https://crrev.com/f3d123417511dd0f812f50e0440da26de0742f6b/ios/chrome/browser/ui/open_in_controller.mm
,
Aug 31
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by eugene...@chromium.org
, May 22 2018Labels: M-69