The sessionStorage backend deletes the database on all open failures |
|||
Issue descriptionChrome Version: 66 OS: All When SessionStorageDatabase::LazyOpen fails to open a leveldb it will *always* destroy and reopen that database. Deletion should probably only ever be done when database corruption is detected. There are other things that can cause database opens to fail such as full disks, and file descriptor exhaustion, and deleting the entire database is likely too severe a response to this.
,
Jun 4 2018
mek@, I agree that you raise an excellent question and I'm not quite sure how to solve it. However, at present 0.04% of all sessionStorage db opens fail and after successfully deleting the db, only 13% are able to be opened (created actually). So even after deleting all the user's data in that db it still doesn't buy us much. My guess is that FD's are exhausted, or maybe the db is on a network shared profile (see issue 647385). So 76% of the time (when we fail to open the first time) we just delete, and then fail the retry. It would be good to come up with a better solution I think.
,
Jun 7 2018
,
Oct 3
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mek@chromium.org
, May 22 2018