New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845561 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Picture-in-Picture: starting a new PIP window in the same page doesn't changes state on previous video

Project Member Reported by mlamouri@chromium.org, May 22 2018

Issue description

STR:
 1. open a page with two videos
 2. start PIP on first video
 3. start PIP on second video (without stopping first one)

Expected result: first video state is no longer PIP
Actual result: both videos show in PIP state (but only one PIP window)
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/503fae899e5e4d93c513cc79598cafda46c51164

commit 503fae899e5e4d93c513cc79598cafda46c51164
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Fri May 25 01:05:48 2018

Picture-in-Picture: stop video in pip when starting a new one in page.

The video is now notified that it is no longer in PIP which allows it
to cleanup its UI.

Bug:  845561 
Change-Id: I046da987e51f2568c6af05a3c51a7c0124a6abbe
Reviewed-on: https://chromium-review.googlesource.com/1067748
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561718}
[modify] https://crrev.com/503fae899e5e4d93c513cc79598cafda46c51164/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/503fae899e5e4d93c513cc79598cafda46c51164/chrome/browser/ui/browser.cc
[modify] https://crrev.com/503fae899e5e4d93c513cc79598cafda46c51164/chrome/test/data/media/picture-in-picture/window-size.html

Status: Fixed (was: Started)

Sign in to add a comment