New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845560 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Picture-in-Picture: closing a window when video is paused doesn't change video's state

Project Member Reported by mlamouri@chromium.org, May 22 2018

Issue description

STR:
 1. start PIP on a paused video
 2. close PIP window

Expected result: video in page doesn't show UI for being in PIP
Actual result: video in page shows UI for being in PIP
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dbae413ae1ffa7594f26206271ab4e64a2f6d30

commit 6dbae413ae1ffa7594f26206271ab4e64a2f6d30
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Thu May 24 21:55:53 2018

Picture-in-Picture: always notify the player when the window is closed.

At the moment, we only notify the player if it was playing. This will
notify the player all the time but only pause it if it is playing.

Bug:  845560 
Change-Id: Ifceafbc5eaa79927935ed4b5f50a147b03f955b5
Reviewed-on: https://chromium-review.googlesource.com/1069713
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561648}
[modify] https://crrev.com/6dbae413ae1ffa7594f26206271ab4e64a2f6d30/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/6dbae413ae1ffa7594f26206271ab4e64a2f6d30/chrome/test/data/media/picture-in-picture/window-size.html
[modify] https://crrev.com/6dbae413ae1ffa7594f26206271ab4e64a2f6d30/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment