New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845553 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression

Blocked on:
issue 845920

Blocking:
issue 843511



Sign in to add a comment

Android CFI failing since https://ci.chromium.org/buildbot/chromium.memory/Android%20CFI/1295

Project Member Reported by scottmg@chromium.org, May 22 2018

Issue description

https://ci.chromium.org/buildbot/chromium.memory/Android%20CFI/

https://ci.chromium.org/buildbot/chromium.memory/Android%20CFI/1295

content_browsertests appears to be timing out.

Not much of a blamelist... kbr@ could you CL be related?
 
Sorry, should have linked the CL. https://chromium-review.googlesource.com/1067109 is the one I was wondering about.
Possibly just actually timing out: https://bugs.chromium.org/p/chromium/issues/detail?id=845462

Comment 3 by kbr@chromium.org, May 22 2018

Cc: thakis@chromium.org engedy@chromium.org
 Issue 845462  has been merged into this issue.

Comment 4 by kbr@chromium.org, May 22 2018

Blocking: 843511
Components: Tools>Test Build
Labels: -Type-Bug Type-Bug-Regression
The issue seems to be that the sharding for content_browsertests on Android was accidentally lost in https://chromium-review.googlesource.com/1067109 . I'll fix it.

Oops, sorry, I can't read and assigned to the wrong person! Thanks for looking.

Comment 6 by kbr@chromium.org, May 22 2018

Status: Started (was: Assigned)
Fix in progress in https://chromium-review.googlesource.com/1069537 .

Project Member

Comment 7 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe876f50c20620add71a7e636168ccd35845a245

commit fe876f50c20620add71a7e636168ccd35845a245
Author: Kenneth Russell <kbr@chromium.org>
Date: Tue May 22 21:33:06 2018

Restore some Swarming parameters for Android tests.

In https://chromium-review.googlesource.com/1067109 a few sharding
parameters were changed for these tests:
  - content_unittests
  - unit_tests
  - webview_instrumentation_test_apk

Restore the original number of shards for these tests.

Additionally, the bot "chromium.memory:Android CFI" wasn't properly
specified as an Android bot (os_type=Android), so none of the sharding
parameters were being applied to it. Fix this, in particular for
content_browsertests.

Bug:  845553 
Change-Id: Icc819dde7327f93ab845343b64a649258e857e28
Tbr: thakis@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1069537
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560786}
[modify] https://crrev.com/fe876f50c20620add71a7e636168ccd35845a245/testing/buildbot/chromium.android.fyi.json
[modify] https://crrev.com/fe876f50c20620add71a7e636168ccd35845a245/testing/buildbot/chromium.android.json
[modify] https://crrev.com/fe876f50c20620add71a7e636168ccd35845a245/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/fe876f50c20620add71a7e636168ccd35845a245/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/fe876f50c20620add71a7e636168ccd35845a245/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/fe876f50c20620add71a7e636168ccd35845a245/testing/buildbot/waterfalls.pyl

Comment 8 by kbr@chromium.org, May 23 2018

Status: Fixed (was: Started)
The bot's passing content_browsertests again:
https://ci.chromium.org/buildbot/chromium.memory/Android%20CFI/

Unfortunately an individual test in net_unittests is failing ( QuicCryptoClientStreamTest.ConnectedAfterTlsHandshake ) but that should be filed separately.

Comment 10 by kbr@chromium.org, May 26 2018

Blockedon: 845920

Sign in to add a comment