New issue
Advanced search Search tips
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Feature

Blocking:
issue 874317
issue 874321
issue 874942



Sign in to add a comment
link

Issue 845549: Create new rotation tool

Reported by zhangtiff@chromium.org, May 22 2018 Project Member

Issue description

Creating a tracking bug to record progress on the new rotation tool. 

Design doc: http://go/rotations-ng
 

Comment 1 by zhangtiff@chromium.org, May 22 2018

Summary: Create new rotation tool (was: Create new rotation )
(Woops, forgot to finish typing the bug title.)

Comment 3 by bugdroid1@chromium.org, May 28 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bac8b4d0802c0de55e88975bca507354db46e3b9

commit bac8b4d0802c0de55e88975bca507354db46e3b9
Author: Ola Karlsson <olakar@chromium.org>
Date: Mon May 28 00:57:57 2018

Revert "Adding in the basic directory structure and defining the rota types."

This reverts commit 2b67e66ed9c9628706efdd2794e9e174596e9d78.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Adding in the basic directory structure and defining the rota types.
> 
> Bug:845549
> 
> Change-Id: I7bf90711037d1e13ddd6b1ea65835857f7290328
> Reviewed-on: https://chromium-review.googlesource.com/1068535
> Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>

TBR=zhangtiff@chromium.org,olakar@chromium.org

Change-Id: Ice6333327c781cd20f71652f53627b65c3668ae0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  845549 
Reviewed-on: https://chromium-review.googlesource.com/1074867
Reviewed-by: Ola Karlsson <olakar@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>

[delete] https://crrev.com/2b67e66ed9c9628706efdd2794e9e174596e9d78/go/src/infra/appengine/rota-ng/backend/rota/rotation.go
[delete] https://crrev.com/2b67e66ed9c9628706efdd2794e9e174596e9d78/go/src/infra/appengine/rota-ng/rota-ng.infra_testing
[delete] https://crrev.com/2b67e66ed9c9628706efdd2794e9e174596e9d78/go/src/infra/appengine/rota-ng/README.md
[delete] https://crrev.com/2b67e66ed9c9628706efdd2794e9e174596e9d78/go/src/infra/appengine/rota-ng/backend/rota/rota.infra_testing
[delete] https://crrev.com/2b67e66ed9c9628706efdd2794e9e174596e9d78/go/src/infra/appengine/rota-ng/backend/rota/rotation_test.go
[delete] https://crrev.com/2b67e66ed9c9628706efdd2794e9e174596e9d78/go/src/infra/appengine/rota-ng/OWNERS
[delete] https://crrev.com/2b67e66ed9c9628706efdd2794e9e174596e9d78/go/src/infra/appengine/rota-ng/Makefile

Comment 4 by olakar@chromium.org, Jul 23 2018

Adding in the godebug dependency at last:


https://bugs.chromium.org/p/chromium/issues/detail?id=860553

Comment 5 by olakar@chromium.org, Jul 23 2018

While I'm here I might as well update some of the progress .. 

While waiting for some Go dependencies to be added to the Infra environment I've messed around with a prototype. 

nop2.c.googlers.com:8080 and a-ng-staging.googleplex.com are currently actively under development.

Comment 6 by olakar@chromium.org, Jul 23 2018

Hoping to have the service generate "shadow" rotas by the end of this week. 

A shadow rota would be it generating entries in some test calendar in parallell to the current service .. If that looks all right, start to moving things over to the new service.

Comment 7 by bugdroid1@chromium.org, Jul 25 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3863fb6ed94a73ac7cdda7f7235eee3385d48189

commit 3863fb6ed94a73ac7cdda7f7235eee3385d48189
Author: Ola Karlsson <olakar@chromium.org>
Date: Wed Jul 25 01:51:19 2018

Being a bit curious to try out the current best practice of how to structure
Go projects I reshuffled the stuff to closer match the advice from:

https://peter.bourgon.org/go-for-industrial-programming/#structuring-your-code-and-repository

This CL contains the basic datatypes for the rotang project together with
functions to convert the legacy JSON rota configurations into the new
configuration type.

Bug:  845549 
Change-Id: I61544c7da49aeb3096cdbe289d52fb766b3fdac2
Reviewed-on: https://chromium-review.googlesource.com/1126695
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>

[add] https://crrev.com/3863fb6ed94a73ac7cdda7f7235eee3385d48189/go/src/infra/appengine/rotang/Makefile
[add] https://crrev.com/3863fb6ed94a73ac7cdda7f7235eee3385d48189/go/src/infra/appengine/rotang/pkg/rotang/rotang.infra_testing
[add] https://crrev.com/3863fb6ed94a73ac7cdda7f7235eee3385d48189/go/src/infra/appengine/rotang/OWNERS
[add] https://crrev.com/3863fb6ed94a73ac7cdda7f7235eee3385d48189/go/src/infra/appengine/rotang/pkg/rotang/rotang.go
[add] https://crrev.com/3863fb6ed94a73ac7cdda7f7235eee3385d48189/go/src/infra/appengine/rotang/pkg/jsoncfg/jsoncfg.infra_testing
[add] https://crrev.com/3863fb6ed94a73ac7cdda7f7235eee3385d48189/go/src/infra/appengine/rotang/pkg/jsoncfg/jsoncfg.go
[add] https://crrev.com/3863fb6ed94a73ac7cdda7f7235eee3385d48189/go/src/infra/appengine/rotang/pkg/jsoncfg/jsoncfg_test.go
[add] https://crrev.com/3863fb6ed94a73ac7cdda7f7235eee3385d48189/go/src/infra/appengine/rotang/README.md

Comment 8 by bugdroid1@chromium.org, Jul 30 2018

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 31 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0b667d653cce401cbdfddc39715206213751e1ea

commit 0b667d653cce401cbdfddc39715206213751e1ea
Author: Ola Karlsson <olakar@chromium.org>
Date: Tue Jul 31 01:34:40 2018

This CL contains the initial Appengine application.

Handlers for presenting an index page and uploading legacy JSON cfg.

Bug:  845549 
Change-Id: I7ea558b017ad2219c83b4027645d0603f700a928
Reviewed-on: https://chromium-review.googlesource.com/1154731
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>

[add] https://crrev.com/0b667d653cce401cbdfddc39715206213751e1ea/go/src/infra/appengine/rotang/cmd/app/css/style.css
[modify] https://crrev.com/0b667d653cce401cbdfddc39715206213751e1ea/go/src/infra/appengine/rotang/Makefile
[add] https://crrev.com/0b667d653cce401cbdfddc39715206213751e1ea/go/src/infra/appengine/rotang/cmd/app/handlers/handle_upload.go
[add] https://crrev.com/0b667d653cce401cbdfddc39715206213751e1ea/go/src/infra/appengine/rotang/cmd/app/images/favicon.ico
[add] https://crrev.com/0b667d653cce401cbdfddc39715206213751e1ea/go/src/infra/appengine/rotang/cmd/app/.gitignore
[add] https://crrev.com/0b667d653cce401cbdfddc39715206213751e1ea/go/src/infra/appengine/rotang/cmd/app/app.yaml
[add] https://crrev.com/0b667d653cce401cbdfddc39715206213751e1ea/go/src/infra/appengine/rotang/cmd/app/handlers/handlers.infra_testing
[add] https://crrev.com/0b667d653cce401cbdfddc39715206213751e1ea/go/src/infra/appengine/rotang/cmd/app/templates/pages/upload.html
[add] https://crrev.com/0b667d653cce401cbdfddc39715206213751e1ea/go/src/infra/appengine/rotang/cmd/app/handlers/handle_upload_test.go
[add] https://crrev.com/0b667d653cce401cbdfddc39715206213751e1ea/go/src/infra/appengine/rotang/cmd/app/templates/pages/index.html
[add] https://crrev.com/0b667d653cce401cbdfddc39715206213751e1ea/go/src/infra/appengine/rotang/cmd/app/handlers/handle_index_test.go
[add] https://crrev.com/0b667d653cce401cbdfddc39715206213751e1ea/go/src/infra/appengine/rotang/cmd/app/app.infra_testing
[add] https://crrev.com/0b667d653cce401cbdfddc39715206213751e1ea/go/src/infra/appengine/rotang/cmd/app/handlers/handle_index.go
[add] https://crrev.com/0b667d653cce401cbdfddc39715206213751e1ea/go/src/infra/appengine/rotang/cmd/app/app.go

Comment 10 by bugdroid1@chromium.org, Aug 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f5d4b353118b16611b0e1131bae7b9da66f3420b

commit f5d4b353118b16611b0e1131bae7b9da66f3420b
Author: Ola Karlsson <olakar@chromium.org>
Date: Fri Aug 10 02:27:36 2018

[rotang] Tidying up the interface a bit.

Tidying up of the interfaces after some of the discussions during
the ProjectReview.

Bug:  845549 
Change-Id: I5e8729f4e72c2ea945d7974bd91b28f10bb61d29
Reviewed-on: https://chromium-review.googlesource.com/1164730
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/f5d4b353118b16611b0e1131bae7b9da66f3420b/go/src/infra/appengine/rotang/pkg/datastore/datastore.go
[rename] https://crrev.com/f5d4b353118b16611b0e1131bae7b9da66f3420b/go/src/infra/appengine/rotang/cmd/handlers/templates/pages/index.html
[rename] https://crrev.com/f5d4b353118b16611b0e1131bae7b9da66f3420b/go/src/infra/appengine/rotang/cmd/handlers/handle_index.go
[add] https://crrev.com/f5d4b353118b16611b0e1131bae7b9da66f3420b/go/src/infra/appengine/rotang/BROWSE.md
[modify] https://crrev.com/f5d4b353118b16611b0e1131bae7b9da66f3420b/go/src/infra/appengine/rotang/pkg/jsoncfg/jsoncfg.go
[rename] https://crrev.com/f5d4b353118b16611b0e1131bae7b9da66f3420b/go/src/infra/appengine/rotang/cmd/handlers/handle_upload.go
[rename] https://crrev.com/f5d4b353118b16611b0e1131bae7b9da66f3420b/go/src/infra/appengine/rotang/cmd/handlers/handle_index_test.go
[rename] https://crrev.com/f5d4b353118b16611b0e1131bae7b9da66f3420b/go/src/infra/appengine/rotang/rotang.go
[rename] https://crrev.com/f5d4b353118b16611b0e1131bae7b9da66f3420b/go/src/infra/appengine/rotang/cmd/handlers/templates/pages/upload.html
[delete] https://crrev.com/ab24090318dc1e3be070b66927f129577e8bc772/go/src/infra/appengine/rotang/cmd/app/handlers/handlers.infra_testing
[modify] https://crrev.com/f5d4b353118b16611b0e1131bae7b9da66f3420b/go/src/infra/appengine/rotang/pkg/jsoncfg/jsoncfg_test.go
[modify] https://crrev.com/f5d4b353118b16611b0e1131bae7b9da66f3420b/go/src/infra/appengine/rotang/pkg/datastore/datastore_test.go
[rename] https://crrev.com/f5d4b353118b16611b0e1131bae7b9da66f3420b/go/src/infra/appengine/rotang/cmd/handlers/handle_upload_test.go
[modify] https://crrev.com/f5d4b353118b16611b0e1131bae7b9da66f3420b/go/src/infra/appengine/rotang/cmd/app/app.go
[rename] https://crrev.com/f5d4b353118b16611b0e1131bae7b9da66f3420b/go/src/infra/appengine/rotang/rotang.infra_testing
[add] https://crrev.com/f5d4b353118b16611b0e1131bae7b9da66f3420b/go/src/infra/appengine/rotang/cmd/handlers/handlers.infra_testing

Comment 11 by olakar@chromium.org, Aug 15

Blocking: 874317

Comment 12 by olakar@chromium.org, Aug 15

Blocking: 874321

Comment 13 by olakar@chromium.org, Aug 16

Blocking: 874942

Comment 14 by bugdroid1@chromium.org, Aug 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/35fccf2d846b779a225457a17a1300b3b4c0dba0

commit 35fccf2d846b779a225457a17a1300b3b4c0dba0
Author: Ola Karlsson <olakar@chromium.org>
Date: Wed Aug 22 06:24:04 2018

[rota-ng] List handler to list all stored rotations.

Bug:845549
Change-Id: Ibfa404e86f8da54a772aac85a51ba25444f8ca99
Reviewed-on: https://chromium-review.googlesource.com/1182711
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/35fccf2d846b779a225457a17a1300b3b4c0dba0/go/src/infra/appengine/rotang/pkg/datastore/datastore.go
[modify] https://crrev.com/35fccf2d846b779a225457a17a1300b3b4c0dba0/go/src/infra/appengine/rotang/cmd/handlers/templates/pages/index.html
[add] https://crrev.com/35fccf2d846b779a225457a17a1300b3b4c0dba0/go/src/infra/appengine/rotang/cmd/handlers/templates/pages/list.html
[modify] https://crrev.com/35fccf2d846b779a225457a17a1300b3b4c0dba0/go/src/infra/appengine/rotang/cmd/handlers/handle_index.go
[modify] https://crrev.com/35fccf2d846b779a225457a17a1300b3b4c0dba0/go/src/infra/appengine/rotang/rotang.go
[modify] https://crrev.com/35fccf2d846b779a225457a17a1300b3b4c0dba0/go/src/infra/appengine/rotang/cmd/handlers/handle_upload.go
[modify] https://crrev.com/35fccf2d846b779a225457a17a1300b3b4c0dba0/go/src/infra/appengine/rotang/cmd/handlers/handle_index_test.go
[add] https://crrev.com/35fccf2d846b779a225457a17a1300b3b4c0dba0/go/src/infra/appengine/rotang/cmd/handlers/handle_list_test.go
[add] https://crrev.com/35fccf2d846b779a225457a17a1300b3b4c0dba0/go/src/infra/appengine/rotang/cmd/handlers/handle_list.go
[add] https://crrev.com/35fccf2d846b779a225457a17a1300b3b4c0dba0/go/src/infra/appengine/rotang/cmd/handlers/handlers.go
[modify] https://crrev.com/35fccf2d846b779a225457a17a1300b3b4c0dba0/go/src/infra/appengine/rotang/pkg/datastore/datastore_test.go
[modify] https://crrev.com/35fccf2d846b779a225457a17a1300b3b4c0dba0/go/src/infra/appengine/rotang/cmd/handlers/handle_upload_test.go
[modify] https://crrev.com/35fccf2d846b779a225457a17a1300b3b4c0dba0/go/src/infra/appengine/rotang/cmd/app/app.go

Comment 15 by bugdroid1@chromium.org, Aug 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f064062b969ec36f46ef9153a0ade7515c4c31ab

commit f064062b969ec36f46ef9153a0ade7515c4c31ab
Author: Ola Karlsson <olakar@chromium.org>
Date: Wed Aug 29 18:42:06 2018

Adding in a LICENSE blub to all go files.

Bug:845549
Change-Id: I12260a9b4694c967854610f17ab844dc4b103b10
Reviewed-on: https://chromium-review.googlesource.com/1194526
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/pkg/algo/legacy_test.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/pkg/algo/random_test.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/pkg/datastore/datastore.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/pkg/algo/random.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/pkg/algo/fair.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/cmd/handlers/handle_index.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/pkg/algo/fair_test.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/pkg/algo/algo.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/pkg/algo/legacy.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/pkg/jsoncfg/jsoncfg.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/cmd/handlers/handle_upload.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/cmd/handlers/handle_index_test.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/rotang.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/cmd/handlers/handle_list_test.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/pkg/algo/algo_test.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/cmd/handlers/handle_list.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/cmd/handlers/handlers.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/pkg/datastore/datastore_test.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/cmd/handlers/handle_upload_test.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/pkg/jsoncfg/jsoncfg_test.go
[modify] https://crrev.com/f064062b969ec36f46ef9153a0ade7515c4c31ab/go/src/infra/appengine/rotang/cmd/app/app.go

Comment 16 by bugdroid1@chromium.org, Sep 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/55c7e42f7649ca303e9e7cb076a44a5ec491bff6

commit 55c7e42f7649ca303e9e7cb076a44a5ec491bff6
Author: Ola Karlsson <olakar@chromium.org>
Date: Mon Sep 17 23:04:40 2018

[rotang] Split shift support.

This CL adds in support for shifts being split over 24 hours eg. MTB -> SYD -> EU follow the sun shifts.
It also eables having office hour shifts with nobody oncall oustide of specific hours.



Bug:  845549 
Change-Id: Ie5157119eaa74de0f7bf0b309d475e9ff63a55a7
Reviewed-on: https://chromium-review.googlesource.com/1226725
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17645}
[modify] https://crrev.com/55c7e42f7649ca303e9e7cb076a44a5ec491bff6/go/src/infra/appengine/rotang/pkg/algo/random_test.go
[modify] https://crrev.com/55c7e42f7649ca303e9e7cb076a44a5ec491bff6/go/src/infra/appengine/rotang/pkg/algo/random.go
[modify] https://crrev.com/55c7e42f7649ca303e9e7cb076a44a5ec491bff6/go/src/infra/appengine/rotang/pkg/algo/fair.go
[modify] https://crrev.com/55c7e42f7649ca303e9e7cb076a44a5ec491bff6/go/src/infra/appengine/rotang/rotang.go
[modify] https://crrev.com/55c7e42f7649ca303e9e7cb076a44a5ec491bff6/go/src/infra/appengine/rotang/pkg/algo/fair_test.go
[modify] https://crrev.com/55c7e42f7649ca303e9e7cb076a44a5ec491bff6/go/src/infra/appengine/rotang/pkg/algo/algo.go
[modify] https://crrev.com/55c7e42f7649ca303e9e7cb076a44a5ec491bff6/go/src/infra/appengine/rotang/pkg/algo/legacy.go
[modify] https://crrev.com/55c7e42f7649ca303e9e7cb076a44a5ec491bff6/go/src/infra/appengine/rotang/pkg/datastore/shiftstorer.go
[modify] https://crrev.com/55c7e42f7649ca303e9e7cb076a44a5ec491bff6/go/src/infra/appengine/rotang/pkg/algo/algo_test.go
[modify] https://crrev.com/55c7e42f7649ca303e9e7cb076a44a5ec491bff6/go/src/infra/appengine/rotang/pkg/datastore/shiftstorer_test.go
[modify] https://crrev.com/55c7e42f7649ca303e9e7cb076a44a5ec491bff6/go/src/infra/appengine/rotang/pkg/algo/legacy_test.go
[modify] https://crrev.com/55c7e42f7649ca303e9e7cb076a44a5ec491bff6/go/src/infra/appengine/rotang/pkg/datastore/datastore_test.go

Comment 17 by bugdroid1@chromium.org, Sep 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/619ed3746c5fde4ea569d6d69f4f7c871b145f31

commit 619ed3746c5fde4ea569d6d69f4f7c871b145f31
Author: Ola Karlsson <olakar@chromium.org>
Date: Mon Sep 17 23:33:38 2018

[rotang] Adding in the email job handler.

The first job checking.. Jobs are handlers that runs periodically.
This handler goes through all rotations sending notification emails to
upcoming on-callers.

This first CL does not consider the calendar entries with the accept/decline
state.


Bug:  845549 
Change-Id: I74feea33a573152140692293f20f21d753b259e6
Reviewed-on: https://chromium-review.googlesource.com/1226728
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17648}
[modify] https://crrev.com/619ed3746c5fde4ea569d6d69f4f7c871b145f31/go/src/infra/appengine/rotang/rotang.go
[add] https://crrev.com/619ed3746c5fde4ea569d6d69f4f7c871b145f31/go/src/infra/appengine/rotang/cmd/handlers/job_email_test.go
[add] https://crrev.com/619ed3746c5fde4ea569d6d69f4f7c871b145f31/go/src/infra/appengine/rotang/cmd/handlers/job_email.go
[modify] https://crrev.com/619ed3746c5fde4ea569d6d69f4f7c871b145f31/go/src/infra/appengine/rotang/cmd/app/app.go
[modify] https://crrev.com/619ed3746c5fde4ea569d6d69f4f7c871b145f31/go/src/infra/appengine/rotang/cmd/handlers/handlers.go

Comment 18 by bugdroid1@chromium.org, Sep 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/15daa28f6a028f76a5a8b99265a28e417a6936a2

commit 15daa28f6a028f76a5a8b99265a28e417a6936a2
Author: Ola Karlsson <olakar@chromium.org>
Date: Tue Sep 18 23:30:41 2018

[rotang] Add a handler for Deleting rotations.


Bug:  845549 
Change-Id: I002a74b4d01a439b1658e8d76a67e610203e4268
Reviewed-on: https://chromium-review.googlesource.com/1227863
Reviewed-by: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17687}
[add] https://crrev.com/15daa28f6a028f76a5a8b99265a28e417a6936a2/go/src/infra/appengine/rotang/cmd/handlers/handle_deleterota_test.go
[modify] https://crrev.com/15daa28f6a028f76a5a8b99265a28e417a6936a2/go/src/infra/appengine/rotang/cmd/handlers/templates/pages/index.html
[modify] https://crrev.com/15daa28f6a028f76a5a8b99265a28e417a6936a2/go/src/infra/appengine/rotang/cmd/handlers/handle_createrota.go
[modify] https://crrev.com/15daa28f6a028f76a5a8b99265a28e417a6936a2/go/src/infra/appengine/rotang/cmd/handlers/handle_index.go
[modify] https://crrev.com/15daa28f6a028f76a5a8b99265a28e417a6936a2/go/src/infra/appengine/rotang/rotang.go
[modify] https://crrev.com/15daa28f6a028f76a5a8b99265a28e417a6936a2/go/src/infra/appengine/rotang/cmd/handlers/handle_index_test.go
[add] https://crrev.com/15daa28f6a028f76a5a8b99265a28e417a6936a2/go/src/infra/appengine/rotang/cmd/handlers/handle_managerota_test.go
[add] https://crrev.com/15daa28f6a028f76a5a8b99265a28e417a6936a2/go/src/infra/appengine/rotang/cmd/handlers/handle_deleterota.go
[modify] https://crrev.com/15daa28f6a028f76a5a8b99265a28e417a6936a2/go/src/infra/appengine/rotang/cmd/handlers/handle_createrota_test.go
[add] https://crrev.com/15daa28f6a028f76a5a8b99265a28e417a6936a2/go/src/infra/appengine/rotang/cmd/handlers/templates/pages/managerota.html
[add] https://crrev.com/15daa28f6a028f76a5a8b99265a28e417a6936a2/go/src/infra/appengine/rotang/cmd/handlers/handle_managerota.go
[modify] https://crrev.com/15daa28f6a028f76a5a8b99265a28e417a6936a2/go/src/infra/appengine/rotang/cmd/app/app.go

Comment 19 by bugdroid1@chromium.org, Sep 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/db714bca7e3f1d287f74277d6d4cbeca1d8dd4d4

commit db714bca7e3f1d287f74277d6d4cbeca1d8dd4d4
Author: Ola Karlsson <olakar@chromium.org>
Date: Thu Sep 20 23:11:20 2018

[rotang] Changing the Config DaysToSchedule -> ShiftsToSchedule

Just make a lot more sense to schedule by shifts than days.
Esp. with shifts being week oriented with no on-calls on weekends.

Bug:  845549 
Change-Id: Ie416969b32963b3ed5829674a104118679ac127c
Reviewed-on: https://chromium-review.googlesource.com/1234516
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17778}
[modify] https://crrev.com/db714bca7e3f1d287f74277d6d4cbeca1d8dd4d4/go/src/infra/appengine/rotang/cmd/handlers/handle_createrota.go
[modify] https://crrev.com/db714bca7e3f1d287f74277d6d4cbeca1d8dd4d4/go/src/infra/appengine/rotang/rotang.go
[modify] https://crrev.com/db714bca7e3f1d287f74277d6d4cbeca1d8dd4d4/go/src/infra/appengine/rotang/cmd/handlers/handle_index_test.go
[modify] https://crrev.com/db714bca7e3f1d287f74277d6d4cbeca1d8dd4d4/go/src/infra/appengine/rotang/cmd/handlers/handle_upload_test.go
[modify] https://crrev.com/db714bca7e3f1d287f74277d6d4cbeca1d8dd4d4/go/src/infra/appengine/rotang/cmd/handlers/handle_list_test.go
[modify] https://crrev.com/db714bca7e3f1d287f74277d6d4cbeca1d8dd4d4/go/src/infra/appengine/rotang/pkg/jsoncfg/jsoncfg.go
[modify] https://crrev.com/db714bca7e3f1d287f74277d6d4cbeca1d8dd4d4/go/src/infra/appengine/rotang/pkg/jsoncfg/jsoncfg_test.go
[modify] https://crrev.com/db714bca7e3f1d287f74277d6d4cbeca1d8dd4d4/go/src/infra/appengine/rotang/cmd/handlers/handle_createrota_test.go
[modify] https://crrev.com/db714bca7e3f1d287f74277d6d4cbeca1d8dd4d4/go/src/infra/appengine/rotang/pkg/datastore/datastore_test.go

Comment 20 by bugdroid1@chromium.org, Sep 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a8ba791fd8e43ef3bc0b2330445c85ee8037f351

commit a8ba791fd8e43ef3bc0b2330445c85ee8037f351
Author: Ola Karlsson <olakar@chromium.org>
Date: Sat Sep 22 23:50:17 2018

[rotang] Add in the UpdateRota handler.

Trying to reuse as much as possible from the CreateRota handler.

Bug:  845549 
Change-Id: I3b651d7092ae487b04236eaae2fe21ac79fec9a7
Reviewed-on: https://chromium-review.googlesource.com/1233136
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17816}
[delete] https://crrev.com/601a57ac8265416d972b6c00308dd1bde9213eb6/go/src/infra/appengine/rotang/cmd/handlers/handle_createrota.go
[modify] https://crrev.com/a8ba791fd8e43ef3bc0b2330445c85ee8037f351/go/src/infra/appengine/rotang/cmd/handlers/handle_managerota_test.go
[add] https://crrev.com/a8ba791fd8e43ef3bc0b2330445c85ee8037f351/go/src/infra/appengine/rotang/cmd/handlers/handle_rota_test.go
[delete] https://crrev.com/601a57ac8265416d972b6c00308dd1bde9213eb6/go/src/infra/appengine/rotang/cmd/handlers/handle_createrota_test.go
[modify] https://crrev.com/a8ba791fd8e43ef3bc0b2330445c85ee8037f351/go/src/infra/appengine/rotang/cmd/handlers/templates/pages/managerota.html
[add] https://crrev.com/a8ba791fd8e43ef3bc0b2330445c85ee8037f351/go/src/infra/appengine/rotang/cmd/handlers/handle_rota.go
[modify] https://crrev.com/a8ba791fd8e43ef3bc0b2330445c85ee8037f351/go/src/infra/appengine/rotang/cmd/handlers/handle_managerota.go
[add] https://crrev.com/a8ba791fd8e43ef3bc0b2330445c85ee8037f351/go/src/infra/appengine/rotang/cmd/handlers/templates/pages/modifyrota.html
[modify] https://crrev.com/a8ba791fd8e43ef3bc0b2330445c85ee8037f351/go/src/infra/appengine/rotang/cmd/app/app.go
[delete] https://crrev.com/601a57ac8265416d972b6c00308dd1bde9213eb6/go/src/infra/appengine/rotang/cmd/handlers/templates/pages/createrota.html

Comment 21 by bugdroid1@chromium.org, Sep 23

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e7b4450ccb7b8ffe231f6b19226903639dffa4c6

commit e7b4450ccb7b8ffe231f6b19226903639dffa4c6
Author: Ola Karlsson <olakar@chromium.org>
Date: Tue Sep 25 23:21:54 2018

[rotang] This CL adds in the Calender interface and the Events implementation.

Other methods and handlers for Importing events from calendars together
with the job to handle swaps from accepting/declining calendar events coming
next.

Bug:  845549 
Change-Id: I0112c59780eafcb91bda66bdd1495757bd205339
Reviewed-on: https://chromium-review.googlesource.com/1239914
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17876}
[add] https://crrev.com/e7b4450ccb7b8ffe231f6b19226903639dffa4c6/go/src/infra/appengine/rotang/pkg/calendar/calendar_test.go
[add] https://crrev.com/e7b4450ccb7b8ffe231f6b19226903639dffa4c6/go/src/infra/appengine/rotang/pkg/calendar/calendar.go
[add] https://crrev.com/e7b4450ccb7b8ffe231f6b19226903639dffa4c6/go/src/infra/appengine/rotang/pkg/calendar/calendar.infra_testing
[modify] https://crrev.com/e7b4450ccb7b8ffe231f6b19226903639dffa4c6/go/src/infra/appengine/rotang/rotang.go

Comment 23 by bugdroid1@chromium.org, Sep 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/ba173351c3bec24ebf338f49ff9624d2aa8aa868

commit ba173351c3bec24ebf338f49ff9624d2aa8aa868
Author: Ola Karlsson <olakar@chromium.org>
Date: Tue Sep 25 23:45:52 2018

[rotang] Add handler for importing legacy calendar to ShiftEntries.

Bug:  845549 
Change-Id: Ic20c7cc2bce2b382f54895dd041f2c189ab19470
Reviewed-on: https://chromium-review.googlesource.com/1239916
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17877}
[modify] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/handle_deleterota_test.go
[modify] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/handlers_test.go
[modify] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/handle_index.go
[modify] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/job_email_test.go
[modify] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/handle_index_test.go
[add] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/templates/pages/shiftimport.html
[modify] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/handle_managerota_test.go
[modify] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/handle_list_test.go
[add] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/handle_shiftimport.go
[modify] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/handlers.infra_testing
[modify] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/handlers.go
[modify] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/job_schedule_test.go
[modify] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/handle_rota_test.go
[modify] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/handle_managerota.go
[add] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/handle_shiftimport_test.go
[modify] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/app/app.go
[modify] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/templates/pages/managerota.html
[modify] https://crrev.com/ba173351c3bec24ebf338f49ff9624d2aa8aa868/go/src/infra/appengine/rotang/cmd/handlers/handle_upload_test.go

Comment 24 by bugdroid1@chromium.org, Sep 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1e094e760e98e232a69f121da8505715bbbd2874

commit 1e094e760e98e232a69f121da8505715bbbd2874
Author: Ola Karlsson <olakar@chromium.org>
Date: Wed Sep 26 06:13:24 2018

[rotang] Adding in the remaining calendar package methods.


Bug:  845549 
Change-Id: Ied046873a1563f26b9081ae8e1bf0636fd2a6810
Reviewed-on: https://chromium-review.googlesource.com/1244856
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#17884}
[modify] https://crrev.com/1e094e760e98e232a69f121da8505715bbbd2874/go/src/infra/appengine/rotang/pkg/calendar/calendar.go
[modify] https://crrev.com/1e094e760e98e232a69f121da8505715bbbd2874/go/src/infra/appengine/rotang/rotang.go
[rename] https://crrev.com/1e094e760e98e232a69f121da8505715bbbd2874/go/src/infra/appengine/rotang/cmd/app/templates/pages/modifyrota.html
[modify] https://crrev.com/1e094e760e98e232a69f121da8505715bbbd2874/go/src/infra/appengine/rotang/cmd/app/app.yaml
[modify] https://crrev.com/1e094e760e98e232a69f121da8505715bbbd2874/go/src/infra/appengine/rotang/cmd/handlers/handle_upload_test.go
[rename] https://crrev.com/1e094e760e98e232a69f121da8505715bbbd2874/go/src/infra/appengine/rotang/cmd/app/templates/pages/upload.html
[modify] https://crrev.com/1e094e760e98e232a69f121da8505715bbbd2874/go/src/infra/appengine/rotang/pkg/calendar/calendar.infra_testing
[rename] https://crrev.com/1e094e760e98e232a69f121da8505715bbbd2874/go/src/infra/appengine/rotang/cmd/app/templates/pages/index.html
[rename] https://crrev.com/1e094e760e98e232a69f121da8505715bbbd2874/go/src/infra/appengine/rotang/cmd/app/templates/pages/list.html
[modify] https://crrev.com/1e094e760e98e232a69f121da8505715bbbd2874/go/src/infra/appengine/rotang/pkg/calendar/calendar_test.go
[modify] https://crrev.com/1e094e760e98e232a69f121da8505715bbbd2874/go/src/infra/appengine/rotang/cmd/handlers/job_email.go
[rename] https://crrev.com/1e094e760e98e232a69f121da8505715bbbd2874/go/src/infra/appengine/rotang/cmd/app/templates/pages/managerota.html
[modify] https://crrev.com/1e094e760e98e232a69f121da8505715bbbd2874/go/src/infra/appengine/rotang/cmd/app/app.go
[rename] https://crrev.com/1e094e760e98e232a69f121da8505715bbbd2874/go/src/infra/appengine/rotang/cmd/app/templates/pages/shiftimport.html

Comment 26 by bugdroid1@chromium.org, Oct 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4c15a0debf0b84236d547368e7a496e815b49ec5

commit 4c15a0debf0b84236d547368e7a496e815b49ec5
Author: Ola Karlsson <olakar@chromium.org>
Date: Wed Oct 03 03:09:21 2018

[rotang] Add in the EventUpdater.

This is the Job that read teh calendar events for encbled rotations to
update oncall status. This to handle the legacy systems shift swap using
the calendar accept/decline.

-- Changes to the handle_shiftimport_test.go and handlers_test.go is due to
moving shared test funcs / fakes to the handlers_test.go file.

Bug:  845549 
Change-Id: I8dfeed9cf2c5b2da4fd73a0e370baacbb0825141
Reviewed-on: https://chromium-review.googlesource.com/c/1244858
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18018}
[modify] https://crrev.com/4c15a0debf0b84236d547368e7a496e815b49ec5/go/src/infra/appengine/rotang/cmd/handlers/handle_shiftimport_test.go
[modify] https://crrev.com/4c15a0debf0b84236d547368e7a496e815b49ec5/go/src/infra/appengine/rotang/cmd/handlers/handlers_test.go
[add] https://crrev.com/4c15a0debf0b84236d547368e7a496e815b49ec5/go/src/infra/appengine/rotang/cmd/handlers/job_eventupdate_test.go
[modify] https://crrev.com/4c15a0debf0b84236d547368e7a496e815b49ec5/go/src/infra/appengine/rotang/cmd/handlers/handle_upload_test.go
[add] https://crrev.com/4c15a0debf0b84236d547368e7a496e815b49ec5/go/src/infra/appengine/rotang/cmd/handlers/job_eventupdate.go
[modify] https://crrev.com/4c15a0debf0b84236d547368e7a496e815b49ec5/go/src/infra/appengine/rotang/cmd/handlers/job_schedule_test.go

Comment 27 by bugdroid1@chromium.org, Oct 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23

commit 151e4cc62bc33a6a2ae95d709e7eecc95d96ce23
Author: Ola Karlsson <olakar@chromium.org>
Date: Fri Oct 05 00:16:25 2018

[rotang] Enable splits into different production environments.

Also added in a testSetup function to the handlers.
This to limit repeating the same setup over and over.

Bug:  845549 
Change-Id: Ie84a528c23c6285bf127b26557234960fb809c10
Reviewed-on: https://chromium-review.googlesource.com/c/1258725
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18079}
[modify] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/handlers/handle_deleterota_test.go
[modify] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/Makefile
[modify] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/handlers/handlers_test.go
[modify] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/handlers/job_email_test.go
[modify] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/handlers/handle_index_test.go
[modify] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/handlers/handle_managerota_test.go
[modify] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/handlers/handle_list_test.go
[rename] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/app/app_staging.yaml
[modify] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/handlers/job_eventupdate_test.go
[copy] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/app/app_local.yaml
[modify] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/handlers/handlers.go
[modify] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/handlers/job_schedule_test.go
[modify] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/handlers/handle_rota_test.go
[modify] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/handlers/handle_upload_test.go
[modify] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/handlers/handle_shiftimport_test.go
[modify] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/app/app.go
[copy] https://crrev.com/151e4cc62bc33a6a2ae95d709e7eecc95d96ce23/go/src/infra/appengine/rotang/cmd/app/app_prod.yaml

Comment 28 by bugdroid1@chromium.org, Oct 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9f29f401affcc3f2cb29029e3c75611d848382e6

commit 9f29f401affcc3f2cb29029e3c75611d848382e6
Author: Ola Karlsson <olakar@chromium.org>
Date: Fri Oct 05 00:33:25 2018

[rotang] Handling shifts spanning PDT/PST changes.

The Shift StartTime is in MTV time.
This CL handles changes between PDT/PST; without this change half the
year the shifts will show 23:00 instead of the expected 00:00 as the
start of a shift.

Time is hard.

Additionally the helperFunction adminOrOwner was added to get less repeated code
figuring out if the user owns the configuration to be changed.

Bug:  845549 
Change-Id: Iac88d8f25b22008417fa3b098176000b2e7e92fc
Reviewed-on: https://chromium-review.googlesource.com/c/1258727
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18080}
[modify] https://crrev.com/9f29f401affcc3f2cb29029e3c75611d848382e6/go/src/infra/appengine/rotang/pkg/calendar/calendar.go
[modify] https://crrev.com/9f29f401affcc3f2cb29029e3c75611d848382e6/go/src/infra/appengine/rotang/cmd/handlers/handlers_test.go
[modify] https://crrev.com/9f29f401affcc3f2cb29029e3c75611d848382e6/go/src/infra/appengine/rotang/pkg/algo/algo.go
[modify] https://crrev.com/9f29f401affcc3f2cb29029e3c75611d848382e6/go/src/infra/appengine/rotang/pkg/algo/fair_test.go
[modify] https://crrev.com/9f29f401affcc3f2cb29029e3c75611d848382e6/go/src/infra/appengine/rotang/cmd/handlers/job_email_test.go
[modify] https://crrev.com/9f29f401affcc3f2cb29029e3c75611d848382e6/go/src/infra/appengine/rotang/pkg/jsoncfg/jsoncfg.go
[modify] https://crrev.com/9f29f401affcc3f2cb29029e3c75611d848382e6/go/src/infra/appengine/rotang/cmd/handlers/handle_upload_test.go
[modify] https://crrev.com/9f29f401affcc3f2cb29029e3c75611d848382e6/go/src/infra/appengine/rotang/pkg/algo/algo_test.go
[modify] https://crrev.com/9f29f401affcc3f2cb29029e3c75611d848382e6/go/src/infra/appengine/rotang/cmd/handlers/handle_shiftimport.go
[modify] https://crrev.com/9f29f401affcc3f2cb29029e3c75611d848382e6/go/src/infra/appengine/rotang/cmd/handlers/handlers.go
[modify] https://crrev.com/9f29f401affcc3f2cb29029e3c75611d848382e6/go/src/infra/appengine/rotang/pkg/calendar/calendar_test.go
[modify] https://crrev.com/9f29f401affcc3f2cb29029e3c75611d848382e6/go/src/infra/appengine/rotang/cmd/handlers/handle_rota.go
[modify] https://crrev.com/9f29f401affcc3f2cb29029e3c75611d848382e6/go/src/infra/appengine/rotang/pkg/algo/legacy_test.go
[modify] https://crrev.com/9f29f401affcc3f2cb29029e3c75611d848382e6/go/src/infra/appengine/rotang/cmd/handlers/handle_rota_test.go

Comment 29 by bugdroid1@chromium.org, Oct 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a7eb094f7b9971f6c5271ada0ba92c370c47201d

commit a7eb094f7b9971f6c5271ada0ba92c370c47201d
Author: Ola Karlsson <olakar@chromium.org>
Date: Fri Oct 05 00:48:15 2018

[rotang] Add in the manageshifts handler.

This CL contains handers for
- Getting shift history.
- Changing current shift entries.
- Generating new shift entries.



Bug:  845549 
Change-Id: I0364bfefe52a45070842695e2fab4a5ea5219e99
Reviewed-on: https://chromium-review.googlesource.com/c/1258729
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18081}
[add] https://crrev.com/a7eb094f7b9971f6c5271ada0ba92c370c47201d/go/src/infra/appengine/rotang/cmd/handlers/handle_manageshifts_test.go
[add] https://crrev.com/a7eb094f7b9971f6c5271ada0ba92c370c47201d/go/src/infra/appengine/rotang/cmd/app/templates/pages/manageshifts.html
[add] https://crrev.com/a7eb094f7b9971f6c5271ada0ba92c370c47201d/go/src/infra/appengine/rotang/cmd/handlers/handle_manageshifts.go

Comment 30 by bugdroid1@chromium.org, Oct 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b103d03dfb55a4b8f910930288ed9efbdaecc24b

commit b103d03dfb55a4b8f910930288ed9efbdaecc24b
Author: Ola Karlsson <olakar@chromium.org>
Date: Fri Oct 05 00:58:46 2018

[rotang] This is the handler used by the 'shiftgenerate-element'



Bug:  845549 
Change-Id: I21a3e6650fed54e9ee02fe824a085f2e8d0a2dc1
Reviewed-on: https://chromium-review.googlesource.com/c/1258730
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18085}
[add] https://crrev.com/b103d03dfb55a4b8f910930288ed9efbdaecc24b/go/src/infra/appengine/rotang/cmd/handlers/handle_generate.go
[add] https://crrev.com/b103d03dfb55a4b8f910930288ed9efbdaecc24b/go/src/infra/appengine/rotang/cmd/handlers/handle_generate_test.go

Comment 31 by bugdroid1@chromium.org, Oct 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d876fbd3479ca75c93928b25ceda0597dcec2dcc

commit d876fbd3479ca75c93928b25ceda0597dcec2dcc
Author: Ola Karlsson <olakar@chromium.org>
Date: Sat Oct 06 04:45:52 2018

[rotang] Some documentation on how to switch things over.

Bug:  845549 
Change-Id: I83d8f2d698799aa90835390505987823fe2d4017
Reviewed-on: https://chromium-review.googlesource.com/c/1263720
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18137}
[modify] https://crrev.com/d876fbd3479ca75c93928b25ceda0597dcec2dcc/go/src/infra/appengine/rotang/README.md
[modify] https://crrev.com/d876fbd3479ca75c93928b25ceda0597dcec2dcc/go/src/infra/appengine/rotang/BROWSE.md
[add] https://crrev.com/d876fbd3479ca75c93928b25ceda0597dcec2dcc/go/src/infra/appengine/rotang/SWITCH.md

Comment 32 by bugdroid1@chromium.org, Oct 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1cccbf346fcc2e55a931b5b0a85adb49ca3def86

commit 1cccbf346fcc2e55a931b5b0a85adb49ca3def86
Author: Ola Karlsson <olakar@chromium.org>
Date: Mon Oct 08 05:59:19 2018

[rotang] Some tweaks to the documentation and a broken link fixed.

Bug:  845549 
Change-Id: I98e96e5f07340a589c9560281a3b570066a01d4f
Reviewed-on: https://chromium-review.googlesource.com/c/1267856
Reviewed-by: Andrew McRae <amcrae@chromium.org>
Reviewed-by: Ola Karlsson <olakar@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18139}
[modify] https://crrev.com/1cccbf346fcc2e55a931b5b0a85adb49ca3def86/go/src/infra/appengine/rotang/cmd/app/templates/pages/index.html
[modify] https://crrev.com/1cccbf346fcc2e55a931b5b0a85adb49ca3def86/go/src/infra/appengine/rotang/SWITCH.md

Comment 33 by bugdroid1@chromium.org, Oct 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/74474de216f631c20873d2284db31b6d20af30ce

commit 74474de216f631c20873d2284db31b6d20af30ce
Author: Ola Karlsson <olakar@chromium.org>
Date: Fri Oct 12 00:14:05 2018

[rotang] Adding in the elements to handle shifts.

Ran into a nice surprise that TS in not allowed so had to rewrite
the modules in JS..


Bug:  845549 
Change-Id: Ic1c8f08945203629df7e688ad1f9b67fad4a17ff
Reviewed-on: https://chromium-review.googlesource.com/c/1258731
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18266}
[add] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/cmd/app/static/src/rotashiftgenerate.js
[modify] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/pkg/algo/fair.go
[add] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/cmd/app/.gcloudignore
[add] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/cmd/app/static/.gitignore
[modify] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/cmd/app/templates/pages/managerota.html
[modify] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/cmd/app/index.yaml
[add] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/cmd/app/static/package.json
[add] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/cmd/app/static/src/.eslintrc.json
[add] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/cmd/app/static/src/constants.js
[modify] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/cmd/app/templates/pages/manageshifts.html
[add] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/cmd/app/static/webpack.config.js
[modify] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/cmd/handlers/handlers.go
[add] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/cmd/app/static/src/rotashifthistory.js
[add] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/cmd/app/static/package-lock.json
[add] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/cmd/app/static/src/rotashiftcurrent.js
[modify] https://crrev.com/74474de216f631c20873d2284db31b6d20af30ce/go/src/infra/appengine/rotang/cmd/app/app.go

Comment 34 by bugdroid1@chromium.org, Oct 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1ca9ba3aad71ed915ee361ad50f9d8cc7ab4e83d

commit 1ca9ba3aad71ed915ee361ad50f9d8cc7ab4e83d
Author: Ola Karlsson <olakar@chromium.org>
Date: Tue Oct 16 01:41:17 2018

[rotang] Borrowing some stuff from Sheriff-o-matic auth users to the Rota service.

Bug:  845549 
Change-Id: I5d6cb652909c11e3d4bb1fb631988d8d8462f56e
Reviewed-on: https://chromium-review.googlesource.com/c/1279983
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18339}
[modify] https://crrev.com/1ca9ba3aad71ed915ee361ad50f9d8cc7ab4e83d/go/src/infra/appengine/rotang/cmd/app/app_staging.yaml
[modify] https://crrev.com/1ca9ba3aad71ed915ee361ad50f9d8cc7ab4e83d/go/src/infra/appengine/rotang/cmd/app/app.go
[modify] https://crrev.com/1ca9ba3aad71ed915ee361ad50f9d8cc7ab4e83d/go/src/infra/appengine/rotang/cmd/app/app_prod.yaml

Comment 35 by bugdroid1@chromium.org, Nov 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/154352f05e8729e97d09e91ae75faf25e741a43a

commit 154352f05e8729e97d09e91ae75faf25e741a43a
Author: Ola Karlsson <olakar@chromium.org>
Date: Thu Nov 08 00:43:09 2018

[rotang] Adding scheduled backups of the Datastore.

Bug:  845549 
Change-Id: I903cee24e996e6382204d7b3e369060f1b3442c0
Reviewed-on: https://chromium-review.googlesource.com/c/1319218
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Ola Karlsson <olakar@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18855}
[add] https://crrev.com/154352f05e8729e97d09e91ae75faf25e741a43a/go/src/infra/appengine/rotang/cmd/handlers/job_backup.go
[modify] https://crrev.com/154352f05e8729e97d09e91ae75faf25e741a43a/go/src/infra/appengine/rotang/cmd/handlers/handlers_test.go
[modify] https://crrev.com/154352f05e8729e97d09e91ae75faf25e741a43a/go/src/infra/appengine/rotang/cmd/app/cron.yaml
[modify] https://crrev.com/154352f05e8729e97d09e91ae75faf25e741a43a/go/src/infra/appengine/rotang/cmd/handlers/handlers.go
[modify] https://crrev.com/154352f05e8729e97d09e91ae75faf25e741a43a/go/src/infra/appengine/rotang/cmd/handlers/handle_managerota_test.go
[modify] https://crrev.com/154352f05e8729e97d09e91ae75faf25e741a43a/go/src/infra/appengine/rotang/cmd/handlers/handle_index_test.go
[modify] https://crrev.com/154352f05e8729e97d09e91ae75faf25e741a43a/go/src/infra/appengine/rotang/cmd/handlers/handle_list_test.go
[modify] https://crrev.com/154352f05e8729e97d09e91ae75faf25e741a43a/go/src/infra/appengine/rotang/cmd/handlers/handle_deleterota.go
[modify] https://crrev.com/154352f05e8729e97d09e91ae75faf25e741a43a/go/src/infra/appengine/rotang/cmd/handlers/handle_rota_test.go
[modify] https://crrev.com/154352f05e8729e97d09e91ae75faf25e741a43a/go/src/infra/appengine/rotang/cmd/handlers/handle_upload_test.go
[modify] https://crrev.com/154352f05e8729e97d09e91ae75faf25e741a43a/go/src/infra/appengine/rotang/cmd/handlers/job_eventupdate_test.go
[modify] https://crrev.com/154352f05e8729e97d09e91ae75faf25e741a43a/go/src/infra/appengine/rotang/cmd/app/app.go
[add] https://crrev.com/154352f05e8729e97d09e91ae75faf25e741a43a/go/src/infra/appengine/rotang/cmd/handlers/job_backup_test.go
[modify] https://crrev.com/154352f05e8729e97d09e91ae75faf25e741a43a/go/src/infra/appengine/rotang/cmd/handlers/job_schedule_test.go

Comment 39 by bugdroid1@chromium.org, Nov 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/17b972a3d8894e4f36c5a1b35bca6a09ad9af885

commit 17b972a3d8894e4f36c5a1b35bca6a09ad9af885
Author: Ola Karlsson <olakar@chromium.org>
Date: Wed Nov 14 02:49:19 2018

[rotang] Add in the Oncall Element and Handler.
Bug:845549
Change-Id: Ice5b25690488dd49d3be9a1b17e8647195f0433d

Change-Id: Ice5b25690488dd49d3be9a1b17e8647195f0433d
Reviewed-on: https://chromium-review.googlesource.com/c/1331187
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18974}
[add] https://crrev.com/17b972a3d8894e4f36c5a1b35bca6a09ad9af885/go/src/infra/appengine/rotang/cmd/handlers/handle_oncall.go
[modify] https://crrev.com/17b972a3d8894e4f36c5a1b35bca6a09ad9af885/go/src/infra/appengine/rotang/cmd/handlers/handle_index.go
[add] https://crrev.com/17b972a3d8894e4f36c5a1b35bca6a09ad9af885/go/src/infra/appengine/rotang/cmd/handlers/handle_oncall_test.go
[modify] https://crrev.com/17b972a3d8894e4f36c5a1b35bca6a09ad9af885/go/src/infra/appengine/rotang/cmd/app/templates/pages/index.html
[modify] https://crrev.com/17b972a3d8894e4f36c5a1b35bca6a09ad9af885/go/src/infra/appengine/rotang/cmd/app/static/webpack.config.js
[add] https://crrev.com/17b972a3d8894e4f36c5a1b35bca6a09ad9af885/go/src/infra/appengine/rotang/cmd/app/static/src/rotaoncall.js
[modify] https://crrev.com/17b972a3d8894e4f36c5a1b35bca6a09ad9af885/go/src/infra/appengine/rotang/cmd/app/app.go
[add] https://crrev.com/17b972a3d8894e4f36c5a1b35bca6a09ad9af885/go/src/infra/appengine/rotang/cmd/app/templates/pages/oncall.html

Comment 40 by bugdroid1@chromium.org, Nov 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/04c02f070a324e6690b1b7dbf995420c2045e685

commit 04c02f070a324e6690b1b7dbf995420c2045e685
Author: Ola Karlsson <olakar@chromium.org>
Date: Wed Nov 14 03:04:19 2018

[rotang] Add in a the ability to query shifts from a time range.

Bug:  845549 
Change-Id: I5af40d61bb2a4b1839d9137dc62f192933efacc3
Reviewed-on: https://chromium-review.googlesource.com/c/1334867
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18975}
[modify] https://crrev.com/04c02f070a324e6690b1b7dbf995420c2045e685/go/src/infra/appengine/rotang/cmd/handlers/handle_manageshifts_test.go
[modify] https://crrev.com/04c02f070a324e6690b1b7dbf995420c2045e685/go/src/infra/appengine/rotang/rotang.go
[modify] https://crrev.com/04c02f070a324e6690b1b7dbf995420c2045e685/go/src/infra/appengine/rotang/cmd/handlers/handle_manageshifts.go
[modify] https://crrev.com/04c02f070a324e6690b1b7dbf995420c2045e685/go/src/infra/appengine/rotang/pkg/datastore/shiftstorer.go
[modify] https://crrev.com/04c02f070a324e6690b1b7dbf995420c2045e685/go/src/infra/appengine/rotang/pkg/datastore/shiftstorer_test.go
[modify] https://crrev.com/04c02f070a324e6690b1b7dbf995420c2045e685/go/src/infra/appengine/rotang/cmd/handlers/job_schedule.go
[modify] https://crrev.com/04c02f070a324e6690b1b7dbf995420c2045e685/go/src/infra/appengine/rotang/pkg/datastore/datastore_test.go
[modify] https://crrev.com/04c02f070a324e6690b1b7dbf995420c2045e685/go/src/infra/appengine/rotang/cmd/handlers/job_eventupdate.go

Comment 41 by bugdroid1@chromium.org, Nov 15

Project Member

Comment 43 by bugdroid1@chromium.org, Nov 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b884712d8730f24353c9d2c17b536a6c24f173dd

commit b884712d8730f24353c9d2c17b536a6c24f173dd
Author: Ola Karlsson <olakar@chromium.org>
Date: Tue Nov 27 00:30:44 2018

[rotang] Change from the /x/net/context to just context.

This due to it just being a link to "context" anyway in go1.9+.


Bug:  845549 
Change-Id: I2cd8439d621aaf44599973396ed5090298930302
Reviewed-on: https://chromium-review.googlesource.com/c/1338779
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19163}
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/cmd/handlers/handle_deleterota_test.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/pkg/calendar/calendar.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/cmd/handlers/handle_manageshifts_test.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/cmd/handlers/handlers_test.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/cmd/handlers/job_legacy_test.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/cmd/handlers/job_email_test.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/rotang.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/cmd/handlers/handle_managerota_test.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/cmd/handlers/handle_legacy_test.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/cmd/handlers/job_eventupdate.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/cmd/handlers/job_eventupdate_test.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/cmd/handlers/handlers.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/pkg/calendar/calendar_test.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/cmd/handlers/handle_rota_test.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/cmd/handlers/handle_generate_test.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/cmd/handlers/handle_shiftimport_test.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/cmd/handlers/job_schedule_test.go
[modify] https://crrev.com/b884712d8730f24353c9d2c17b536a6c24f173dd/go/src/infra/appengine/rotang/cmd/handlers/job_email.go

Comment 44 by bugdroid1@chromium.org, Nov 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a2cb321988613331eec66c59e467f2cbe50e1a1d

commit a2cb321988613331eec66c59e467f2cbe50e1a1d
Author: Ola Karlsson <olakar@chromium.org>
Date: Tue Nov 27 03:06:20 2018

[rotang] Fix emails being sent once per day of oncall.

- With this fix in the emails are only sent once per shift.
- Additionally I created the group g/rotang-staging as the destination
  for emails sent in the staging environment.


Bug:  845549 
Change-Id: I624bb4572b66831be7600f2277583e7ed14e9ee4
Reviewed-on: https://chromium-review.googlesource.com/c/1351850
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19170}
[modify] https://crrev.com/a2cb321988613331eec66c59e467f2cbe50e1a1d/go/src/infra/appengine/rotang/cmd/handlers/job_email_test.go
[modify] https://crrev.com/a2cb321988613331eec66c59e467f2cbe50e1a1d/go/src/infra/appengine/rotang/cmd/handlers/job_email.go

Comment 45 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c68c0369f7cdb895f4a654f9f10c335c7a7545a5

commit c68c0369f7cdb895f4a654f9f10c335c7a7545a5
Author: Ola Karlsson <olakar@chromium.org>
Date: Wed Nov 28 02:52:09 2018

[rotang] Changing the rota create/modify to use lit-element.

This to get rid of the JS manipulationg the DOM directly.

Bug:  845549 
Change-Id: Ibf18c9c6565600da59910b808eb9b338af84474f
Reviewed-on: https://chromium-review.googlesource.com/c/1351854
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19195}
[add] https://crrev.com/c68c0369f7cdb895f4a654f9f10c335c7a7545a5/go/src/infra/appengine/rotang/cmd/app/templates/pages/rotamodify.html
[delete] https://crrev.com/aa9d68ceed8516e09390d1bbd2f374397de24d23/go/src/infra/appengine/rotang/cmd/app/templates/pages/modifyrota.html
[modify] https://crrev.com/c68c0369f7cdb895f4a654f9f10c335c7a7545a5/go/src/infra/appengine/rotang/cmd/handlers/handle_rota_test.go
[modify] https://crrev.com/c68c0369f7cdb895f4a654f9f10c335c7a7545a5/go/src/infra/appengine/rotang/cmd/handlers/handle_rota.go
[modify] https://crrev.com/c68c0369f7cdb895f4a654f9f10c335c7a7545a5/go/src/infra/appengine/rotang/pkg/datastore/datastore.go
[modify] https://crrev.com/c68c0369f7cdb895f4a654f9f10c335c7a7545a5/go/src/infra/appengine/rotang/cmd/app/app.go
[add] https://crrev.com/c68c0369f7cdb895f4a654f9f10c335c7a7545a5/go/src/infra/appengine/rotang/cmd/app/templates/pages/rotacreate.html

Comment 47 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/86d9d3ad3eab0f84b96fc88026a2addb3825bc48

commit 86d9d3ad3eab0f84b96fc88026a2addb3825bc48
Author: Ola Karlsson <olakar@chromium.org>
Date: Thu Nov 29 03:44:40 2018

[rotang] Make the Calendar Event description exact match.

b/118075231

The Chrome Os Gardener have two rotations in the same calendar.

Chrome on ChromeOS Gardening

and

Chrome on ChromeOS Gardening Shadow

The Calendar query for "Chrome on ChromeOS Gardening" matches both.


Bug:  845549 
Change-Id: I68f60b267fc2fd8ac94511e163b4ace8eaea971b
Reviewed-on: https://chromium-review.googlesource.com/c/1351863
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19225}
[modify] https://crrev.com/86d9d3ad3eab0f84b96fc88026a2addb3825bc48/go/src/infra/appengine/rotang/pkg/calendar/calendar.go

Comment 48 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5dc57145167445791b556912f924f8b69d01bbe2

commit 5dc57145167445791b556912f924f8b69d01bbe2
Author: Ola Karlsson <olakar@chromium.org>
Date: Thu Nov 29 21:37:53 2018

[rotang] Adding in a login URL link on Access Denied.

Bug:  845549 
Change-Id: I7061b10fec0c671123999297291156b8b49f33c4
Reviewed-on: https://chromium-review.googlesource.com/c/1353010
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19248}
[modify] https://crrev.com/5dc57145167445791b556912f924f8b69d01bbe2/go/src/infra/appengine/rotang/cmd/app/app.go

Comment 49 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0cc41730fa0d728658ace2b41e9310412f49d70b

commit 0cc41730fa0d728658ace2b41e9310412f49d70b
Author: Ola Karlsson <olakar@chromium.org>
Date: Thu Nov 29 21:51:19 2018

[rotang] CORS header only applied on cached entries.

Currently the CORS headers are only applied on cached entries.
Results should pretty much always come from the cache but for
cornercases this will put CORS headers on all requests.

Bug:  845549 
Change-Id: I46034e52df7286726bbd9c19b2bece78d179e5b8
Reviewed-on: https://chromium-review.googlesource.com/c/1353012
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19251}
[modify] https://crrev.com/0cc41730fa0d728658ace2b41e9310412f49d70b/go/src/infra/appengine/rotang/cmd/handlers/handle_legacy.go

Comment 50 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4b5fb2e3f3cf517fe7f3a58bca13ff1d9b4e4ce2

commit 4b5fb2e3f3cf517fe7f3a58bca13ff1d9b4e4ce2
Author: Ola Karlsson <olakar@chromium.org>
Date: Thu Nov 29 21:59:58 2018

[rotang] Small fixes to elements and handlers.

- Fixes to elements.
- Add in Generators read from the html template instead of static list.
- Update the Calendar when swapping shifts.

Bug:  845549 
Change-Id: If4a94f663d1bc9101f41da8d319e4f3fcee80c04
Reviewed-on: https://chromium-review.googlesource.com/c/1353011
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19252}
[modify] https://crrev.com/4b5fb2e3f3cf517fe7f3a58bca13ff1d9b4e4ce2/go/src/infra/appengine/rotang/cmd/app/static/src/rotashiftgenerate.js
[modify] https://crrev.com/4b5fb2e3f3cf517fe7f3a58bca13ff1d9b4e4ce2/go/src/infra/appengine/rotang/cmd/handlers/handle_manageshifts.go
[modify] https://crrev.com/4b5fb2e3f3cf517fe7f3a58bca13ff1d9b4e4ce2/go/src/infra/appengine/rotang/cmd/app/static/package.json
[modify] https://crrev.com/4b5fb2e3f3cf517fe7f3a58bca13ff1d9b4e4ce2/go/src/infra/appengine/rotang/pkg/datastore/shiftstorer.go
[modify] https://crrev.com/4b5fb2e3f3cf517fe7f3a58bca13ff1d9b4e4ce2/go/src/infra/appengine/rotang/cmd/app/templates/pages/manageshifts.html
[modify] https://crrev.com/4b5fb2e3f3cf517fe7f3a58bca13ff1d9b4e4ce2/go/src/infra/appengine/rotang/cmd/app/templates/pages/index.html
[modify] https://crrev.com/4b5fb2e3f3cf517fe7f3a58bca13ff1d9b4e4ce2/go/src/infra/appengine/rotang/cmd/app/static/src/rotaoncall.js
[modify] https://crrev.com/4b5fb2e3f3cf517fe7f3a58bca13ff1d9b4e4ce2/go/src/infra/appengine/rotang/cmd/app/static/src/rotashiftswap.js
[modify] https://crrev.com/4b5fb2e3f3cf517fe7f3a58bca13ff1d9b4e4ce2/go/src/infra/appengine/rotang/cmd/handlers/handle_shiftswap_test.go
[modify] https://crrev.com/4b5fb2e3f3cf517fe7f3a58bca13ff1d9b4e4ce2/go/src/infra/appengine/rotang/cmd/handlers/handle_shiftswap.go
[modify] https://crrev.com/4b5fb2e3f3cf517fe7f3a58bca13ff1d9b4e4ce2/go/src/infra/appengine/rotang/cmd/app/static/package-lock.json
[modify] https://crrev.com/4b5fb2e3f3cf517fe7f3a58bca13ff1d9b4e4ce2/go/src/infra/appengine/rotang/cmd/app/static/src/rotamember.js

Comment 51 by bugdroid1@chromium.org, Dec 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4ba9709e4dec4664969a96ec2c141203dd675ad8

commit 4ba9709e4dec4664969a96ec2c141203dd675ad8
Author: Ola Karlsson <olakar@chromium.org>
Date: Sun Dec 02 23:17:07 2018

[rotang] A lit-element used to create/modify rotation configurations.

https://rota-ng-staging.googleplex.com/managerota - The manage button and the "Create new rotation" link uses the element.

Bug:  845549 
Change-Id: I7647408b80d1cb86f8069a3c2ce897e27dcf4aea
Reviewed-on: https://chromium-review.googlesource.com/c/1351859
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19289}
[add] https://crrev.com/4ba9709e4dec4664969a96ec2c141203dd675ad8/go/src/infra/appengine/rotang/cmd/app/templates/pages/playcreate.html
[modify] https://crrev.com/4ba9709e4dec4664969a96ec2c141203dd675ad8/go/src/infra/appengine/rotang/cmd/app/templates/pages/rotamodify.html
[add] https://crrev.com/4ba9709e4dec4664969a96ec2c141203dd675ad8/go/src/infra/appengine/rotang/cmd/app/templates/pages/playmodify.html
[modify] https://crrev.com/4ba9709e4dec4664969a96ec2c141203dd675ad8/go/src/infra/appengine/rotang/cmd/app/static/src/constants.js
[modify] https://crrev.com/4ba9709e4dec4664969a96ec2c141203dd675ad8/go/src/infra/appengine/rotang/cmd/app/static/webpack.config.js
[add] https://crrev.com/4ba9709e4dec4664969a96ec2c141203dd675ad8/go/src/infra/appengine/rotang/cmd/app/static/src/rotacreate.js
[modify] https://crrev.com/4ba9709e4dec4664969a96ec2c141203dd675ad8/go/src/infra/appengine/rotang/cmd/app/templates/pages/rotacreate.html

Comment 52 by bugdroid1@chromium.org, Dec 2

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/f56bfcf7d6ad647aa5f721745388fa5ccff49fbd

commit f56bfcf7d6ad647aa5f721745388fa5ccff49fbd
Author: Ola Karlsson <olakar@chromium.org>
Date: Sun Dec 02 23:43:37 2018

[rotang] Adding in a basic navigation bar.

Bug:  845549 
Change-Id: I238bb92ce7e0e56bdf8ddc7d3108489e99a6febd
Reviewed-on: https://chromium-review.googlesource.com/c/1353022
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19290}
[modify] https://crrev.com/f56bfcf7d6ad647aa5f721745388fa5ccff49fbd/go/src/infra/appengine/rotang/cmd/app/templates/pages/rotamodify.html
[modify] https://crrev.com/f56bfcf7d6ad647aa5f721745388fa5ccff49fbd/go/src/infra/appengine/rotang/Makefile
[modify] https://crrev.com/f56bfcf7d6ad647aa5f721745388fa5ccff49fbd/go/src/infra/appengine/rotang/cmd/app/templates/pages/shiftimport.html
[modify] https://crrev.com/f56bfcf7d6ad647aa5f721745388fa5ccff49fbd/go/src/infra/appengine/rotang/cmd/app/static/src/constants.js
[modify] https://crrev.com/f56bfcf7d6ad647aa5f721745388fa5ccff49fbd/go/src/infra/appengine/rotang/cmd/app/templates/pages/upload.html
[modify] https://crrev.com/f56bfcf7d6ad647aa5f721745388fa5ccff49fbd/go/src/infra/appengine/rotang/cmd/app/templates/pages/manageshifts.html
[modify] https://crrev.com/f56bfcf7d6ad647aa5f721745388fa5ccff49fbd/go/src/infra/appengine/rotang/cmd/app/templates/pages/index.html
[modify] https://crrev.com/f56bfcf7d6ad647aa5f721745388fa5ccff49fbd/go/src/infra/appengine/rotang/cmd/app/static/webpack.config.js
[add] https://crrev.com/f56bfcf7d6ad647aa5f721745388fa5ccff49fbd/go/src/infra/appengine/rotang/cmd/app/static/Makefile
[modify] https://crrev.com/f56bfcf7d6ad647aa5f721745388fa5ccff49fbd/go/src/infra/appengine/rotang/cmd/app/templates/pages/rotacreate.html
[modify] https://crrev.com/f56bfcf7d6ad647aa5f721745388fa5ccff49fbd/go/src/infra/appengine/rotang/cmd/app/templates/pages/managerota.html
[add] https://crrev.com/f56bfcf7d6ad647aa5f721745388fa5ccff49fbd/go/src/infra/appengine/rotang/cmd/app/static/src/navbar.js
[modify] https://crrev.com/f56bfcf7d6ad647aa5f721745388fa5ccff49fbd/go/src/infra/appengine/rotang/cmd/app/templates/pages/oncall.html
[modify] https://crrev.com/f56bfcf7d6ad647aa5f721745388fa5ccff49fbd/go/src/infra/appengine/rotang/cmd/app/templates/pages/list.html

Comment 53 by bugdroid1@chromium.org, Dec 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf

commit d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf
Author: Ola Karlsson <olakar@chromium.org>
Date: Tue Dec 04 00:56:59 2018

[rotang] This CL adds in migration documentation and tests.

pushed to: https://rota-ng-staging.googleplex.com -> Migrate in the NavBar

Bug:  845549 
Change-Id: Ia6cfdd3977e00d582369a3292030c653ebcf9419
Reviewed-on: https://chromium-review.googlesource.com/c/1358023
Reviewed-by: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19313}
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/app/templates/pages/rotamodify.html
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/Makefile
[add] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handle_switchlist.go
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handle_legacy.go
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/job_email.go
[add] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/app/static/src/rotatestemail.js
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handle_rota.go
[add] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handle_emailtest.go
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/app/static/src/navbar.js
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handle_enabledisable_test.go
[add] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handle_emailtest_test.go
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/app/templates/pages/managerota.html
[add] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/app/templates/pages/switchlist.html
[delete] https://crrev.com/d8db46f418174fe5ec2280c8c3c3b43948303537/go/src/infra/appengine/rotang/cmd/app/templates/pages/playcreate.html
[delete] https://crrev.com/d8db46f418174fe5ec2280c8c3c3b43948303537/go/src/infra/appengine/rotang/cmd/app/templates/pages/playmodify.html
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handle_legacy_test.go
[add] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/app/static/src/rotatestcal.js
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/app/templates/pages/index.html
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handle_deleterota.go
[add] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handle_switch.go
[delete] https://crrev.com/d8db46f418174fe5ec2280c8c3c3b43948303537/go/src/infra/appengine/rotang/cmd/app/templates/pages/shiftimport.html
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handle_deleterota_test.go
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handle_managerota.go
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handle_enabledisable.go
[add] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/app/templates/pages/switchrota.html
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handle_shiftimport_test.go
[add] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handle_caltest.go
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/app/static/src/constants.js
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/app/static/webpack.config.js
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handlers.go
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/handlers/handle_shiftimport.go
[add] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/app/static/src/rotashiftimport.js
[modify] https://crrev.com/d0db1296646172b03ab2c3fcaee2ee6e0d51d6cf/go/src/infra/appengine/rotang/cmd/app/app.go

Comment 54 by olakar@chromium.org, Dec 4

With the migration document submitted, this will be the release used to test out the migration process. 

js/json files are already served by this service. 
Bar: 

https://chromium-review.googlesource.com/c/chromium/src/+/1280084 <- Some tool that have been a bit tricky to get reviewed. 
https://chrome-internal-review.googlesource.com/c/chrome/tools/build/+/724108 <- Some build webpages.

Comment 55 by bugdroid1@chromium.org, Dec 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/eecfeb32a546b9ff56044cd22099c3c8ff6ebe7b

commit eecfeb32a546b9ff56044cd22099c3c8ff6ebe7b
Author: Ola Karlsson <olakar@chromium.org>
Date: Thu Dec 06 21:41:09 2018

[rotang] OOO not working properly with Outage larger than a shift.

- Turns out the Personal Outage logic was checking for an outage to start
or end inside a day. This gave that longer outages larger than a full shift
was not handled correctly.
- While there I moved the Generator code over to the shared handlers rota method too.


Bug:  845549 
Change-Id: Idf6ebb4884749797314095f3eab9c31e40d53d4e
Reviewed-on: https://chromium-review.googlesource.com/c/1365290
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19393}
[modify] https://crrev.com/eecfeb32a546b9ff56044cd22099c3c8ff6ebe7b/go/src/infra/appengine/rotang/pkg/algo/algo.go
[modify] https://crrev.com/eecfeb32a546b9ff56044cd22099c3c8ff6ebe7b/go/src/infra/appengine/rotang/pkg/algo/algo_test.go
[modify] https://crrev.com/eecfeb32a546b9ff56044cd22099c3c8ff6ebe7b/go/src/infra/appengine/rotang/cmd/handlers/handle_generate.go
[modify] https://crrev.com/eecfeb32a546b9ff56044cd22099c3c8ff6ebe7b/go/src/infra/appengine/rotang/cmd/handlers/handle_member.go
[modify] https://crrev.com/eecfeb32a546b9ff56044cd22099c3c8ff6ebe7b/go/src/infra/appengine/rotang/cmd/handlers/handle_generate_test.go

Comment 57 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1c9d9628e61494e50ab742129f64f0c1acffcf76

commit 1c9d9628e61494e50ab742129f64f0c1acffcf76
Author: Ola Karlsson <olakar@chromium.org>
Date: Mon Dec 10 23:51:10 2018

[rotang] A CL with some smaller fixes to Calendar and Email handling.

- Makes the email job use Before/After instead of Date.
   This due to daylight savings messing up times when using Date.
- Changing the Rota Name -> shift separator.
- Some spelling and minor fixes.


Turns out when you mess areound with date Daylight Savings start messing
things up.. Using the time.Before/After methods makes that nicer.


Bug:  845549 
Change-Id: I43817b83fd6a0665f501c16399c4ff066e3cd060
Reviewed-on: https://chromium-review.googlesource.com/c/1369470
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19466}
[modify] https://crrev.com/1c9d9628e61494e50ab742129f64f0c1acffcf76/go/src/infra/appengine/rotang/pkg/calendar/calendar.go
[modify] https://crrev.com/1c9d9628e61494e50ab742129f64f0c1acffcf76/go/src/infra/appengine/rotang/cmd/app/templates/pages/switchrota.html
[modify] https://crrev.com/1c9d9628e61494e50ab742129f64f0c1acffcf76/go/src/infra/appengine/rotang/cmd/handlers/job_email_test.go
[modify] https://crrev.com/1c9d9628e61494e50ab742129f64f0c1acffcf76/go/src/infra/appengine/rotang/cmd/handlers/job_schedule.go
[modify] https://crrev.com/1c9d9628e61494e50ab742129f64f0c1acffcf76/go/src/infra/appengine/rotang/cmd/handlers/handle_caltest.go
[modify] https://crrev.com/1c9d9628e61494e50ab742129f64f0c1acffcf76/go/src/infra/appengine/rotang/cmd/handlers/job_email.go
[modify] https://crrev.com/1c9d9628e61494e50ab742129f64f0c1acffcf76/go/src/infra/appengine/rotang/pkg/datastore/shiftstorer.go
[modify] https://crrev.com/1c9d9628e61494e50ab742129f64f0c1acffcf76/go/src/infra/appengine/rotang/cmd/handlers/handlers.go
[modify] https://crrev.com/1c9d9628e61494e50ab742129f64f0c1acffcf76/go/src/infra/appengine/rotang/pkg/calendar/calendar_test.go
[modify] https://crrev.com/1c9d9628e61494e50ab742129f64f0c1acffcf76/go/src/infra/appengine/rotang/cmd/handlers/handle_rota.go
[modify] https://crrev.com/1c9d9628e61494e50ab742129f64f0c1acffcf76/go/src/infra/appengine/rotang/cmd/app/static/src/rotashiftgenerate.js
[modify] https://crrev.com/1c9d9628e61494e50ab742129f64f0c1acffcf76/go/src/infra/appengine/rotang/cmd/handlers/job_schedule_test.go

Comment 58 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4fda6ce4a3e2e78fb263a9bb698c36f5ac9e581b

commit 4fda6ce4a3e2e78fb263a9bb698c36f5ac9e581b
Author: Ola Karlsson <olakar@chromium.org>
Date: Wed Dec 12 22:59:59 2018

[rotang] With some rotations getting migrated adding in the event update job.


This job reads the calendar and updates the DataStore shift if there's been
any changes. This to handle the legacy shift swap process.



Bug:  845549 
Change-Id: I15476abad03095eb49222b793e7bffb4d97c37d3
Reviewed-on: https://chromium-review.googlesource.com/c/1369479
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19530}
[modify] https://crrev.com/4fda6ce4a3e2e78fb263a9bb698c36f5ac9e581b/go/src/infra/appengine/rotang/cmd/handlers/handlers_test.go
[modify] https://crrev.com/4fda6ce4a3e2e78fb263a9bb698c36f5ac9e581b/go/src/infra/appengine/rotang/cmd/app/templates/pages/switchrota.html
[modify] https://crrev.com/4fda6ce4a3e2e78fb263a9bb698c36f5ac9e581b/go/src/infra/appengine/rotang/cmd/app/cron.yaml
[modify] https://crrev.com/4fda6ce4a3e2e78fb263a9bb698c36f5ac9e581b/go/src/infra/appengine/rotang/cmd/handlers/job_email.go
[modify] https://crrev.com/4fda6ce4a3e2e78fb263a9bb698c36f5ac9e581b/go/src/infra/appengine/rotang/cmd/app/static/src/rotacreate.js
[modify] https://crrev.com/4fda6ce4a3e2e78fb263a9bb698c36f5ac9e581b/go/src/infra/appengine/rotang/cmd/handlers/job_eventupdate.go
[modify] https://crrev.com/4fda6ce4a3e2e78fb263a9bb698c36f5ac9e581b/go/src/infra/appengine/rotang/cmd/app/app.go

Comment 59 by bugdroid1@chromium.org, Dec 14

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b232fd50ed227aeaab944f5e9be6074d075ff829

commit b232fd50ed227aeaab944f5e9be6074d075ff829
Author: Ola Karlsson <olakar@chromium.org>
Date: Fri Dec 14 01:03:55 2018

[rotang] For enabled configurations, use the native calendar permissions.

Bug:  845549 
Change-Id: I119bcc5a0b59071d9a5cb6dedad7dc979e799074
Reviewed-on: https://chromium-review.googlesource.com/c/1375411
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19558}
[modify] https://crrev.com/b232fd50ed227aeaab944f5e9be6074d075ff829/go/src/infra/appengine/rotang/cmd/handlers/handle_legacy.go
[modify] https://crrev.com/b232fd50ed227aeaab944f5e9be6074d075ff829/go/src/infra/appengine/rotang/cmd/handlers/job_eventupdate.go

Comment 61 by bugdroid1@chromium.org, Dec 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/85ccc0c6e8a40f5264af527a3f9d9ae899486dbb

commit 85ccc0c6e8a40f5264af527a3f9d9ae899486dbb
Author: Ola Karlsson <olakar@chromium.org>
Date: Sun Dec 16 23:19:56 2018

[rotang] Some element touch ups.

- When modifying an existing rota config the default generator is not set from config.
- The Description field for create/modify rotation changed to a textarea.

Bug:  845549 
Change-Id: I970a92dfa8d828f369a479a7a064213aa8912f8a
Reviewed-on: https://chromium-review.googlesource.com/c/1377811
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19589}
[modify] https://crrev.com/85ccc0c6e8a40f5264af527a3f9d9ae899486dbb/go/src/infra/appengine/rotang/cmd/app/static/src/rotacreate.js

Comment 62 by bugdroid1@chromium.org, Dec 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4394044d609fae6b607b698c4812985562182d67

commit 4394044d609fae6b607b698c4812985562182d67
Author: Ola Karlsson <olakar@chromium.org>
Date: Sun Dec 16 23:22:36 2018

[rotang] Updating the CLANK stability calendar entry.

They've changed the entry in the legacy JSON files making the legacy handler
not able to find the calendar events.

Bug:  845549 
Change-Id: Ib4a8dbf22c739a6c93ee753126d55288e61140cc
Reviewed-on: https://chromium-review.googlesource.com/c/1377809
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19590}
[modify] https://crrev.com/4394044d609fae6b607b698c4812985562182d67/go/src/infra/appengine/rotang/cmd/handlers/handle_legacy.go

Comment 64 by bugdroid1@chromium.org, Jan 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b55880d5b161440d25acf6212d6fe5b3ef954deb

commit b55880d5b161440d25acf6212d6fe5b3ef954deb
Author: Ola Karlsson <olakar@chromium.org>
Date: Tue Jan 08 23:50:03 2019

[rotang] Looks like prod-tech will be the new owners of rotation tooling.

This gives I'll add the Sydney people in here now, will sort out a group
later.


Bug:  845549 
Change-Id: I857ad4fab4fe66b2c3949fd0ee26398b4edfb521
Reviewed-on: https://chromium-review.googlesource.com/c/1401681
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19839}
[modify] https://crrev.com/b55880d5b161440d25acf6212d6fe5b3ef954deb/go/src/infra/appengine/rotang/OWNERS

Comment 65 by olakar@chromium.org, Jan 21

Components: Infra>ProdTech>Rotation
ProdTech in Syd is responsible for rotations.

Moving bugs to the new component

Comment 66 by bugdroid1@chromium.org, Jan 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/69a17e9c89c0485084604737e38a9c3943fa9566

commit 69a17e9c89c0485084604737e38a9c3943fa9566
Author: Ola Karlsson <olakar@chromium.org>
Date: Mon Jan 21 03:57:36 2019

[rotang] Updating the bug link with the new ProdTech component.

Bug:  845549 
Change-Id: Ifafa3525284e005dc580eaee682b9a7d3085d88b
Reviewed-on: https://chromium-review.googlesource.com/c/1424523
Reviewed-by: Scott Lewis-Kelly <slewiskelly@google.com>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20093}
[modify] https://crrev.com/69a17e9c89c0485084604737e38a9c3943fa9566/go/src/infra/appengine/rotang/cmd/app/static/src/constants.js
[modify] https://crrev.com/69a17e9c89c0485084604737e38a9c3943fa9566/go/src/infra/appengine/rotang/cmd/app/static/src/navbar.js

Comment 67 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/98695cd9165d7844c173a6c9c28be147b9f54d80

commit 98695cd9165d7844c173a6c9c28be147b9f54d80
Author: Ola Karlsson <olakar@chromium.org>
Date: Thu Jan 24 02:03:43 2019

[rotang] Storing the legacy calendar token in Datastore.

Currently the legacy token is read from files stored in the app/token folder.
Aside from not being optimal for security this makes it harder to adapt for the new deploy process.

Bug:  845549 
Change-Id: I1e08ef78373ef0aaf729180f8a7624dce1c2bb90
Reviewed-on: https://chromium-review.googlesource.com/c/1401964
Reviewed-by: Ola Karlsson <olakar@chromium.org>
Reviewed-by: Scott Lewis-Kelly <slewiskelly@google.com>
Commit-Queue: Ola Karlsson <olakar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20165}
[modify] https://crrev.com/98695cd9165d7844c173a6c9c28be147b9f54d80/go/src/infra/appengine/rotang/rotang.go
[modify] https://crrev.com/98695cd9165d7844c173a6c9c28be147b9f54d80/go/src/infra/appengine/rotang/pkg/datastore/datastore.go
[modify] https://crrev.com/98695cd9165d7844c173a6c9c28be147b9f54d80/go/src/infra/appengine/rotang/cmd/app/app.go
[add] https://crrev.com/98695cd9165d7844c173a6c9c28be147b9f54d80/go/src/infra/appengine/rotang/pkg/datastore/tokenstore_test.go
[add] https://crrev.com/98695cd9165d7844c173a6c9c28be147b9f54d80/go/src/infra/appengine/rotang/pkg/datastore/tokenstore.go

Comment 68 by olakar@chromium.org, Feb 6

Status: Fixed (was: Started)

Comment 69 by dpranke@chromium.org, Feb 6

Does marking this fixed mean that all of the rotations have been migrated over and the old code is cleaned up?

(Just asking because I didn't realize we were quite that far along if so; woohoo?)

Comment 70 by olakar@chromium.org, Feb 6

Hi Dirk.

No that was not my intention with closing this bug.

What I wanted to signal was that the service is released and open for everyone to use. From here on it's bug/feature fixes.

Fine to reopen if you think that makes more sense, or maybe create another bug with migration status. 

== 

The migration process is self-serve and can be done at the rotation owners convenience. 
The new service handles the legacy calendar, serving the <sheriff>.{js,json} files and go/chromecals.

Mails have been sent to all rotation owners about how and when they need to change over their rotations. The majority have already migrated. 

Surprisingly there's also been a bunch of new rotations created, seem to be ChromeOS rotations that are coming over from rotation.googleplex.com that's being deprecated.

ChromeOS has requested for the rotation.py tool to stay until they finish their Google3 Oncall migration. 

Chrome Build is migrating in March.

Comment 71 by dpranke@chromium.org, Feb 6

Got it, thanks. It's fine to close this bug, but we should probably then have a separate bug tracking getting all of the existing rotations migrated over and the old code deleted.

Comment 72 by olakar@chromium.org, Feb 6

Makes a lot of sense , I'll sort that out.

Sign in to add a comment