[Standalone] Overflow menu Close incognito tabs option appears when there aren't any. |
|||||
Issue descriptionChrome Version: 68.0.3437.0 OS: Daydream Device: Lenovo standalone device What steps will reproduce the problem? (1) Open overflow menu by clicking on menu in Omnibox (2) Click Close incognito tabs (3) Re-open menu What is the expected result? The Close incognito tabs option should not appear since there aren't any incognito tabs open. What happens instead? The Close incognito tabs option always appears.
,
May 22 2018
,
May 23 2018
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e4e8783787ab02dcd37fcd5bbe9383da033ddd2 commit 3e4e8783787ab02dcd37fcd5bbe9383da033ddd2 Author: Christopher Grant <cjgrant@chromium.org> Date: Wed May 23 20:35:41 2018 VR: Fix visibility of close tabs menu item and add tests This was broken with the removal of extra menu items. BUG= 845548 R=bshe Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Id5fb1122738af342cf83c0d554f3f9dc46182885 Reviewed-on: https://chromium-review.googlesource.com/1070463 Reviewed-by: Biao She <bshe@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#561236} [modify] https://crrev.com/3e4e8783787ab02dcd37fcd5bbe9383da033ddd2/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/3e4e8783787ab02dcd37fcd5bbe9383da033ddd2/chrome/browser/vr/ui_unittest.cc
,
May 23 2018
,
May 30 2018
Verified on 68.0.3440.7 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dbbrooks@chromium.org
, May 22 2018