New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 845545 link

Starred by 2 users
Status: Assigned
Owner:
minch@chromium.org
Cc:
█ elizabethchiu@chromium.org
zalcorn@chromium.org
derat@chromium.org
█ warx@chromium.org
tbuck...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add corresponding accelerators for power button menu

Project Member Reported by minch@chromium.org, May 22 2018 
Power button menu includes at most three items, "Power off", "Sign out" and "Lock screen".

The accelerators that we enabled when the power button menu is opened are 
RIGHTNESS_DOWN, BRIGHTNESS_UP, VOLUME_DOWN, VOLUME_UP, VOLUME_MUTE,

We might also want to enable LOCK_SCREEN if menu contains "Lock screen"
and enable EXIT if menu contains "Sign out"

One problem is what Joe mentioned in 841600

"For "Ctrl+Shift+Q" signing out accelerator, the code path here: https://cs.chromium.org/chromium/src/ash/accelerators/accelerator_controller.cc?type=cs&sq=package:chromium&g=0&l=1385, will trigger warning dialog: `Press Ctrl+Shift+Q twice to sign out`. We need UX opinions here as well. We probably don't need to display the dialog, instead focus on signout menu item?"

Dan also suggested to add text like "Search+L" in the "Lock screen" item, and "Ctrl+Shift+Q" text in the "Sign out" item.

Comment 1 by minch@chromium.org, May 22 2018 

Zalcorn and Elizabeth, could you please help take a look whether we need this and how should we do if we need it?
e.g, how to detail with the reminder dialog of EXIT since we need to press "Ctrl+Shift+Q" twice to sign out.
And whether we need to add the reminder text of accelerators in the menu items? Thanks.

Comment 2 by zalcorn@chromium.org, May 24 2018 

Yep I'll sync with Elizabeth on this and come back with an answer!

Comment 3 by xiy...@chromium.org, May 25 2018

Components: UI>Shell UI>Input>KeyboardShortcuts

Comment 4 by zalcorn@chromium.org, Jun 1 2018 

I don't think we should include text for the accellerators in the power menu itself as it will end up looking very visually crowded.

For ctrl+shift+Q, is it possible to skip the dialog and allow for it to sign out with a single press IFF the power menu is already visible?

Comment 5 by warx@chromium.org, Jun 1 2018 

Probably tooltip for accelerator text?

It is possible to skip.

Comment 6 by lhchavez@chromium.org, Jun 1 2018

Components: -UI>Shell UI>Shell>PowerButton

Comment 7 by benhenry@chromium.org, Aug 3

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
►

Sign in to add a comment