performance_test_suite on Windows-10-15063 failing on chromium.win/Win10 Tests x64 (dbg) |
|||
Issue descriptionhttps://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/720 is the first failing build. Looks like it might have started after: https://chromium-review.googlesource.com/c/chromium/src/+/1066088
,
May 22 2018
,
May 22 2018
Does that fix actually address the issue entirely? If you pick a low-numbered shared, e.g. https://chromium-swarm.appspot.com/task?id=3da15b5409378f10&refresh=10&show_raw=1 then you see BrowserFinderException: Cannot find browser of type debug. Available browsers: debug_x64 reference which seems likely to be caused by this diff: 'Win10 Tests x64 (dbg)': { 'args': [ '--browser=debug', ], },
,
May 22 2018
Given that, should we revert?
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e653b28d15b1f801007c670bada8e64149211bc commit 4e653b28d15b1f801007c670bada8e64149211bc Author: Jeremy Roman <jbroman@chromium.org> Date: Tue May 22 20:03:03 2018 Revert "Re-adding dummy benchamrks to chromium debug waterfalls." This reverts commit 81715b6193a1841807e99bc416712b62a3df0c58. Reason for revert: Breaks on Win10 Tests x64 (dbg). """ BrowserFinderException: Cannot find browser of type debug. Available browsers: debug_x64 reference """ and """ Traceback (most recent call last): File "..\..\testing\scripts\run_performance_tests.py", line 312, in <module> sys.exit(main()) File "..\..\testing\scripts\run_performance_tests.py", line 284, in main sharding = sharding_map[shard_index]['benchmarks'] KeyError: '7' """ depending on shard number Original change's description: > Re-adding dummy benchamrks to chromium debug waterfalls. > > Previously > reviewed here: https://chromium-review.googlesource.com/c/chromium/src/+/1055776 > and then reverted. > > We have to set the browser for each configuration that we run on. > It will be one of debug, release or android-chromium. We can do this one > of two ways: > > 1) multiple entries in test_suites.pyl > 2) add each entry in test_suite_exceptions.pyl > > Although #1 is less verbose I think #2 is how these files are intended > to be used. > > Bug: 840427 > Change-Id: Idff4c36a248215dbfdf0faed45b483800046bf26 > Reviewed-on: https://chromium-review.googlesource.com/1066088 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Emily Hanley <eyaich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560571} TBR=nednguyen@google.com,eyaich@chromium.org,jbudorick@chromium.org Change-Id: I89ca43c0eb6292ee252c459e1db94749bfb603b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840427 , 845543 Reviewed-on: https://chromium-review.googlesource.com/1069420 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#560744} [modify] https://crrev.com/4e653b28d15b1f801007c670bada8e64149211bc/testing/buildbot/chromium.mac.json [modify] https://crrev.com/4e653b28d15b1f801007c670bada8e64149211bc/testing/buildbot/chromium.win.json [modify] https://crrev.com/4e653b28d15b1f801007c670bada8e64149211bc/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/4e653b28d15b1f801007c670bada8e64149211bc/testing/buildbot/test_suites.pyl [delete] https://crrev.com/ebc94b58f609b461e0799e10797080d4c8add639/tools/perf/core/smoke_test_benchmark_shard_map.json
,
Jun 14 2018
We are still experiencing issues with dummy_benchmark.stable_benchmark_1/dummy_page.html: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29 Is this the same bug, or a different one?
,
Jun 14 2018
No this is a different bug, crbug.com/848900
,
Jun 14 2018
Marking this as fixed as I have resolved the new issue in the other bug. |
|||
►
Sign in to add a comment |
|||
Comment 1 by eyaich@chromium.org
, May 22 2018