New issue
Advanced search Search tips

Issue 845530 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 918671
issue 674478



Sign in to add a comment

Surface "not useful" stats on the front-end with charts of not-useful over time.

Project Member Reported by qyears...@chromium.org, May 22 2018

Issue description

Proposal: there should be a page on the Tricium web app frontend with charts showing feedback numbers for different analyzers and categories over time.

Ideally, this front-end page should fetch from the backend all of the data that it needs in parallel when it needs it, e.g. we could initially show an overview, and then users could get the charts to show results per-category or for a longer time frame, or for just a specific analyzer.

The specific set of results to show could be specified in the URL, perhaps in the query string.

The initial version of the page could just show a table of numbers for the past few weeks.
 
Components: Infra>Platform>Tricium
Components: -Infra>CodeAnalysis
Labels: -Tricium
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0a798482882bc4efb5bf77309cf01e61c9d3b9d6

commit 0a798482882bc4efb5bf77309cf01e61c9d3b9d6
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Aug 02 16:44:00 2018

[tricium] Change parsing of dates in Feedback

Parsing of dates based on the given format string didn't appear
to work for RFC3339-formatted times that I tried out.

In this CL:
 - Change the parsing of dates to use the RFC3339 constant.
 - Also, minor refactoring: validateFeedbackRequest is different
   from all of the other validate functions, and the main thing it
   actually does is parse times. This CL renames and changes the
   function to reflect that.
 - Adds a couple tests.

Bug: 845530
Change-Id: Ia9a169a401478fb0e5295b71b170b22affdfebec
Reviewed-on: https://chromium-review.googlesource.com/1159471
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/0a798482882bc4efb5bf77309cf01e61c9d3b9d6/go/src/infra/tricium/appengine/frontend/rpc_feedback.go
[modify] https://crrev.com/0a798482882bc4efb5bf77309cf01e61c9d3b9d6/go/src/infra/tricium/appengine/frontend/rpc_feedback_test.go

Owner: ----
Status: Available (was: Assigned)
Blockedon: 918671
Next step: Plan a change to the datstore schema and add a cron job, bug 918671.

Sign in to add a comment