New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845522 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----


Previous locations:
gerrit:9052


Sign in to add a comment

"Reland" button doesn't work

Project Member Reported by thakis@chromium.org, May 22 2018

Issue description

Affected Version:

What steps will reproduce the problem?
1. Go to https://chromium-review.googlesource.com/c/chromium/src/+/1059860
2. Hit "Reland"

What is the expected output?

Creates reland.


What do you see instead?

Get "Cannot reland: Cherry pick failed: identical tree", button becomes "Can't reland"


Please provide any additional information below.


(I feel I filed this before, but I can't find it right now. Sorry if this is a dupe.)
 

Comment 1 by thakis@chromium.org, May 22 2018

Doesn't work on https://chromium-review.googlesource.com/c/chromium/src/+/1067949 either -- maybe the button is just broken everywhere?

Comment 2 by kaspern@google.com, May 22 2018

Project: chromium
Moved issue gerrit:9052 to now be issue chromium:845522.

Comment 3 by kaspern@google.com, May 22 2018

Components: Infra>Codereview>Gerrit
The reland button has now been broken for months. Should we just remove it? Who owns it?
Status: Untriaged (was: New)
I think Reland button is supposed to be used on the CL you want to reland (https://chromium-review.googlesource.com/c/chromium/src/+/1067460), not its revert
Aha! Maybe it should say that then instead of "Get "Cannot reland: Cherry pick failed: identical tree"?
Cc: kaspern@google.com
that would be helpful. That is a issue in polygerrit. I think I don't have permissions to move this issue there. +kaspern
I don't know that this is a PolyGerrit bug.

It sounds like the button should be eagerly disabled. Failing that, it seems like chromium-specific error messages should be added by chromium plugins, not Gerrit core. Here seems like a good spot:
https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/master/src/main/resources/static/chromium-behavior.html#544
ah, i assumed Revert button is not chromium-specific. Leaving the issue here then for triage (by folks who actually manage this component)
The Revert button is definitely part of Gerrit code, but the issue being described has only to do with the Reland button.
Status: Available (was: Untriaged)
Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment