"Reland" button doesn't work |
||||||
Issue descriptionAffected Version: What steps will reproduce the problem? 1. Go to https://chromium-review.googlesource.com/c/chromium/src/+/1059860 2. Hit "Reland" What is the expected output? Creates reland. What do you see instead? Get "Cannot reland: Cherry pick failed: identical tree", button becomes "Can't reland" Please provide any additional information below. (I feel I filed this before, but I can't find it right now. Sorry if this is a dupe.)
,
May 22 2018
,
May 22 2018
,
Sep 21
The reland button has now been broken for months. Should we just remove it? Who owns it?
,
Sep 21
,
Sep 21
I think Reland button is supposed to be used on the CL you want to reland (https://chromium-review.googlesource.com/c/chromium/src/+/1067460), not its revert
,
Sep 21
Aha! Maybe it should say that then instead of "Get "Cannot reland: Cherry pick failed: identical tree"?
,
Sep 21
that would be helpful. That is a issue in polygerrit. I think I don't have permissions to move this issue there. +kaspern
,
Sep 24
I don't know that this is a PolyGerrit bug. It sounds like the button should be eagerly disabled. Failing that, it seems like chromium-specific error messages should be added by chromium plugins, not Gerrit core. Here seems like a good spot: https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/master/src/main/resources/static/chromium-behavior.html#544
,
Sep 24
ah, i assumed Revert button is not chromium-specific. Leaving the issue here then for triage (by folks who actually manage this component)
,
Sep 24
The Revert button is definitely part of Gerrit code, but the issue being described has only to do with the Reland button.
,
Oct 31
,
Jan 11
Setting defect without priority to Pri-2. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by thakis@chromium.org
, May 22 2018