New issue
Advanced search Search tips

Issue 845511 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue 846720



Sign in to add a comment

dromaeo/http://dromaeo.com?dom-modify in dromaeo failing on chromium.perf/Android Nexus5X Perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 22 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of sullivan@google.com

dromaeo/http://dromaeo.com?dom-modify in dromaeo failing on chromium.perf/Android Nexus5X Perf

Builders failed on: 
- Android Nexus5X Perf: 
  https://ci.chromium.org/buildbot/chromium.perf/Android%20Nexus5X%20Perf

Disabling and kicking off a bisect.

Sample log:
https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Nexus5X_Perf%2F1784%2F%2B%2Frecipes%2Fsteps%2Fdromaeo_on_Android%2F0%2Fstdout
Traceback (most recent call last):
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 125, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 312, in RunStory
    self._current_page, self._current_tab, results)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/tools/perf/benchmarks/dromaeo.py", line 48, in ValidateAndMeasurePage
    tab.WaitForJavaScriptCondition('!!window.results_', timeout=600)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 239, in WaitForJavaScriptCondition
    return self._inspector_backend.WaitForJavaScriptCondition(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 302, in WaitForJavaScriptCondition
    e.message + '\n' + debug_message)
TimeoutException: Timed out while waiting 600s for IsJavaScriptExpressionTrue.
Console output:
(INFO) 2018-05-22 09:05:14,167 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s 01e15d4fa2659c8d shell '( ps | grep -F org.chromium.chrome; echo "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
(INFO) 2018-05-22 09:05:14,274 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s 01e15d4fa2659c8d shell '( ps | grep -F zygote; echo "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
(INFO) 2018-05-22 09:05:14,382 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s 01e15d4fa2659c8d shell '( ps | grep -F org.chromium.chrome; echo "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
(INFO) 2018-05-22 09:05:14,498 browser.Close:207  Closing browser (pid=6673) ...
(INFO) 2018-05-22 09:05:14,503 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s 01e15d4fa2659c8d forward --remove tcp:42077
(INFO) 2018-05-22 09:05:14,506 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s 01e15d4fa2659c8d shell '( ps | grep -F org.chromium.chrome; echo "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
(INFO) 2018-05-22 09:05:14,606 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s 01e15d4fa2659c8d shell '( am force-stop org.chromium.chrome );echo %$?'
(INFO) 2018-05-22 09:05:15,439 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s 01e15d4fa2659c8d shell '( ps | grep -F org.chromium.chrome; echo "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
(INFO) 2018-05-22 09:05:15,539 browser.Close:220  Browser is closed.
[  FAILED  ] dromaeo/http://dromaeo.com?dom-modify (625951 ms)
 
Cc: jbroman@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4fe92c0fd2538d87f738f1d5cd3bc8dedd11427

commit e4fe92c0fd2538d87f738f1d5cd3bc8dedd11427
Author: Annie Sullivan <sullivan@chromium.org>
Date: Tue May 22 15:39:45 2018

Disable failing dromaeo modify benchmark on Nexus 5X.

Bug:  845511 
Change-Id: Id4e81ee812e4f2e3005b0d1f8392bd01be6e340d
TBR: charliea@chromium.org
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/1069123
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560606}
[modify] https://crrev.com/e4fe92c0fd2538d87f738f1d5cd3bc8dedd11427/tools/perf/expectations.config

Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, May 23 2018

Cc: thomasanderson@chromium.org twelling...@chromium.org
Owner: thomasanderson@chromium.org
Status: Assigned (was: Available)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/14853862240000

[EoC] Update in-product help for slim peek by twellington@chromium.org
https://chromium.googlesource.com/chromium/src/+/f42a7fdb7c4748e4316f5836a2eb3aa57c6e9494

Revert "[EoC] Update in-product help for slim peek" by thomasanderson@chromium.org
https://chromium.googlesource.com/chromium/src/+/1d0b7474e5737da7f6914cf56c16c924552c3693

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: -thomasanderson@chromium.org
Cc: thomasanderson@chromium.org
Owner: ----
Status: Available (was: Assigned)
The original CL caused a compilation failure and the revert fixed it. This isn't a performance regression, but rather got picked up because Android Compile Perf failed one build then passed the next.

Comment 8 by sullivan@google.com, May 24 2018

Cc: dtu@chromium.org
Sorry the UX is a little confusing in this case. The bug isn't about a performance regression, it's about a performance test failure. The graph in https://pinpoint-dot-chromeperf.appspot.com/job/14853862240000 shows the test failure rate: It goes from 0 to 100% when the build fails at r560427 and stays at 100% (test failures) after the build is fixed at r560433.

I re-ran the bisect on r560428-r560432 with r560433 patched in; hopefully the builds will succeed and we can narrow down which change cause the test failure.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, May 25 2018

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14f081aa240000

All of the attempts failed. See the individual attempts for details on each error.
Blockedon: 846720
Status: Fixed (was: Available)
Reverting disable CL and marking this fixed per comments in  bug 846720 .
Project Member

Comment 12 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68e9e68a28a07b35f63ce23485feefefeb5541e7

commit 68e9e68a28a07b35f63ce23485feefefeb5541e7
Author: Annie Sullivan <sullivan@chromium.org>
Date: Wed May 30 18:00:46 2018

Revert "Disable failing dromaeo modify benchmark on Nexus 5X."

This reverts commit e4fe92c0fd2538d87f738f1d5cd3bc8dedd11427.

Reason for revert: The memory issues should be fixed per  crbug.com/846720 

Bug:  846720 ,  845511 

Original change's description:
> Disable failing dromaeo modify benchmark on Nexus 5X.
> 
> Bug:  845511 
> Change-Id: Id4e81ee812e4f2e3005b0d1f8392bd01be6e340d
> TBR: charliea@chromium.org
> NOTRY: true
> Reviewed-on: https://chromium-review.googlesource.com/1069123
> Reviewed-by: Annie Sullivan <sullivan@chromium.org>
> Commit-Queue: Annie Sullivan <sullivan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560606}

TBR=sullivan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  845511 
Change-Id: Iab5dd9abfdad3f235335e52cd5caa24dfa25e6b8
Reviewed-on: https://chromium-review.googlesource.com/1079088
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562908}
[modify] https://crrev.com/68e9e68a28a07b35f63ce23485feefefeb5541e7/tools/perf/expectations.config

Cc: -twelling...@chromium.org

Sign in to add a comment