New issue
Advanced search Search tips

Issue 845500 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 902905
issue 913009

Blocking:
issue 702966



Sign in to add a comment

Re-enable smooth scroll for find on Android

Project Member Reported by sunyunjia@chromium.org, May 22 2018

Issue description

We previously disabled smooth-scroll-for-find on Android due to crbug.com/839795, because smooth scroll would be interrupted by other activities triggered by "find". We should fix the interruptions and re-enable smooth-scroll-for-find on Android.
 
Blocking: 702966
Labels: -Pri-1 Pri-2
What's left to do here? Can we find time this/next quarter to get this shipped - IMHO, the find-in-page experience was much better with this.
Blockedon: 902905
Any updates on this? 
Blockedon: 833617
We're actively working on this. There's still a bug blocking it. We target to fix the bug and re-enable the smooth find by the end of the year.
Blockedon: 913009
Blockedon: -833617
839795 is fixed? (I don't have permission to view that bug)
Yes that's just fixed. We'll turn on smooth scroll soon.
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afb37505b9c7ad815534b162b2d424ad9ab9f3e0

commit afb37505b9c7ad815534b162b2d424ad9ab9f3e0
Author: Sandra Sun <sunyunjia@chromium.org>
Date: Tue Dec 18 15:58:05 2018

Re-enable smooth scroll for find

We previously disabled smooth-scroll-for-find on Android, since smooth
scroll would be interrupted by other activities triggered by "find".
Now we've fixed the conflict and we can re-enable smooth scroll for
find.

Bug:  845500 
Change-Id: I228353ab24eeb40c200d1d824304015cdd2c327e
Reviewed-on: https://chromium-review.googlesource.com/c/1380960
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617506}
[modify] https://crrev.com/afb37505b9c7ad815534b162b2d424ad9ab9f3e0/content/public/common/web_preferences.cc

Status: Fixed (was: Assigned)

Sign in to add a comment