LocalNTPJavascriptTest.SimpleJavascriptTests (browser_tests) flakily failing on chromium.win/Win7 Tests (dbg)(1) |
|||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of jbroman@chromium.org browser_tests failing on chromium.win/Win7 Tests (dbg)(1) Builders failed on: - Win7 Tests (dbg)(1): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29 [7408:7908:0522/003142.264:FATAL:web_contents_observer_sanity_checker.cc(311)] Check failed: !is_loading_. Backtrace: base::debug::StackTrace::StackTrace [0x6F189A36+102] base::debug::StackTrace::StackTrace [0x6F188ADB+27] logging::LogMessage::~LogMessage [0x6F1E79D4+148] content::WebContentsObserverSanityChecker::DidStartLoading [0x08D62429+169] content::WebContentsImpl::LoadingStateChanged [0x61A6907B+1355] content::WebContentsImpl::DidStartLoading [0x61A7362E+110] content::FrameTreeNode::DidStartLoading [0x60C8CCC8+136] content::RenderFrameHostImpl::DidCommitNavigationInternal [0x60D1DECF+447] content::RenderFrameHostImpl::DidCommitProvisionalLoad [0x60D1D8B5+1253] content::mojom::FrameHostStubDispatch::Accept [0x5F593187+1863]
,
May 22 2018
,
May 22 2018
Disabling the test for now; removing sheriff label.
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a172cdbe55106ffae4ccc2f47dbaef7fcb0944f7 commit a172cdbe55106ffae4ccc2f47dbaef7fcb0944f7 Author: Jeremy Roman <jbroman@chromium.org> Date: Tue May 22 14:46:26 2018 Disable LocalNTPJavascriptTest.DISABLED_SimpleJavascriptTests due to flaky crashes on Win debug. Bug: 845498 Change-Id: I8429787c9c47413fac24332560928437feb853b7 Tbr: estade@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1069108 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#560577} [modify] https://crrev.com/a172cdbe55106ffae4ccc2f47dbaef7fcb0944f7/chrome/browser/ui/search/local_ntp_js_browsertest.cc
,
May 22 2018
to dpapad@ to triage
,
May 22 2018
,
May 22 2018
,
Aug 21
,
Aug 21
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b52cfc05e0aaede354199a14bdb2b78c0b62f0b0 commit b52cfc05e0aaede354199a14bdb2b78c0b62f0b0 Author: Kyle Milka <kmilka@chromium.org> Date: Wed Aug 22 17:26:33 2018 [NTP] Disable MV iframes for SimpleJavascriptTests The SimpleJavascriptTests were flaky due to loading/destroying of the MV iframe. Disabling all iframes for these tests will prevent the flakiness and the iframes aren't needed by the tests anyway. Also update some of the tests, as things have changed in the time they've been disabled. Bug: 857256 , 845498 Change-Id: I98d6f337ab2a5172f5e07648f2df0ce272f25597 Reviewed-on: https://chromium-review.googlesource.com/1183958 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#585132} [modify] https://crrev.com/b52cfc05e0aaede354199a14bdb2b78c0b62f0b0/chrome/browser/resources/local_ntp/local_ntp.js [modify] https://crrev.com/b52cfc05e0aaede354199a14bdb2b78c0b62f0b0/chrome/browser/ui/search/local_ntp_js_browsertest.cc [modify] https://crrev.com/b52cfc05e0aaede354199a14bdb2b78c0b62f0b0/chrome/test/data/local_ntp/local_ntp_browsertest.js
,
Aug 29
Looks like these tests have been fine for the week since the fix. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jbroman@chromium.org
, May 22 2018Owner: est...@chromium.org
Status: Assigned (was: Available)
Summary: LocalNTPJavascriptTest.SimpleJavascriptTests (browser_tests) failing on chromium.win/Win7 Tests (dbg)(1) (was: browser_tests failing on chromium.win/Win7 Tests (dbg)(1))