The following actions should be added to the share menu: - Request Desktop/Mobile Site - Find in Page
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/115e3e443a5340e0cf5755be48054721772dff71 commit 115e3e443a5340e0cf5755be48054721772dff71 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon May 28 13:18:35 2018 Move activities to their own folder This CL moves the activities classes to their own folder. This is a preliminary step before adding new activities to have the folder correctly organized. Bug: 845497 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia3156702233044881ae54154b26951c136e63480 Reviewed-on: https://chromium-review.googlesource.com/1073411 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#562245} [modify] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/BUILD.gn [add] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/BUILD.gn [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/bookmark_activity.h [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/bookmark_activity.mm [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/print_activity.h [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/print_activity.mm [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/reading_list_activity.h [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/reading_list_activity.mm [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/BUILD.gn [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_add_bookmark.imageset/Contents.json [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_add_bookmark.imageset/activity_services_add_bookmark-60@2x.png [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_add_bookmark.imageset/activity_services_add_bookmark-60@3x.png [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_add_bookmark.imageset/activity_services_add_bookmark-76@2x.png [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_edit_bookmark.imageset/Contents.json [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_edit_bookmark.imageset/activity_services_edit_bookmark-60@2x.png [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_edit_bookmark.imageset/activity_services_edit_bookmark-60@3x.png [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_edit_bookmark.imageset/activity_services_edit_bookmark-76@2x.png [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_print.imageset/Contents.json [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_print.imageset/activity_services_print-60@2x.png [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_print.imageset/activity_services_print-60@3x.png [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_print.imageset/activity_services_print-76.png [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_print.imageset/activity_services_print-76@2x.png [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_read_later.imageset/Contents.json [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_read_later.imageset/activity_services_read_later-60@2x.png [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_read_later.imageset/activity_services_read_later-60@3x.png [rename] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_read_later.imageset/activity_services_read_later-76@2x.png [modify] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activity_service_controller.mm [modify] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm [modify] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activity_type_util.mm [modify] https://crrev.com/115e3e443a5340e0cf5755be48054721772dff71/ios/chrome/browser/ui/activity_services/activity_type_util_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cf25da95bee042ec69811e16116fdadb0ea600d commit 6cf25da95bee042ec69811e16116fdadb0ea600d Author: Olga Sharonova <olka@chromium.org> Date: Mon May 28 13:45:03 2018 Revert "Move activities to their own folder" This reverts commit 115e3e443a5340e0cf5755be48054721772dff71. Reason for revert: Broke compilation: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-device-xcode-clang/62184 Original change's description: > Move activities to their own folder > > This CL moves the activities classes to their own folder. > This is a preliminary step before adding new activities to have the > folder correctly organized. > > Bug: 845497 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: Ia3156702233044881ae54154b26951c136e63480 > Reviewed-on: https://chromium-review.googlesource.com/1073411 > Reviewed-by: Mark Cogan <marq@chromium.org> > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562245} TBR=marq@chromium.org,gambard@chromium.org Change-Id: Ia3fdfa985e017a00f933f78e1de037054af213fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845497 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1075347 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#562249} [modify] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/BUILD.gn [delete] https://crrev.com/7e7dd55cce56f643d5945f5a2dbd42d475c73e1b/ios/chrome/browser/ui/activity_services/activities/BUILD.gn [modify] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/activity_service_controller.mm [modify] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm [modify] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/activity_type_util.mm [modify] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/activity_type_util_unittest.mm [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/bookmark_activity.h [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/bookmark_activity.mm [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/print_activity.h [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/print_activity.mm [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/reading_list_activity.h [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/reading_list_activity.mm [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/BUILD.gn [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_add_bookmark.imageset/Contents.json [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_add_bookmark.imageset/activity_services_add_bookmark-60@2x.png [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_add_bookmark.imageset/activity_services_add_bookmark-60@3x.png [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_add_bookmark.imageset/activity_services_add_bookmark-76@2x.png [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_edit_bookmark.imageset/Contents.json [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_edit_bookmark.imageset/activity_services_edit_bookmark-60@2x.png [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_edit_bookmark.imageset/activity_services_edit_bookmark-60@3x.png [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_edit_bookmark.imageset/activity_services_edit_bookmark-76@2x.png [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_print.imageset/Contents.json [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_print.imageset/activity_services_print-60@2x.png [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_print.imageset/activity_services_print-60@3x.png [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_print.imageset/activity_services_print-76.png [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_print.imageset/activity_services_print-76@2x.png [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_read_later.imageset/Contents.json [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_read_later.imageset/activity_services_read_later-60@2x.png [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_read_later.imageset/activity_services_read_later-60@3x.png [rename] https://crrev.com/6cf25da95bee042ec69811e16116fdadb0ea600d/ios/chrome/browser/ui/activity_services/resources/activity_services_read_later.imageset/activity_services_read_later-76@2x.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dca90b1cc90ac15f8635740bd047bc86391de85d commit dca90b1cc90ac15f8635740bd047bc86391de85d Author: Gauthier Ambard <gambard@chromium.org> Date: Mon May 28 16:10:14 2018 Reland "Move activities to their own folder" This is a reland of 115e3e443a5340e0cf5755be48054721772dff71 Original change's description: > Move activities to their own folder > > This CL moves the activities classes to their own folder. > This is a preliminary step before adding new activities to have the > folder correctly organized. > > Bug: 845497 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: Ia3156702233044881ae54154b26951c136e63480 > Reviewed-on: https://chromium-review.googlesource.com/1073411 > Reviewed-by: Mark Cogan <marq@chromium.org> > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562245} Bug: 845497 Change-Id: I6bdcc635445ccf13715cddfbca8be08a30793b25 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet TBR=marq@chromium.org Change-Id: I6bdcc635445ccf13715cddfbca8be08a30793b25 Reviewed-on: https://chromium-review.googlesource.com/1075527 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#562272} [modify] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/BUILD.gn [add] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/BUILD.gn [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/bookmark_activity.h [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/bookmark_activity.mm [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/print_activity.h [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/print_activity.mm [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/reading_list_activity.h [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/reading_list_activity.mm [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/BUILD.gn [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_add_bookmark.imageset/Contents.json [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_add_bookmark.imageset/activity_services_add_bookmark-60@2x.png [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_add_bookmark.imageset/activity_services_add_bookmark-60@3x.png [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_add_bookmark.imageset/activity_services_add_bookmark-76@2x.png [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_edit_bookmark.imageset/Contents.json [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_edit_bookmark.imageset/activity_services_edit_bookmark-60@2x.png [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_edit_bookmark.imageset/activity_services_edit_bookmark-60@3x.png [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_edit_bookmark.imageset/activity_services_edit_bookmark-76@2x.png [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_print.imageset/Contents.json [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_print.imageset/activity_services_print-60@2x.png [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_print.imageset/activity_services_print-60@3x.png [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_print.imageset/activity_services_print-76.png [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_print.imageset/activity_services_print-76@2x.png [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_read_later.imageset/Contents.json [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_read_later.imageset/activity_services_read_later-60@2x.png [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_read_later.imageset/activity_services_read_later-60@3x.png [rename] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_read_later.imageset/activity_services_read_later-76@2x.png [modify] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activity_service_controller.mm [modify] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm [modify] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activity_type_util.mm [modify] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/ios/chrome/browser/ui/activity_services/activity_type_util_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7776af68a50c06be15230f2504ca15d379e0e24 commit a7776af68a50c06be15230f2504ca15d379e0e24 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed May 30 15:08:36 2018 Add new actions to the Share Menu This CL adds the Request {Desktop|Mobile} Site and Find in Page actions to the Share Menu. Bug: 845497 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6d54ed7f723c262608c0144ec1686f317a5d376c Reviewed-on: https://chromium-review.googlesource.com/1075090 Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#562827} [modify] https://crrev.com/a7776af68a50c06be15230f2504ca15d379e0e24/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/a7776af68a50c06be15230f2504ca15d379e0e24/ios/chrome/browser/ui/activity_services/activities/BUILD.gn [add] https://crrev.com/a7776af68a50c06be15230f2504ca15d379e0e24/ios/chrome/browser/ui/activity_services/activities/find_in_page_activity.h [add] https://crrev.com/a7776af68a50c06be15230f2504ca15d379e0e24/ios/chrome/browser/ui/activity_services/activities/find_in_page_activity.mm [add] https://crrev.com/a7776af68a50c06be15230f2504ca15d379e0e24/ios/chrome/browser/ui/activity_services/activities/request_desktop_or_mobile_site_activity.h [add] https://crrev.com/a7776af68a50c06be15230f2504ca15d379e0e24/ios/chrome/browser/ui/activity_services/activities/request_desktop_or_mobile_site_activity.mm [modify] https://crrev.com/a7776af68a50c06be15230f2504ca15d379e0e24/ios/chrome/browser/ui/activity_services/activity_service_controller.mm [modify] https://crrev.com/a7776af68a50c06be15230f2504ca15d379e0e24/ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm [modify] https://crrev.com/a7776af68a50c06be15230f2504ca15d379e0e24/ios/chrome/browser/ui/activity_services/share_to_data.h [modify] https://crrev.com/a7776af68a50c06be15230f2504ca15d379e0e24/ios/chrome/browser/ui/activity_services/share_to_data.mm [modify] https://crrev.com/a7776af68a50c06be15230f2504ca15d379e0e24/ios/chrome/browser/ui/activity_services/share_to_data_builder.mm [modify] https://crrev.com/a7776af68a50c06be15230f2504ca15d379e0e24/ios/chrome/browser/ui/browser_view_controller.mm
Verified in 69.0.3449.0 Canary, iPhone X iOS 1.4, iPhone 7 iOS12.0, iPad Air iOS11.4
The NextAction date has arrived: 2018-06-06
Comment 1 by bugdroid1@chromium.org
, May 28 2018