New issue
Advanced search Search tips

Issue 845495 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

roll-dep breaks on repo split across lines?

Project Member Reported by jbudorick@chromium.org, May 22 2018

Issue description

I used roll-dep to update infra in infra_internal recently. It didn't seem to like having the spec split across lines and spit out https://chrome-internal-review.googlesource.com/c/infra/infra_internal/+/625610/1, which contains both the new and the old revision.
 

Comment 1 by aga...@chromium.org, May 25 2018

Owner: ehmaldonado@chromium.org
Status: Started (was: Untriaged)
I believe https://chromium-review.googlesource.com/c/infra/infra/+/1073684 fixes this for infra; Edward can do something similar for infra_internal and I think that should address this.
Project Member

Comment 2 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3ec445e68e81d0b27de547c72780296631db1e6f

commit 3ec445e68e81d0b27de547c72780296631db1e6f
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Tue May 29 17:29:04 2018

Don't use implicit concatenation on DEPS file.

Is not supported by gclient getdep/setdep.

Bug:  845495 
Change-Id: I8d881bc0b701321167fc1a2d92abd1c83e44cf4f
Reviewed-on: https://chromium-review.googlesource.com/1073684
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/3ec445e68e81d0b27de547c72780296631db1e6f/DEPS

Status: Fixed (was: Started)

Sign in to add a comment