New issue
Advanced search Search tips

Issue 845492 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-06
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

UX Request: Assets for the Share menu

Project Member Reported by gambard@chromium.org, May 22 2018

Issue description

The new share menu actions should have asset:
- Request Desktop Site
- Request Mobile Site
- Find in Page

Need them for iPhone and iPad (60 and 76 pt).
 
Cc: -martijnb@chromium.org pschaffner@chromium.org
Owner: martijnb@chromium.org
Cc: martijnb@chromium.org
Owner: gambard@chromium.org
Taking the bug to add the assets.
Labels: small
NextAction: 2018-06-06
Status: Started (was: Assigned)
Labels: S-Visual-Polish
Project Member

Comment 6 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d9e7c38f1db70e8ae001fd8df6332fa13425764

commit 3d9e7c38f1db70e8ae001fd8df6332fa13425764
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed May 30 15:45:56 2018

Add assets for share menu actions

This CL adds the assets for the new share menu actions.

Bug:  845492 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I12c954c957f6106a17f05285ca4d6b660a217543
Reviewed-on: https://chromium-review.googlesource.com/1076293
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562848}
[modify] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/BUILD.gn
[modify] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/find_in_page_activity.mm
[modify] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/request_desktop_or_mobile_site_activity.mm
[modify] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/resources/BUILD.gn
[add] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_find_in_page.imageset/Contents.json
[add] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_find_in_page.imageset/activity_services_find_in_page-60@2x.png
[add] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_find_in_page.imageset/activity_services_find_in_page-60@3x.png
[add] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_find_in_page.imageset/activity_services_find_in_page-76@2x.png
[add] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_request_desktop_site.imageset/Contents.json
[add] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_request_desktop_site.imageset/activity_services_request_desktop_site-60@2x.png
[add] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_request_desktop_site.imageset/activity_services_request_desktop_site-60@3x.png
[add] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_request_desktop_site.imageset/activity_services_request_desktop_site-76@2x.png
[add] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_request_mobile_site.imageset/Contents.json
[add] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_request_mobile_site.imageset/activity_services_request_mobile_site-60@2x.png
[add] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_request_mobile_site.imageset/activity_services_request_mobile_site-60@3x.png
[add] https://crrev.com/3d9e7c38f1db70e8ae001fd8df6332fa13425764/ios/chrome/browser/ui/activity_services/activities/resources/activity_services_request_mobile_site.imageset/activity_services_request_mobile_site-76@2x.png

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Share menu icons looking good.
Verified on M69.0.3450.0 canary
iOS: 11.2.6, 12
iPhoneX, iPhone8
The NextAction date has arrived: 2018-06-06

Sign in to add a comment