New issue
Advanced search Search tips

Issue 845491 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-06
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

UX Request: Assets for the Search popup menu

Project Member Reported by gambard@chromium.org, May 22 2018

Issue description

The popup menu associated with the popup menu should have assets for:
- Paste and Go
- QR Code Search
- Voice Search
 
Cc: -martijnb@chromium.org pschaffner@chromium.org
Owner: martijnb@chromium.org
Cc: martijnb@chromium.org
Owner: gambard@chromium.org
The assets can be found here:
https://drive.google.com/corp/drive/folders/11n3ATz2W69hh8VLCARgmO5eiKjyFFWFL
Labels: small
NextAction: 2018-06-06
Status: Started (was: Assigned)
Labels: S-Visual-Polish
Project Member

Comment 5 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/467d4e4fad7e8002f734e3ee00ee1bdafaa46408

commit 467d4e4fad7e8002f734e3ee00ee1bdafaa46408
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed May 30 15:18:39 2018

Add assets for Search Button popup menu

This CL adds the assets for the actions of the popup menu associated
with the Search button.

Bug:  845491 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie793e1a666d72277c519b4f349f6b5416704e65b
Reviewed-on: https://chromium-review.googlesource.com/1078736
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562829}
[modify] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/ios/chrome/browser/ui/popup_menu/BUILD.gn
[modify] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/ios/chrome/browser/ui/popup_menu/resources/BUILD.gn
[add] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/ios/chrome/browser/ui/popup_menu/resources/popup_menu_paste_and_go.imageset/Contents.json
[add] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/ios/chrome/browser/ui/popup_menu/resources/popup_menu_paste_and_go.imageset/popup_menu_paste_and_go.png
[add] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/ios/chrome/browser/ui/popup_menu/resources/popup_menu_paste_and_go.imageset/popup_menu_paste_and_go@2x.png
[add] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/ios/chrome/browser/ui/popup_menu/resources/popup_menu_paste_and_go.imageset/popup_menu_paste_and_go@3x.png
[add] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/ios/chrome/browser/ui/popup_menu/resources/popup_menu_qr_scanner.imageset/Contents.json
[add] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/ios/chrome/browser/ui/popup_menu/resources/popup_menu_qr_scanner.imageset/popup_menu_qr_scanner.png
[add] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/ios/chrome/browser/ui/popup_menu/resources/popup_menu_qr_scanner.imageset/popup_menu_qr_scanner@2x.png
[add] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/ios/chrome/browser/ui/popup_menu/resources/popup_menu_qr_scanner.imageset/popup_menu_qr_scanner@3x.png
[add] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/ios/chrome/browser/ui/popup_menu/resources/popup_menu_voice_search.imageset/Contents.json
[add] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/ios/chrome/browser/ui/popup_menu/resources/popup_menu_voice_search.imageset/popup_menu_voice_search.png
[add] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/ios/chrome/browser/ui/popup_menu/resources/popup_menu_voice_search.imageset/popup_menu_voice_search@2x.png
[add] https://crrev.com/467d4e4fad7e8002f734e3ee00ee1bdafaa46408/ios/chrome/browser/ui/popup_menu/resources/popup_menu_voice_search.imageset/popup_menu_voice_search@3x.png

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Icons on Search popup looks good.
https://drive.google.com/file/d/1dFqw7ELUKRwzzlMeNvIeytikvcn0sWW2/view

Verified on M69.0.3450.0 canary
iOS: 11.2.6, 12
iPhoneX, iPhone8
The NextAction date has arrived: 2018-06-06

Sign in to add a comment