New issue
Advanced search Search tips

Issue 845477 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-05-23
OS: iOS
Pri: 2
Type: Task
Q2



Sign in to add a comment

Popup Menu: Tools menu polish

Project Member Reported by gambard@chromium.org, May 22 2018

Issue description

The tools menu should be about 50 pt taller and still have some half visible row (to know it is possible to scroll down).
 
Also the browser actions and the collections actions should be reversed (collections before browser actions).
Cc: pschaffner@chromium.org
Here is what it could look like with the new height (+35pt) and the inversion.
Simulator Screen Shot - iPhone 8 Plus - 2018-05-22 at 17.20.52.png
334 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77a5b2b4d7ef02c9f9d9bfb45c81d329f5c4a186

commit 77a5b2b4d7ef02c9f9d9bfb45c81d329f5c4a186
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed May 23 09:02:14 2018

Polish the popup menu

This CL adds some polish to the popup menu, increasing its max height
and swaping the BrowserActions and CollectionsActions items.

Bug:  845477 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia7f05c29f0110bedb6f0ede7847ca3e39e420360
Reviewed-on: https://chromium-review.googlesource.com/1069148
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561009}
[modify] https://crrev.com/77a5b2b4d7ef02c9f9d9bfb45c81d329f5c4a186/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/77a5b2b4d7ef02c9f9d9bfb45c81d329f5c4a186/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.mm

NextAction: 2018-05-23
Status: Fixed (was: Assigned)
The NextAction date has arrived: 2018-05-23

Sign in to add a comment