New issue
Advanced search Search tips

Issue 845475 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: May 2018
Cc:
mard...@chromium.org
pschaffner@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-05-23
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Popup Menu: Add separator between the destructive and additive actions of the tab grid menu

Project Member Reported by gambard@chromium.org, May 22 2018 
The TabGrid popup menu should have a separator between the additives actions (Open New {Incognito} Tab) and the destructive actions (Close {All Incognito} Tab{s}).
Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/950668ec9ebb69e439726de235df94cd839fe0ce

commit 950668ec9ebb69e439726de235df94cd839fe0ce
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue May 22 14:54:53 2018

Add separator for TabGrid popup menu

This CL adds a separator between the additive and destructive actions
of the TabGrid popup menu.
The separator is automatically added between sections, so this CL is
putting the additive and destructive actions in two separate sections.

Bug: 821560,  828367 ,  845475 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1769a63aa7d968f31ce3a5854164b81fb80e705b
Reviewed-on: https://chromium-review.googlesource.com/1069068
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560584}
[modify] https://crrev.com/950668ec9ebb69e439726de235df94cd839fe0ce/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/950668ec9ebb69e439726de235df94cd839fe0ce/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm

Comment 2 by gambard@chromium.org, May 22 2018

Status: Fixed (was: Assigned)

Comment 3 by gambard@chromium.org, May 23 2018

Labels: small

Comment 4 by monor...@bugs.chromium.org, May 23 2018 

The NextAction date has arrived: 2018-05-23

Comment 5 by shbarezer@chromium.org, May 29 2018

Status: Verified (was: Fixed)
Verified in 69.0.3444.0 Canary, iPhone X iOS 11.4 beta 6, iPhone 6 iOS 10.3.3, iPhone 7 iOS 

TabGrid popup menu separator is added.
►

Sign in to add a comment