New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Feature

Blocked on:
issue 878388
issue 905650
issue 905651
issue 905652
issue 905654
issue 905656
issue 905657
issue 906017
issue 906019
issue 907087
issue 908063
issue 911086
issue 911142
issue 911148
issue 911168
issue 912085



Sign in to add a comment
link

Issue 845472: Manual Fill in Chrome

Reported by javierrobles@chromium.org, May 22 2018 Project Member

Issue description

Create a prototype showing how manual fill can work in chrome.
 
Showing comments 21 - 120 of 120 Older

Comment 21 by bugdroid1@chromium.org, Aug 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05eba0983de50f2627c671bb31593808e04cd546

commit 05eba0983de50f2627c671bb31593808e04cd546
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Tue Aug 21 08:57:51 2018

[iOS][MF] Creates action table view cell

Creates a new UITableViewCell to show user credentials in a table view.
The design is according to the specs for Manual Fallback, which can be
found in:
https://folio.googleplex.com/ntp/Autofill/Autofill%20Manual%20Fallback

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iaa916c36dfb9ca2a567c904c4ab536b037840077
Reviewed-on: https://chromium-review.googlesource.com/1179756
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584691}
[add] https://crrev.com/05eba0983de50f2627c671bb31593808e04cd546/ios/chrome/browser/ui/autofill/manual_fill/action_cell.h
[add] https://crrev.com/05eba0983de50f2627c671bb31593808e04cd546/ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm
[add] https://crrev.com/05eba0983de50f2627c671bb31593808e04cd546/ios/chrome/browser/ui/autofill/manual_fill/uicolor_manualfill.h
[add] https://crrev.com/05eba0983de50f2627c671bb31593808e04cd546/ios/chrome/browser/ui/autofill/manual_fill/uicolor_manualfill.mm

Comment 22 by bugdroid1@chromium.org, Aug 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59d4ab82ca7a054cbda347a6351b50b6b1a1f3fb

commit 59d4ab82ca7a054cbda347a6351b50b6b1a1f3fb
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Tue Aug 21 15:34:30 2018

[iOS][MF] New strings for Manual Fallback

Add strings used in Manual Fallback and in the new Autofill input
accessory bar design.

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1d4c6c89ee74853d76b0890c19226a1ce9000d59
Reviewed-on: https://chromium-review.googlesource.com/1179826
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584756}
[modify] https://crrev.com/59d4ab82ca7a054cbda347a6351b50b6b1a1f3fb/ios/chrome/app/strings/ios_strings.grd

Comment 23 by bugdroid1@chromium.org, Aug 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b6f9c31effad8383009582bc60a7b9c196fdc79

commit 0b6f9c31effad8383009582bc60a7b9c196fdc79
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Wed Aug 22 14:21:48 2018

[iOS][MF] Update keyboard accessory view

Adds the new icon for addresses and for keyboard.

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I775b06b39a8f797c16669511ab8aa057bdd14133
Reviewed-on: https://chromium-review.googlesource.com/1183223
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585009}
[modify] https://crrev.com/0b6f9c31effad8383009582bc60a7b9c196fdc79/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[delete] https://crrev.com/2cfecef77d9663b849aee94264418f89b09e5a88/ios/chrome/browser/ui/autofill/manual_fill/keyboard_accessory_view.h
[delete] https://crrev.com/2cfecef77d9663b849aee94264418f89b09e5a88/ios/chrome/browser/ui/autofill/manual_fill/keyboard_accessory_view.mm
[add] https://crrev.com/0b6f9c31effad8383009582bc60a7b9c196fdc79/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.h
[add] https://crrev.com/0b6f9c31effad8383009582bc60a7b9c196fdc79/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
[modify] https://crrev.com/0b6f9c31effad8383009582bc60a7b9c196fdc79/third_party/material_design_icons/BUILD.gn

Comment 24 by bugdroid1@chromium.org, Aug 22

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/580c69963c034832eabfa88f266e6408289e769e

commit 580c69963c034832eabfa88f266e6408289e769e
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Wed Aug 22 17:07:42 2018

[iOS][MF] Create Cells to show credentials

Adds cells to show credentials. These support dynamic fonts and have 2
buttons. One for password and one for username, which send the events
to the delegate passed when setting the cell up.

Mocks: https://folio.googleplex.com/ntp/Autofill/Autofill%20Manual%20Fallback

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia375e00789fb21935817801b904ec7190a516875
Reviewed-on: https://chromium-review.googlesource.com/1183192
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585107}
[modify] https://crrev.com/580c69963c034832eabfa88f266e6408289e769e/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[add] https://crrev.com/580c69963c034832eabfa88f266e6408289e769e/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_content_delegate.h
[add] https://crrev.com/580c69963c034832eabfa88f266e6408289e769e/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.h
[add] https://crrev.com/580c69963c034832eabfa88f266e6408289e769e/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.mm

Comment 25 by javierrobles@chromium.org, Aug 28

Blockedon: 878388

Comment 26 by bugdroid1@chromium.org, Sep 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db00db8a42bc5a9ca717e2c55cd5d232abdb7e6c

commit db00db8a42bc5a9ca717e2c55cd5d232abdb7e6c
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Mon Sep 03 12:47:34 2018

[iOS][MF] Injection Handler for manual fallback

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7f82b8491f3faeb782cebd4d9b88b2b3a0246711
Reviewed-on: https://chromium-review.googlesource.com/1199664
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588375}
[add] https://crrev.com/db00db8a42bc5a9ca717e2c55cd5d232abdb7e6c/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_injection_handler.h
[add] https://crrev.com/db00db8a42bc5a9ca717e2c55cd5d232abdb7e6c/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_injection_handler.mm

Comment 27 by bugdroid1@chromium.org, Sep 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/269822cb38a00f55d5ee2afe31924086e9937892

commit 269822cb38a00f55d5ee2afe31924086e9937892
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Wed Sep 05 16:13:46 2018

[iOS][MF] Starts FormInputAccessoryCoordinator with a BrowserState

self.browserState was nil at the point of initialization.

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id3fb457b493cecc1686144160a486fb6446fdea2
Reviewed-on: https://chromium-review.googlesource.com/1186334
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588884}
[modify] https://crrev.com/269822cb38a00f55d5ee2afe31924086e9937892/ios/chrome/browser/ui/browser_view_controller.mm

Comment 28 by bugdroid1@chromium.org, Sep 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67f0af813a5d5a0ff2db431a905da5b0184f3ea4

commit 67f0af813a5d5a0ff2db431a905da5b0184f3ea4
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Tue Sep 11 15:41:16 2018

[iOS][MF] Enables manual fill behind a flag

This CL wires all the parts and enables Manual Fallback, still work in
progress, behind it's flag.

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8bef297135511a1d122dcac0c6199e263f112566
Reviewed-on: https://chromium-review.googlesource.com/1203994
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590323}
[modify] https://crrev.com/67f0af813a5d5a0ff2db431a905da5b0184f3ea4/ios/chrome/browser/autofill/BUILD.gn
[modify] https://crrev.com/67f0af813a5d5a0ff2db431a905da5b0184f3ea4/ios/chrome/browser/autofill/form_input_accessory_consumer.h
[modify] https://crrev.com/67f0af813a5d5a0ff2db431a905da5b0184f3ea4/ios/chrome/browser/autofill/form_input_accessory_view_controller.h
[modify] https://crrev.com/67f0af813a5d5a0ff2db431a905da5b0184f3ea4/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
[modify] https://crrev.com/67f0af813a5d5a0ff2db431a905da5b0184f3ea4/ios/chrome/browser/autofill/form_suggestion_controller.mm
[modify] https://crrev.com/67f0af813a5d5a0ff2db431a905da5b0184f3ea4/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm
[modify] https://crrev.com/67f0af813a5d5a0ff2db431a905da5b0184f3ea4/ios/chrome/browser/autofill/form_suggestion_view.h
[modify] https://crrev.com/67f0af813a5d5a0ff2db431a905da5b0184f3ea4/ios/chrome/browser/autofill/form_suggestion_view.mm
[modify] https://crrev.com/67f0af813a5d5a0ff2db431a905da5b0184f3ea4/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.h
[modify] https://crrev.com/67f0af813a5d5a0ff2db431a905da5b0184f3ea4/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
[modify] https://crrev.com/67f0af813a5d5a0ff2db431a905da5b0184f3ea4/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.h
[modify] https://crrev.com/67f0af813a5d5a0ff2db431a905da5b0184f3ea4/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm

Comment 29 by bugdroid1@chromium.org, Sep 12

Project Member

Comment 30 by bugdroid1@chromium.org, Sep 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c25f33beeb4de2a0d0826837af97d75aa25b29bf

commit c25f33beeb4de2a0d0826837af97d75aa25b29bf
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Mon Sep 17 12:54:57 2018

[iOS][MF] Hide addresses and cards behind flag

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8fb71bf52486244ad034c4d958bbd5a534cc240c
Reviewed-on: https://chromium-review.googlesource.com/1221190
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591652}
[modify] https://crrev.com/c25f33beeb4de2a0d0826837af97d75aa25b29bf/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm

Comment 31 by bugdroid1@chromium.org, Sep 26

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97ec10ef30d024b391967066f22659be34325f1d

commit 97ec10ef30d024b391967066f22659be34325f1d
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Wed Sep 26 14:37:30 2018

[iOS][MF] Keyboard observer helper

Creates a helper that observes the keyboard. This observer is used to
more precisely remove the animations of the presented view, and also to
correctly restore the keyboard when it disappears. It is a separate
file to make it easier to test, in a separate CL.

This CL also cleans the logic for hiding subviews which is obsolete and
not needed.

This adds a new Earl Grey test suite, where in a follow up CL will
enable the manual fallback flags so they can be tested.

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I299b36915d1d2b6f0ef642e73b302c9cd2f4f931
Reviewed-on: https://chromium-review.googlesource.com/1233835
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594310}
[modify] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/autofill/form_input_accessory_consumer.h
[modify] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
[modify] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm
[modify] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[add] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/autofill/manual_fill/keyboard_observer_egtest.mm
[add] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/autofill/manual_fill/keyboard_observer_helper.h
[add] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/browser/ui/autofill/manual_fill/keyboard_observer_helper.mm
[modify] https://crrev.com/97ec10ef30d024b391967066f22659be34325f1d/ios/chrome/test/earl_grey/BUILD.gn

Comment 32 by bugdroid1@chromium.org, Oct 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41d7dc9bc7859e544456b020ce53d7515370ae2f

commit 41d7dc9bc7859e544456b020ce53d7515370ae2f
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Wed Oct 03 09:28:48 2018

[iOS] Presentation of table views in the leading edge

Adds options to invert the direction of the animation and the position of
the table view when presenting.
Supporting presenting table views in the leading edge is required for the
manual fallback UI: go/leftpresentation

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I1e8466bc90fe29fd77bb71fed1639bcbac14eb02
Reviewed-on: https://chromium-review.googlesource.com/c/1255242
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596161}
[modify] https://crrev.com/41d7dc9bc7859e544456b020ce53d7515370ae2f/ios/chrome/browser/ui/table_view/table_view_animator.h
[modify] https://crrev.com/41d7dc9bc7859e544456b020ce53d7515370ae2f/ios/chrome/browser/ui/table_view/table_view_animator.mm
[modify] https://crrev.com/41d7dc9bc7859e544456b020ce53d7515370ae2f/ios/chrome/browser/ui/table_view/table_view_presentation_controller.h
[modify] https://crrev.com/41d7dc9bc7859e544456b020ce53d7515370ae2f/ios/chrome/browser/ui/table_view/table_view_presentation_controller.mm

Comment 33 by bugdroid1@chromium.org, Oct 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47c75629f0e8502c11ab98856dfd2b979b1f1d0f

commit 47c75629f0e8502c11ab98856dfd2b979b1f1d0f
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Thu Oct 04 13:45:35 2018

[iOS][MF] Pause and restore keyboard custom view

This CL adds the capability to pause the keyboard views when the
webstate is hidden. This happens i.e. when the passwords coordinator
presents a full screen selection. This way, when the webstate is shown
again, it can restore it's views if needed.

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5eddf31ada277a1a9c0c0e8cc0ae7be3d8d01ad2
Reviewed-on: https://chromium-review.googlesource.com/c/1236436
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596648}
[modify] https://crrev.com/47c75629f0e8502c11ab98856dfd2b979b1f1d0f/ios/chrome/browser/autofill/form_input_accessory_consumer.h
[modify] https://crrev.com/47c75629f0e8502c11ab98856dfd2b979b1f1d0f/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
[modify] https://crrev.com/47c75629f0e8502c11ab98856dfd2b979b1f1d0f/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm
[modify] https://crrev.com/47c75629f0e8502c11ab98856dfd2b979b1f1d0f/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
[modify] https://crrev.com/47c75629f0e8502c11ab98856dfd2b979b1f1d0f/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm
[modify] https://crrev.com/47c75629f0e8502c11ab98856dfd2b979b1f1d0f/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[modify] https://crrev.com/47c75629f0e8502c11ab98856dfd2b979b1f1d0f/ios/chrome/browser/ui/autofill/manual_fill/password_mediator.h
[modify] https://crrev.com/47c75629f0e8502c11ab98856dfd2b979b1f1d0f/ios/chrome/browser/ui/autofill/manual_fill/password_mediator.mm
[modify] https://crrev.com/47c75629f0e8502c11ab98856dfd2b979b1f1d0f/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.h
[modify] https://crrev.com/47c75629f0e8502c11ab98856dfd2b979b1f1d0f/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.mm
[modify] https://crrev.com/47c75629f0e8502c11ab98856dfd2b979b1f1d0f/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller_egtest.mm
[modify] https://crrev.com/47c75629f0e8502c11ab98856dfd2b979b1f1d0f/ios/third_party/earl_grey/BUILD.gn

Comment 34 by bugdroid1@chromium.org, Oct 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/145f556296431777d4a5e8b7d5d8a962c5331f78

commit 145f556296431777d4a5e8b7d5d8a962c5331f78
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Tue Oct 16 21:40:42 2018

[iOS][MF] Present on iPad as popover

This CL enables presentation in iPads as a popover instead of above the keyboard.
This follows the UX design for Manual Fallback.
- Makes sure the accessory bar for iPad is always added when Manual Fallback is Enabled.
- The responsibility of not showing the accessory bar when other UI is presenting the
keyboard is now fully own by the input accessory bar view controller.

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ife13cc44b4912084ccb10376ee9c53039dc00548
Reviewed-on: https://chromium-review.googlesource.com/c/1256793
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600131}
[modify] https://crrev.com/145f556296431777d4a5e8b7d5d8a962c5331f78/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
[modify] https://crrev.com/145f556296431777d4a5e8b7d5d8a962c5331f78/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.h
[modify] https://crrev.com/145f556296431777d4a5e8b7d5d8a962c5331f78/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
[modify] https://crrev.com/145f556296431777d4a5e8b7d5d8a962c5331f78/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm
[modify] https://crrev.com/145f556296431777d4a5e8b7d5d8a962c5331f78/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[modify] https://crrev.com/145f556296431777d4a5e8b7d5d8a962c5331f78/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.h
[modify] https://crrev.com/145f556296431777d4a5e8b7d5d8a962c5331f78/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
[modify] https://crrev.com/145f556296431777d4a5e8b7d5d8a962c5331f78/ios/chrome/browser/ui/autofill/manual_fill/password_coordinator.h
[modify] https://crrev.com/145f556296431777d4a5e8b7d5d8a962c5331f78/ios/chrome/browser/ui/autofill/manual_fill/password_coordinator.mm
[modify] https://crrev.com/145f556296431777d4a5e8b7d5d8a962c5331f78/ios/chrome/browser/ui/autofill/manual_fill/password_list_delegate.h
[modify] https://crrev.com/145f556296431777d4a5e8b7d5d8a962c5331f78/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.mm
[modify] https://crrev.com/145f556296431777d4a5e8b7d5d8a962c5331f78/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller_egtest.mm

Comment 35 by bugdroid1@chromium.org, Oct 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03ca325346b739d3f50389fcae832bcadb5b0f17

commit 03ca325346b739d3f50389fcae832bcadb5b0f17
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Tue Oct 16 23:48:02 2018

[iOS][MF] Keyboard dismissal

This CL presents the popover in the same window as the accessory button.
By doing this it won't be hidden by the keyboard and it will dissapear
when the user interacts with the keyboard.

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5ab3243cb8d6281105d77387b384692086e260b9
Reviewed-on: https://chromium-review.googlesource.com/c/1268342
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600191}
[modify] https://crrev.com/03ca325346b739d3f50389fcae832bcadb5b0f17/ios/chrome/browser/ui/autofill/manual_fill/password_coordinator.mm
[modify] https://crrev.com/03ca325346b739d3f50389fcae832bcadb5b0f17/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.h
[modify] https://crrev.com/03ca325346b739d3f50389fcae832bcadb5b0f17/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller_egtest.mm

Comment 36 by bugdroid1@chromium.org, Oct 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dec7e3882ba4165e0028584f495a35a07c3130cd

commit dec7e3882ba4165e0028584f495a35a07c3130cd
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Fri Oct 19 00:18:44 2018

[iOS][AF] Update icons and new design

This CL updates the accessory bar to the newest icons and design.
Currently behind the AutofillManualFallback feature flag.

[Current: https://drive.google.com/file/d/1x60dQkNt0B88Srlo0v-vNyNXHDs_nu_F/view?usp=sharing]
[New: https://drive.google.com/file/d/1Sf_WMeI83g-viW6x065hZXO3PUXcgBj0/view?usp=sharing]

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I4a97a254a1e8c9918c1db23ddfcfb93faf734aec
Reviewed-on: https://chromium-review.googlesource.com/c/1289679
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600984}
[modify] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/autofill/form_input_accessory_view.mm
[modify] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[modify] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
[modify] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/resources/BUILD.gn
[add] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/resources/mf_arrow_down.imageset/Contents.json
[add] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/resources/mf_arrow_down.imageset/mf_arrow_down.png
[add] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/resources/mf_arrow_down.imageset/mf_arrow_down@2x.png
[add] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/resources/mf_arrow_down.imageset/mf_arrow_down@3x.png
[add] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/resources/mf_arrow_up.imageset/Contents.json
[add] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/resources/mf_arrow_up.imageset/mf_arrow_up.png
[add] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/resources/mf_arrow_up.imageset/mf_arrow_up@2x.png
[add] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/resources/mf_arrow_up.imageset/mf_arrow_up@3x.png
[add] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/resources/mf_gradient.imageset/Contents.json
[add] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/resources/mf_gradient.imageset/mf_gradient.png
[add] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/resources/mf_keyboard.imageset/Contents.json
[add] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/resources/mf_keyboard.imageset/mf_keyboard.png
[add] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/resources/mf_keyboard.imageset/mf_keyboard@2x.png
[add] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/resources/mf_keyboard.imageset/mf_keyboard@3x.png
[modify] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/uicolor_manualfill.h
[modify] https://crrev.com/dec7e3882ba4165e0028584f495a35a07c3130cd/ios/chrome/browser/ui/autofill/manual_fill/uicolor_manualfill.mm

Comment 37 by bugdroid1@chromium.org, Oct 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c62a9956e74f8204531943ddd70b92e0f22f7eca

commit c62a9956e74f8204531943ddd70b92e0f22f7eca
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Fri Oct 19 07:32:51 2018

[iOS][MF] Add support for device rotation

Adds a flag wich resets after a delay when the device rotates. This
allows to know if certain notification are caused due a recent rotation.

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I7b36544a451c677ff0ff842876f80841847a2833
Reviewed-on: https://chromium-review.googlesource.com/c/1273145
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601072}
[modify] https://crrev.com/c62a9956e74f8204531943ddd70b92e0f22f7eca/ios/chrome/browser/ui/autofill/manual_fill/keyboard_observer_helper.mm
[modify] https://crrev.com/c62a9956e74f8204531943ddd70b92e0f22f7eca/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller_egtest.mm

Comment 38 by bugdroid1@chromium.org, Oct 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d29c1236dfa3291acded5b0c196a7a8271c157c3

commit d29c1236dfa3291acded5b0c196a7a8271c157c3
Author: David Jean <djean@google.com>
Date: Mon Oct 29 15:56:25 2018

[ios] separate full_card_requester dependencies so it can be used in manual_fill

Replaces https://crrev.com/c/1280277

Bug:  845472 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Iad5a713243dab998a1a202602a90eb06df0b603d
Reviewed-on: https://chromium-review.googlesource.com/c/1283131
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603510}
[modify] https://crrev.com/d29c1236dfa3291acded5b0c196a7a8271c157c3/ios/chrome/browser/ui/autofill/BUILD.gn
[modify] https://crrev.com/d29c1236dfa3291acded5b0c196a7a8271c157c3/ios/chrome/browser/ui/payments/BUILD.gn

Comment 39 by bugdroid1@chromium.org, Oct 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c44dadf2cc7186c5d47537b7a3b7a88715c15a3d

commit c44dadf2cc7186c5d47537b7a3b7a88715c15a3d
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Wed Oct 31 19:37:17 2018

[iOS][MF] Support iFrames in Manual Fallback

Enables the injection handler used in Manual Fallback to work on frames.
Adds testing utilities to support tapping an element in a window
frame.
Adds the frame messaging flag to the manual fallback test bot.

Bug:  845472 
Change-Id: Id054361af1f4be5450f13cd0afabe46e24ea11ff
Reviewed-on: https://chromium-review.googlesource.com/c/1292409
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604364}
[modify] https://crrev.com/c44dadf2cc7186c5d47537b7a3b7a88715c15a3d/ios/build/bots/tests/eg_tests.json
[modify] https://crrev.com/c44dadf2cc7186c5d47537b7a3b7a88715c15a3d/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[modify] https://crrev.com/c44dadf2cc7186c5d47537b7a3b7a88715c15a3d/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_injection_handler.mm
[modify] https://crrev.com/c44dadf2cc7186c5d47537b7a3b7a88715c15a3d/ios/chrome/browser/ui/autofill/manual_fill/password_mediator.mm
[modify] https://crrev.com/c44dadf2cc7186c5d47537b7a3b7a88715c15a3d/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller_egtest.mm
[modify] https://crrev.com/c44dadf2cc7186c5d47537b7a3b7a88715c15a3d/ios/chrome/test/earl_grey/chrome_actions.h
[modify] https://crrev.com/c44dadf2cc7186c5d47537b7a3b7a88715c15a3d/ios/chrome/test/earl_grey/chrome_actions.mm
[modify] https://crrev.com/c44dadf2cc7186c5d47537b7a3b7a88715c15a3d/ios/testing/BUILD.gn
[add] https://crrev.com/c44dadf2cc7186c5d47537b7a3b7a88715c15a3d/ios/testing/data/http_server_files/iframe_form.html
[modify] https://crrev.com/c44dadf2cc7186c5d47537b7a3b7a88715c15a3d/ios/web/public/test/element_selector.h
[modify] https://crrev.com/c44dadf2cc7186c5d47537b7a3b7a88715c15a3d/ios/web/public/test/element_selector.mm
[modify] https://crrev.com/c44dadf2cc7186c5d47537b7a3b7a88715c15a3d/testing/buildbot/gn_isolate_map.pyl

Comment 40 by bugdroid1@chromium.org, Nov 6

Project Member

Comment 41 by bugdroid1@chromium.org, Nov 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8850716febeaf055404fdc8668b0b6dc2470048

commit e8850716febeaf055404fdc8668b0b6dc2470048
Author: David Jean <djean@google.com>
Date: Thu Nov 08 08:13:36 2018

[ios] Add helpers to manual fill to unlock credit cards

These helpers create a bridge between manual fill credit card and
payments' FullCardRequester to let user 'unlock' server side credit card
by entering correct cvc.

Bug:  845472 
Change-Id: I9fcf013a0352673659d77291c03faa8aa31a9980
Reviewed-on: https://chromium-review.googlesource.com/c/1304413
Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606382}
[modify] https://crrev.com/e8850716febeaf055404fdc8668b0b6dc2470048/ios/chrome/browser/autofill/BUILD.gn
[modify] https://crrev.com/e8850716febeaf055404fdc8668b0b6dc2470048/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[add] https://crrev.com/e8850716febeaf055404fdc8668b0b6dc2470048/ios/chrome/browser/ui/autofill/manual_fill/full_card_request_result_delegate_bridge.h
[add] https://crrev.com/e8850716febeaf055404fdc8668b0b6dc2470048/ios/chrome/browser/ui/autofill/manual_fill/full_card_request_result_delegate_bridge.mm
[add] https://crrev.com/e8850716febeaf055404fdc8668b0b6dc2470048/ios/chrome/browser/ui/autofill/manual_fill/full_card_requester.h
[add] https://crrev.com/e8850716febeaf055404fdc8668b0b6dc2470048/ios/chrome/browser/ui/autofill/manual_fill/full_card_requester.mm

Comment 42 by bugdroid1@chromium.org, Nov 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e573ccd3444f3191f14a41fe726ab4763daf4b7

commit 2e573ccd3444f3191f14a41fe726ab4763daf4b7
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Thu Nov 08 10:49:25 2018

[iOS][MF] General and password actions metrics

Creates and logs user actions for the following actions.

ManualFallback_Close
ManualFallback_ClosePopover
ManualFallback_OpenPassword
ManualFallback_OpenCreditCard
ManualFallback_OpenProfile

ManualFallback_Password_SelectUsername
ManualFallback_Password_SelectPassword
ManualFallback_Password_OpenOtherPassword
ManualFallback_Password_OpenManagePassword

Bug:  845472 , 881734
Change-Id: If251294575be60b9c27296e79e06a394a277762e
Reviewed-on: https://chromium-review.googlesource.com/c/1317914
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606408}
[modify] https://crrev.com/2e573ccd3444f3191f14a41fe726ab4763daf4b7/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
[modify] https://crrev.com/2e573ccd3444f3191f14a41fe726ab4763daf4b7/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.mm
[modify] https://crrev.com/2e573ccd3444f3191f14a41fe726ab4763daf4b7/ios/chrome/browser/ui/autofill/manual_fill/password_coordinator.mm
[modify] https://crrev.com/2e573ccd3444f3191f14a41fe726ab4763daf4b7/ios/chrome/browser/ui/autofill/manual_fill/password_mediator.mm
[modify] https://crrev.com/2e573ccd3444f3191f14a41fe726ab4763daf4b7/tools/metrics/actions/actions.xml

Comment 43 by bugdroid1@chromium.org, Nov 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50ac3f623fa6da1a440b6c72c78aa28c0cc56b3a

commit 50ac3f623fa6da1a440b6c72c78aa28c0cc56b3a
Author: David Jean <djean@google.com>
Date: Thu Nov 08 12:32:44 2018

[ios] add manual fallback address cell

Will merge the cell_utils with card_cell after crrev/c/1303730 is merged.

Bug:  845472 
Change-Id: Iead98637aeaa8b7e3b0252057b8592ef4fff0529
Reviewed-on: https://chromium-review.googlesource.com/c/1317853
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606423}
[modify] https://crrev.com/50ac3f623fa6da1a440b6c72c78aa28c0cc56b3a/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[add] https://crrev.com/50ac3f623fa6da1a440b6c72c78aa28c0cc56b3a/ios/chrome/browser/ui/autofill/manual_fill/address_list_delegate.h
[modify] https://crrev.com/50ac3f623fa6da1a440b6c72c78aa28c0cc56b3a/ios/chrome/browser/ui/autofill/manual_fill/card_list_delegate.h
[add] https://crrev.com/50ac3f623fa6da1a440b6c72c78aa28c0cc56b3a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.h
[add] https://crrev.com/50ac3f623fa6da1a440b6c72c78aa28c0cc56b3a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.mm
[add] https://crrev.com/50ac3f623fa6da1a440b6c72c78aa28c0cc56b3a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.h
[add] https://crrev.com/50ac3f623fa6da1a440b6c72c78aa28c0cc56b3a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.mm
[modify] https://crrev.com/50ac3f623fa6da1a440b6c72c78aa28c0cc56b3a/ios/chrome/browser/ui/autofill/manual_fill/password_list_delegate.h

Comment 44 by bugdroid1@chromium.org, Nov 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dea647a392f2b185dc0f7d004373032f6d77f090

commit dea647a392f2b185dc0f7d004373032f6d77f090
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Thu Nov 08 12:51:30 2018

Revert "[ios] add manual fallback address cell"

This reverts commit 50ac3f623fa6da1a440b6c72c78aa28c0cc56b3a.

Reason for revert: it breaks ios_webview build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-webview/988

Original change's description:
> [ios] add manual fallback address cell
> 
> Will merge the cell_utils with card_cell after crrev/c/1303730 is merged.
> 
> Bug:  845472 
> Change-Id: Iead98637aeaa8b7e3b0252057b8592ef4fff0529
> Reviewed-on: https://chromium-review.googlesource.com/c/1317853
> Commit-Queue: David Jean <djean@chromium.org>
> Reviewed-by: Eric Noyau <noyau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606423}

TBR=noyau@chromium.org,mahmadi@chromium.org,javierrobles@chromium.org,djean@chromium.org

Change-Id: Ib17331c289372d4ad6a1d46ba26906d63c2c3da8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  845472 
Reviewed-on: https://chromium-review.googlesource.com/c/1326152
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606425}
[modify] https://crrev.com/dea647a392f2b185dc0f7d004373032f6d77f090/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[delete] https://crrev.com/ae58e0551120acd2d198d91397f83c43a3e214fa/ios/chrome/browser/ui/autofill/manual_fill/address_list_delegate.h
[modify] https://crrev.com/dea647a392f2b185dc0f7d004373032f6d77f090/ios/chrome/browser/ui/autofill/manual_fill/card_list_delegate.h
[delete] https://crrev.com/ae58e0551120acd2d198d91397f83c43a3e214fa/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.h
[delete] https://crrev.com/ae58e0551120acd2d198d91397f83c43a3e214fa/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.mm
[delete] https://crrev.com/ae58e0551120acd2d198d91397f83c43a3e214fa/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.h
[delete] https://crrev.com/ae58e0551120acd2d198d91397f83c43a3e214fa/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.mm
[modify] https://crrev.com/dea647a392f2b185dc0f7d004373032f6d77f090/ios/chrome/browser/ui/autofill/manual_fill/password_list_delegate.h

Comment 45 by bugdroid1@chromium.org, Nov 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c8ed7821e7e41656226e1719f8f822775f0891a

commit 6c8ed7821e7e41656226e1719f8f822775f0891a
Author: David Jean <djean@google.com>
Date: Thu Nov 08 15:26:34 2018

Reland "[ios] add manual fallback address cell"

This is a reland of 50ac3f623fa6da1a440b6c72c78aa28c0cc56b3a
The problem is fixed in https://crrev.com/c/1326155

Original change's description:
> [ios] add manual fallback address cell
>
> Will merge the cell_utils with card_cell after crrev/c/1303730 is merged.
>
> Bug:  845472 
> Change-Id: Iead98637aeaa8b7e3b0252057b8592ef4fff0529
> Reviewed-on: https://chromium-review.googlesource.com/c/1317853
> Commit-Queue: David Jean <djean@chromium.org>
> Reviewed-by: Eric Noyau <noyau@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606423}

TBR=noyau@chromium.org,mahmadi@chromium.org

Bug:  845472 
Change-Id: I6524b3ed9d38233c0c5489a2b6ecd2753708d09a
Reviewed-on: https://chromium-review.googlesource.com/c/1326484
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606471}
[modify] https://crrev.com/6c8ed7821e7e41656226e1719f8f822775f0891a/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[add] https://crrev.com/6c8ed7821e7e41656226e1719f8f822775f0891a/ios/chrome/browser/ui/autofill/manual_fill/address_list_delegate.h
[modify] https://crrev.com/6c8ed7821e7e41656226e1719f8f822775f0891a/ios/chrome/browser/ui/autofill/manual_fill/card_list_delegate.h
[add] https://crrev.com/6c8ed7821e7e41656226e1719f8f822775f0891a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.h
[add] https://crrev.com/6c8ed7821e7e41656226e1719f8f822775f0891a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.mm
[add] https://crrev.com/6c8ed7821e7e41656226e1719f8f822775f0891a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.h
[add] https://crrev.com/6c8ed7821e7e41656226e1719f8f822775f0891a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.mm
[modify] https://crrev.com/6c8ed7821e7e41656226e1719f8f822775f0891a/ios/chrome/browser/ui/autofill/manual_fill/password_list_delegate.h

Comment 48 by bugdroid1@chromium.org, Nov 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9f5a2e523469d0570b1b9ae0bc5818523b2528b

commit d9f5a2e523469d0570b1b9ae0bc5818523b2528b
Author: David Jean <djean@google.com>
Date: Fri Nov 09 09:38:11 2018

[ios] add manual fallback credit card and address view controller

Added base class that should be used in passwords later.

Bug:  845472 
Change-Id: I1c1d2204d920ae141448239cfeb1c1c5a0e93a20
Reviewed-on: https://chromium-review.googlesource.com/c/1319714
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606773}
[modify] https://crrev.com/d9f5a2e523469d0570b1b9ae0bc5818523b2528b/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[add] https://crrev.com/d9f5a2e523469d0570b1b9ae0bc5818523b2528b/ios/chrome/browser/ui/autofill/manual_fill/address_view_controller.h
[add] https://crrev.com/d9f5a2e523469d0570b1b9ae0bc5818523b2528b/ios/chrome/browser/ui/autofill/manual_fill/address_view_controller.mm
[add] https://crrev.com/d9f5a2e523469d0570b1b9ae0bc5818523b2528b/ios/chrome/browser/ui/autofill/manual_fill/card_view_controller.h
[add] https://crrev.com/d9f5a2e523469d0570b1b9ae0bc5818523b2528b/ios/chrome/browser/ui/autofill/manual_fill/card_view_controller.mm
[add] https://crrev.com/d9f5a2e523469d0570b1b9ae0bc5818523b2528b/ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.h
[add] https://crrev.com/d9f5a2e523469d0570b1b9ae0bc5818523b2528b/ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm

Comment 49 by bugdroid1@chromium.org, Nov 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b02a7719f78de1e78ded7807aa4d139f8c2b77d6

commit b02a7719f78de1e78ded7807aa4d139f8c2b77d6
Author: David Jean <djean@google.com>
Date: Fri Nov 09 15:34:07 2018

[ios] add manual fallback credit card and address coordinator

And a common base class.

Bug:  845472 
Change-Id: I12999d306804227e605e270c9b4f14bd8ee6a2bb
Reviewed-on: https://chromium-review.googlesource.com/c/1318914
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606850}
[modify] https://crrev.com/b02a7719f78de1e78ded7807aa4d139f8c2b77d6/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[add] https://crrev.com/b02a7719f78de1e78ded7807aa4d139f8c2b77d6/ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.h
[add] https://crrev.com/b02a7719f78de1e78ded7807aa4d139f8c2b77d6/ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.mm
[modify] https://crrev.com/b02a7719f78de1e78ded7807aa4d139f8c2b77d6/ios/chrome/browser/ui/autofill/manual_fill/address_list_delegate.h
[add] https://crrev.com/b02a7719f78de1e78ded7807aa4d139f8c2b77d6/ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.h
[add] https://crrev.com/b02a7719f78de1e78ded7807aa4d139f8c2b77d6/ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.mm
[modify] https://crrev.com/b02a7719f78de1e78ded7807aa4d139f8c2b77d6/ios/chrome/browser/ui/autofill/manual_fill/card_list_delegate.h
[add] https://crrev.com/b02a7719f78de1e78ded7807aa4d139f8c2b77d6/ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.h
[add] https://crrev.com/b02a7719f78de1e78ded7807aa4d139f8c2b77d6/ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm

Comment 51 by bugdroid1@chromium.org, Nov 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7187874ae5eaf5009545a9408e7d55f308f28e10

commit 7187874ae5eaf5009545a9408e7d55f308f28e10
Author: David Jean <djean@google.com>
Date: Tue Nov 13 09:58:46 2018

[ios] add opening of credit cards / addresses settings from manual fallback

Bug:  845472 
Change-Id: I1dabe1fd33812e0d533087b0aa2b4f56f6c2f721
Reviewed-on: https://chromium-review.googlesource.com/c/1332298
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607539}
[modify] https://crrev.com/7187874ae5eaf5009545a9408e7d55f308f28e10/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/7187874ae5eaf5009545a9408e7d55f308f28e10/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.h
[modify] https://crrev.com/7187874ae5eaf5009545a9408e7d55f308f28e10/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
[modify] https://crrev.com/7187874ae5eaf5009545a9408e7d55f308f28e10/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/7187874ae5eaf5009545a9408e7d55f308f28e10/ios/chrome/browser/ui/commands/application_commands.h
[modify] https://crrev.com/7187874ae5eaf5009545a9408e7d55f308f28e10/ios/chrome/browser/ui/settings/settings_navigation_controller.h
[modify] https://crrev.com/7187874ae5eaf5009545a9408e7d55f308f28e10/ios/chrome/browser/ui/settings/settings_navigation_controller.mm

Comment 53 by bugdroid1@chromium.org, Nov 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a332fd8b08dd1f2d6e86f4e3fd550790bf91ba74

commit a332fd8b08dd1f2d6e86f4e3fd550790bf91ba74
Author: David Jean <djean@google.com>
Date: Tue Nov 13 14:39:26 2018

[ios] Add pure obj-c credit card for manual fallback

Includes translator from autofill::CreditCard. Will be used in manual_fill in a follow up cl.

Bug:  845472 
Change-Id: I1f70757e5de4ace6f12a3dfebbcf263c960a7d57
Reviewed-on: https://chromium-review.googlesource.com/c/1331391
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607583}
[modify] https://crrev.com/a332fd8b08dd1f2d6e86f4e3fd550790bf91ba74/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[add] https://crrev.com/a332fd8b08dd1f2d6e86f4e3fd550790bf91ba74/ios/chrome/browser/ui/autofill/manual_fill/credit_card.h
[add] https://crrev.com/a332fd8b08dd1f2d6e86f4e3fd550790bf91ba74/ios/chrome/browser/ui/autofill/manual_fill/credit_card.mm
[add] https://crrev.com/a332fd8b08dd1f2d6e86f4e3fd550790bf91ba74/ios/chrome/browser/ui/autofill/manual_fill/credit_card_form.h
[add] https://crrev.com/a332fd8b08dd1f2d6e86f4e3fd550790bf91ba74/ios/chrome/browser/ui/autofill/manual_fill/credit_card_form.mm
[add] https://crrev.com/a332fd8b08dd1f2d6e86f4e3fd550790bf91ba74/ios/chrome/browser/ui/autofill/manual_fill/credit_card_form_unittest.mm
[add] https://crrev.com/a332fd8b08dd1f2d6e86f4e3fd550790bf91ba74/ios/chrome/browser/ui/autofill/manual_fill/credit_card_unittest.mm

Comment 54 by bugdroid1@chromium.org, Nov 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68b00bfc5e7c1b905d3ccff759e17afcf35c3de2

commit 68b00bfc5e7c1b905d3ccff759e17afcf35c3de2
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Tue Nov 13 18:12:05 2018

[iOS][MF] Present the icons to the right on iPad

Shows the manual fallback icons to the right on iPads. Changes include:
-Updates FormInputAccessoryView to support a custom view to the right.
-Stops instantiation of ManualFillAccessoryViewController when manual
fallback is disabled.

Bug:  845472 
Change-Id: I82b3772bf60af33f3102b520ce3cc647b16310b9
Reviewed-on: https://chromium-review.googlesource.com/c/1329176
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607655}
[modify] https://crrev.com/68b00bfc5e7c1b905d3ccff759e17afcf35c3de2/ios/chrome/browser/autofill/form_input_accessory_view.h
[modify] https://crrev.com/68b00bfc5e7c1b905d3ccff759e17afcf35c3de2/ios/chrome/browser/autofill/form_input_accessory_view.mm
[modify] https://crrev.com/68b00bfc5e7c1b905d3ccff759e17afcf35c3de2/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
[modify] https://crrev.com/68b00bfc5e7c1b905d3ccff759e17afcf35c3de2/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm

Comment 55 by bugdroid1@chromium.org, Nov 14

Project Member

Comment 56 by bugdroid1@chromium.org, Nov 14

Project Member

Comment 58 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f6e484b9478f353e8eb806c9ea45faef0e602e5

commit 7f6e484b9478f353e8eb806c9ea45faef0e602e5
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Thu Nov 15 12:18:40 2018

[iOS][MF] Replace address icon with ic_place

Bug:  845472 
Change-Id: I2f37b2310f16f0591e503929229eada33b3aec20
Reviewed-on: https://chromium-review.googlesource.com/c/1329244
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608334}
[modify] https://crrev.com/7f6e484b9478f353e8eb806c9ea45faef0e602e5/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[modify] https://crrev.com/7f6e484b9478f353e8eb806c9ea45faef0e602e5/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
[modify] https://crrev.com/7f6e484b9478f353e8eb806c9ea45faef0e602e5/ios/chrome/browser/ui/autofill/manual_fill/resources/BUILD.gn
[delete] https://crrev.com/cbf246df754f2375f274b1b8a6e0657203423979/ios/chrome/browser/ui/autofill/manual_fill/resources/addresses.imageset/Contents.json
[delete] https://crrev.com/cbf246df754f2375f274b1b8a6e0657203423979/ios/chrome/browser/ui/autofill/manual_fill/resources/addresses.imageset/addresses.png
[delete] https://crrev.com/cbf246df754f2375f274b1b8a6e0657203423979/ios/chrome/browser/ui/autofill/manual_fill/resources/addresses.imageset/addresses@2x.png
[delete] https://crrev.com/cbf246df754f2375f274b1b8a6e0657203423979/ios/chrome/browser/ui/autofill/manual_fill/resources/addresses.imageset/addresses@3x.png
[modify] https://crrev.com/7f6e484b9478f353e8eb806c9ea45faef0e602e5/third_party/material_design_icons/BUILD.gn

Comment 59 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73c81f2435b5005fbac81ab3b34d74e43e63a4a0

commit 73c81f2435b5005fbac81ab3b34d74e43e63a4a0
Author: David Jean <djean@google.com>
Date: Thu Nov 15 14:19:36 2018

[ios] Plug in obj-c credit card object in manual fill.

Also added use of cell utils in manual_fill_card_cell.

Bug:  845472 
Change-Id: Ie015a2335c3cfe37f34620e2efb1447b8429d3c1
Reviewed-on: https://chromium-review.googlesource.com/c/1335550
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608355}
[modify] https://crrev.com/73c81f2435b5005fbac81ab3b34d74e43e63a4a0/ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.mm
[modify] https://crrev.com/73c81f2435b5005fbac81ab3b34d74e43e63a4a0/ios/chrome/browser/ui/autofill/manual_fill/card_list_delegate.h
[modify] https://crrev.com/73c81f2435b5005fbac81ab3b34d74e43e63a4a0/ios/chrome/browser/ui/autofill/manual_fill/card_mediator.h
[modify] https://crrev.com/73c81f2435b5005fbac81ab3b34d74e43e63a4a0/ios/chrome/browser/ui/autofill/manual_fill/card_mediator.mm
[modify] https://crrev.com/73c81f2435b5005fbac81ab3b34d74e43e63a4a0/ios/chrome/browser/ui/autofill/manual_fill/credit_card_form.mm
[modify] https://crrev.com/73c81f2435b5005fbac81ab3b34d74e43e63a4a0/ios/chrome/browser/ui/autofill/manual_fill/credit_card_form_unittest.mm
[modify] https://crrev.com/73c81f2435b5005fbac81ab3b34d74e43e63a4a0/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.h
[modify] https://crrev.com/73c81f2435b5005fbac81ab3b34d74e43e63a4a0/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.mm

Comment 60 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e676b7b4c45de16791c3148da4214c7e88a1a4bd

commit e676b7b4c45de16791c3148da4214c7e88a1a4bd
Author: David Jean <djean@google.com>
Date: Thu Nov 15 15:37:56 2018

[ios] use view controller base class for manual fill passwords

Bug:  845472 
Change-Id: I012839e8ee5dee6ae54d66327f1de5f38ff96d71
Reviewed-on: https://chromium-review.googlesource.com/c/1335599
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608376}
[modify] https://crrev.com/e676b7b4c45de16791c3148da4214c7e88a1a4bd/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.h
[modify] https://crrev.com/e676b7b4c45de16791c3148da4214c7e88a1a4bd/ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.mm

Comment 61 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff7402f2bd091fa13c558454077d3448d4f07747

commit ff7402f2bd091fa13c558454077d3448d4f07747
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Thu Nov 15 19:04:47 2018

[iOS][MF] Hide and show autofill buttons

Hide card and address icons when no data is available. Show them again
if data becomes available.

Bug:  845472 ,  905650 
Change-Id: If0420746b2df8fd3ebbbbd8dff6524eb326cef7c
Reviewed-on: https://chromium-review.googlesource.com/c/1335570
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608462}
[modify] https://crrev.com/ff7402f2bd091fa13c558454077d3448d4f07747/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
[modify] https://crrev.com/ff7402f2bd091fa13c558454077d3448d4f07747/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.h
[modify] https://crrev.com/ff7402f2bd091fa13c558454077d3448d4f07747/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm

Comment 62 by bugdroid1@chromium.org, Nov 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d92217062a32761d901245b8bb465209bf28a9a

commit 2d92217062a32761d901245b8bb465209bf28a9a
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Thu Nov 15 19:18:17 2018

[iOS][MF] Post an a11y notification when presenting

Bug:  845472 
Change-Id: I1691063eecb6fa423bc36c21a910adcf21f00da8
Reviewed-on: https://chromium-review.googlesource.com/c/1338108
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608468}
[modify] https://crrev.com/2d92217062a32761d901245b8bb465209bf28a9a/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm

Comment 63 by bugdroid1@chromium.org, Nov 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/daee8f2b92e445c47233c7c019daf4aa949b2923

commit daee8f2b92e445c47233c7c019daf4aa949b2923
Author: David Jean <djean@google.com>
Date: Fri Nov 16 08:24:42 2018

[ios] use cell utils in manual fill password cell

Bug:  845472 
Change-Id: I1eb716c293492ada3476d356fcdfcfe23597fa59
Reviewed-on: https://chromium-review.googlesource.com/c/1335596
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608695}
[modify] https://crrev.com/daee8f2b92e445c47233c7c019daf4aa949b2923/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.mm

Comment 65 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ac04b3b385ad95f475f5015f9f2a73a6bea307b

commit 3ac04b3b385ad95f475f5015f9f2a73a6bea307b
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Mon Nov 19 14:02:19 2018

[iOS][MF] 'Manage...' metrics to actions.xml

Adds descriptions to the new actions opening settings in Manual
Fallback.

Bug:  845472 
Change-Id: If6ff348f3e8277ada4756001cfa4b98d3cc520e5
Reviewed-on: https://chromium-review.googlesource.com/c/1341535
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609275}
[modify] https://crrev.com/3ac04b3b385ad95f475f5015f9f2a73a6bea307b/tools/metrics/actions/actions.xml

Comment 66 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58e0403558cd8e9dcf797e257ca9a29b1dbe32e9

commit 58e0403558cd8e9dcf797e257ca9a29b1dbe32e9
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Mon Nov 19 14:47:04 2018

[iOS][MF] Add a11y labels for the accessory icons

Bug:  845472 
Change-Id: I47898430b16721084ec836c2d4627ccf1db7c0c3
Reviewed-on: https://chromium-review.googlesource.com/c/1338181
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609288}
[modify] https://crrev.com/58e0403558cd8e9dcf797e257ca9a29b1dbe32e9/ios/chrome/app/strings/ios_strings.grd
[add] https://crrev.com/58e0403558cd8e9dcf797e257ca9a29b1dbe32e9/ios/chrome/app/strings/ios_strings_grd/IDS_IOS_MANUAL_FALLBACK_SHOW_ADDRESSES.png.sha1
[add] https://crrev.com/58e0403558cd8e9dcf797e257ca9a29b1dbe32e9/ios/chrome/app/strings/ios_strings_grd/IDS_IOS_MANUAL_FALLBACK_SHOW_CREDIT_CARDS.png.sha1
[add] https://crrev.com/58e0403558cd8e9dcf797e257ca9a29b1dbe32e9/ios/chrome/app/strings/ios_strings_grd/IDS_IOS_MANUAL_FALLBACK_SHOW_KEYBOARD.png.sha1
[add] https://crrev.com/58e0403558cd8e9dcf797e257ca9a29b1dbe32e9/ios/chrome/app/strings/ios_strings_grd/IDS_IOS_MANUAL_FALLBACK_SHOW_PASSWORDS.png.sha1
[add] https://crrev.com/58e0403558cd8e9dcf797e257ca9a29b1dbe32e9/ios/chrome/app/strings/ios_strings_grd/OWNERS
[modify] https://crrev.com/58e0403558cd8e9dcf797e257ca9a29b1dbe32e9/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm

Comment 67 by bugdroid1@chromium.org, Nov 19

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c5020fdfc05622997bd51495d804c41a884a07a

commit 5c5020fdfc05622997bd51495d804c41a884a07a
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Mon Nov 19 17:35:49 2018

[iOS][MF] Disable accessory view animation

Disabling the manual fill accessory animation until the suggestion
animation is done. Animating the suggestions disappearing is hard and
it looks better with no animations than with one animation in one part
and no animation in the other.

Bug:  845472 ,  905660 ,  905651 
Change-Id: Ic0d9de58a85b0e5366105102f0bf3706e5ce42ba
Reviewed-on: https://chromium-review.googlesource.com/c/1341995
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609348}
[modify] https://crrev.com/5c5020fdfc05622997bd51495d804c41a884a07a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm

Comment 68 by bugdroid1@chromium.org, Nov 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc6b054145ca56dda1a2e453ec8d1e72fde56da2

commit bc6b054145ca56dda1a2e453ec8d1e72fde56da2
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Tue Nov 20 21:10:55 2018

[iOS][MF] Check for all credit cards

Instead of looking only to the credit cards to suggest, check for all
to hide and show the Manual Fallback icon. User can also use this icon
to go to the manage cards settings page.

Bug:  845472 , 906019
Change-Id: I3be2a715ebd00583ec44c5d45517e769c92d57f5
Reviewed-on: https://chromium-review.googlesource.com/c/1340265
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609800}
[modify] https://crrev.com/bc6b054145ca56dda1a2e453ec8d1e72fde56da2/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm

Comment 69 by bugdroid1@chromium.org, Nov 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d670fd60743918a34bc7b906dde3cfbbc0944ca0

commit d670fd60743918a34bc7b906dde3cfbbc0944ca0
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Wed Nov 21 10:09:17 2018

[iOS][MF] Show an alert when a field won't be filled

Only fill credit cards on HTTPS, and passwords on HTTPS and password
fields. Show an alert to the user otherwise.

Bug:  905652 , 878388,  845472 
Change-Id: I51e0f07757dc4f7f1e002b88b83a2d2eeea071b5
Reviewed-on: https://chromium-review.googlesource.com/c/1340259
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609980}
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/BUILD.gn
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/card_mediator.mm
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.mm
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.mm
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_content_delegate.h
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_injection_handler.h
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_injection_handler.mm
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.mm
[modify] https://crrev.com/d670fd60743918a34bc7b906dde3cfbbc0944ca0/ios/chrome/browser/ui/autofill/manual_fill/password_mediator.mm

Comment 70 by bugdroid1@chromium.org, Nov 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b15d163a220bc1000aecfddca42d6f86985c5c71

commit b15d163a220bc1000aecfddca42d6f86985c5c71
Author: David Jean <djean@google.com>
Date: Wed Nov 21 11:33:50 2018

[ios] add change monitor to card and address fallbacks

Bug:  845472 
Change-Id: Id077ed820ad559e00da61d96bf82f890333d9c86
Reviewed-on: https://chromium-review.googlesource.com/c/1341523
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610002}
[modify] https://crrev.com/b15d163a220bc1000aecfddca42d6f86985c5c71/ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.mm
[modify] https://crrev.com/b15d163a220bc1000aecfddca42d6f86985c5c71/ios/chrome/browser/ui/autofill/manual_fill/address_form.h
[modify] https://crrev.com/b15d163a220bc1000aecfddca42d6f86985c5c71/ios/chrome/browser/ui/autofill/manual_fill/address_form.mm
[modify] https://crrev.com/b15d163a220bc1000aecfddca42d6f86985c5c71/ios/chrome/browser/ui/autofill/manual_fill/address_mediator.h
[modify] https://crrev.com/b15d163a220bc1000aecfddca42d6f86985c5c71/ios/chrome/browser/ui/autofill/manual_fill/address_mediator.mm
[modify] https://crrev.com/b15d163a220bc1000aecfddca42d6f86985c5c71/ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.mm
[modify] https://crrev.com/b15d163a220bc1000aecfddca42d6f86985c5c71/ios/chrome/browser/ui/autofill/manual_fill/card_mediator.h
[modify] https://crrev.com/b15d163a220bc1000aecfddca42d6f86985c5c71/ios/chrome/browser/ui/autofill/manual_fill/card_mediator.mm

Comment 71 by javierrobles@chromium.org, Nov 21

Blockedon: 907087

Comment 72 by bugdroid1@chromium.org, Nov 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8ab74191295bd78e6dfb6c5ba45d3c13842e71f

commit d8ab74191295bd78e6dfb6c5ba45d3c13842e71f
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Fri Nov 23 10:58:22 2018

[iOS][MF] Rotate gradient in new accessory view

Adds support for RTL.

Bug:  845472 
Change-Id: Iefc3aeb4d0d6a5d951be43e5337f5bda0328015c
Reviewed-on: https://chromium-review.googlesource.com/c/1348332
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610566}
[modify] https://crrev.com/d8ab74191295bd78e6dfb6c5ba45d3c13842e71f/ios/chrome/browser/autofill/form_input_accessory_view.mm

Comment 73 by javierrobles@chromium.org, Nov 23

Blockedon: 908063

Comment 74 by javierrobles@chromium.org, Nov 23

Blockedon: 905657

Comment 75 by javierrobles@chromium.org, Nov 23

Blockedon: 905650

Comment 76 by javierrobles@chromium.org, Nov 23

Blockedon: 905652

Comment 77 by javierrobles@chromium.org, Nov 23

Blockedon: 906019

Comment 78 by javierrobles@chromium.org, Nov 23

Blockedon: 905654

Comment 79 by javierrobles@chromium.org, Nov 23

Blockedon: 905656

Comment 80 by javierrobles@chromium.org, Nov 23

Blockedon: 905651

Comment 81 by bugdroid1@chromium.org, Nov 23

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbd360b334ef36a9d178738814f2ec52e4c9e52a

commit dbd360b334ef36a9d178738814f2ec52e4c9e52a
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Fri Nov 23 15:23:17 2018

[iOS][MF] Animate suggestions out and in

In order to add the animations some refactoring was required.
This also updates the suggestions view and form accessory view instead
of recreating them every time new suggestions arrive.
Continues the UI layering of these views, by removing the navigator
related logic from them.
Relies on setting content insets instead of removing suggestions to
lock on the manual fill icons.
Refactors names of delegates and properties to more appropriate ones
Fixes an issue when disabled suggestions was ignored when jumping
between fields.



Bug:  905651 , 907084,  845472 ,  905660 
Change-Id: I4ceebcabadbb26e6d948c26f9691d5684a143b79
Reviewed-on: https://chromium-review.googlesource.com/c/1346833
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610611}
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/BUILD.gn
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_accessory_consumer.h
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_accessory_view.h
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_accessory_view.mm
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_accessory_view_controller.h
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_accessory_view_handler.h
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_accessory_view_handler.mm
[rename] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_navigator.h
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_input_suggestions_provider.h
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_suggestion_controller.mm
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_suggestion_view.h
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/autofill/form_suggestion_view.mm
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.h
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm
[modify] https://crrev.com/dbd360b334ef36a9d178738814f2ec52e4c9e52a/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm

Comment 82 by bugdroid1@chromium.org, Nov 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b752e0f1215bbb1e161390b0119a51f9f8b0de9

commit 4b752e0f1215bbb1e161390b0119a51f9f8b0de9
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Tue Nov 27 14:04:35 2018

[iOS][MF] Filter android passwords

Filter android passwords from the manual fallback options.

Bug:  905659 , 878388,  845472 
Change-Id: Id7f120f0747f3ff01d5239568a427dea97a965a9
Reviewed-on: https://chromium-review.googlesource.com/c/1352149
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611094}
[modify] https://crrev.com/4b752e0f1215bbb1e161390b0119a51f9f8b0de9/ios/chrome/browser/autofill/manual_fill/passwords_fetcher.mm

Comment 83 by bugdroid1@chromium.org, Nov 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c94239ba37744263320880954a7debcb1ce818b8

commit c94239ba37744263320880954a7debcb1ce818b8
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Tue Nov 27 16:14:42 2018

[iOS][MF] Adjusts tintAdjustmentMode

This change is made so the buttons keep the color on iPads when the
popovers are presented.

Bug:  845472 
Change-Id: I7ce4d410bd66a5aa0dc1c1258914df493d3ac1db
Reviewed-on: https://chromium-review.googlesource.com/c/1352154
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611132}
[modify] https://crrev.com/c94239ba37744263320880954a7debcb1ce818b8/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm

Comment 85 by javierrobles@chromium.org, Nov 27

Blockedon: 906017

Comment 86 by bugdroid1@chromium.org, Nov 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e58d464b41eb97847b9feae497a5c98e0a9b8734

commit e58d464b41eb97847b9feae497a5c98e0a9b8734
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Tue Nov 27 17:02:30 2018

[iOS][MF] Don't allow row selection

Not explicitly disabling row selection would cause Voice Over to read
"selected" on double taps.

Bug:  845472 
Change-Id: If41b29356a86b6ae2bad9ffd365c68a46c7c5cb1
Reviewed-on: https://chromium-review.googlesource.com/c/1352158
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611151}
[modify] https://crrev.com/e58d464b41eb97847b9feae497a5c98e0a9b8734/ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm

Comment 88 by bugdroid1@chromium.org, Nov 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d1a7a54082e4e43ebdc5b60d0acdf6b440ef40a

commit 9d1a7a54082e4e43ebdc5b60d0acdf6b440ef40a
Author: Ken Rockot <rockot@google.com>
Date: Tue Nov 27 20:44:33 2018

Revert "[ios] add credit card test for manual fallback"

This reverts commit 30e1dd180408413c8fce6dbe5b856c048a8ca908.

Reason for revert:  https://crbug.com/908970 

Original change's description:
> [ios] add credit card test for manual fallback
> 
> Also adds AutofillManualFallbackPhaseTwo to test bots.
> 
> Bug:  845472 
> Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d
> Reviewed-on: https://chromium-review.googlesource.com/c/1337347
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Commit-Queue: David Jean <djean@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611171}

TBR=rohitrao@chromium.org,bpastene@chromium.org,javierrobles@chromium.org,djean@chromium.org

Change-Id: Ied47c5923ca1a71604a04df719bf2a18bae39265
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  845472 
Reviewed-on: https://chromium-review.googlesource.com/c/1352513
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#611297}
[modify] https://crrev.com/9d1a7a54082e4e43ebdc5b60d0acdf6b440ef40a/ios/build/bots/tests/eg_tests.json
[modify] https://crrev.com/9d1a7a54082e4e43ebdc5b60d0acdf6b440ef40a/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[modify] https://crrev.com/9d1a7a54082e4e43ebdc5b60d0acdf6b440ef40a/ios/chrome/browser/ui/autofill/manual_fill/card_mediator.h
[delete] https://crrev.com/2b7c7c06fb5a4b27b92aec536c0e42890462e84f/ios/chrome/browser/ui/autofill/manual_fill/card_view_controller_egtest.mm
[modify] https://crrev.com/9d1a7a54082e4e43ebdc5b60d0acdf6b440ef40a/testing/buildbot/gn_isolate_map.pyl

Comment 89 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7122bbaa44f5c258cdcca3b933f1d18b24976d2b

commit 7122bbaa44f5c258cdcca3b933f1d18b24976d2b
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Wed Nov 28 10:31:06 2018

[iOS][MF] Tweaks to the Manual Fallback popover

Sets the background color to white.
Changes the preffered height to 360.

Bug: 878388,  845472 
Change-Id: If4ff0363808af7c373e4f70d9d664196867fdbb6
Reviewed-on: https://chromium-review.googlesource.com/c/1350967
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611632}
[modify] https://crrev.com/7122bbaa44f5c258cdcca3b933f1d18b24976d2b/ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm
[modify] https://crrev.com/7122bbaa44f5c258cdcca3b933f1d18b24976d2b/ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm

Comment 90 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/965f2dd775e784aa146f1905cf1013f84a6ab512

commit 965f2dd775e784aa146f1905cf1013f84a6ab512
Author: David Jean <djean@google.com>
Date: Wed Nov 28 14:02:44 2018

Reland "[ios] add credit card test for manual fallback"

This is a reland of 30e1dd180408413c8fce6dbe5b856c048a8ca908

Adding feature flags to slimnav.
Revert bug: https://bugs.chromium.org/p/chromium/issues/detail?id=908970

Original change's description:
> [ios] add credit card test for manual fallback
>
> Also adds AutofillManualFallbackPhaseTwo to test bots.
>
> Bug:  845472 
> Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d
> Reviewed-on: https://chromium-review.googlesource.com/c/1337347
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Commit-Queue: David Jean <djean@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611171}

TBR=rohitrao@chromium.org

Bug:  845472 , 908970 
Change-Id: I2cc0cddf0be8cea447f45f69457afbe19c840f29
Reviewed-on: https://chromium-review.googlesource.com/c/1352328
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611679}
[modify] https://crrev.com/965f2dd775e784aa146f1905cf1013f84a6ab512/ios/build/bots/chromium.mac/ios-slimnav.json
[modify] https://crrev.com/965f2dd775e784aa146f1905cf1013f84a6ab512/ios/build/bots/tests/eg_tests.json
[modify] https://crrev.com/965f2dd775e784aa146f1905cf1013f84a6ab512/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[modify] https://crrev.com/965f2dd775e784aa146f1905cf1013f84a6ab512/ios/chrome/browser/ui/autofill/manual_fill/card_mediator.h
[add] https://crrev.com/965f2dd775e784aa146f1905cf1013f84a6ab512/ios/chrome/browser/ui/autofill/manual_fill/card_view_controller_egtest.mm
[modify] https://crrev.com/965f2dd775e784aa146f1905cf1013f84a6ab512/testing/buildbot/gn_isolate_map.pyl

Comment 91 by bugdroid1@chromium.org, Nov 28

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/452fa50b0defb321f38081c645fad92153e6dd55

commit 452fa50b0defb321f38081c645fad92153e6dd55
Author: Ken Rockot <rockot@google.com>
Date: Wed Nov 28 17:07:50 2018

Revert "Reland "[ios] add credit card test for manual fallback""

This reverts commit 965f2dd775e784aa146f1905cf1013f84a6ab512.

Reason for revert: Still broken, unfortunately:  https://crbug.com/909760 

Original change's description:
> Reland "[ios] add credit card test for manual fallback"
> 
> This is a reland of 30e1dd180408413c8fce6dbe5b856c048a8ca908
> 
> Adding feature flags to slimnav.
> Revert bug: https://bugs.chromium.org/p/chromium/issues/detail?id=908970
> 
> Original change's description:
> > [ios] add credit card test for manual fallback
> >
> > Also adds AutofillManualFallbackPhaseTwo to test bots.
> >
> > Bug:  845472 
> > Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d
> > Reviewed-on: https://chromium-review.googlesource.com/c/1337347
> > Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> > Reviewed-by: Ben Pastene <bpastene@chromium.org>
> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> > Commit-Queue: David Jean <djean@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#611171}
> 
> TBR=rohitrao@chromium.org
> 
> Bug:  845472 , 908970 
> Change-Id: I2cc0cddf0be8cea447f45f69457afbe19c840f29
> Reviewed-on: https://chromium-review.googlesource.com/c/1352328
> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611679}

TBR=rohitrao@chromium.org,bpastene@chromium.org,javierrobles@chromium.org,djean@chromium.org

Change-Id: Ie4ab90910a6c9b63c0b15044663c2dab68637ae9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  845472 ,  908970 
Reviewed-on: https://chromium-review.googlesource.com/c/1352934
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#611741}
[modify] https://crrev.com/452fa50b0defb321f38081c645fad92153e6dd55/ios/build/bots/chromium.mac/ios-slimnav.json
[modify] https://crrev.com/452fa50b0defb321f38081c645fad92153e6dd55/ios/build/bots/tests/eg_tests.json
[modify] https://crrev.com/452fa50b0defb321f38081c645fad92153e6dd55/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[modify] https://crrev.com/452fa50b0defb321f38081c645fad92153e6dd55/ios/chrome/browser/ui/autofill/manual_fill/card_mediator.h
[delete] https://crrev.com/4bd59ad2d83df87dbe7d43dfd7b27fc2529f428e/ios/chrome/browser/ui/autofill/manual_fill/card_view_controller_egtest.mm
[modify] https://crrev.com/452fa50b0defb321f38081c645fad92153e6dd55/testing/buildbot/gn_isolate_map.pyl

Comment 92 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8d3e6d991451bedf136b9d5e03cd2509a7dbfe1

commit e8d3e6d991451bedf136b9d5e03cd2509a7dbfe1
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Thu Nov 29 10:32:22 2018

[iOS][MF] Refactors coordinator logic to mediator

This CL only moves the logic from the coordinator to the mediator. It
shouldn't change any behavior. And it only moves logic related to the
manual fill view controller.

Bug:  845472 
Change-Id: Id17a14903c50fa63a4a643025ef235256bc2474e
Reviewed-on: https://chromium-review.googlesource.com/c/1352185
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612130}
[modify] https://crrev.com/e8d3e6d991451bedf136b9d5e03cd2509a7dbfe1/ios/chrome/browser/autofill/autofill_controller_unittest.mm
[modify] https://crrev.com/e8d3e6d991451bedf136b9d5e03cd2509a7dbfe1/ios/chrome/browser/autofill/form_input_accessory_consumer.h
[modify] https://crrev.com/e8d3e6d991451bedf136b9d5e03cd2509a7dbfe1/ios/chrome/browser/autofill/form_input_accessory_view_controller.h
[modify] https://crrev.com/e8d3e6d991451bedf136b9d5e03cd2509a7dbfe1/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
[modify] https://crrev.com/e8d3e6d991451bedf136b9d5e03cd2509a7dbfe1/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm
[modify] https://crrev.com/e8d3e6d991451bedf136b9d5e03cd2509a7dbfe1/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/e8d3e6d991451bedf136b9d5e03cd2509a7dbfe1/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
[modify] https://crrev.com/e8d3e6d991451bedf136b9d5e03cd2509a7dbfe1/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.h
[modify] https://crrev.com/e8d3e6d991451bedf136b9d5e03cd2509a7dbfe1/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm

Comment 93 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b44ef4b1154ef2609a31dde665c100a51ce54a6

commit 1b44ef4b1154ef2609a31dde665c100a51ce54a6
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Thu Nov 29 13:03:04 2018

[iOS][MF] Add histograms

Adds histograms for:
How many autofill suggestions exists when a user opens passwords manual fallback.
How many autofill suggestions exists when a user opens credit cards manual fallback.
How many autofill suggestions exists when a user opens profiles manual fallback.

Bug:  905653 ,  845472 
Change-Id: I114fee74ea1f78a8fe08b3e8a373fa8946e0d7ae
Reviewed-on: https://chromium-review.googlesource.com/c/1352166
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612166}
[modify] https://crrev.com/1b44ef4b1154ef2609a31dde665c100a51ce54a6/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
[modify] https://crrev.com/1b44ef4b1154ef2609a31dde665c100a51ce54a6/tools/metrics/histograms/histograms.xml

Comment 94 by bugdroid1@chromium.org, Nov 29

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebeabf9457dc7c3649fcb9650e2bf9ba84a0e4d4

commit ebeabf9457dc7c3649fcb9650e2bf9ba84a0e4d4
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Thu Nov 29 18:23:15 2018

[iOS][MF] Prevent leaking suggestions

Makes explicit when the custom keyboard views are paused.
Nils last suggestions on reset.
Removes the accessory view from non web urls.
Organizes code in the the form activity handler.
Stops using |lastSuggestions| to gate view controller updates,
|[pause / continue]CustomViewController| is used instead.

Bug:  845472 
Change-Id: I751015f9bd2b7b085c15a10fd41fd949dc1fa672
Reviewed-on: https://chromium-review.googlesource.com/c/1355179
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612280}
[modify] https://crrev.com/ebeabf9457dc7c3649fcb9650e2bf9ba84a0e4d4/ios/chrome/browser/autofill/form_input_accessory_view_controller.h
[modify] https://crrev.com/ebeabf9457dc7c3649fcb9650e2bf9ba84a0e4d4/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
[modify] https://crrev.com/ebeabf9457dc7c3649fcb9650e2bf9ba84a0e4d4/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm

Comment 95 by bugdroid1@chromium.org, Nov 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39cf762f8d2d380ab767ec6c1f0842569587eceb

commit 39cf762f8d2d380ab767ec6c1f0842569587eceb
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Fri Nov 30 10:08:38 2018

[iOS][MF] Fix content instets on rotation

Bug:  845472 
Change-Id: I3afc1e03c280c88cce039ac8d4a6b288edd7be78
Reviewed-on: https://chromium-review.googlesource.com/c/1355173
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612608}
[modify] https://crrev.com/39cf762f8d2d380ab767ec6c1f0842569587eceb/ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm

Comment 96 by bugdroid1@chromium.org, Nov 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f9e02a91564e3bd3a7a026e5982697cacefa886

commit 3f9e02a91564e3bd3a7a026e5982697cacefa886
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Fri Nov 30 10:10:45 2018

[iOS][MF] Fix constraints on password cell

Clears the vertical constraints for reuse.
Removes extra vertical constraints from separator.

Bug: 878388,  845472 
Change-Id: I5ba9efdacd2ac642361069b241a9e53956edc215
Reviewed-on: https://chromium-review.googlesource.com/c/1355137
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612609}
[modify] https://crrev.com/3f9e02a91564e3bd3a7a026e5982697cacefa886/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.mm

Comment 97 by bugdroid1@chromium.org, Nov 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e11b6aecfc7a328da8d2be63d29943da57ce666f

commit e11b6aecfc7a328da8d2be63d29943da57ce666f
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Fri Nov 30 15:32:10 2018

[iOS][MF] Fix cell with extra constraint

Bug:  845472 
Change-Id: Ibdcc5ead0e06decf0fc27914bea6801120cc77a9
Reviewed-on: https://chromium-review.googlesource.com/c/1356980
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612656}
[modify] https://crrev.com/e11b6aecfc7a328da8d2be63d29943da57ce666f/ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm

Comment 98 by javierrobles@chromium.org, Dec 3

Blockedon: 911086

Comment 99 by bugdroid1@chromium.org, Dec 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53342bfec319d1f357ea7280bd10fe58543f1f62

commit 53342bfec319d1f357ea7280bd10fe58543f1f62
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Mon Dec 03 13:21:24 2018

[iOS][MF] Clean unused code

Bug:  845472 
Change-Id: I30ae4dd0811b60aa5509c8d3a276a62626bb454c
Reviewed-on: https://chromium-review.googlesource.com/c/1355133
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613066}
[modify] https://crrev.com/53342bfec319d1f357ea7280bd10fe58543f1f62/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm

Comment 100 by javierrobles@chromium.org, Dec 3

Blockedon: 911142

Comment 101 by javierrobles@chromium.org, Dec 3

Blockedon: 911148

Comment 102 by javierrobles@chromium.org, Dec 3

Blockedon: 911168

Comment 103 by bugdroid1@chromium.org, Dec 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02ec4e9cfb45e7781692e6dff2941875cc4d913b

commit 02ec4e9cfb45e7781692e6dff2941875cc4d913b
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Mon Dec 03 17:06:35 2018

[iOS][MF] Make sure the gray line is hidden when appears

View was being hidden on prepare to reuse only, causing it to be shown
the first time the cell was used.

Bug:  845472 , 911148
Change-Id: Ic59d5de5f476c7e499d40a244ef1291e4ccd3bfa
Reviewed-on: https://chromium-review.googlesource.com/c/1358447
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613128}
[modify] https://crrev.com/02ec4e9cfb45e7781692e6dff2941875cc4d913b/ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm

Comment 104 by bugdroid1@chromium.org, Dec 3

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30956fc7738fbebc7792e115520b5f58b719f752

commit 30956fc7738fbebc7792e115520b5f58b719f752
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Mon Dec 03 18:34:45 2018

[iOS][MF] Enable pull to reset

Similar to pull to refresh, pulling the suggestions to the right will
reset the keyboard and the manual fallback view.

Video: https://drive.google.com/file/d/1QpoiU3YPXdFhLQ_ubzZcyJ7VxVo86Zpv/view?usp=sharing

Bug:  845472 , 911142
Change-Id: Ie13322d168dac81288d95a8e10a0bcb5bab59339
Reviewed-on: https://chromium-review.googlesource.com/c/1355188
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613169}
[modify] https://crrev.com/30956fc7738fbebc7792e115520b5f58b719f752/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
[modify] https://crrev.com/30956fc7738fbebc7792e115520b5f58b719f752/ios/chrome/browser/autofill/form_suggestion_view.h
[modify] https://crrev.com/30956fc7738fbebc7792e115520b5f58b719f752/ios/chrome/browser/autofill/form_suggestion_view.mm
[modify] https://crrev.com/30956fc7738fbebc7792e115520b5f58b719f752/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
[modify] https://crrev.com/30956fc7738fbebc7792e115520b5f58b719f752/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.h
[modify] https://crrev.com/30956fc7738fbebc7792e115520b5f58b719f752/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
[modify] https://crrev.com/30956fc7738fbebc7792e115520b5f58b719f752/tools/metrics/actions/actions.xml

Comment 105 by javierrobles@chromium.org, Dec 4

Status: Fixed (was: Assigned)

Comment 106 by bugdroid1@chromium.org, Dec 5

Project Member
Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2df866fbe1b265c4bcbcd5a7754c6c2f76c50ea7

commit 2df866fbe1b265c4bcbcd5a7754c6c2f76c50ea7
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Wed Dec 05 13:36:46 2018

[iOS][MF] Fix content instets on rotation

Bug:  845472 
Change-Id: I3afc1e03c280c88cce039ac8d4a6b288edd7be78
Reviewed-on: https://chromium-review.googlesource.com/c/1355173
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612608}(cherry picked from commit 39cf762f8d2d380ab767ec6c1f0842569587eceb)
Reviewed-on: https://chromium-review.googlesource.com/c/1363176
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#72}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/2df866fbe1b265c4bcbcd5a7754c6c2f76c50ea7/ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm

Comment 107 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe7fa78d65c6f799e64c0c8f635a2d53e1638eea

commit fe7fa78d65c6f799e64c0c8f635a2d53e1638eea
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Wed Dec 05 13:37:05 2018

[iOS][MF] Fix constraints on password cell

Clears the vertical constraints for reuse.
Removes extra vertical constraints from separator.

Bug: 878388,  845472 
Change-Id: I5ba9efdacd2ac642361069b241a9e53956edc215
Reviewed-on: https://chromium-review.googlesource.com/c/1355137
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612609}(cherry picked from commit 3f9e02a91564e3bd3a7a026e5982697cacefa886)
Reviewed-on: https://chromium-review.googlesource.com/c/1363272
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#73}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/fe7fa78d65c6f799e64c0c8f635a2d53e1638eea/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_password_cell.mm

Comment 108 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaa6ec0690ff6a57bd75a07a2115467e6f88da17

commit aaa6ec0690ff6a57bd75a07a2115467e6f88da17
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Wed Dec 05 13:37:14 2018

[iOS][MF] Fix cell with extra constraint

Bug:  845472 
Change-Id: Ibdcc5ead0e06decf0fc27914bea6801120cc77a9
Reviewed-on: https://chromium-review.googlesource.com/c/1356980
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612656}(cherry picked from commit e11b6aecfc7a328da8d2be63d29943da57ce666f)
Reviewed-on: https://chromium-review.googlesource.com/c/1363195
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#74}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/aaa6ec0690ff6a57bd75a07a2115467e6f88da17/ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm

Comment 109 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/077c0120234d55efa4e31c8590965c49b622cbeb

commit 077c0120234d55efa4e31c8590965c49b622cbeb
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Wed Dec 05 13:41:06 2018

[iOS][MF] Make sure the gray line is hidden when appears

View was being hidden on prepare to reuse only, causing it to be shown
the first time the cell was used.

Bug:  845472 , 911148
Change-Id: Ic59d5de5f476c7e499d40a244ef1291e4ccd3bfa
Reviewed-on: https://chromium-review.googlesource.com/c/1358447
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613128}(cherry picked from commit 02ec4e9cfb45e7781692e6dff2941875cc4d913b)
Reviewed-on: https://chromium-review.googlesource.com/c/1363273
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#76}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/077c0120234d55efa4e31c8590965c49b622cbeb/ios/chrome/browser/ui/autofill/manual_fill/action_cell.mm

Comment 110 by bugdroid1@chromium.org, Dec 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69e568c3119cd06b345f9118268dfc45032d9d98

commit 69e568c3119cd06b345f9118268dfc45032d9d98
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Wed Dec 05 13:42:55 2018

[iOS][MF] Enable pull to reset

Similar to pull to refresh, pulling the suggestions to the right will
reset the keyboard and the manual fallback view.

Video: https://drive.google.com/file/d/1QpoiU3YPXdFhLQ_ubzZcyJ7VxVo86Zpv/view?usp=sharing

Bug:  845472 , 911142
Change-Id: Ie13322d168dac81288d95a8e10a0bcb5bab59339
Reviewed-on: https://chromium-review.googlesource.com/c/1355188
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613169}(cherry picked from commit 30956fc7738fbebc7792e115520b5f58b719f752)
Reviewed-on: https://chromium-review.googlesource.com/c/1363197
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#77}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/69e568c3119cd06b345f9118268dfc45032d9d98/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
[modify] https://crrev.com/69e568c3119cd06b345f9118268dfc45032d9d98/ios/chrome/browser/autofill/form_suggestion_view.h
[modify] https://crrev.com/69e568c3119cd06b345f9118268dfc45032d9d98/ios/chrome/browser/autofill/form_suggestion_view.mm
[modify] https://crrev.com/69e568c3119cd06b345f9118268dfc45032d9d98/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
[modify] https://crrev.com/69e568c3119cd06b345f9118268dfc45032d9d98/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.h
[modify] https://crrev.com/69e568c3119cd06b345f9118268dfc45032d9d98/ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
[modify] https://crrev.com/69e568c3119cd06b345f9118268dfc45032d9d98/tools/metrics/actions/actions.xml

Comment 111 by javierrobles@chromium.org, Dec 5

Blockedon: 912085

Comment 112 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e7f3e89661f3f89fb5c41f2cca29cbd02f50453

commit 9e7f3e89661f3f89fb5c41f2cca29cbd02f50453
Author: David Jean <djean@google.com>
Date: Fri Dec 07 12:53:07 2018

Reland "Reland "[ios] add credit card test for manual fallback""

This is a reland of 965f2dd775e784aa146f1905cf1013f84a6ab512

Original change's description:
> Reland "[ios] add credit card test for manual fallback"
> 
> This is a reland of 30e1dd180408413c8fce6dbe5b856c048a8ca908
> 
> Adding feature flags to slimnav.
> Revert bug: https://bugs.chromium.org/p/chromium/issues/detail?id=908970
> 
> Original change's description:
> > [ios] add credit card test for manual fallback
> >
> > Also adds AutofillManualFallbackPhaseTwo to test bots.
> >
> > Bug:  845472 
> > Change-Id: I6bd05781c09c24c0768e24acfe59efa7ce1da05d
> > Reviewed-on: https://chromium-review.googlesource.com/c/1337347
> > Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> > Reviewed-by: Ben Pastene <bpastene@chromium.org>
> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> > Commit-Queue: David Jean <djean@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#611171}
> 
> TBR=rohitrao@chromium.org
> 
> Bug:  845472 , 908970 
> Change-Id: I2cc0cddf0be8cea447f45f69457afbe19c840f29
> Reviewed-on: https://chromium-review.googlesource.com/c/1352328
> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611679}

Bug:  845472 ,  908970 
Change-Id: Ia84d71d73733d5c326443c3441e3127b700e73ef
Reviewed-on: https://chromium-review.googlesource.com/c/1356718
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614677}
[modify] https://crrev.com/9e7f3e89661f3f89fb5c41f2cca29cbd02f50453/ios/build/bots/chromium.mac/ios-slimnav.json
[modify] https://crrev.com/9e7f3e89661f3f89fb5c41f2cca29cbd02f50453/ios/build/bots/tests/eg_tests.json
[modify] https://crrev.com/9e7f3e89661f3f89fb5c41f2cca29cbd02f50453/ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
[modify] https://crrev.com/9e7f3e89661f3f89fb5c41f2cca29cbd02f50453/ios/chrome/browser/ui/autofill/manual_fill/card_mediator.h
[add] https://crrev.com/9e7f3e89661f3f89fb5c41f2cca29cbd02f50453/ios/chrome/browser/ui/autofill/manual_fill/card_view_controller_egtest.mm
[modify] https://crrev.com/9e7f3e89661f3f89fb5c41f2cca29cbd02f50453/testing/buildbot/gn_isolate_map.pyl

Comment 113 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Project Member
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/077c0120234d55efa4e31c8590965c49b622cbeb

Commit: 077c0120234d55efa4e31c8590965c49b622cbeb
Author: javierrobles@chromium.org
Commiter: javierrobles@chromium.org
Date: 2018-12-05 13:41:06 +0000 UTC

[iOS][MF] Make sure the gray line is hidden when appears

View was being hidden on prepare to reuse only, causing it to be shown
the first time the cell was used.

Bug:  845472 , 911148
Change-Id: Ic59d5de5f476c7e499d40a244ef1291e4ccd3bfa
Reviewed-on: https://chromium-review.googlesource.com/c/1358447
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613128}(cherry picked from commit 02ec4e9cfb45e7781692e6dff2941875cc4d913b)
Reviewed-on: https://chromium-review.googlesource.com/c/1363273
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#76}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Comment 114 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Project Member
Labels: CommitLog-Audit-Violation Merge-Without-Approval M-72
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 2df866fbe1b265c4bcbcd5a7754c6c2f76c50ea7 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required --

Comment 115 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Project Member
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/2df866fbe1b265c4bcbcd5a7754c6c2f76c50ea7

Commit: 2df866fbe1b265c4bcbcd5a7754c6c2f76c50ea7
Author: javierrobles@chromium.org
Commiter: javierrobles@chromium.org
Date: 2018-12-05 13:36:46 +0000 UTC

[iOS][MF] Fix content instets on rotation

Bug:  845472 
Change-Id: I3afc1e03c280c88cce039ac8d4a6b288edd7be78
Reviewed-on: https://chromium-review.googlesource.com/c/1355173
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612608}(cherry picked from commit 39cf762f8d2d380ab767ec6c1f0842569587eceb)
Reviewed-on: https://chromium-review.googlesource.com/c/1363176
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#72}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Comment 116 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Project Member
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/69e568c3119cd06b345f9118268dfc45032d9d98

Commit: 69e568c3119cd06b345f9118268dfc45032d9d98
Author: javierrobles@chromium.org
Commiter: javierrobles@chromium.org
Date: 2018-12-05 13:42:55 +0000 UTC

[iOS][MF] Enable pull to reset

Similar to pull to refresh, pulling the suggestions to the right will
reset the keyboard and the manual fallback view.

Video: https://drive.google.com/file/d/1QpoiU3YPXdFhLQ_ubzZcyJ7VxVo86Zpv/view?usp=sharing

Bug:  845472 , 911142
Change-Id: Ie13322d168dac81288d95a8e10a0bcb5bab59339
Reviewed-on: https://chromium-review.googlesource.com/c/1355188
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613169}(cherry picked from commit 30956fc7738fbebc7792e115520b5f58b719f752)
Reviewed-on: https://chromium-review.googlesource.com/c/1363197
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#77}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Comment 117 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Project Member
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision aaa6ec0690ff6a57bd75a07a2115467e6f88da17 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required --

Comment 118 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Project Member
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/aaa6ec0690ff6a57bd75a07a2115467e6f88da17

Commit: aaa6ec0690ff6a57bd75a07a2115467e6f88da17
Author: javierrobles@chromium.org
Commiter: javierrobles@chromium.org
Date: 2018-12-05 13:37:14 +0000 UTC

[iOS][MF] Fix cell with extra constraint

Bug:  845472 
Change-Id: Ibdcc5ead0e06decf0fc27914bea6801120cc77a9
Reviewed-on: https://chromium-review.googlesource.com/c/1356980
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612656}(cherry picked from commit e11b6aecfc7a328da8d2be63d29943da57ce666f)
Reviewed-on: https://chromium-review.googlesource.com/c/1363195
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#74}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Comment 119 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Project Member
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision fe7fa78d65c6f799e64c0c8f635a2d53e1638eea was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required --

Comment 120 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Project Member
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/fe7fa78d65c6f799e64c0c8f635a2d53e1638eea

Commit: fe7fa78d65c6f799e64c0c8f635a2d53e1638eea
Author: javierrobles@chromium.org
Commiter: javierrobles@chromium.org
Date: 2018-12-05 13:37:05 +0000 UTC

[iOS][MF] Fix constraints on password cell

Clears the vertical constraints for reuse.
Removes extra vertical constraints from separator.

Bug: 878388,  845472 
Change-Id: I5ba9efdacd2ac642361069b241a9e53956edc215
Reviewed-on: https://chromium-review.googlesource.com/c/1355137
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612609}(cherry picked from commit 3f9e02a91564e3bd3a7a026e5982697cacefa886)
Reviewed-on: https://chromium-review.googlesource.com/c/1363272
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#73}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
Showing comments 21 - 120 of 120 Older

Sign in to add a comment