New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845467 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove redundant filters from Chrome UI Catalog Viewer's UI

Project Member Reported by aber...@chromium.org, May 22 2018

Issue description

At present the Chrome UI Catalog Viewer's UI shows, and lets the user select values for, all the filters listed in the screenshots, even if all the screenshots use the same filter value. Filters with only a single value should either be hidden, or simply shown as text. There should not be a menu for selecting the values of such filters.
 
Owner: aber...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4efeecdbec0305a3ef504c00d0262a0a82c004aa

commit 4efeecdbec0305a3ef504c00d0262a0a82c004aa
Author: Anthony Berent <aberent@chromium.org>
Date: Wed May 30 16:53:06 2018

Don't show redundant filter values in UI Catalog

If all screenshots in the current set have the same filter value
then just show that value in the filter menu. In particular don't
show the 'Any' option.

BUG= 845467 

Change-Id: Icdca0917a8adefd6df531700d5c3ac8c701c1809
Reviewed-on: https://chromium-review.googlesource.com/1076430
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/4efeecdbec0305a3ef504c00d0262a0a82c004aa/appengine/ui_catalogue/src/cuic-shot-selector.js

Status: Fixed (was: Started)

Sign in to add a comment