[macviews] navigating menus with keyboard doesn't work right |
|||||||||||
Issue descriptionWhat steps will reproduce the problem? 1. ctrl-click omnibox 2. press 'p' (3. continue writing 'aste a') What is the expected result? 'paste' gets highlighted. (after 3, 'paste and search' gets highlighted) What happens instead of that? After 2, 'paste and search' gets highlighted _and executed_. Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.106 Safari/537.36
,
May 25 2018
,
May 25 2018
Triage: Assigning to ellyjones@ for menus.
,
May 29 2018
,
Jun 22 2018
,
Jul 2
,
Jul 12
,
Jul 12
,
Aug 2
MacViews triage: punting to M70 - context menus are now Cocoa. Other menus do need to support prefix search, though.
,
Aug 2
,
Aug 23
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3c431a27cb8043f057e4bfd167808230d0bb4d1 commit c3c431a27cb8043f057e4bfd167808230d0bb4d1 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Aug 28 15:30:41 2018 views: support menu prefix searching Combobox menus support this already, but on Mac all menus should support it instead of Windows/Linux-style mnemonics for items. This change: 1) Adds a new MenuConfig knob for whether the platform behaves this way; 2) Adds PrefixSelector::WillContinueSelection() to expose whether the PrefixSelector search is still "live" (versus having timed out); 3) Adds logic to MenuController to only activate items on VKEY_SPACE when the PrefixSelector is not still accumulating a prefix search; 4) Changes SubmenuView::GetTextForRow() to use the accessible name for the row instead of the raw title. Not doing this causes prefix searches to fail because the raw title includes mnemonic-marking ampersands; 5) Disables MenuRunnerTest.{,Non}LatinMnemonic on Mac; 6) Adds MenuRunnerTest.PrefixSelect to test most of this behavior on Mac. Bug: 845466 Change-Id: I5d1e2c940026560d1e542263d99911889f52c742 Reviewed-on: https://chromium-review.googlesource.com/1187062 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#586716} [modify] https://crrev.com/c3c431a27cb8043f057e4bfd167808230d0bb4d1/chrome/browser/ui/views/menu_controller_interactive_uitest.cc [modify] https://crrev.com/c3c431a27cb8043f057e4bfd167808230d0bb4d1/ui/views/controls/menu/menu_config.cc [modify] https://crrev.com/c3c431a27cb8043f057e4bfd167808230d0bb4d1/ui/views/controls/menu/menu_config.h [modify] https://crrev.com/c3c431a27cb8043f057e4bfd167808230d0bb4d1/ui/views/controls/menu/menu_config_mac.mm [modify] https://crrev.com/c3c431a27cb8043f057e4bfd167808230d0bb4d1/ui/views/controls/menu/menu_controller.cc [modify] https://crrev.com/c3c431a27cb8043f057e4bfd167808230d0bb4d1/ui/views/controls/menu/menu_controller.h [modify] https://crrev.com/c3c431a27cb8043f057e4bfd167808230d0bb4d1/ui/views/controls/menu/menu_runner_unittest.cc [modify] https://crrev.com/c3c431a27cb8043f057e4bfd167808230d0bb4d1/ui/views/controls/menu/submenu_view.cc [modify] https://crrev.com/c3c431a27cb8043f057e4bfd167808230d0bb4d1/ui/views/controls/prefix_selector.cc [modify] https://crrev.com/c3c431a27cb8043f057e4bfd167808230d0bb4d1/ui/views/controls/prefix_selector.h
,
Aug 28
,
Sep 17
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by meh...@chromium.org
, May 22 2018