[MacViews] Web content context menu doesn't take keyboard input |
|||||||||||
Issue descriptionWhat steps will reproduce the problem? 1. Click omnibox 2. ctrl-click web area to open context menu, keep it open 3. arrow up/down What is the expected result? The selection in the context menu moves up and down. What happens instead of that? The selection in the omnibox moves up and down. Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.106 Safari/537.36
,
May 22 2018
,
May 22 2018
,
May 22 2018
Adjusted description.
,
May 25 2018
,
May 25 2018
,
May 25 2018
Tested the issue on chrome version# 68.0.3438.0 using Mac 10.12.6 with steps mentioned below: 1) Launched chrome version, navigated to chrome:/flags and enabled #views-browser-windows flag 2) clicked on omnibox, able to see focus on omnibox 3) Ctrl+Click on web area, context menu opened, used arrow up/down, observed web page moves up and down @Reporter: Please find the attached screencast for your reference and let us know if you are also observing the same issue which i have captured in the screencast, provide your feedback on it which help in further triaging it. Thanks!
,
May 29 2018
I can do this without focusing the omnibox — the up and down arrows scroll the web content with a context menu open. Over to ellyjones@ for triage/assignment.
,
May 30 2018
,
May 31 2018
I'll take it https://chromium-review.googlesource.com/c/chromium/src/+/1080427
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37806cbab68a9100c6e2c5ce99a010f34c533816 commit 37806cbab68a9100c6e2c5ce99a010f34c533816 Author: Trent Apted <tapted@chromium.org> Date: Fri Jun 01 03:10:04 2018 Give MacViews renderer context menus an owner. Menus need an owner to share key handling and for other reasons. Make them owned in the same way as on other platforms. TEST=With chrome://flags/#views-browser-windows on Mac, right-click on WebContents, then press arrow-keys. Menu highlight should move up/down. Bug: 845463 Change-Id: Ie3b578db1c2427b7e3367784f8a476b13c9104ed Reviewed-on: https://chromium-review.googlesource.com/1080427 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#563512} [modify] https://crrev.com/37806cbab68a9100c6e2c5ce99a010f34c533816/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_views.mm
,
Jun 1 2018
,
Jun 4 2018
Able to reproduce the issue on chrome reported version 69.0.3447.0(build without fix) Verified the fix on Mac 10.12.6 on Chrome version# 69.0.3449.0 as per the comment#0 Attaching screen cast for reference. Observed "The selection in the context menu moves up and down" Hence, the fix is working as expected. Adding the verified label. Thanks!
,
Jun 4 2018
Nice! Filed issue 849298 as follow-up for arrow-up not doing the right thing now that it does something. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by thakis@chromium.org
, May 22 2018