Regression: Grey Focus highlight on navigation arrow button appears darker and is not uniform like other icons present on toolbar
Reported by
khushal....@etouch.net,
May 22 2018
|
|||||||||
Issue descriptionChrome Version: 68.0.3437.2 (Official Build) Revision 59dae9de14a34f5f1cd861acdb3a304530915560-refs/branch-heads/3437@{#4} (32/64-bit) OS: Win (7, 8, 8.1, 10) & Linux (14.04 LTS) Steps to reproduce: 1. Launch chrome, navigate to any link so as to enable 'Back' and 'Forward' navigation arrow button. 2. Now observe the grey focus highlight on 'Back' & 'Forward' navigation arrow button. Actual Result: Grey Focus highlight on 'Back' & 'Forward' navigation arrow button appears darker than expected and is not uniform like other icons present on toolbar. Expected Result: Grey Focus highlight on 'Back' & 'Forward' navigation arrow button should be seen properly and uniform like other icons present on toolbar. This is Regression issue broken in 'M-67’ and providing the bisect info below: Good Build: 67.0.3366.0 (Revision: 541889) Bad Build: 67.0.3367.0 (Revision: 542330) Narrow bisect URL: https://chromium.googlesource.com/chromium/src/+log/87b4b6996f8d730e95e780bff56b8bc31a6d80ba..6d048fe52bcd40611c86e146bf3fd3875d1d3a79?pretty=fuller&n=10000 Suspect: https://chromium.googlesource.com/chromium/src/+/6d048fe52bcd40611c86e146bf3fd3875d1d3a79 @afakhry: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 2) Issue is also seen on M-67 Beta (build #67.0.3396.48) & M-68 Dev (build #68.0.3432.3). 1) Issue is not seen on Mac OS (10.12.6, 10.13.1, 10.13.5). Kindly refer attached screen-cast and screenshot. Thank You..!!
,
May 22 2018
This is also seen on ChromeOS.
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f448fd4ed19a01120a82166ba3f59190ceb9635a commit f448fd4ed19a01120a82166ba3f59190ceb9635a Author: Ahmed Fakhry <afakhry@google.com> Date: Wed May 23 18:42:45 2018 Fix inconsistent ink drop base colors for the toolbar buttons The reload button, the browser actions buttons, and the menu button used to have a slightly different ink drop base color than those of the other toolbar buttons such as the back, forward, and home buttons. This CL unifies the base ink drop colors for all these buttons. BUG= 845442 Change-Id: I46137e3a5a78a0cc1cb6772989ac6cd03bd2ce1f Reviewed-on: https://chromium-review.googlesource.com/1069452 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#561178} [modify] https://crrev.com/f448fd4ed19a01120a82166ba3f59190ceb9635a/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/f448fd4ed19a01120a82166ba3f59190ceb9635a/chrome/browser/ui/views/frame/app_menu_button.cc [modify] https://crrev.com/f448fd4ed19a01120a82166ba3f59190ceb9635a/chrome/browser/ui/views/frame/app_menu_button.h [modify] https://crrev.com/f448fd4ed19a01120a82166ba3f59190ceb9635a/chrome/browser/ui/views/frame/hosted_app_menu_button.cc [modify] https://crrev.com/f448fd4ed19a01120a82166ba3f59190ceb9635a/chrome/browser/ui/views/toolbar/reload_button.cc [modify] https://crrev.com/f448fd4ed19a01120a82166ba3f59190ceb9635a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc [modify] https://crrev.com/f448fd4ed19a01120a82166ba3f59190ceb9635a/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/f448fd4ed19a01120a82166ba3f59190ceb9635a/chrome/browser/ui/views/toolbar/toolbar_button.h [add] https://crrev.com/f448fd4ed19a01120a82166ba3f59190ceb9635a/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.cc [modify] https://crrev.com/f448fd4ed19a01120a82166ba3f59190ceb9635a/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h [modify] https://crrev.com/f448fd4ed19a01120a82166ba3f59190ceb9635a/chrome/browser/ui/views/toolbar/toolbar_view.cc
,
May 23 2018
Should we merge this?
,
May 24 2018
Update : Rechecked the above issue on Windows (7, 8, 8.1, 10) and Linux (14.04 LTS) OS with latest Canary build version 68.0.3439.0 and the issue is fixed.Kindly refer the attached screen cast for reference.
,
May 24 2018
,
May 29 2018
,
May 29 2018
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 29 2018
Fro Desktop (Win, Mac & Linux) we already promoted 67.0.3396.62 to stable this morning, currently this is rolling out at small percentage users. How critical is this merge for M67? If it is critical, why "Release-Block-Stable" label wasn't applied?
,
May 29 2018
It's not a critical fix. It fixes a minor visual discrepancy.
,
May 29 2018
Thank you afakhry@. Rejecting merge to M67 per comment #10. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by afakhry@chromium.org
, May 22 2018