New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845436 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Border frame is seen missing for omnibox in Candy and Cyan devices

Project Member Reported by mmanchala@chromium.org, May 22 2018

Issue description

Chrome Version: 68.0.3436.0/10703.0.0 dev-channel Candy
OS: Chrome

What steps will reproduce the problem?
(1)Sign into user -> open New tab in browser -> observe Omnibox i.e. border frame is seen missing
(Please refer Video and Screenshot)

Expected:  Border frame should be seen for omnibox
Actual: Instead  border frame is seen missing

This is Regression Issue as same is working fine in 68.0.3431/10682.0.0 dev-channel Candy

Note : 
1.Unable to repro on Peppy,Reks, Daisy and Jerry as omnibox UI is seen changed in Cyan and Candy from M-68
2.Issue is also seen on Cyan Device
 
Actual_Omnibox.mp4
9.7 MB View Download
Actual_Omnibox.jpg
161 KB View Download
Expected_Omnibox.jpg
168 KB View Download
Expected_Omnibox.webm
1.1 MB View Download
Labels: ReleaseBlock-Stable
Adding Stable blocker as this is a recent Regression, please remove if not required 
Labels: zine-triaged

Comment 3 by skare@chromium.org, May 29 2018

Labels: Needs-Feedback
Owner: mmanchala@chromium.org
Status: Assigned (was: Untriaged)
hi mmanchala@, 

There is a new UI spec for Omnibox where unfocused will have a gray background and focused will have a white background - so I think the actual/expected values in this bug are perhaps backwards?

recent Windows Canary 69.0.3444.0 matches the "actual" video here - that is, when the omnibox is focused, the background is white, which is expected.

Of course, this means the "expected" video is not correct. Do you see this behavior on new versions of CrOS, regardless of device? 

If everything now matches the new behavior (focused omnibox ==> white background), then the bug can be closed.

Thank you!
Labels: -Needs-Feedback
Owner: skare@chromium.org
C#3>>

In Non Touch devices(Kip,Daisy,Reks...) when the omnibox is focused, the background is white but there is frame to separate the Bookmark bar and header part whereas in Touch devices(Cyan and Candy) when the omnibox is focused, no frame is seen and it feels like omnibox is missing. At least frame should be seen to know the presence of omnibox.

Attaching Screenshots for reference

Thanks..!!

OmniboxInTouchDevice.jpg
108 KB View Download
OmniboxNonTouchDevice.jpg
138 KB View Download

Comment 5 by skare@chromium.org, Jun 5 2018

This may be that different devices are on different versions and it's changing fairly quickly?

Last week I saw Windows canary did not have a frame, and now it does on my machine.

Will check on what versions are active on what devices and reassign if needed. thanks!
Cc: skare@chromium.org
Labels: Needs-Feedback
Owner: mmanchala@chromium.org
Status: Unconfirmed (was: Assigned)
mmanchala@, does this repro? I think the UI code has settled now. 
Labels: -Needs-Feedback
C#6>>

Issue is working fine on latest M-69 69.0.3491.0/10881.0.0 dev-channel Candy device

Thanks..!!
Owner: skare@chromium.org
Status: Assigned (was: Unconfirmed)
Status: Fixed (was: Assigned)
Marking as fixed, per comment #7.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.
Project Member

Comment 11 by sheriffbot@chromium.org, Aug 31

Labels: -Merge-TBD

Sign in to add a comment