New issue
Advanced search Search tips

Issue 845431 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:Text field Height appears small in size in send feedback dialogue.

Reported by shruti.j...@etouch.net, May 22 2018

Issue description

Chrome Version:68.0.3437.2 (Official Build) Revision	59dae9de14a34f5f1cd861acdb3a304530915560-refs/branch-heads/3437@{#4}(64-bit)
OS:Mac (10.12.6, 10.13.1)

Steps to reproduce:
1. Launch chrome and navigate to youtube.com
2. Play any video and right click on video.
3. Select 'Troubleshoot Playback Issue' and observe Send Feedback page.

Actual Result :Text field Height appears small in size in send feedback dialogue.
Expected Result :Text field Height should be big enough so that user can describe his issue properly.

This is regression issue broken in ‘M-68’ and providing per-revision bisect info below
Good Build:68.0.3434.0(Revision:560130)  
Bad Build:68.0.3435.0(Revision:559776)
 
You are probably looking for a change made after 560003 (known good), but no later than 560004 (first known bad).
CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/922bfa991327cf2dac756094b9caebdae4715f3c..aa9c26bad48e9fd8e861f1e4494672a5aa162ce2

Suspecting:https://chromium.googlesource.com/chromium/src/+/aa9c26bad48e9fd8e861f1e4494672a5aa162ce2

@Morten Stenshorne: Could you please help to reassign if your change is not the cause for this change.

Note:
1.When enter key is pressed in issue description field, written context shifts upwards which is not visible.
2.Issue is seen for MAC Mini devices only.(Resolution:1366x768)

Kindly review the attached screen-cast .

Thank You!

 
Actual_Result.mov
3.4 MB View Download
Expected_Result.mov
4.2 MB View Download
I can reproduce this on Linux too, but the browser window needs to be rather short, or a different style sheet is picked and everything looks nice.

It's introduced by the suspected CL.

Attaching demo based on what I saw in devtools. Not a clean testcase.
demo.html
912 bytes View Download
Minimal test case attached. This is the regression. Renders fine in Firefox.
tc-quirks.html
343 bytes View Download
Cc: cbiesin...@chromium.org
This is where it gets interesting! Attaching a strict mode version of the test, which also fails, but this is not caused by the offending CL.

It looks like our quirks mode special behavior for percent height flex items hid an old bug in the flexbox implementation, that only used to affect strict mode. Now it affects both modes.

I think we need to revert the offending CL, fix this bug (so that the test passes in both strict and quirks mode), then reland the CL.
tc-strict.html
320 bytes View Download
Blocking: 531783
Blocking: 841276
Cc: mstensho@chromium.org
Components: -Blink>Media Blink>Layout>Flexbox
Owner: ----
Status: Available (was: Assigned)
Offending CL reverted: https://chromium-review.googlesource.com/1068868
Can reland once THIS bug is fixed.
Labels: -Pri-1 Pri-2
Blocking: -841276 -531783
Cc: -mstensho@chromium.org
Owner: mstensho@chromium.org
Status: Fixed (was: Available)
Closing this, to avoid confusion. The regression has been fixed by reverting the offending CL.

For the underlying bug that needs to be fixed before attempting to reland, see  bug 847152 .
Issue 846249 has been merged into this issue.

Sign in to add a comment