New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845411 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression

Blocked on:
issue 840988
issue 844897

Blocking:
issue 845438
issue 845763



Sign in to add a comment

"gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance_glsl_constructors_glsl_construct_mat3" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 22 2018

Issue description

"gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance_glsl_constructors_glsl_construct_mat3" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNymwELEgVGbGFrZSKPAWdwdV90ZXN0cy53ZWJnbF9jb25mb3JtYW5jZV9pbnRlZ3JhdGlvbl90ZXN0LldlYkdMQ29uZm9ybWFuY2VJbnRlZ3JhdGlvblRlc3QuV2ViZ2xDb25mb3JtYW5jZV9jb25mb3JtYW5jZV9nbHNsX2NvbnN0cnVjdG9yc19nbHNsX2NvbnN0cnVjdF9tYXQzDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Components: Blink>WebGL
Owner: kbr@chromium.org
Status: Assigned (was: Untriaged)
kbr, please bounce to whoever is an appropriate owner on the webgl/gpu/etc side
Labels: -Sheriff-Chromium
Labels: Hotlist-PixelWrangler OS-Android
Owner: enne@chromium.org
->enne as pixel wrangler (probably needs a Flaky suppression)

This is a flaky timeout, but this test should run quickly.

[28/156] gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance_glsl_constructors_glsl_construct_mat3 failed unexpectedly 321.5712s:
  
  Traceback (most recent call last):
    _RunGpuTest at content/test/gpu/gpu_tests/gpu_integration_test.py:132
      self.RunActualGpuTest(url, *args)
    RunActualGpuTest at content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:185
      getattr(self, test_name)(test_path, *args[1:])
    _RunConformanceTest at content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:199
      self._CheckTestCompletion()
    _CheckTestCompletion at content/test/gpu/gpu_tests/webgl_conformance_integration_test.py:193
      'webglTestHarness._finished', timeout=self._GetTestTimeout())
    traced_function at third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
      return func(*args, **kwargs)
    WaitForJavaScriptCondition at third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py:261
      return self._tab.WaitForJavaScriptCondition(*args, **kwargs)
    traced_function at third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
      return func(*args, **kwargs)
    WaitForJavaScriptCondition at third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py:239
      return self._inspector_backend.WaitForJavaScriptCondition(*args, **kwargs)
    traced_function at third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
      return func(*args, **kwargs)
    WaitForJavaScriptCondition at third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py:302
      e.message + '\n' + debug_message)
  TimeoutException: Timed out while waiting 300s for IsJavaScriptExpressionTrue.
  Console output:
  
  Locals:
    IsJavaScriptExpressionTrue : <function IsJavaScriptExpressionTrue at 0x7f80f9444b18>
    condition                  : 'webglTestHarness._finished'
    context_id                 : None
    debug_message              : 'Console output:\n'
    e                          : TimeoutException('Timed out while waiting 300s for IsJavaScriptExpressionTrue.',)
    kwargs                     : {}
    timeout                    : 300
  
  No minidump paths to symbolize
  Restarting browser due to unexpected test failure

Comment 5 by kbr@chromium.org, May 22 2018

Blockedon: 840988
Cc: st...@chromium.org lucferron@chromium.org
Labels: -Type-Bug Type-Bug-Regression
enne, as pixel wrangler can you try to find a regression range for these flakes? It looks like they're happening with a fairly high frequency on android_n5x_swarming_rel, though unfortunately it looks like it's not happening as often on the waterfall bots:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20FYI%20Release%20%28Nexus%205X%29?limit=200

https://ci.chromium.org/buildbot/chromium.gpu/Android%20Release%20%28Nexus%205X%29/?limit=200

Basically: I'd go back to the tryjob revision of the first failure on android_n5x_swarming_rel, and create a blamelist with a 12 hour window. Then let's go through it and try to find a culprit.

Here are a couple of failures:

https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/427019
https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/427414

and Swarming tasks:

https://chromium-swarm.appspot.com/task?id=3d9e5c28b1fff210&refresh=10&show_raw=1
https://chromium-swarm.appspot.com/task?id=3da13e7f38f49e10&refresh=10&show_raw=1

The symptom is that the tests are timing out flakily. The last time this sort of thing happened was  Issue 840988  and it was very tricky to diagnose.

+stgao because FindIt would be very helpful for this sort of thing. Wish it was working for the WebGL conformance tests.

Comment 6 by kbr@chromium.org, May 22 2018

Blocking: 845438

Comment 7 by enne@chromium.org, May 22 2018

Sure thing.  Looking into it.

Comment 8 by st...@chromium.org, May 22 2018

Cc: lijeffrey@chromium.org
lijeffrey@: this is a good case to support in your flake analysis. You may want to add it to our user wish list.
Blockedon: 844897
I just reverted a change this weekend that was causing timeouts in  bug 844897 . That one was a viz change.

Comment 10 by enne@chromium.org, May 22 2018

Here's a 12 hour blame list from the first build with a failure that I could find from either of those bots: https://chromium.googlesource.com/chromium/src/+log/3a21271cb39d94f36755c9d6aee42a7ebd9eb41a..de251ef1db042969dca0942a021a779b764a30d?pretty=fuller&n=

Comment 11 by enne@chromium.org, May 22 2018

I don't see anything too obvious here.  These are the most suspicious changes, but nothing stands out.  Am going to keep looking.

Remove WEBGL_compressed_texture_atc
https://chromium-review.googlesource.com/c/chromium/src/+/1067700

Use thresholds based on RAM size for OOM intervention
https://chromium-review.googlesource.com/c/chromium/src/+/1066804

Revert "android: Remove readback_layer"
https://chromium-review.googlesource.com/c/chromium/src/+/1068073

gles2_implementation: un-autogen CopyBufferSubData
https://chromium-review.googlesource.com/c/chromium/src/+/1066744

Roll clang 332335:332838
https://chromium-review.googlesource.com/c/chromium/src/+/1067108
Project Member

Comment 12 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebc94b58f609b461e0799e10797080d4c8add639

commit ebc94b58f609b461e0799e10797080d4c8add639
Author: Jeremy Roman <jbroman@chromium.org>
Date: Tue May 22 20:02:04 2018

Mark two WebGL conformance tests as flaky on Android.

Bug:  845411 , 845438 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I96ea108224def7f2c8fa5e994f5a7c8a79164e58
Reviewed-on: https://chromium-review.googlesource.com/1069329
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560743}
[modify] https://crrev.com/ebc94b58f609b461e0799e10797080d4c8add639/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Comment 13 by kbr@chromium.org, May 22 2018

Cc: ssid@chromium.org
This one:

Use thresholds based on RAM size for OOM intervention
https://chromium-review.googlesource.com/1066804

Sounds the most likely, since the tests started flaking on Android, this is an Android-specific patch, and 

The code review seems weirdly broken (can't see which files were changed) but Gitiles shows the diffs:
https://chromium.googlesource.com/chromium/src/+/0c2124b3c9acf283315fb56beea340d050db0acd

I think we should revert that patch and see whether the tryserver recovers. It sounds like a similar bug to  Issue 840988  and that one seemed innocent, but there is probably some underlying bug in MemoryCoordinator::PurgeMemory or something that it calls.

Comment 14 by ssid@chromium.org, May 22 2018

I think none of the code in the pointed CL would run on the webgl tests, unless finch config was passed. The cl is required for getting metrics from M68, else I would need a merge. Let me try to debug the test and see if there is any related code running.
Project Member

Comment 15 by bugdroid1@chromium.org, May 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50257b9eafc8ec098a9693d4740fd761ace59c35

commit 50257b9eafc8ec098a9693d4740fd761ace59c35
Author: enne <enne@chromium.org>
Date: Tue May 22 20:38:40 2018

Revert "Use thresholds based on RAM size for OOM intervention"

This reverts commit 0c2124b3c9acf283315fb56beea340d050db0acd.

Reason for revert: Speculatively reverting to see if it fixes webgl conformance test timeouts
Bug:  845411 

Original change's description:
> Use thresholds based on RAM size for OOM intervention
> 
> This CL does not change behavior of existing experiment on 512 devices.
> 1. Remove low-end device checks while enabling intervention. This can be
>    filtered in Finch config.
> 2. Set threshold based on percentage of RAM instead of absolute number.
> 3. Disable intervention if device has more than 512MB RAM and threshold
>    was set to absolute number.
> 
> BUG=843419
> 
> 
> Change-Id: Ib40a038d9d2f111a514b3f41ce7f32a3ea3a156d
> Reviewed-on: https://chromium-review.googlesource.com/1066804
> Commit-Queue: Siddhartha S <ssid@chromium.org>
> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560430}

TBR=bashi@chromium.org,ssid@chromium.org

Change-Id: I4b50e522dcc6c91542927a9e769e5eee24f486a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 843419
Reviewed-on: https://chromium-review.googlesource.com/1069567
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560761}
[modify] https://crrev.com/50257b9eafc8ec098a9693d4740fd761ace59c35/chrome/browser/android/oom_intervention/near_oom_monitor.cc
[modify] https://crrev.com/50257b9eafc8ec098a9693d4740fd761ace59c35/chrome/browser/android/oom_intervention/near_oom_monitor.h
[modify] https://crrev.com/50257b9eafc8ec098a9693d4740fd761ace59c35/chrome/browser/android/oom_intervention/near_oom_monitor_unittest.cc
[modify] https://crrev.com/50257b9eafc8ec098a9693d4740fd761ace59c35/chrome/browser/android/oom_intervention/oom_intervention_tab_helper.cc

Comment 16 by enne@chromium.org, May 22 2018

I'll reland the patch later today if it ends up not being the root cause.

Comment 17 by ssid@chromium.org, May 22 2018

But I have to merge since today is branch date

Comment 18 by enne@chromium.org, May 23 2018

This is tentatively looking like the cause.

5428 is the first build from https://ci.chromium.org/buildbot/chromium.gpu/Android%20Release%20%28Nexus%205X%29/ that has this revert.  Three builds since then have been good.

427803 is the first build from https://ci.chromium.org/buildbot/tryserver.chromium.android/android_n5x_swarming_rel/ that has this revert.  Three builds have failed webgl_conformance_tests, but no timeouts and all different/unique failures from this bug.  The other 200 builds are ok (although many don't run webgl_conformance_tests, so hard to say).

Will check back later.

Comment 19 by ssid@chromium.org, May 23 2018

This build failure just happened (after teh revert): https://ci.chromium.org/buildbot/chromium.gpu/Android%20Release%20%28Nexus%205X%29/5433

Comment 20 by kbr@chromium.org, May 23 2018

Blockedon: 845763

Comment 21 by kbr@chromium.org, May 23 2018

ssid@: those failures were infrastructure failures, just filed as Issue 845763.

Project Member

Comment 22 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9191004f57d2bbb925d1d48194036bb1230d0f1f

commit 9191004f57d2bbb925d1d48194036bb1230d0f1f
Author: Siddhartha S <ssid@chromium.org>
Date: Wed May 23 01:45:50 2018

Reland "Use thresholds based on RAM size for OOM intervention"

This reverts commit 50257b9eafc8ec098a9693d4740fd761ace59c35.

Reason for revert: This was not the cause of failure, see
https://crbug.com/845763

Original change's description:
> Revert "Use thresholds based on RAM size for OOM intervention"
> 
> This reverts commit 0c2124b3c9acf283315fb56beea340d050db0acd.
> 
> Reason for revert: Speculatively reverting to see if it fixes webgl conformance test timeouts
> Bug:  845411 
> 
> Original change's description:
> > Use thresholds based on RAM size for OOM intervention
> > 
> > This CL does not change behavior of existing experiment on 512 devices.
> > 1. Remove low-end device checks while enabling intervention. This can be
> >    filtered in Finch config.
> > 2. Set threshold based on percentage of RAM instead of absolute number.
> > 3. Disable intervention if device has more than 512MB RAM and threshold
> >    was set to absolute number.
> > 
> > BUG=843419
> > 
> > 
> > Change-Id: Ib40a038d9d2f111a514b3f41ce7f32a3ea3a156d
> > Reviewed-on: https://chromium-review.googlesource.com/1066804
> > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#560430}
> 
> TBR=bashi@chromium.org,ssid@chromium.org
> 
> Change-Id: I4b50e522dcc6c91542927a9e769e5eee24f486a5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 843419
> Reviewed-on: https://chromium-review.googlesource.com/1069567
> Reviewed-by: enne <enne@chromium.org>
> Commit-Queue: enne <enne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560761}

TBR=bashi@chromium.org,enne@chromium.org,ssid@chromium.org

Change-Id: I4d0a08cd44772dc690ac1d93b1d92b4934ed0373
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  845411 , 843419
Reviewed-on: https://chromium-review.googlesource.com/1069888
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560882}
[modify] https://crrev.com/9191004f57d2bbb925d1d48194036bb1230d0f1f/chrome/browser/android/oom_intervention/near_oom_monitor.cc
[modify] https://crrev.com/9191004f57d2bbb925d1d48194036bb1230d0f1f/chrome/browser/android/oom_intervention/near_oom_monitor.h
[modify] https://crrev.com/9191004f57d2bbb925d1d48194036bb1230d0f1f/chrome/browser/android/oom_intervention/near_oom_monitor_unittest.cc
[modify] https://crrev.com/9191004f57d2bbb925d1d48194036bb1230d0f1f/chrome/browser/android/oom_intervention/oom_intervention_tab_helper.cc

Comment 23 by kbr@chromium.org, May 23 2018

ssid@: the evidence so far is that your CL was, in fact, responsible for the failures. http://crbug.com/845763 is a completely different failure mode than before.

enne@, please continue to watch these bots and if you see a correlation between this reland and failures on android_n5x_chromium_rel, please re-revert.

Project Member

Comment 25 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a21bf6f95c3698b9542d8aa3a4ed081e2771d7fd

commit a21bf6f95c3698b9542d8aa3a4ed081e2771d7fd
Author: Siddhartha S <ssid@chromium.org>
Date: Wed May 23 01:58:51 2018

Revert "Reland "Use thresholds based on RAM size for OOM intervention""

This reverts commit 9191004f57d2bbb925d1d48194036bb1230d0f1f.

Reason for revert: The failure after the revert was a different failure.
Sorry for the reland.

Original change's description:
> Reland "Use thresholds based on RAM size for OOM intervention"
> 
> This reverts commit 50257b9eafc8ec098a9693d4740fd761ace59c35.
> 
> Reason for revert: This was not the cause of failure, see
> https://crbug.com/845763
> 
> Original change's description:
> > Revert "Use thresholds based on RAM size for OOM intervention"
> > 
> > This reverts commit 0c2124b3c9acf283315fb56beea340d050db0acd.
> > 
> > Reason for revert: Speculatively reverting to see if it fixes webgl conformance test timeouts
> > Bug:  845411 
> > 
> > Original change's description:
> > > Use thresholds based on RAM size for OOM intervention
> > > 
> > > This CL does not change behavior of existing experiment on 512 devices.
> > > 1. Remove low-end device checks while enabling intervention. This can be
> > >    filtered in Finch config.
> > > 2. Set threshold based on percentage of RAM instead of absolute number.
> > > 3. Disable intervention if device has more than 512MB RAM and threshold
> > >    was set to absolute number.
> > > 
> > > BUG=843419
> > > 
> > > 
> > > Change-Id: Ib40a038d9d2f111a514b3f41ce7f32a3ea3a156d
> > > Reviewed-on: https://chromium-review.googlesource.com/1066804
> > > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#560430}
> > 
> > TBR=bashi@chromium.org,ssid@chromium.org
> > 
> > Change-Id: I4b50e522dcc6c91542927a9e769e5eee24f486a5
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 843419
> > Reviewed-on: https://chromium-review.googlesource.com/1069567
> > Reviewed-by: enne <enne@chromium.org>
> > Commit-Queue: enne <enne@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#560761}
> 
> TBR=bashi@chromium.org,enne@chromium.org,ssid@chromium.org
> 
> Change-Id: I4d0a08cd44772dc690ac1d93b1d92b4934ed0373
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  845411 , 843419
> Reviewed-on: https://chromium-review.googlesource.com/1069888
> Reviewed-by: Siddhartha S <ssid@chromium.org>
> Commit-Queue: Siddhartha S <ssid@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560882}

TBR=bashi@chromium.org,enne@chromium.org,ssid@chromium.org

Change-Id: Ib8841dddaa2a167e674c997ec1577036df26e8cb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  845411 , 843419
Reviewed-on: https://chromium-review.googlesource.com/1069876
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560889}
[modify] https://crrev.com/a21bf6f95c3698b9542d8aa3a4ed081e2771d7fd/chrome/browser/android/oom_intervention/near_oom_monitor.cc
[modify] https://crrev.com/a21bf6f95c3698b9542d8aa3a4ed081e2771d7fd/chrome/browser/android/oom_intervention/near_oom_monitor.h
[modify] https://crrev.com/a21bf6f95c3698b9542d8aa3a4ed081e2771d7fd/chrome/browser/android/oom_intervention/near_oom_monitor_unittest.cc
[modify] https://crrev.com/a21bf6f95c3698b9542d8aa3a4ed081e2771d7fd/chrome/browser/android/oom_intervention/oom_intervention_tab_helper.cc

Project Member

Comment 26 by chromium...@appspot.gserviceaccount.com, May 23 2018

Labels: Sheriff-Chromium
Detected 14 new flakes for test/step "gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglConformance_conformance_glsl_constructors_glsl_construct_mat3". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNymwELEgVGbGFrZSKPAWdwdV90ZXN0cy53ZWJnbF9jb25mb3JtYW5jZV9pbnRlZ3JhdGlvbl90ZXN0LldlYkdMQ29uZm9ybWFuY2VJbnRlZ3JhdGlvblRlc3QuV2ViZ2xDb25mb3JtYW5jZV9jb25mb3JtYW5jZV9nbHNsX2NvbnN0cnVjdG9yc19nbHNsX2NvbnN0cnVjdF9tYXQzDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 27 by gab@chromium.org, May 23 2018

Blocking: 845926

Comment 28 by enne@chromium.org, May 23 2018

Blocking: -845926

Comment 29 by enne@chromium.org, May 23 2018

Status: Fixed (was: Assigned)
All of those "new" flakes are all based on revisions that included the patch that got reverted (and not the reverts).  None of the builds since the revert have had this same timeout.

So, I think this is fixed and the oom patch was the cause.

Comment 30 by enne@chromium.org, May 23 2018

Cc: enne@chromium.org
 Issue 845438  has been merged into this issue.

Comment 31 by enne@chromium.org, May 23 2018

 Issue 845663  has been merged into this issue.

Comment 32 by kbr@chromium.org, May 26 2018

Enne, *thank you* for tracking down the cause of this flakiness!

Comment 33 by kbr@chromium.org, May 26 2018

Blockedon: -845763
Blocking: 845763
Project Member

Comment 34 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac3d5886352ec97a24347c07bec28870ac3bb8d2

commit ac3d5886352ec97a24347c07bec28870ac3bb8d2
Author: Siddhartha <ssid@chromium.org>
Date: Tue May 29 07:37:14 2018

Reland "Reland "Use thresholds based on RAM size for OOM intervention""

This reverts commit a21bf6f95c3698b9542d8aa3a4ed081e2771d7fd.

Reason for revert: Test field trial config does not support low_end_device flag.
So, make sure the config does not turn on intervention on high end devices
without new param.

Original change's description:
> Revert "Reland "Use thresholds based on RAM size for OOM intervention""
>
> This reverts commit 9191004f57d2bbb925d1d48194036bb1230d0f1f.
>
> Reason for revert: The failure after the revert was a different failure.
> Sorry for the reland.
>
> Original change's description:
> > Reland "Use thresholds based on RAM size for OOM intervention"
> >
> > This reverts commit 50257b9eafc8ec098a9693d4740fd761ace59c35.
> >
> > Reason for revert: This was not the cause of failure, see
> > https://crbug.com/845763
> >
> > Original change's description:
> > > Revert "Use thresholds based on RAM size for OOM intervention"
> > >
> > > This reverts commit 0c2124b3c9acf283315fb56beea340d050db0acd.
> > >
> > > Reason for revert: Speculatively reverting to see if it fixes webgl conformance test timeouts
> > > Bug:  845411 
> > >
> > > Original change's description:
> > > > Use thresholds based on RAM size for OOM intervention
> > > >
> > > > This CL does not change behavior of existing experiment on 512 devices.
> > > > 1. Remove low-end device checks while enabling intervention. This can be
> > > >    filtered in Finch config.
> > > > 2. Set threshold based on percentage of RAM instead of absolute number.
> > > > 3. Disable intervention if device has more than 512MB RAM and threshold
> > > >    was set to absolute number.
> > > >
> > > > BUG=843419
> > > >
> > > >
> > > > Change-Id: Ib40a038d9d2f111a514b3f41ce7f32a3ea3a156d
> > > > Reviewed-on: https://chromium-review.googlesource.com/1066804
> > > > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#560430}
> > >
> > > TBR=bashi@chromium.org,ssid@chromium.org
> > >
> > > Change-Id: I4b50e522dcc6c91542927a9e769e5eee24f486a5
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 843419
> > > Reviewed-on: https://chromium-review.googlesource.com/1069567
> > > Reviewed-by: enne <enne@chromium.org>
> > > Commit-Queue: enne <enne@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#560761}
> >
> > TBR=bashi@chromium.org,enne@chromium.org,ssid@chromium.org
> >
> > Change-Id: I4d0a08cd44772dc690ac1d93b1d92b4934ed0373
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug:  845411 , 843419
> > Reviewed-on: https://chromium-review.googlesource.com/1069888
> > Reviewed-by: Siddhartha S <ssid@chromium.org>
> > Commit-Queue: Siddhartha S <ssid@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#560882}
>
> TBR=bashi@chromium.org,enne@chromium.org,ssid@chromium.org
>
> Change-Id: Ib8841dddaa2a167e674c997ec1577036df26e8cb
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  845411 , 843419
> Reviewed-on: https://chromium-review.googlesource.com/1069876
> Reviewed-by: Siddhartha S <ssid@chromium.org>
> Commit-Queue: Siddhartha S <ssid@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560889}

TBR=enne@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  845411 , 843419
Change-Id: I5c03b1ac806a5f4e0b1516761e3b86c242a3c200
Reviewed-on: https://chromium-review.googlesource.com/1074151
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562362}
[modify] https://crrev.com/ac3d5886352ec97a24347c07bec28870ac3bb8d2/chrome/browser/android/oom_intervention/near_oom_monitor.cc
[modify] https://crrev.com/ac3d5886352ec97a24347c07bec28870ac3bb8d2/chrome/browser/android/oom_intervention/near_oom_monitor.h
[modify] https://crrev.com/ac3d5886352ec97a24347c07bec28870ac3bb8d2/chrome/browser/android/oom_intervention/near_oom_monitor_unittest.cc
[modify] https://crrev.com/ac3d5886352ec97a24347c07bec28870ac3bb8d2/chrome/browser/android/oom_intervention/oom_intervention_tab_helper.cc

Sign in to add a comment