Feature bug: Unified Heap Memory Reporting and Garbage Collection Scheduling
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/db4b7e75985f95cb5698c3d758b8c41bd278a076 commit db4b7e75985f95cb5698c3d758b8c41bd278a076 Author: Rodrigo Bruno <rfbpb@google.com> Date: Thu Jun 07 12:38:34 2018 [heap] Refactoring heap growing strategy from Heap to HeapController class. Bug: chromium:845409 Change-Id: I377d6f9d26a193f7fd829f7b74f9fdabc1337dc0 Reviewed-on: https://chromium-review.googlesource.com/1089053 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53580} [modify] https://crrev.com/db4b7e75985f95cb5698c3d758b8c41bd278a076/BUILD.gn [add] https://crrev.com/db4b7e75985f95cb5698c3d758b8c41bd278a076/src/heap/heap-controller.cc [add] https://crrev.com/db4b7e75985f95cb5698c3d758b8c41bd278a076/src/heap/heap-controller.h [modify] https://crrev.com/db4b7e75985f95cb5698c3d758b8c41bd278a076/src/heap/heap.cc [modify] https://crrev.com/db4b7e75985f95cb5698c3d758b8c41bd278a076/src/heap/heap.h [modify] https://crrev.com/db4b7e75985f95cb5698c3d758b8c41bd278a076/src/heap/spaces.cc [modify] https://crrev.com/db4b7e75985f95cb5698c3d758b8c41bd278a076/test/unittests/BUILD.gn [add] https://crrev.com/db4b7e75985f95cb5698c3d758b8c41bd278a076/test/unittests/heap/heap-controller-unittest.cc [modify] https://crrev.com/db4b7e75985f95cb5698c3d758b8c41bd278a076/test/unittests/heap/heap-unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/502f92160f3883c64cba32e966c163de85bb27ff commit 502f92160f3883c64cba32e966c163de85bb27ff Author: Rodrigo Bruno <rfbpb@google.com> Date: Fri Jun 08 10:48:09 2018 [heap] Refactor of HeapController to avoid Heap dependencies. Bug: chromium:845409 Change-Id: If1fbb03258fdfae528069ba37bbef0395ddb230d Reviewed-on: https://chromium-review.googlesource.com/1090920 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#53608} [modify] https://crrev.com/502f92160f3883c64cba32e966c163de85bb27ff/src/heap/heap-controller.cc [modify] https://crrev.com/502f92160f3883c64cba32e966c163de85bb27ff/src/heap/heap-controller.h [modify] https://crrev.com/502f92160f3883c64cba32e966c163de85bb27ff/src/heap/heap.cc [modify] https://crrev.com/502f92160f3883c64cba32e966c163de85bb27ff/src/heap/heap.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/748e33944da5bf355bb9ec480af0942ca041a7a3 commit 748e33944da5bf355bb9ec480af0942ca041a7a3 Author: Rodrigo Bruno <rfbpb@google.com> Date: Fri Jun 08 16:45:41 2018 [heap ]Added test to verify the output of CalculateOldGenerationAllocationLimit. Bug: chromium:845409 Change-Id: Id8b89e6dac48bba9065ac9f04ce48f951aa2186b Reviewed-on: https://chromium-review.googlesource.com/1092860 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53617} [modify] https://crrev.com/748e33944da5bf355bb9ec480af0942ca041a7a3/src/heap/heap-controller.h [modify] https://crrev.com/748e33944da5bf355bb9ec480af0942ca041a7a3/src/heap/heap.h [modify] https://crrev.com/748e33944da5bf355bb9ec480af0942ca041a7a3/test/unittests/heap/heap-controller-unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/e92e007e7fc93a3c0e4df04e4b800caa7badc198 commit e92e007e7fc93a3c0e4df04e4b800caa7badc198 Author: Rodrigo Bruno <rfbpb@google.com> Date: Thu Jun 21 15:53:17 2018 [heap] Preparing space class to hold different external memory counters. Bug: chromium:845409 Change-Id: Ica0f7417a0d695900fa0578cd1248499ffa55f08 Reviewed-on: https://chromium-review.googlesource.com/1109965 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53938} [modify] https://crrev.com/e92e007e7fc93a3c0e4df04e4b800caa7badc198/src/heap/spaces.cc [modify] https://crrev.com/e92e007e7fc93a3c0e4df04e4b800caa7badc198/src/heap/spaces.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/da831e966d18ac9d68a2b3c025fd525ac1082e2b commit da831e966d18ac9d68a2b3c025fd525ac1082e2b Author: Rodrigo Bruno <rfbpb@google.com> Date: Mon Jun 25 13:26:09 2018 [heap] Added NewToOld page promotion test using JSArrayBuffers. Bug: chromium:845409 Change-Id: I7a4e19529193f7e8369b7db02c7bcf01ae302ee3 Reviewed-on: https://chromium-review.googlesource.com/1113439 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54002} [modify] https://crrev.com/da831e966d18ac9d68a2b3c025fd525ac1082e2b/test/cctest/heap/test-page-promotion.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/92f461c0b554303b8a5b21cc217a4e761ceb831b commit 92f461c0b554303b8a5b21cc217a4e761ceb831b Author: Rodrigo Bruno <rfbpb@google.com> Date: Tue Jun 26 06:46:35 2018 [heap] Preparing memory chunks to contain external memory counters. Bug: chromium:845409 Change-Id: Id4f1b93f0992e15ed592156c7dec7d15828e4c42 Reviewed-on: https://chromium-review.googlesource.com/1113552 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#54014} [modify] https://crrev.com/92f461c0b554303b8a5b21cc217a4e761ceb831b/src/heap/spaces.cc [modify] https://crrev.com/92f461c0b554303b8a5b21cc217a4e761ceb831b/src/heap/spaces.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/d4792e8f6b67a040671b43e28f2c8c8d001587d0 commit d4792e8f6b67a040671b43e28f2c8c8d001587d0 Author: Rodrigo Bruno <rfbpb@google.com> Date: Tue Jun 26 12:24:23 2018 [heap] Added per-page array buffer accouting (external memory). Bug: chromium:845409 Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af Reviewed-on: https://chromium-review.googlesource.com/1114602 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54028} [modify] https://crrev.com/d4792e8f6b67a040671b43e28f2c8c8d001587d0/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/d4792e8f6b67a040671b43e28f2c8c8d001587d0/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/d4792e8f6b67a040671b43e28f2c8c8d001587d0/src/heap/spaces.cc [modify] https://crrev.com/d4792e8f6b67a040671b43e28f2c8c8d001587d0/src/heap/spaces.h [modify] https://crrev.com/d4792e8f6b67a040671b43e28f2c8c8d001587d0/test/cctest/heap/test-array-buffer-tracker.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/6b810dad78fcccf9c174a2a6590607ca9be13e25 commit 6b810dad78fcccf9c174a2a6590607ca9be13e25 Author: Rodrigo Bruno <rfbpb@google.com> Date: Tue Jun 26 14:35:55 2018 [heap] Updated spaces Verify to check external memory count. Bug: chromium:845409 Change-Id: Ieb690f2d6ed699f306f1ff351cb5f62d9e2db860 Reviewed-on: https://chromium-review.googlesource.com/1114820 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#54035} [modify] https://crrev.com/6b810dad78fcccf9c174a2a6590607ca9be13e25/src/heap/spaces.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/e14086f09d0c6cc46aa2096dbabd3b05e833931e commit e14086f09d0c6cc46aa2096dbabd3b05e833931e Author: Bill Budge <bbudge@chromium.org> Date: Tue Jun 26 18:45:58 2018 Revert "[heap] Added per-page array buffer accouting (external memory)." This reverts commit d4792e8f6b67a040671b43e28f2c8c8d001587d0. Reason for revert: Breaks V8 Linux - gc stress https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20gc%20stress/17056 Original change's description: > [heap] Added per-page array buffer accouting (external memory). > > Bug: chromium:845409 > Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af > Reviewed-on: https://chromium-review.googlesource.com/1114602 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54028} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: I9a354e72df1ab6782bd1c7c4d6b10194bcfaba2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1115478 Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#54040} [modify] https://crrev.com/e14086f09d0c6cc46aa2096dbabd3b05e833931e/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/e14086f09d0c6cc46aa2096dbabd3b05e833931e/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/e14086f09d0c6cc46aa2096dbabd3b05e833931e/src/heap/spaces.cc [modify] https://crrev.com/e14086f09d0c6cc46aa2096dbabd3b05e833931e/src/heap/spaces.h [modify] https://crrev.com/e14086f09d0c6cc46aa2096dbabd3b05e833931e/test/cctest/heap/test-array-buffer-tracker.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/44a82d6b6c6698e8fc53c3e65b91e8f9809277ea commit 44a82d6b6c6698e8fc53c3e65b91e8f9809277ea Author: Bill Budge <bbudge@chromium.org> Date: Tue Jun 26 18:59:13 2018 Reland "[heap] Added per-page array buffer accouting (external memory)." This reverts commit e14086f09d0c6cc46aa2096dbabd3b05e833931e. Reason for revert: Breaks the build. There is another dependent change that must be reverted first. Original change's description: > Revert "[heap] Added per-page array buffer accouting (external memory)." > > This reverts commit d4792e8f6b67a040671b43e28f2c8c8d001587d0. > > Reason for revert: Breaks V8 Linux - gc stress > > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20gc%20stress/17056 > > Original change's description: > > [heap] Added per-page array buffer accouting (external memory). > > > > Bug: chromium:845409 > > Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af > > Reviewed-on: https://chromium-review.googlesource.com/1114602 > > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54028} > > TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com > > Change-Id: I9a354e72df1ab6782bd1c7c4d6b10194bcfaba2b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:845409 > Reviewed-on: https://chromium-review.googlesource.com/1115478 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54040} TBR=bbudge@chromium.org,ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: Iec078656ff3a79a9cee4de046215c55f908c62c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1115479 Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#54041} [modify] https://crrev.com/44a82d6b6c6698e8fc53c3e65b91e8f9809277ea/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/44a82d6b6c6698e8fc53c3e65b91e8f9809277ea/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/44a82d6b6c6698e8fc53c3e65b91e8f9809277ea/src/heap/spaces.cc [modify] https://crrev.com/44a82d6b6c6698e8fc53c3e65b91e8f9809277ea/src/heap/spaces.h [modify] https://crrev.com/44a82d6b6c6698e8fc53c3e65b91e8f9809277ea/test/cctest/heap/test-array-buffer-tracker.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/628996a4b21b5a6897ec30a5a8aec9664a68ce7a commit 628996a4b21b5a6897ec30a5a8aec9664a68ce7a Author: Bill Budge <bbudge@chromium.org> Date: Tue Jun 26 19:04:28 2018 Revert "[heap] Updated spaces Verify to check external memory count." This reverts commit 6b810dad78fcccf9c174a2a6590607ca9be13e25. Reason for revert: Depends on another change that is causing gc-stress to fail. Original change's description: > [heap] Updated spaces Verify to check external memory count. > > Bug: chromium:845409 > Change-Id: Ieb690f2d6ed699f306f1ff351cb5f62d9e2db860 > Reviewed-on: https://chromium-review.googlesource.com/1114820 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Cr-Commit-Position: refs/heads/master@{#54035} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: I72fcebf5485b991872e375d4b7c3e4aa6f70c41b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1115480 Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#54042} [modify] https://crrev.com/628996a4b21b5a6897ec30a5a8aec9664a68ce7a/src/heap/spaces.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/7ca8fdb858c4deebb82f86dbffd86e28a95ba031 commit 7ca8fdb858c4deebb82f86dbffd86e28a95ba031 Author: Bill Budge <bbudge@chromium.org> Date: Tue Jun 26 19:07:28 2018 Revert "[heap] Added per-page array buffer accouting (external memory)." This reverts commit d4792e8f6b67a040671b43e28f2c8c8d001587d0. Reason for revert: Breaks V8 Linux - gc stress https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20gc%20stress/17056 Original change's description: > [heap] Added per-page array buffer accouting (external memory). > > Bug: chromium:845409 > Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af > Reviewed-on: https://chromium-review.googlesource.com/1114602 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54028} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: I8664522a3155d73bac72c9949995d477d2885b8e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1115481 Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#54043} [modify] https://crrev.com/7ca8fdb858c4deebb82f86dbffd86e28a95ba031/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/7ca8fdb858c4deebb82f86dbffd86e28a95ba031/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/7ca8fdb858c4deebb82f86dbffd86e28a95ba031/src/heap/spaces.cc [modify] https://crrev.com/7ca8fdb858c4deebb82f86dbffd86e28a95ba031/src/heap/spaces.h [modify] https://crrev.com/7ca8fdb858c4deebb82f86dbffd86e28a95ba031/test/cctest/heap/test-array-buffer-tracker.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/9072bef085537d58a349e8b3afce21c963ca05aa commit 9072bef085537d58a349e8b3afce21c963ca05aa Author: Rodrigo Bruno <rfbpb@google.com> Date: Wed Jun 27 18:12:07 2018 Reland "[heap] Added per-page array buffer accouting (external memory)." This is a reland of d4792e8f6b67a040671b43e28f2c8c8d001587d0 Original change's description: > [heap] Added per-page array buffer accouting (external memory). > > Bug: chromium:845409 > Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af > Reviewed-on: https://chromium-review.googlesource.com/1114602 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54028} Bug: chromium:845409 Change-Id: I6b11d7f66313bcbcc31be9217c1b780cf3eaee99 Reviewed-on: https://chromium-review.googlesource.com/1116638 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54066} [modify] https://crrev.com/9072bef085537d58a349e8b3afce21c963ca05aa/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/9072bef085537d58a349e8b3afce21c963ca05aa/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/9072bef085537d58a349e8b3afce21c963ca05aa/src/heap/spaces.cc [modify] https://crrev.com/9072bef085537d58a349e8b3afce21c963ca05aa/src/heap/spaces.h [modify] https://crrev.com/9072bef085537d58a349e8b3afce21c963ca05aa/test/cctest/heap/test-array-buffer-tracker.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/07422dbde5a6278aedee5fd1bded27aa8119283d commit 07422dbde5a6278aedee5fd1bded27aa8119283d Author: Michael Hablich <hablich@chromium.org> Date: Fri Jun 29 07:59:45 2018 Revert "Reland "[heap] Added per-page array buffer accouting (external memory)."" This reverts commit 9072bef085537d58a349e8b3afce21c963ca05aa. Reason for revert: Speculative revert because of https://chromium-review.googlesource.com/c/chromium/src/+/1118280 Original change's description: > Reland "[heap] Added per-page array buffer accouting (external memory)." > > This is a reland of d4792e8f6b67a040671b43e28f2c8c8d001587d0 > > Original change's description: > > [heap] Added per-page array buffer accouting (external memory). > > > > Bug: chromium:845409 > > Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af > > Reviewed-on: https://chromium-review.googlesource.com/1114602 > > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54028} > > Bug: chromium:845409 > Change-Id: I6b11d7f66313bcbcc31be9217c1b780cf3eaee99 > Reviewed-on: https://chromium-review.googlesource.com/1116638 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54066} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:845409 Change-Id: I818e24d236d93a4645d1532b666056f89156eb86 Reviewed-on: https://chromium-review.googlesource.com/1119825 Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#54100} [modify] https://crrev.com/07422dbde5a6278aedee5fd1bded27aa8119283d/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/07422dbde5a6278aedee5fd1bded27aa8119283d/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/07422dbde5a6278aedee5fd1bded27aa8119283d/src/heap/spaces.cc [modify] https://crrev.com/07422dbde5a6278aedee5fd1bded27aa8119283d/src/heap/spaces.h [modify] https://crrev.com/07422dbde5a6278aedee5fd1bded27aa8119283d/test/cctest/heap/test-array-buffer-tracker.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/4442ed615daf84b61c063a0aeb640c4a1e672d9e commit 4442ed615daf84b61c063a0aeb640c4a1e672d9e Author: Rodrigo Bruno <rfbpb@google.com> Date: Fri Jun 29 10:07:10 2018 Reland "Reland "[heap] Added per-page array buffer accouting (external memory)."" This is a reland of 9072bef085537d58a349e8b3afce21c963ca05aa Original change's description: > Reland "[heap] Added per-page array buffer accouting (external memory)." > > This is a reland of d4792e8f6b67a040671b43e28f2c8c8d001587d0 > > Original change's description: > > [heap] Added per-page array buffer accouting (external memory). > > > > Bug: chromium:845409 > > Change-Id: Ibc568cdc501edf5d84d9c6379aff58be069369af > > Reviewed-on: https://chromium-review.googlesource.com/1114602 > > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54028} > > Bug: chromium:845409 > Change-Id: I6b11d7f66313bcbcc31be9217c1b780cf3eaee99 > Reviewed-on: https://chromium-review.googlesource.com/1116638 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54066} Bug: chromium:845409 Change-Id: Icff4e2a2b974942f73f5e6bb0bfd6ee8655e8ce7 Reviewed-on: https://chromium-review.googlesource.com/1119985 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#54108} [modify] https://crrev.com/4442ed615daf84b61c063a0aeb640c4a1e672d9e/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/4442ed615daf84b61c063a0aeb640c4a1e672d9e/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/4442ed615daf84b61c063a0aeb640c4a1e672d9e/src/heap/spaces.cc [modify] https://crrev.com/4442ed615daf84b61c063a0aeb640c4a1e672d9e/src/heap/spaces.h [modify] https://crrev.com/4442ed615daf84b61c063a0aeb640c4a1e672d9e/test/cctest/heap/test-array-buffer-tracker.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/5863c0b652cbf0f98d84fc59c9e1a64e0244de65 commit 5863c0b652cbf0f98d84fc59c9e1a64e0244de65 Author: Rodrigo Bruno <rfbpb@google.com> Date: Fri Jun 29 10:54:55 2018 [heap] Added External Strings to external memory accounting. Bug: chromium:845409 Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550 Reviewed-on: https://chromium-review.googlesource.com/1118164 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54110} [modify] https://crrev.com/5863c0b652cbf0f98d84fc59c9e1a64e0244de65/src/heap/heap-inl.h [modify] https://crrev.com/5863c0b652cbf0f98d84fc59c9e1a64e0244de65/src/heap/heap.cc [modify] https://crrev.com/5863c0b652cbf0f98d84fc59c9e1a64e0244de65/src/heap/heap.h [modify] https://crrev.com/5863c0b652cbf0f98d84fc59c9e1a64e0244de65/src/heap/mark-compact.cc [modify] https://crrev.com/5863c0b652cbf0f98d84fc59c9e1a64e0244de65/src/heap/spaces.h [modify] https://crrev.com/5863c0b652cbf0f98d84fc59c9e1a64e0244de65/test/cctest/BUILD.gn [add] https://crrev.com/5863c0b652cbf0f98d84fc59c9e1a64e0244de65/test/cctest/heap/test-external-string-tracker.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/142441697586f6e0b171a6f865cba5e713d4909f commit 142441697586f6e0b171a6f865cba5e713d4909f Author: Rodrigo Bruno <rfbpb@google.com> Date: Fri Jun 29 13:13:26 2018 Revert "[heap] Added External Strings to external memory accounting." This reverts commit 5863c0b652cbf0f98d84fc59c9e1a64e0244de65. Reason for revert: Breaks GPU bots (https://ci.chromium.org/p/v8/builders/luci.v8.ci/Mac%20V8%20FYI%20Release%20(Intel)/1648) Original change's description: > [heap] Added External Strings to external memory accounting. > > Bug: chromium:845409 > Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550 > Reviewed-on: https://chromium-review.googlesource.com/1118164 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54110} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: I77787df6aef2efec95c79714d1baf43feeb8a27e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1120265 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#54114} [modify] https://crrev.com/142441697586f6e0b171a6f865cba5e713d4909f/src/heap/heap-inl.h [modify] https://crrev.com/142441697586f6e0b171a6f865cba5e713d4909f/src/heap/heap.cc [modify] https://crrev.com/142441697586f6e0b171a6f865cba5e713d4909f/src/heap/heap.h [modify] https://crrev.com/142441697586f6e0b171a6f865cba5e713d4909f/src/heap/mark-compact.cc [modify] https://crrev.com/142441697586f6e0b171a6f865cba5e713d4909f/src/heap/spaces.h [modify] https://crrev.com/142441697586f6e0b171a6f865cba5e713d4909f/test/cctest/BUILD.gn [delete] https://crrev.com/79349d506daa87335ec56192141c1100f751cb59/test/cctest/heap/test-external-string-tracker.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/90da229fa29f24ac0049126d8ce6d7d8c5c14416 commit 90da229fa29f24ac0049126d8ce6d7d8c5c14416 Author: Rodrigo Bruno <rfbpb@google.com> Date: Fri Jun 29 16:00:00 2018 Reland "[heap] Updated spaces Verify to check external memory count." This is a reland of 6b810dad78fcccf9c174a2a6590607ca9be13e25 Original change's description: > [heap] Updated spaces Verify to check external memory count. > > Bug: chromium:845409 > Change-Id: Ieb690f2d6ed699f306f1ff351cb5f62d9e2db860 > Reviewed-on: https://chromium-review.googlesource.com/1114820 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Cr-Commit-Position: refs/heads/master@{#54035} Bug: chromium:845409 Change-Id: I71576bd397ca70d9ce76de279c2d9d1fa5a70596 Reviewed-on: https://chromium-review.googlesource.com/1120365 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#54115} [modify] https://crrev.com/90da229fa29f24ac0049126d8ce6d7d8c5c14416/src/heap/spaces.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/83f5b8d4cd093df183f3db130651a2db36eb4360 commit 83f5b8d4cd093df183f3db130651a2db36eb4360 Author: Rodrigo Bruno <rfbpb@google.com> Date: Mon Jul 02 10:26:39 2018 [heap] Improved spaces verify with fine grained external memory counter checks. Bug: chromium:845409 Change-Id: I422277d565173273e632db07e0e762ee7ae01e87 Reviewed-on: https://chromium-review.googlesource.com/1122116 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#54129} [modify] https://crrev.com/83f5b8d4cd093df183f3db130651a2db36eb4360/src/heap/spaces.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/c5c4b588f18900a6c9659690a71b0affcf7bc33a commit c5c4b588f18900a6c9659690a71b0affcf7bc33a Author: Rodrigo Bruno <rfbpb@google.com> Date: Wed Jul 04 10:55:26 2018 [heap] Forcing external strings to be registered in the external string table. Bug: chromium:845409 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I2ab1ca18a900828e4e116f1b087925319d41bf97 Reviewed-on: https://chromium-review.googlesource.com/1124845 Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#54203} [modify] https://crrev.com/c5c4b588f18900a6c9659690a71b0affcf7bc33a/include/v8.h [modify] https://crrev.com/c5c4b588f18900a6c9659690a71b0affcf7bc33a/src/api.cc [modify] https://crrev.com/c5c4b588f18900a6c9659690a71b0affcf7bc33a/src/bootstrapper.cc [modify] https://crrev.com/c5c4b588f18900a6c9659690a71b0affcf7bc33a/src/compiler-dispatcher/unoptimized-compile-job.cc [modify] https://crrev.com/c5c4b588f18900a6c9659690a71b0affcf7bc33a/src/compiler-dispatcher/unoptimized-compile-job.h [modify] https://crrev.com/c5c4b588f18900a6c9659690a71b0affcf7bc33a/src/extensions/externalize-string-extension.cc [modify] https://crrev.com/c5c4b588f18900a6c9659690a71b0affcf7bc33a/src/heap/factory.cc [modify] https://crrev.com/c5c4b588f18900a6c9659690a71b0affcf7bc33a/src/objects.cc [modify] https://crrev.com/c5c4b588f18900a6c9659690a71b0affcf7bc33a/test/cctest/heap/test-heap.cc [modify] https://crrev.com/c5c4b588f18900a6c9659690a71b0affcf7bc33a/test/cctest/parsing/test-scanner-streams.cc [modify] https://crrev.com/c5c4b588f18900a6c9659690a71b0affcf7bc33a/test/cctest/test-api.cc [modify] https://crrev.com/c5c4b588f18900a6c9659690a71b0affcf7bc33a/test/cctest/test-serialize.cc [modify] https://crrev.com/c5c4b588f18900a6c9659690a71b0affcf7bc33a/test/cctest/test-strings.cc [modify] https://crrev.com/c5c4b588f18900a6c9659690a71b0affcf7bc33a/test/unittests/compiler-dispatcher/unoptimized-compile-job-unittest.cc
Issue 837583 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c commit 7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c Author: Rodrigo Bruno <rfbpb@google.com> Date: Thu Jul 12 13:19:28 2018 Reland "[heap] Added External Strings to external memory accounting." This is a reland of 5863c0b652cbf0f98d84fc59c9e1a64e0244de65 Original change's description: > [heap] Added External Strings to external memory accounting. > > Bug: chromium:845409 > Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550 > Reviewed-on: https://chromium-review.googlesource.com/1118164 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54110} Bug: chromium:845409 Change-Id: Ied341ec6268000343d2a577b22f2a483460b01f5 Reviewed-on: https://chromium-review.googlesource.com/1121736 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54410} [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/src/heap/factory.cc [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/src/heap/heap-inl.h [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/src/heap/heap.cc [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/src/heap/heap.h [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/src/heap/mark-compact.cc [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/src/heap/spaces.cc [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/src/heap/spaces.h [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/src/objects.cc [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/src/objects/string-inl.h [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/src/objects/string.h [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/src/snapshot/deserializer.cc [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/test/cctest/BUILD.gn [add] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/test/cctest/heap/test-external-string-tracker.cc [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/test/cctest/heap/test-heap.cc [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/test/cctest/parsing/test-scanner-streams.cc [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/test/cctest/test-api.cc [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/test/cctest/test-log.cc [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/test/cctest/test-serialize.cc [modify] https://crrev.com/7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c/test/cctest/test-strings.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/6b4ba7412abea618696ab48115b961c6f6792e18 commit 6b4ba7412abea618696ab48115b961c6f6792e18 Author: Rodrigo Bruno <rfbpb@google.com> Date: Thu Jul 12 16:14:39 2018 Fix update external string call in morph string test. Bug: chromium:845409 Change-Id: Ic9b1fa0f669c8b9a82ed91d3f348dd070fc9267f Reviewed-on: https://chromium-review.googlesource.com/1135247 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54419} [modify] https://crrev.com/6b4ba7412abea618696ab48115b961c6f6792e18/test/cctest/test-api.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/c1663fd300c9580bec6c651f348256fa40228057 commit c1663fd300c9580bec6c651f348256fa40228057 Author: Michael Lippautz <mlippautz@chromium.org> Date: Fri Jul 13 08:26:11 2018 Revert "Fix update external string call in morph string test." This reverts commit 6b4ba7412abea618696ab48115b961c6f6792e18. Reason for revert: Blocks roll, see bug. Bug: v8:7944 Original change's description: > Fix update external string call in morph string test. > > Bug: chromium:845409 > Change-Id: Ic9b1fa0f669c8b9a82ed91d3f348dd070fc9267f > Reviewed-on: https://chromium-review.googlesource.com/1135247 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54419} TBR=mlippautz@chromium.org,rfbpb@google.com Change-Id: I42121de37913bbe858b9a7c6a9dabf86090c493b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1136311 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54427} [modify] https://crrev.com/c1663fd300c9580bec6c651f348256fa40228057/test/cctest/test-api.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/71dddd145d53b3f79b4afc9a60fb98043541e0a9 commit 71dddd145d53b3f79b4afc9a60fb98043541e0a9 Author: Michael Lippautz <mlippautz@chromium.org> Date: Fri Jul 13 08:27:51 2018 Revert "Reland "[heap] Added External Strings to external memory accounting."" This reverts commit 7bff339e7fa3fdf49d724c9ce8fdfaad5d19294c. Reason for revert: Breaks autoroll, see bug. Bug: v8:7944 Original change's description: > Reland "[heap] Added External Strings to external memory accounting." > > This is a reland of 5863c0b652cbf0f98d84fc59c9e1a64e0244de65 > > Original change's description: > > [heap] Added External Strings to external memory accounting. > > > > Bug: chromium:845409 > > Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550 > > Reviewed-on: https://chromium-review.googlesource.com/1118164 > > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54110} > > Bug: chromium:845409 > Change-Id: Ied341ec6268000343d2a577b22f2a483460b01f5 > Reviewed-on: https://chromium-review.googlesource.com/1121736 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54410} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,petermarshall@chromium.org,rfbpb@google.com Change-Id: Ie55586e84f44a2d83c7f97110d60abb86f0730c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1136312 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54428} [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/src/heap/factory.cc [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/src/heap/heap-inl.h [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/src/heap/heap.cc [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/src/heap/heap.h [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/src/heap/mark-compact.cc [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/src/heap/spaces.cc [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/src/heap/spaces.h [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/src/objects.cc [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/src/objects/string-inl.h [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/src/objects/string.h [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/src/snapshot/deserializer.cc [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/test/cctest/BUILD.gn [delete] https://crrev.com/c1663fd300c9580bec6c651f348256fa40228057/test/cctest/heap/test-external-string-tracker.cc [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/test/cctest/heap/test-heap.cc [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/test/cctest/parsing/test-scanner-streams.cc [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/test/cctest/test-api.cc [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/test/cctest/test-log.cc [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/test/cctest/test-serialize.cc [modify] https://crrev.com/71dddd145d53b3f79b4afc9a60fb98043541e0a9/test/cctest/test-strings.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/2c4c2ad694dfd4e852039644c7bfe22e594587c6 commit 2c4c2ad694dfd4e852039644c7bfe22e594587c6 Author: Rodrigo Bruno <rfbpb@google.com> Date: Fri Jul 20 18:02:59 2018 Avoiding re-externalization of strings. Bug: chromium:845409 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I75bddcf0e8879d2161486f24d1cd4e46d8fe008d Reviewed-on: https://chromium-review.googlesource.com/1139056 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54599} [modify] https://crrev.com/2c4c2ad694dfd4e852039644c7bfe22e594587c6/include/v8.h [modify] https://crrev.com/2c4c2ad694dfd4e852039644c7bfe22e594587c6/src/api.cc [modify] https://crrev.com/2c4c2ad694dfd4e852039644c7bfe22e594587c6/src/heap/heap-inl.h [modify] https://crrev.com/2c4c2ad694dfd4e852039644c7bfe22e594587c6/src/heap/heap.cc [modify] https://crrev.com/2c4c2ad694dfd4e852039644c7bfe22e594587c6/src/heap/heap.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/367815ea13a088e8ba24765dc291d0649e4880d9 commit 367815ea13a088e8ba24765dc291d0649e4880d9 Author: Sigurd Schneider <sigurds@chromium.org> Date: Mon Jul 23 14:25:09 2018 Revert "Avoiding re-externalization of strings." This reverts commit 2c4c2ad694dfd4e852039644c7bfe22e594587c6. Reason for revert: Speculatively revert CL, as it seems to break blink debug bots: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064%20(dbg)/12756 https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064%20(dbg)/12764 # Fatal error in ../../v8/src/api.cc, line 5960 # Check failed: expected == value ((nil) vs. 0x176ae0f70a48). Original change's description: > Avoiding re-externalization of strings. > > Bug: chromium:845409 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I75bddcf0e8879d2161486f24d1cd4e46d8fe008d > Reviewed-on: https://chromium-review.googlesource.com/1139056 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54599} TBR=ulan@chromium.org,jkummerow@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:845409 Change-Id: Ie172148c0bdef71c0cf9819e63a66aec09d6888d Reviewed-on: https://chromium-review.googlesource.com/1146582 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54611} [modify] https://crrev.com/367815ea13a088e8ba24765dc291d0649e4880d9/include/v8.h [modify] https://crrev.com/367815ea13a088e8ba24765dc291d0649e4880d9/src/api.cc [modify] https://crrev.com/367815ea13a088e8ba24765dc291d0649e4880d9/src/heap/heap-inl.h [modify] https://crrev.com/367815ea13a088e8ba24765dc291d0649e4880d9/src/heap/heap.cc [modify] https://crrev.com/367815ea13a088e8ba24765dc291d0649e4880d9/src/heap/heap.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/f34158c9d2abec367ec3930732fdf294cd1ca188 commit f34158c9d2abec367ec3930732fdf294cd1ca188 Author: Rodrigo Bruno <rfbpb@google.com> Date: Tue Jul 24 11:02:59 2018 Reland "Avoiding re-externalization of strings." This is a reland of 2c4c2ad694dfd4e852039644c7bfe22e594587c6 Original change's description: > Avoiding re-externalization of strings. > > Bug: chromium:845409 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I75bddcf0e8879d2161486f24d1cd4e46d8fe008d > Reviewed-on: https://chromium-review.googlesource.com/1139056 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54599} Bug: chromium:866208 Change-Id: I7714bfc695ebeaf55b9ccbbc6b11368416ce7fec Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1146583 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#54637} [modify] https://crrev.com/f34158c9d2abec367ec3930732fdf294cd1ca188/include/v8.h [modify] https://crrev.com/f34158c9d2abec367ec3930732fdf294cd1ca188/src/api.cc [modify] https://crrev.com/f34158c9d2abec367ec3930732fdf294cd1ca188/src/extensions/externalize-string-extension.cc [modify] https://crrev.com/f34158c9d2abec367ec3930732fdf294cd1ca188/src/heap/heap-inl.h [modify] https://crrev.com/f34158c9d2abec367ec3930732fdf294cd1ca188/src/heap/heap.cc [modify] https://crrev.com/f34158c9d2abec367ec3930732fdf294cd1ca188/src/heap/heap.h [modify] https://crrev.com/f34158c9d2abec367ec3930732fdf294cd1ca188/src/objects.cc [modify] https://crrev.com/f34158c9d2abec367ec3930732fdf294cd1ca188/src/objects/string.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/765c1eac1f0377dc133eecf25e623b8d68b69376 commit 765c1eac1f0377dc133eecf25e623b8d68b69376 Author: Sigurd Schneider <sigurds@chromium.org> Date: Tue Jul 24 13:37:04 2018 Speculatively Revert "Reland "Avoiding re-externalization of strings."" This reverts commit f34158c9d2abec367ec3930732fdf294cd1ca188. Reason for revert: Seems to trigger DCHECKS. Two CLs in range; this one seemed more likely. https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064%20(dbg)/12787 https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064%20(dbg)/12788 Original change's description: > Reland "Avoiding re-externalization of strings." > > This is a reland of 2c4c2ad694dfd4e852039644c7bfe22e594587c6 > > Original change's description: > > Avoiding re-externalization of strings. > > > > Bug: chromium:845409 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > > Change-Id: I75bddcf0e8879d2161486f24d1cd4e46d8fe008d > > Reviewed-on: https://chromium-review.googlesource.com/1139056 > > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54599} > > Bug: chromium:866208 > Change-Id: I7714bfc695ebeaf55b9ccbbc6b11368416ce7fec > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/1146583 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Cr-Commit-Position: refs/heads/master@{#54637} TBR=ulan@chromium.org,jkummerow@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: Id12382d66bc5c9b5c76d73b06a6b421dd4d7be66 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:866208 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1148400 Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54645} [modify] https://crrev.com/765c1eac1f0377dc133eecf25e623b8d68b69376/include/v8.h [modify] https://crrev.com/765c1eac1f0377dc133eecf25e623b8d68b69376/src/api.cc [modify] https://crrev.com/765c1eac1f0377dc133eecf25e623b8d68b69376/src/extensions/externalize-string-extension.cc [modify] https://crrev.com/765c1eac1f0377dc133eecf25e623b8d68b69376/src/heap/heap-inl.h [modify] https://crrev.com/765c1eac1f0377dc133eecf25e623b8d68b69376/src/heap/heap.cc [modify] https://crrev.com/765c1eac1f0377dc133eecf25e623b8d68b69376/src/heap/heap.h [modify] https://crrev.com/765c1eac1f0377dc133eecf25e623b8d68b69376/src/objects.cc [modify] https://crrev.com/765c1eac1f0377dc133eecf25e623b8d68b69376/src/objects/string.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/da9386ae2d0416ac883cd1ce343a0ca3eac43519 commit da9386ae2d0416ac883cd1ce343a0ca3eac43519 Author: Rodrigo Bruno <rfbpb@google.com> Date: Wed Jul 25 18:54:28 2018 Reland^2 "Avoiding re-externalization of strings" Previously landed as 2c4c2ad694dfd4e852039644c7bfe22e594587c6 / #54599 and f34158c9d2abec367ec3930732fdf294cd1ca188 / #54637 Previously reviewed at https://chromium-review.googlesource.com/1139056 and https://chromium-review.googlesource.com/1146583 Bug: chromium:845409, chromium:866208 Change-Id: Idb1b6d1b29499f66bf8cd704977c40b027f99dbd Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1148281 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#54703} [modify] https://crrev.com/da9386ae2d0416ac883cd1ce343a0ca3eac43519/include/v8.h [modify] https://crrev.com/da9386ae2d0416ac883cd1ce343a0ca3eac43519/src/api.cc [modify] https://crrev.com/da9386ae2d0416ac883cd1ce343a0ca3eac43519/src/extensions/externalize-string-extension.cc [modify] https://crrev.com/da9386ae2d0416ac883cd1ce343a0ca3eac43519/src/heap/heap-inl.h [modify] https://crrev.com/da9386ae2d0416ac883cd1ce343a0ca3eac43519/src/heap/heap.cc [modify] https://crrev.com/da9386ae2d0416ac883cd1ce343a0ca3eac43519/src/heap/heap.h [modify] https://crrev.com/da9386ae2d0416ac883cd1ce343a0ca3eac43519/src/objects.cc [modify] https://crrev.com/da9386ae2d0416ac883cd1ce343a0ca3eac43519/src/objects/string.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/82632ed5e47e08036365cb568ed3f9db79a567d1 commit 82632ed5e47e08036365cb568ed3f9db79a567d1 Author: Rodrigo Bruno <rfbpb@google.com> Date: Thu Jul 26 09:25:41 2018 Reland^2 "Added External Strings to external memory accounting". This CL depends on Reland^2 "Avoiding re-externalization of strings" (Idb1b6d1b29499f66bf8cd704977c40b027f99dbd).. Previously landed as Ied341ec6268000343d2a577b22f2a483460b01f5 and I3fe2b294f6e038d77787cf0870d244ba7cc20550 Previously reviewed at https://chromium-review.googlesource.com/1121736 and https://chromium-review.googlesource.com/1118164 Bug: chromium:845409 Change-Id: Ied50bbcaa22a90ecaf15dca19dbc9aaec1737223 Reviewed-on: https://chromium-review.googlesource.com/1147227 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#54712} [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/src/heap/factory.cc [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/src/heap/heap-inl.h [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/src/heap/heap.cc [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/src/heap/heap.h [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/src/heap/mark-compact.cc [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/src/heap/spaces.cc [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/src/heap/spaces.h [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/src/objects.cc [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/src/objects/string-inl.h [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/src/objects/string.h [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/src/snapshot/deserializer.cc [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/test/cctest/BUILD.gn [add] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/test/cctest/heap/test-external-string-tracker.cc [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/test/cctest/heap/test-heap.cc [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/test/cctest/parsing/test-scanner-streams.cc [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/test/cctest/test-api.cc [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/test/cctest/test-log.cc [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/test/cctest/test-serialize.cc [modify] https://crrev.com/82632ed5e47e08036365cb568ed3f9db79a567d1/test/cctest/test-strings.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/d623c25a8403ab304a8eb884b35db8e5455e2141 commit d623c25a8403ab304a8eb884b35db8e5455e2141 Author: Rodrigo Bruno <rfbpb@google.com> Date: Thu Aug 02 06:52:26 2018 [heap] Refactoring HeapController. Created new ExternalMemoryController. This CL introduces a new MemoryController that will be used to control the size of external memory (array buffers and external string for now). Bug: chromium:845409 Change-Id: I119506ce0243ac33cec2b783b888b53ee11225a9 Reviewed-on: https://chromium-review.googlesource.com/1156393 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54854} [modify] https://crrev.com/d623c25a8403ab304a8eb884b35db8e5455e2141/src/heap/heap-controller.cc [modify] https://crrev.com/d623c25a8403ab304a8eb884b35db8e5455e2141/src/heap/heap-controller.h [modify] https://crrev.com/d623c25a8403ab304a8eb884b35db8e5455e2141/test/unittests/heap/heap-controller-unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/ecf51e3477dec5e1ec13c934d4c9da844c6b7d03 commit ecf51e3477dec5e1ec13c934d4c9da844c6b7d03 Author: Rodrigo Bruno <rfbpb@google.com> Date: Thu Aug 09 09:04:26 2018 [heap] refactoring HeapController. The HeapController is now refactored in a way that new controllers only need to specify the constants that define how a space grows and shrinks. Bug: chromium:845409 Change-Id: I804eed440a791d6fbd232b7540a1cbe66b16a5f1 Reviewed-on: https://chromium-review.googlesource.com/1165347 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55006} [modify] https://crrev.com/ecf51e3477dec5e1ec13c934d4c9da844c6b7d03/src/heap/heap-controller.cc [modify] https://crrev.com/ecf51e3477dec5e1ec13c934d4c9da844c6b7d03/src/heap/heap-controller.h [modify] https://crrev.com/ecf51e3477dec5e1ec13c934d4c9da844c6b7d03/src/heap/heap.cc [modify] https://crrev.com/ecf51e3477dec5e1ec13c934d4c9da844c6b7d03/src/heap/heap.h [modify] https://crrev.com/ecf51e3477dec5e1ec13c934d4c9da844c6b7d03/test/unittests/heap/heap-controller-unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/d077c1fa7e5cab872c44b14f9f71f1fbf6e93577 commit d077c1fa7e5cab872c44b14f9f71f1fbf6e93577 Author: Rodrigo Bruno <rfbpb@google.com> Date: Fri Aug 10 12:12:07 2018 [test-heap] fixed test to avoid internal call that will be removed Bug: chromium:845409 Change-Id: I73a5db1c09e0adb3eab0ee0bdf675edbdea6c6e7 Reviewed-on: https://chromium-review.googlesource.com/1170762 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#55045} [modify] https://crrev.com/d077c1fa7e5cab872c44b14f9f71f1fbf6e93577/test/cctest/heap/test-heap.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/3a5751dcd4cf63e234eda5984bbb0d5b1f2bfd92 commit 3a5751dcd4cf63e234eda5984bbb0d5b1f2bfd92 Author: Rodrigo Bruno <rfbpb@google.com> Date: Fri Aug 10 12:20:45 2018 [test-heap] fixed test that was not allowing gc to collect an object Bug: chromium:845409 Change-Id: I865826c0e8927aea264a4f9177380ec3bb8aee4f Reviewed-on: https://chromium-review.googlesource.com/1170764 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#55046} [modify] https://crrev.com/3a5751dcd4cf63e234eda5984bbb0d5b1f2bfd92/test/mjsunit/regress/regress-crbug-380671.js
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/ba735dde20869a2ae4781c880184dcf8f1a1a5fd commit ba735dde20869a2ae4781c880184dcf8f1a1a5fd Author: Rodrigo Bruno <rfbpb@google.com> Date: Tue Aug 14 16:31:32 2018 [heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery. Bug: chromium:845409 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic62a4339110e3dd2a6b1961a246e2bee0c07c03b Reviewed-on: https://chromium-review.googlesource.com/1160162 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55128} [modify] https://crrev.com/ba735dde20869a2ae4781c880184dcf8f1a1a5fd/include/v8.h [modify] https://crrev.com/ba735dde20869a2ae4781c880184dcf8f1a1a5fd/src/api.cc [modify] https://crrev.com/ba735dde20869a2ae4781c880184dcf8f1a1a5fd/src/heap/array-buffer-collector.cc [modify] https://crrev.com/ba735dde20869a2ae4781c880184dcf8f1a1a5fd/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/ba735dde20869a2ae4781c880184dcf8f1a1a5fd/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/ba735dde20869a2ae4781c880184dcf8f1a1a5fd/src/heap/heap-controller.cc [modify] https://crrev.com/ba735dde20869a2ae4781c880184dcf8f1a1a5fd/src/heap/heap-controller.h [modify] https://crrev.com/ba735dde20869a2ae4781c880184dcf8f1a1a5fd/src/heap/heap.cc [modify] https://crrev.com/ba735dde20869a2ae4781c880184dcf8f1a1a5fd/src/heap/heap.h [modify] https://crrev.com/ba735dde20869a2ae4781c880184dcf8f1a1a5fd/src/heap/mark-compact.cc [modify] https://crrev.com/ba735dde20869a2ae4781c880184dcf8f1a1a5fd/src/heap/spaces.h [modify] https://crrev.com/ba735dde20869a2ae4781c880184dcf8f1a1a5fd/test/unittests/heap/heap-controller-unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/7eded3003a184fc2be7d00de6404f421cbeae04f commit 7eded3003a184fc2be7d00de6404f421cbeae04f Author: Sathya Gunasekaran <gsathya@chromium.org> Date: Tue Aug 14 17:17:17 2018 Revert "[heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery." This reverts commit ba735dde20869a2ae4781c880184dcf8f1a1a5fd. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/21991 Original change's description: > [heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery. > > Bug: chromium:845409 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: Ic62a4339110e3dd2a6b1961a246e2bee0c07c03b > Reviewed-on: https://chromium-review.googlesource.com/1160162 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55128} TBR=ulan@chromium.org,mlippautz@chromium.org,rfbpb@google.com Change-Id: Iaf65227c65c11effa11662ac7d7bd7736f4d7846 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1174858 Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55129} [modify] https://crrev.com/7eded3003a184fc2be7d00de6404f421cbeae04f/include/v8.h [modify] https://crrev.com/7eded3003a184fc2be7d00de6404f421cbeae04f/src/api.cc [modify] https://crrev.com/7eded3003a184fc2be7d00de6404f421cbeae04f/src/heap/array-buffer-collector.cc [modify] https://crrev.com/7eded3003a184fc2be7d00de6404f421cbeae04f/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/7eded3003a184fc2be7d00de6404f421cbeae04f/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/7eded3003a184fc2be7d00de6404f421cbeae04f/src/heap/heap-controller.cc [modify] https://crrev.com/7eded3003a184fc2be7d00de6404f421cbeae04f/src/heap/heap-controller.h [modify] https://crrev.com/7eded3003a184fc2be7d00de6404f421cbeae04f/src/heap/heap.cc [modify] https://crrev.com/7eded3003a184fc2be7d00de6404f421cbeae04f/src/heap/heap.h [modify] https://crrev.com/7eded3003a184fc2be7d00de6404f421cbeae04f/src/heap/mark-compact.cc [modify] https://crrev.com/7eded3003a184fc2be7d00de6404f421cbeae04f/src/heap/spaces.h [modify] https://crrev.com/7eded3003a184fc2be7d00de6404f421cbeae04f/test/unittests/heap/heap-controller-unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6 commit eb164dbd0066a0078e58932563eeb5fdd2b8e6d6 Author: Rodrigo Bruno <rfbpb@google.com> Date: Tue Aug 28 12:41:53 2018 Reland "[heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery." This is a reland of ba735dde20869a2ae4781c880184dcf8f1a1a5fd Original change's description: > [heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery. > > Bug: chromium:845409 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: Ic62a4339110e3dd2a6b1961a246e2bee0c07c03b > Reviewed-on: https://chromium-review.googlesource.com/1160162 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55128} Bug: chromium:845409 Change-Id: Iaff177f7bebbc073460fab0ae4e5cd9e632e1921 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1177301 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Cr-Commit-Position: refs/heads/master@{#55454} [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/include/v8.h [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/src/api.cc [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/src/d8.cc [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/src/d8.h [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/src/heap/array-buffer-collector.cc [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/src/heap/heap-controller.cc [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/src/heap/heap-controller.h [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/src/heap/heap.cc [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/src/heap/heap.h [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/src/heap/mark-compact.cc [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/src/heap/spaces.h [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/test/cctest/heap/test-heap.cc [add] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/test/mjsunit/external-backing-store-gc.js [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/test/unittests/heap/heap-controller-unittest.cc [modify] https://crrev.com/eb164dbd0066a0078e58932563eeb5fdd2b8e6d6/tools/gcmole/gcmole.lua
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/82061873810834a5879848d70e1b5d0da83f0ba1 commit 82061873810834a5879848d70e1b5d0da83f0ba1 Author: Michael Lippautz <mlippautz@chromium.org> Date: Thu Aug 30 14:24:38 2018 Revert GC scheduling for external backing stores Revert "Reland "[heap] Attempt to incorporate backing store counters into heap sizing and GC trigger stragery."" This reverts commit eb164dbd0066a0078e58932563eeb5fdd2b8e6d6. Revert "[d8] Fixed external gc test (limit multiplied by number of isolates)." This reverts commit 38cbc26a75c48983d5591d9b8c125e2b97ee1c1e. Revert "[heap] Fixed typo in method name." This reverts commit 263174af75c02cced7d2c11ce80e9f4e7e8c15f7. Bug: chromium:845409, chromium:879045 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I555bcff2ad04ae23368c7b3999a237083010f9c6 Reviewed-on: https://chromium-review.googlesource.com/1196550 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55529} [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/include/v8.h [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/src/api.cc [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/src/d8.cc [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/src/d8.h [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/src/heap/array-buffer-collector.cc [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/src/heap/heap-controller.cc [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/src/heap/heap-controller.h [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/src/heap/heap.cc [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/src/heap/heap.h [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/src/heap/mark-compact.cc [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/src/heap/spaces.h [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/test/cctest/heap/test-heap.cc [delete] https://crrev.com/32745df15a11c78e10da6c84a2072aec26028a85/test/mjsunit/external-backing-store-gc.js [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/test/unittests/heap/heap-controller-unittest.cc [modify] https://crrev.com/82061873810834a5879848d70e1b5d0da83f0ba1/tools/gcmole/gcmole.lua
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/5107ec2a7cccc2947d7ef43b4c2aebb3774e2db3 commit 5107ec2a7cccc2947d7ef43b4c2aebb3774e2db3 Author: Michael Lippautz <mlippautz@chromium.org> Date: Tue Sep 04 14:47:24 2018 Add external backing store JS test Allow mocking the limits for ArrayBuffer allocation to simulate operating system OOM. Bug: chromium:845409 Change-Id: I38bf56a3677e1db547c774223c81e913f56cb631 Reviewed-on: https://chromium-review.googlesource.com/1203895 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55616} [modify] https://crrev.com/5107ec2a7cccc2947d7ef43b4c2aebb3774e2db3/src/d8.cc [modify] https://crrev.com/5107ec2a7cccc2947d7ef43b4c2aebb3774e2db3/src/d8.h [modify] https://crrev.com/5107ec2a7cccc2947d7ef43b4c2aebb3774e2db3/src/flag-definitions.h [add] https://crrev.com/5107ec2a7cccc2947d7ef43b4c2aebb3774e2db3/test/mjsunit/external-backing-store-gc.js
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/f3ad6cdb9c534028296e180ca49c4caf5218c319 commit f3ad6cdb9c534028296e180ca49c4caf5218c319 Author: Yang Guo <yangguo@chromium.org> Date: Wed Sep 05 06:52:00 2018 Revert "Add external backing store JS test" This reverts commit 5107ec2a7cccc2947d7ef43b4c2aebb3774e2db3. Reason for revert: Test is very flaky: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64 Original change's description: > Add external backing store JS test > > Allow mocking the limits for ArrayBuffer allocation to simulate operating > system OOM. > > Bug: chromium:845409 > Change-Id: I38bf56a3677e1db547c774223c81e913f56cb631 > Reviewed-on: https://chromium-review.googlesource.com/1203895 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55616} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: I633988dba1b0a87b652e72e0e667e90122e00f6d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1206290 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55630} [modify] https://crrev.com/f3ad6cdb9c534028296e180ca49c4caf5218c319/src/d8.cc [modify] https://crrev.com/f3ad6cdb9c534028296e180ca49c4caf5218c319/src/d8.h [modify] https://crrev.com/f3ad6cdb9c534028296e180ca49c4caf5218c319/src/flag-definitions.h [delete] https://crrev.com/69fabd0561a01cca1c06683157d161e7ffd8c91a/test/mjsunit/external-backing-store-gc.js
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/408d89041e7a21f74b37294ebed59f88d357b9c1 commit 408d89041e7a21f74b37294ebed59f88d357b9c1 Author: Michael Lippautz <mlippautz@chromium.org> Date: Wed Sep 05 16:03:39 2018 Reland "Add external backing store JS test" Allow mocking the limits for ArrayBuffer allocation to simulate operating system OOM. Fixes: - Ensure OS limit > hard limit for external memory. This is necessary as any processing below the hard limit is opportunistic. E.g. a running sweeper may stall the current marking (GC) round. - Immediately process AB allocations when under memory pressure. Otherwise, the allocations may be stuck in a stalled task. Freeing them upon adding them to the collector still enables parallelism if possible. This reverts commit f3ad6cdb9c534028296e180ca49c4caf5218c319. Bug: chromium:845409 Change-Id: Ic3e458f2af231bae3d53afcfd6002a0347d3f12b Reviewed-on: https://chromium-review.googlesource.com/1206872 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55656} [modify] https://crrev.com/408d89041e7a21f74b37294ebed59f88d357b9c1/src/d8.cc [modify] https://crrev.com/408d89041e7a21f74b37294ebed59f88d357b9c1/src/d8.h [modify] https://crrev.com/408d89041e7a21f74b37294ebed59f88d357b9c1/src/flag-definitions.h [modify] https://crrev.com/408d89041e7a21f74b37294ebed59f88d357b9c1/src/heap/array-buffer-collector.cc [modify] https://crrev.com/408d89041e7a21f74b37294ebed59f88d357b9c1/src/heap/array-buffer-collector.h [modify] https://crrev.com/408d89041e7a21f74b37294ebed59f88d357b9c1/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/408d89041e7a21f74b37294ebed59f88d357b9c1/src/heap/heap.cc [modify] https://crrev.com/408d89041e7a21f74b37294ebed59f88d357b9c1/src/heap/heap.h [modify] https://crrev.com/408d89041e7a21f74b37294ebed59f88d357b9c1/src/heap/mark-compact.cc [add] https://crrev.com/408d89041e7a21f74b37294ebed59f88d357b9c1/test/mjsunit/external-backing-store-gc.js
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/9c67143f4a09ae5f3d170ade5c3e8d50ebfac94b commit 9c67143f4a09ae5f3d170ade5c3e8d50ebfac94b Author: Michael Lippautz <mlippautz@chromium.org> Date: Tue Sep 11 15:35:56 2018 [heap] Introduce backing store counters on Heap - Update those counters from space - Add fast path for move memory Bug: chromium:845409 Change-Id: Icd72e551df2422a635801fb4e31588073f81544e Reviewed-on: https://chromium-review.googlesource.com/1219707 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55798} [modify] https://crrev.com/9c67143f4a09ae5f3d170ade5c3e8d50ebfac94b/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/9c67143f4a09ae5f3d170ade5c3e8d50ebfac94b/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/9c67143f4a09ae5f3d170ade5c3e8d50ebfac94b/src/heap/array-buffer-tracker.h [modify] https://crrev.com/9c67143f4a09ae5f3d170ade5c3e8d50ebfac94b/src/heap/heap-inl.h [modify] https://crrev.com/9c67143f4a09ae5f3d170ade5c3e8d50ebfac94b/src/heap/heap.cc [modify] https://crrev.com/9c67143f4a09ae5f3d170ade5c3e8d50ebfac94b/src/heap/heap.h [modify] https://crrev.com/9c67143f4a09ae5f3d170ade5c3e8d50ebfac94b/src/heap/mark-compact.cc [modify] https://crrev.com/9c67143f4a09ae5f3d170ade5c3e8d50ebfac94b/src/heap/spaces-inl.h [modify] https://crrev.com/9c67143f4a09ae5f3d170ade5c3e8d50ebfac94b/src/heap/spaces.cc [modify] https://crrev.com/9c67143f4a09ae5f3d170ade5c3e8d50ebfac94b/src/heap/spaces.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/0c62f5b39fb9d3e4ecef835a384a28b8c0b60438 commit 0c62f5b39fb9d3e4ecef835a384a28b8c0b60438 Author: Deepti Gandluri <gdeepti@chromium.org> Date: Tue Sep 11 21:22:17 2018 Revert "[heap] Introduce backing store counters on Heap" This reverts commit 9c67143f4a09ae5f3d170ade5c3e8d50ebfac94b. Reason for revert: Potential cause of mac gpu failures for the auto roller - https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_optional_gpu_tests_rel/9158 Original change's description: > [heap] Introduce backing store counters on Heap > > - Update those counters from space > - Add fast path for move memory > > Bug: chromium:845409 > Change-Id: Icd72e551df2422a635801fb4e31588073f81544e > Reviewed-on: https://chromium-review.googlesource.com/1219707 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55798} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: Iaa0d375d84f1c559a13dea9b9f1b7f6907cbd768 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1220293 Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#55807} [modify] https://crrev.com/0c62f5b39fb9d3e4ecef835a384a28b8c0b60438/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/0c62f5b39fb9d3e4ecef835a384a28b8c0b60438/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/0c62f5b39fb9d3e4ecef835a384a28b8c0b60438/src/heap/array-buffer-tracker.h [modify] https://crrev.com/0c62f5b39fb9d3e4ecef835a384a28b8c0b60438/src/heap/heap-inl.h [modify] https://crrev.com/0c62f5b39fb9d3e4ecef835a384a28b8c0b60438/src/heap/heap.cc [modify] https://crrev.com/0c62f5b39fb9d3e4ecef835a384a28b8c0b60438/src/heap/heap.h [modify] https://crrev.com/0c62f5b39fb9d3e4ecef835a384a28b8c0b60438/src/heap/mark-compact.cc [modify] https://crrev.com/0c62f5b39fb9d3e4ecef835a384a28b8c0b60438/src/heap/spaces-inl.h [modify] https://crrev.com/0c62f5b39fb9d3e4ecef835a384a28b8c0b60438/src/heap/spaces.cc [modify] https://crrev.com/0c62f5b39fb9d3e4ecef835a384a28b8c0b60438/src/heap/spaces.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/9d5ab51f9637e87ad38948470f36bf267d2247a0 commit 9d5ab51f9637e87ad38948470f36bf267d2247a0 Author: Michael Lippautz <mlippautz@chromium.org> Date: Wed Sep 12 08:08:37 2018 Reland "[heap] Introduce backing store counters on Heap" - Update those counters from space - Add fast path for move memory Fix: - Introduce proper variants for checked arithmetic on atomics. This reverts commit 0c62f5b39fb9d3e4ecef835a384a28b8c0b60438. Bug: chromium:845409 Change-Id: I98ad1a7c470c7e7b805e087b4ec74e3451344712 Reviewed-on: https://chromium-review.googlesource.com/1219647 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55815} [modify] https://crrev.com/9d5ab51f9637e87ad38948470f36bf267d2247a0/src/base/atomic-utils.h [modify] https://crrev.com/9d5ab51f9637e87ad38948470f36bf267d2247a0/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/9d5ab51f9637e87ad38948470f36bf267d2247a0/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/9d5ab51f9637e87ad38948470f36bf267d2247a0/src/heap/array-buffer-tracker.h [modify] https://crrev.com/9d5ab51f9637e87ad38948470f36bf267d2247a0/src/heap/heap-inl.h [modify] https://crrev.com/9d5ab51f9637e87ad38948470f36bf267d2247a0/src/heap/heap.cc [modify] https://crrev.com/9d5ab51f9637e87ad38948470f36bf267d2247a0/src/heap/heap.h [modify] https://crrev.com/9d5ab51f9637e87ad38948470f36bf267d2247a0/src/heap/mark-compact.cc [modify] https://crrev.com/9d5ab51f9637e87ad38948470f36bf267d2247a0/src/heap/spaces-inl.h [modify] https://crrev.com/9d5ab51f9637e87ad38948470f36bf267d2247a0/src/heap/spaces.cc [modify] https://crrev.com/9d5ab51f9637e87ad38948470f36bf267d2247a0/src/heap/spaces.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/651bd0dec2011c1ff32876e93016a90e28617770 commit 651bd0dec2011c1ff32876e93016a90e28617770 Author: Michael Achenbach <machenbach@chromium.org> Date: Wed Sep 12 08:29:55 2018 Revert "Reland "[heap] Introduce backing store counters on Heap"" This reverts commit 9d5ab51f9637e87ad38948470f36bf267d2247a0. Reason for revert: Blocks important revert. Also rolling is down since 2 days... so please wait with relanding until rolling is confirmed to be up again. https://chromium-review.googlesource.com/c/v8/v8/+/1219695 Original change's description: > Reland "[heap] Introduce backing store counters on Heap" > > - Update those counters from space > - Add fast path for move memory > > Fix: > - Introduce proper variants for checked arithmetic on atomics. > > This reverts commit 0c62f5b39fb9d3e4ecef835a384a28b8c0b60438. > > Bug: chromium:845409 > Change-Id: I98ad1a7c470c7e7b805e087b4ec74e3451344712 > Reviewed-on: https://chromium-review.googlesource.com/1219647 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55815} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: Ifb7c6e31f7f105bd11d1497a1061f73d42c05c31 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1221186 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55816} [modify] https://crrev.com/651bd0dec2011c1ff32876e93016a90e28617770/src/base/atomic-utils.h [modify] https://crrev.com/651bd0dec2011c1ff32876e93016a90e28617770/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/651bd0dec2011c1ff32876e93016a90e28617770/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/651bd0dec2011c1ff32876e93016a90e28617770/src/heap/array-buffer-tracker.h [modify] https://crrev.com/651bd0dec2011c1ff32876e93016a90e28617770/src/heap/heap-inl.h [modify] https://crrev.com/651bd0dec2011c1ff32876e93016a90e28617770/src/heap/heap.cc [modify] https://crrev.com/651bd0dec2011c1ff32876e93016a90e28617770/src/heap/heap.h [modify] https://crrev.com/651bd0dec2011c1ff32876e93016a90e28617770/src/heap/mark-compact.cc [modify] https://crrev.com/651bd0dec2011c1ff32876e93016a90e28617770/src/heap/spaces-inl.h [modify] https://crrev.com/651bd0dec2011c1ff32876e93016a90e28617770/src/heap/spaces.cc [modify] https://crrev.com/651bd0dec2011c1ff32876e93016a90e28617770/src/heap/spaces.h
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/c97cb459d0fb2e383ba4839163d226bf73b6eb40 commit c97cb459d0fb2e383ba4839163d226bf73b6eb40 Author: Michael Lippautz <mlippautz@chromium.org> Date: Wed Sep 12 14:35:34 2018 Reland "[heap] Introduce backing store counters on Heap" - Update those counters from space - Add fast path for move memory Fix: - Introduce proper variants for checked arithmetic on atomics. Previous revert was needed to unblock other reverts. This reverts commit 651bd0dec2011c1ff32876e93016a90e28617770. Bug: chromium:845409 Change-Id: I906ef6c60a589a30a0a632eadb8642735deaf0e4 Tbr: ulan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1221213 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55828} [modify] https://crrev.com/c97cb459d0fb2e383ba4839163d226bf73b6eb40/src/base/atomic-utils.h [modify] https://crrev.com/c97cb459d0fb2e383ba4839163d226bf73b6eb40/src/heap/array-buffer-tracker-inl.h [modify] https://crrev.com/c97cb459d0fb2e383ba4839163d226bf73b6eb40/src/heap/array-buffer-tracker.cc [modify] https://crrev.com/c97cb459d0fb2e383ba4839163d226bf73b6eb40/src/heap/array-buffer-tracker.h [modify] https://crrev.com/c97cb459d0fb2e383ba4839163d226bf73b6eb40/src/heap/heap-inl.h [modify] https://crrev.com/c97cb459d0fb2e383ba4839163d226bf73b6eb40/src/heap/heap.cc [modify] https://crrev.com/c97cb459d0fb2e383ba4839163d226bf73b6eb40/src/heap/heap.h [modify] https://crrev.com/c97cb459d0fb2e383ba4839163d226bf73b6eb40/src/heap/mark-compact.cc [modify] https://crrev.com/c97cb459d0fb2e383ba4839163d226bf73b6eb40/src/heap/spaces-inl.h [modify] https://crrev.com/c97cb459d0fb2e383ba4839163d226bf73b6eb40/src/heap/spaces.cc [modify] https://crrev.com/c97cb459d0fb2e383ba4839163d226bf73b6eb40/src/heap/spaces.h
Comment 1 by bugdroid1@chromium.org
, Jun 7 2018