Weird behaviour of Audit task is seen after hitting ESC key.
Reported by
aiman.an...@etouch.net,
May 22 2018
|
|||||||
Issue descriptionChrome Version: 68.0.3437.2 (Official Build) Revision 59dae9de14a34f5f1cd861acdb3a304530915560-refs/branch-heads/3437@{#4} (32/64 Bit). OS: Win(7,8,8.1,10), Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.4). Steps to reproduce: 1. Launch chrome, Open dev-tools on NTP and go to Audit section. 2. Scroll down, click on Run Audit button and press ESC key after few seconds. 3. Observe "Audit overlay remains disable after hitting ESC key" to terminate Audit process. 4. Now click on '+' button and again click on 'Run Audit button' 5. Observe that 'Run Audit button does not respond' Note: Terminated Audit result is displayed even after terminating the task by hitting ESC key. Actual Result: Weird behaviour of Audit task is seen after hitting ESC key. Expected Result: Audit should not be unresponsive and should not display result after terminating the task by hitting ESC key. This is Non-regression issue seen from ‘M-68’ build #68.0.3434.0
,
May 25 2018
,
May 29 2018
Thanks, ESC key shouldn't do anything on audits panel. This was regressed earlier.
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3fce93a6536e0fd46e21ffb5f3635f1e544696ef commit 3fce93a6536e0fd46e21ffb5f3635f1e544696ef Author: Patrick Hulce <phulce@chromium.org> Date: Tue May 29 18:54:54 2018 DevTools: Audits2 use built-in dialog overlay BUG= 845406 , 847350 , 846607 Change-Id: Id3ed220dcaf00cfbed5ba7b02e27412eab09b219 Reviewed-on: https://chromium-review.googlesource.com/1076325 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#562528} [modify] https://crrev.com/3fce93a6536e0fd46e21ffb5f3635f1e544696ef/third_party/blink/renderer/devtools/front_end/audits2/Audits2Panel.js [modify] https://crrev.com/3fce93a6536e0fd46e21ffb5f3635f1e544696ef/third_party/blink/renderer/devtools/front_end/audits2/Audits2StartView.js [modify] https://crrev.com/3fce93a6536e0fd46e21ffb5f3635f1e544696ef/third_party/blink/renderer/devtools/front_end/audits2/Audits2StatusView.js [modify] https://crrev.com/3fce93a6536e0fd46e21ffb5f3635f1e544696ef/third_party/blink/renderer/devtools/front_end/audits2/audits2Dialog.css [modify] https://crrev.com/3fce93a6536e0fd46e21ffb5f3635f1e544696ef/third_party/blink/renderer/devtools/front_end/audits2/audits2StartView.css
,
May 30 2018
Update: Retested above issue on Win(7,8,8.1,10), Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.4) OS using latest Canary #69.0.3445.0 and issue is fixed. Now, ESC button does not do anything as intended. Thank you!
,
May 30 2018
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65df80761261cdba02aafe8c8f20535ebec0daa1 commit 65df80761261cdba02aafe8c8f20535ebec0daa1 Author: Patrick Hulce <phulce@chromium.org> Date: Thu May 31 20:40:30 2018 DevTools: Audits2 use built-in dialog overlay BUG= 845406 , 847350 , 846607 Change-Id: Id3ed220dcaf00cfbed5ba7b02e27412eab09b219 Reviewed-on: https://chromium-review.googlesource.com/1076325 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562528}(cherry picked from commit 3fce93a6536e0fd46e21ffb5f3635f1e544696ef) Reviewed-on: https://chromium-review.googlesource.com/1081069 Reviewed-by: Patrick Hulce <phulce@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#65} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/65df80761261cdba02aafe8c8f20535ebec0daa1/third_party/blink/renderer/devtools/front_end/audits2/Audits2Panel.js [modify] https://crrev.com/65df80761261cdba02aafe8c8f20535ebec0daa1/third_party/blink/renderer/devtools/front_end/audits2/Audits2StartView.js [modify] https://crrev.com/65df80761261cdba02aafe8c8f20535ebec0daa1/third_party/blink/renderer/devtools/front_end/audits2/Audits2StatusView.js [modify] https://crrev.com/65df80761261cdba02aafe8c8f20535ebec0daa1/third_party/blink/renderer/devtools/front_end/audits2/audits2Dialog.css [modify] https://crrev.com/65df80761261cdba02aafe8c8f20535ebec0daa1/third_party/blink/renderer/devtools/front_end/audits2/audits2StartView.css
,
Jun 5 2018
Update: Retested above issue on Win(7,8,8.1,10), Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.6) OS using latest Dev #68.0.3440.15 and issue is fixed. Now, ESC button does not do anything as intended. Kindly refer the attached screen-cast for reference. Thank you..! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by nyerramilli@chromium.org
, May 22 2018