New issue
Advanced search Search tips

Issue 845396 link

Starred by 4 users
Status: Fixed
Owner:
lgrey@chromium.org
Closed: May 2018
Cc:
cwallez@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
lgrey@chromium.org
e...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Grey focus highlight stays on bookmark icon even when focus traverse to the next icon.

Reported by avsha...@etouch.net, May 22 2018 
Chrome Version : 68.0.3436.0 (Official Build) e0f81fe637f233bf12e821915b72bc8d2194c3f2-refs/branch-heads/3436@{#1} 32/64-bit
OS : Windows(7, 8, 8.1, 10), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://version page.
2. Hit 'F6' key to bring focus in omnibox.
3. Now press 'Tab' key twice (focus reaches Wrench icon) and observe the focus on 'Bookmark' icon.

Actual Result : Grey focus highlight stays on bookmark icon even when focus traverse to next icon in omnibox.

Expected Result : Focus highlight should disappear from bookmark icon as soon as focus is traversed to the next icon.

This is a regression issue, broken in M-68 and will soon update remaining info.
Good Build : 68.0.3432.0 (Revision : 558915) 
Bad Build : 68.0.3433.0 (Revision : 559327)
Actual_Result.mp4
763 KB View Download
Expected_Result.mp4
250 KB View Download

Comment 1 by avsha...@etouch.net, May 22 2018

Cc: e...@chromium.org cwallez@chromium.org
Labels: RegressedIn-68 hasbisect FoundIn-68 Target-68
Owner: lgrey@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue, broken in M-68 and below is the narrow bisect URL:
Good Build : 68.0.3432.0 (Revision : 558915) 
Bad Build : 68.0.3433.0 (Revision : 559327)

(Unable to narrow down the range using per-revision bisect,hence providing bisect using old script)

Narrow bisect URL :
https://chromium.googlesource.com/chromium/src/+log/6a178ca27a2c2cddab78a30b311307ee6e3927f2..31bf6b4501d1f0df15c246a66b35d9c723636440

Suspecting : r559139 ?

@Leonard : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : This issue is not reproducible on Mac(10.12.6, 10.13.1, 10.13.5) OS

Thank you..!

Comment 2 by lgrey@chromium.org, May 29 2018

Status: Started (was: Assigned)

Comment 3 by lgrey@chromium.org, May 29 2018

Cc: lgrey@chromium.org
 Issue 845812  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, May 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef5ac018848da8544374059733bf59d21d17fa27

commit ef5ac018848da8544374059733bf59d21d17fa27
Author: Leonard Grey <lgrey@chromium.org>
Date: Tue May 29 17:22:39 2018

Don't override OnFocus/OnBlur in PageActionIconView

1) This had an error (OnBlur was calling InkDrop's OnFocus, leading to
the linked bug)
2) The override is no longer necessary due to https://crrev.com/c/1050185

Bug:  845396 
Change-Id: I822b522bd92da1ffd0a81c6574bd7cc0dc9bad75
Reviewed-on: https://chromium-review.googlesource.com/1076590
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562481}
[modify] https://crrev.com/ef5ac018848da8544374059733bf59d21d17fa27/chrome/browser/ui/views/page_action/page_action_icon_view.cc
[modify] https://crrev.com/ef5ac018848da8544374059733bf59d21d17fa27/chrome/browser/ui/views/page_action/page_action_icon_view.h

Comment 5 by avsha...@etouch.net, May 30 2018

Labels: TE-Verified-69.0.3445.0 TE-Verified-M69
Update : 
Retested above issue in latest Canary build #69.0.3445.0 on Windows(7, 8, 8.1, 10) & Linux 14.04 LTS OS and the issue is fixed. Now, grey focus highlight vanishes from 'Bookmark' icon as soon as focus traverse to the next item. Kindly review an attached screen-cast for the reference.

Thank you..!
Latest_behaviour.mp4
284 KB View Download

Comment 6 by lgrey@chromium.org, May 30 2018

Status: Fixed (was: Started)
►

Sign in to add a comment