New issue
Advanced search Search tips

Issue 845389 link

Starred by 3 users
Status: Started
Owner:
ellyjo...@chromium.org
Cc:
sdy@chromium.org
robliao@chromium.org
tapted@chromium.org
lgrey@chromium.org
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on: View detail
issue 834908
issue 843878
issue 845503
issue 850594
issue 845979


Sign in to add a comment

Restore test coverage lost when mac_views_browser=1 was flipped (or delete files for dialogs now unused).

Project Member Reported by tapted@chromium.org, May 22 2018 
Chrome Version       : 67.0.3396.40

chrome/test/BUILD.gn has blocks like

      # The browser window can be views or Cocoa on Mac. Test accordingly.
      if (mac_views_browser) {
        /* tests that need a Cocoa browser */


The problem is that these were written under the assumption that browser windows couldn't be picked at runtime, so there was no point testing the "other" browser window.

But that's changed, and these blocks are now incorrectly omitted from the waterfall.

Sadly, some of these files no longer compile.

On the upside.. some of these test files are obsolete, since they are testing Cocoa dialogs made redundant by the SecondaryUiMd flip. So we should delete those tests (and the supporting Release code).

We should remove these `mac_views_browser` checks ASAP, and comment out problematic files (for now), citing this bug.

Comment 1 by tapted@chromium.org, May 22 2018

Cc: tapted@chromium.org
Owner: ellyjo...@chromium.org
Status: Assigned (was: Available)
This isn't as bad as I feared. The stuff in an `if (mac_views_browser)` block for unit_tests seems to all be obsolete secondary UI. I think the files being tested are no longer in the build anyway. That leaves interactive_ui_tests and browser_tests.

 - interactive_ui_tests: https://chromium-review.googlesource.com/c/chromium/src/+/1068631
 - browser_tests: https://chromium-review.googlesource.com/c/chromium/src/+/1068628

Remaining tasks after those CLs land:
 1) restore browser_window_controller_browsertest.mm [doesn't compile / bitrot]
 2) restore task_manager_mac_browsertest.mm [doesn't compile / bitrot]
 3) re-enable FindBarBrowserTest.{FocusOnTabSwitch,EscapeKey}
 4) re-enable PermissionBubbleBrowserTest.{BrowserFullscreenHasLocationBar,TabFullscreenHasLocationBar}
 5) re-enable PermissionBubbleInteractiveUITest.SwitchTabs

It's unlikely I'll get a chance to work on them, so passing this bug to Elly to parcel things out, or tackle :). Note there may be more if tryjobs are not all kind.

There are some other things being disabled or omitted (see CL descriptions). However I think those tests are obsolete, whereas the items above are still relevant for what we currently release to users.
Project Member

Comment 2 by bugdroid1@chromium.org, May 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5161173c43324da2b13e1aa45bbe69901daa1279

commit 5161173c43324da2b13e1aa45bbe69901daa1279
Author: Trent Apted <tapted@chromium.org>
Date: Tue May 22 23:41:25 2018

Restore some Cocoa browser test coverage (interactive_ui_tests).

These fell off the waterfall in r549698.

Re-Enable:
 - browser_action_button_interactive_uitest.mm

Keep Disabled (tests obsolete secondary UI):
 - translate_bubble_test_utils_views_cocoa.mm

Mostly Re-enable:
 - permission_bubble_cocoa_interactive_uitest.mm
   * PermissionBubbleInteractiveUITest.SwitchTabs regressed.

Bug: 845389
Change-Id: If4c9efe9541786f5cf114c6a2c22d7400d92d30b
Reviewed-on: https://chromium-review.googlesource.com/1068631
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560836}
[modify] https://crrev.com/5161173c43324da2b13e1aa45bbe69901daa1279/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_interactive_uitest.mm
[modify] https://crrev.com/5161173c43324da2b13e1aa45bbe69901daa1279/chrome/test/BUILD.gn
Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cd96286f35f4a66e5b3602bb09dadc9af3efaaf

commit 9cd96286f35f4a66e5b3602bb09dadc9af3efaaf
Author: Trent Apted <tapted@chromium.org>
Date: Wed May 23 04:04:50 2018

Restore some Cocoa browser test coverage (browser_tests).

These fell off the waterfall in r549698.

1 file no longer exists (passwords_bubble_browsertest.mm).

6 files stay out of the build. These do not compile with
mac_views_browser since they are for obsolete secondary UI.

2 files currently don't compile but should be added back:
 - browser_window_controller_browsertest.mm
 - task_manager_mac_browsertest.mm

20 files are added back. Some needed minor fixes.

Some tests are disabled (and should be re-enabled):
 - FindBarBrowserTest.FocusOnTabSwitch
 - FindBarBrowserTest.EscapeKey
 - PermissionBubbleBrowserTest.BrowserFullscreenHasLocationBar
 - PermissionBubbleBrowserTest.TabFullscreenHasLocationBar

Bug: 845389
Change-Id: Id3d07165fcb5c9221c82f4c71c4dfad98d513e01
Reviewed-on: https://chromium-review.googlesource.com/1068628
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560928}
[modify] https://crrev.com/9cd96286f35f4a66e5b3602bb09dadc9af3efaaf/chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm
[modify] https://crrev.com/9cd96286f35f4a66e5b3602bb09dadc9af3efaaf/chrome/browser/ui/cocoa/find_bar/find_bar_browsertest.mm
[modify] https://crrev.com/9cd96286f35f4a66e5b3602bb09dadc9af3efaaf/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_views_cocoa_browsertest.mm
[modify] https://crrev.com/9cd96286f35f4a66e5b3602bb09dadc9af3efaaf/chrome/test/BUILD.gn
Project Member

Comment 4 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a51f320b6a5d902c8e51617e3d5964f2b1a7ffa

commit 3a51f320b6a5d902c8e51617e3d5964f2b1a7ffa
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Wed May 23 19:10:41 2018

macviews: flag some tests as cocoa-only

These are newly re-enabled on the waterfall, but only work in Cocoa mode,
so flag them as Cocoa-only.

TBR=sky@chromium.org

Bug: 845389
Change-Id: Idded6ed625034f323e121746a7c27fcd97b415a2
Reviewed-on: https://chromium-review.googlesource.com/1067605
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561192}
[modify] https://crrev.com/3a51f320b6a5d902c8e51617e3d5964f2b1a7ffa/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/3a51f320b6a5d902c8e51617e3d5964f2b1a7ffa/chrome/browser/ui/cocoa/browser_window_touch_bar_browsertest.mm
[modify] https://crrev.com/3a51f320b6a5d902c8e51617e3d5964f2b1a7ffa/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm
[modify] https://crrev.com/3a51f320b6a5d902c8e51617e3d5964f2b1a7ffa/chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm
[modify] https://crrev.com/3a51f320b6a5d902c8e51617e3d5964f2b1a7ffa/chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_browsertest.mm
[modify] https://crrev.com/3a51f320b6a5d902c8e51617e3d5964f2b1a7ffa/chrome/browser/ui/cocoa/find_bar/find_bar_browsertest.mm
[modify] https://crrev.com/3a51f320b6a5d902c8e51617e3d5964f2b1a7ffa/chrome/browser/ui/cocoa/location_bar/content_setting_decoration_browsertest.mm
[modify] https://crrev.com/3a51f320b6a5d902c8e51617e3d5964f2b1a7ffa/chrome/browser/ui/cocoa/location_bar/zoom_decoration_browsertest.mm
[modify] https://crrev.com/3a51f320b6a5d902c8e51617e3d5964f2b1a7ffa/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_browsertest.mm
[modify] https://crrev.com/3a51f320b6a5d902c8e51617e3d5964f2b1a7ffa/chrome/browser/ui/cocoa/view_id_util_browsertest.mm
[modify] https://crrev.com/3a51f320b6a5d902c8e51617e3d5964f2b1a7ffa/chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac_browsertest.mm
Project Member

Comment 5 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e908fe91c3cbc0bc55272f90f0c3db47f273d4d4

commit e908fe91c3cbc0bc55272f90f0c3db47f273d4d4
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu May 24 16:01:08 2018

macviews: fix some interactive UI tests

Two suites are Cocoa-only so they are marked as such.

PopupBlockerBrowserTest has one broken test because of a known bug; the part of
the test that fails is now skipped in Views mode on Mac.

TBR=sky@chromium.org

Bug: 845389,846329
Change-Id: I5643899196401bec3af23e5edcd28c1c865dbfaf
Reviewed-on: https://chromium-review.googlesource.com/1071730
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561515}
[modify] https://crrev.com/e908fe91c3cbc0bc55272f90f0c3db47f273d4d4/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
[modify] https://crrev.com/e908fe91c3cbc0bc55272f90f0c3db47f273d4d4/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm
Project Member

Comment 6 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdb74d1a3399e36aec102579587220e3db8d4a3b

commit bdb74d1a3399e36aec102579587220e3db8d4a3b
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Thu May 24 16:41:57 2018

cocoa: support Turkish-Standard layout in unit tests

This is a new name that seems to alias the existing Turkish layout.

Bug: 845389
Change-Id: Ie7cfb42589644ff410f044d1420fbeb196de2289
Reviewed-on: https://chromium-review.googlesource.com/1071727
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561523}
[modify] https://crrev.com/bdb74d1a3399e36aec102579587220e3db8d4a3b/chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm
Project Member

Comment 7 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cabbdc2e3c0cfece36888a45b4a1cc4cd9c88eaa

commit cabbdc2e3c0cfece36888a45b4a1cc4cd9c88eaa
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Fri May 25 14:46:32 2018

macviews: mark PermissionBubbleInteractiveUITest as Cocoa-only

TBR=sky@chromium.org

Bug: 845389
Change-Id: I694cf9a8c2f0dc8f82d163cc6f96b9752742a295
Reviewed-on: https://chromium-review.googlesource.com/1073051
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561875}
[modify] https://crrev.com/cabbdc2e3c0cfece36888a45b4a1cc4cd9c88eaa/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_interactive_uitest.mm

Comment 8 by ellyjo...@chromium.org, Jun 5 2018

Status: Fixed (was: Assigned)
This is fixed except for a bunch of viz tests, for which I've filed  issue 849736  against ccameron@ separately.

Comment 9 by thakis@chromium.org, Sep 20

Status: Started (was: Fixed)
This is not fixed, see:

https://cs.chromium.org/chromium/src/chrome/test/BUILD.gn?type=cs&q=browser_window_controller_browsertest.mm&sq=package:chromium&g=0&l=1989

        ## TODO(crbug/845389): Re-Enable the following, which were temporarily
        ## omitted from the build, but still in use by the Cocoa browser.
        # "../browser/ui/cocoa/browser_window_controller_browsertest.mm",
        # "../browser/ui/cocoa/task_manager_mac_browsertest.mm",

The bwcb.mm is effectively dead, but we do ship that task manager.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c838a92b3c103dfc7d0b2d8e69271908689e68f

commit 9c838a92b3c103dfc7d0b2d8e69271908689e68f
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Sep 25 17:25:59 2018

Remove a ScopedMacViewsBrowserMode from PDFExtensionHitTestTest.

Bug: 845389
Change-Id: I33de543963096de0a4473252cc4017aa52b4a981
Reviewed-on: https://chromium-review.googlesource.com/1243623
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593984}
[modify] https://crrev.com/9c838a92b3c103dfc7d0b2d8e69271908689e68f/chrome/browser/pdf/pdf_extension_test.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ce49e6c493a56db63a0cdc1367e0884d6e8d24d

commit 7ce49e6c493a56db63a0cdc1367e0884d6e8d24d
Author: Nico Weber <thakis@chromium.org>
Date: Mon Oct 01 22:53:17 2018

mac: Re-enable PermissionBubbleInteractiveUITest.*

The tests seem to pass now.

Bug: 630357,845389
Change-Id: I7e74c1a41f578dc70866d533742e36bafb787f63
Reviewed-on: https://chromium-review.googlesource.com/1251327
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595617}
[modify] https://crrev.com/7ce49e6c493a56db63a0cdc1367e0884d6e8d24d/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_cocoa_interactive_uitest.mm
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6dc568415e36b93fa73755e8b69bce47966e860e

commit 6dc568415e36b93fa73755e8b69bce47966e860e
Author: Nico Weber <thakis@chromium.org>
Date: Wed Oct 03 12:55:27 2018

mac: Restore TaskManagerMacTest.

We ship this code, it should have a test.

It almost still builds, and it still passes, so there's no reason
to keep it disabled.

Bug: 845389
Change-Id: I15066058d3189276edade9f6f4448add94ba2814
Reviewed-on: https://chromium-review.googlesource.com/c/1255983
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596190}
[modify] https://crrev.com/6dc568415e36b93fa73755e8b69bce47966e860e/chrome/browser/ui/cocoa/task_manager_mac_browsertest.mm
[modify] https://crrev.com/6dc568415e36b93fa73755e8b69bce47966e860e/chrome/test/BUILD.gn
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23d3d5377ffc0e4b654c893e7bcd0d629443372d

commit 23d3d5377ffc0e4b654c893e7bcd0d629443372d
Author: Nico Weber <thakis@chromium.org>
Date: Wed Oct 03 14:22:14 2018

mac: Re-enable PageInfoBubbleViewsMacTest.

Bug: 845389
Change-Id: Ifd303cb366e6d2ed3750651463b8de0d931e49f4
Reviewed-on: https://chromium-review.googlesource.com/c/1258293
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596204}
[modify] https://crrev.com/23d3d5377ffc0e4b654c893e7bcd0d629443372d/chrome/browser/ui/cocoa/page_info/page_info_bubble_views_mac_browsertest.mm
[modify] https://crrev.com/23d3d5377ffc0e4b654c893e7bcd0d629443372d/chrome/test/BUILD.gn
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e40eec4780155bc720fbad6105dd34be76ae786

commit 5e40eec4780155bc720fbad6105dd34be76ae786
Author: Sorin Jianu <sorin@chromium.org>
Date: Wed Oct 03 16:35:51 2018

Revert "mac: Re-enable PageInfoBubbleViewsMacTest."

This reverts commit 23d3d5377ffc0e4b654c893e7bcd0d629443372d.

Reason for revert: It breaks tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests such as

failures:
PageInfoBubbleViewsMacTest.NoCrashOnFullScreenToggle/1
PageInfoBubbleViewsMacTest.NoCrashOnFullScreenToggle/0

10.12 is affected too:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15611

Original change's description:
> mac: Re-enable PageInfoBubbleViewsMacTest.
> 
> Bug: 845389
> Change-Id: Ifd303cb366e6d2ed3750651463b8de0d931e49f4
> Reviewed-on: https://chromium-review.googlesource.com/c/1258293
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596204}

TBR=ellyjones@chromium.org,thakis@chromium.org

Change-Id: Ied439ffdb5cce7d708c250251d74a8d2c9b98631
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 845389
Reviewed-on: https://chromium-review.googlesource.com/c/1259143
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596251}
[modify] https://crrev.com/5e40eec4780155bc720fbad6105dd34be76ae786/chrome/browser/ui/cocoa/page_info/page_info_bubble_views_mac_browsertest.mm
[modify] https://crrev.com/5e40eec4780155bc720fbad6105dd34be76ae786/chrome/test/BUILD.gn

Comment 15 by thakis@google.com, Oct 11

Blockedon: 845503

Comment 16 by thakis@google.com, Oct 11

Blockedon: 834908

Comment 17 by thakis@google.com, Oct 11

Blockedon: 843878

Comment 18 by thakis@google.com, Oct 11

Blockedon: 850594

Comment 19 by thakis@google.com, Oct 11

Blockedon: 845979
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c935f0bd613a2527ce4759192719812ea70c867

commit 2c935f0bd613a2527ce4759192719812ea70c867
Author: Avi Drissman <avi@chromium.org>
Date: Thu Oct 25 23:03:07 2018

Remove now-unused constrained window code.

BUG= 895514 , 845389

Change-Id: I7e44184c8a88b3e905fe26fd131a4900969c8f48
Reviewed-on: https://chromium-review.googlesource.com/c/1287326
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602916}
[modify] https://crrev.com/2c935f0bd613a2527ce4759192719812ea70c867/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_control_utils.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_control_utils.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_sheet.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller_unittest.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_info.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_info.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/constrained_window/constrained_window_web_dialog_sheet.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/single_web_contents_dialog_manager_cocoa.mm
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/web_contents_modal_dialog_host_cocoa.h
[delete] https://crrev.com/b057832fb30243485d71f67b36dfe08ff83666a1/chrome/browser/ui/cocoa/web_contents_modal_dialog_host_cocoa.mm
[modify] https://crrev.com/2c935f0bd613a2527ce4759192719812ea70c867/chrome/test/BUILD.gn
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1e4445d16305c5d0c709d2f416cfa418ecb61ff

commit e1e4445d16305c5d0c709d2f416cfa418ecb61ff
Author: Wei Li <weili@chromium.org>
Date: Wed Nov 14 18:07:50 2018

Re-enable TabFullscreenHasLocationBar browser test

This test was disabled before. Now we should be able to re-enable it
since we can reliably test fullscreen states. In this CL, we also
removed an obsolete TODO since we no longer support MacOS 10.9.

BUG=845389

Change-Id: I2226bb408bf966b9eeca185fade145c0206ea0bd
Reviewed-on: https://chromium-review.googlesource.com/c/1334200
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608031}
[modify] https://crrev.com/e1e4445d16305c5d0c709d2f416cfa418ecb61ff/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_views_cocoa_browsertest.mm

Comment 22 by jmukthavaram@chromium.org, Nov 20

Labels: Hotlist-DesktopUIValid Hotlist-DesktopUIChecked
***Mass UI Triage***

 tapted@ could you please help in verifying the issue?

Comment 23 by ellyjo...@chromium.org, Nov 20

Labels: -Pri-1 M-74 Target-74 Pri-2
This bug is still live - see the blocking bugs.
►

Sign in to add a comment