Download location: Permanently remove missing files on SD card after 30 days. |
||
Issue descriptionChrome Version: 68 OS: Android Currently if the user pulls out the SD card, we removed the database records, and user can no longer see the downloads. For M68, we should always keep the records for files on SD card. Later, we can check if the records is last seen for 30 days or something, this needs to modify sqlite db schema.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c33a87907482a4cd3d9f3bb8cdeac3d0e10b828 commit 2c33a87907482a4cd3d9f3bb8cdeac3d0e10b828 Author: Xing Liu <xingliu@chromium.org> Date: Thu May 24 03:01:03 2018 Download location: Don't delete DB record for missing files on SD card. If the user pulls out the SD card, currently the download database record will be removed and user can no longer see the download. Instead, we shouldn't erase the database records for files on SD card when checking if they are externally removed. Later we can add a timestamp to persist the time when the file is found missing for the first time, and erase the db record 30 days after this timestamp. TBR=mpearson@chromium.org Bug: 845369 Change-Id: I5b129df435119d501867cedde85ef49ec844aa38 Reviewed-on: https://chromium-review.googlesource.com/1068273 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#561369} [modify] https://crrev.com/2c33a87907482a4cd3d9f3bb8cdeac3d0e10b828/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java [modify] https://crrev.com/2c33a87907482a4cd3d9f3bb8cdeac3d0e10b828/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java [modify] https://crrev.com/2c33a87907482a4cd3d9f3bb8cdeac3d0e10b828/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java [modify] https://crrev.com/2c33a87907482a4cd3d9f3bb8cdeac3d0e10b828/tools/metrics/actions/actions.xml
,
May 24 2018
M-68 goal has been achieved.
,
May 31 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by xingliu@chromium.org
, May 22 2018