You can reassign to me if you don't have time to look.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3433075a470b4c7a4e50ff33b6485989799f7cc

commit d3433075a470b4c7a4e50ff33b6485989799f7cc
Author: James Hawkins <jhawkins@chromium.org>
Date: Fri May 25 17:25:35 2018

LoginAuthUserView: Display "Signing in..." when the user activates SmartLock.

This change also animates the ellipses while the operation is executing.

R=jdufault@chromium.org

Bug: 845313
Test: LoginAuthUserViewUnittest.PressReturnWithTapToUnlockEnabled
Change-Id: I5054a49177049070db5169e4c7e594dfe0a45baf
Reviewed-on: https://chromium-review.googlesource.com/1072804
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561932}
[modify] https://crrev.com/d3433075a470b4c7a4e50ff33b6485989799f7cc/ash/ash_strings.grd
[modify] https://crrev.com/d3433075a470b4c7a4e50ff33b6485989799f7cc/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/d3433075a470b4c7a4e50ff33b6485989799f7cc/ash/login/ui/login_auth_user_view.h
[modify] https://crrev.com/d3433075a470b4c7a4e50ff33b6485989799f7cc/ash/login/ui/login_auth_user_view_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f59e3a0112c5b09bee04402bbbcdb89236efd578

commit f59e3a0112c5b09bee04402bbbcdb89236efd578
Author: James Hawkins <jhawkins@chromium.org>
Date: Tue Sep 18 16:03:22 2018

Revert "LoginAuthUserView: Display "Signing in..." when the user activates SmartLock."

This reverts commit d3433075a470b4c7a4e50ff33b6485989799f7cc.

With this change in place, if an auth error occurs after the user
attempts the Smart Lock sign-in/unlock operation, the user is unable to
enter their password because the 'Signing in...' text is still displayed
in the password input field.

Rolling this forward requires handling that auth error state.

Original change's description:
> LoginAuthUserView: Display "Signing in..." when the user activates SmartLock.
>
> This change also animates the ellipses while the operation is executing.
>
> R=jdufault@chromium.org
>
> Bug: 845313
> Test: LoginAuthUserViewUnittest.PressReturnWithTapToUnlockEnabled
> Change-Id: I5054a49177049070db5169e4c7e594dfe0a45baf
> Reviewed-on: https://chromium-review.googlesource.com/1072804
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Commit-Queue: James Hawkins <jhawkins@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561932}

R=jdufault@chromium.org

Bug:  873723 
Test: none
Change-Id: I0fdf6a491c991983bb0eea1c151d5d30851e4ee5
Reviewed-on: https://chromium-review.googlesource.com/1227293
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592060}
[modify] https://crrev.com/f59e3a0112c5b09bee04402bbbcdb89236efd578/ash/ash_strings.grd
[modify] https://crrev.com/f59e3a0112c5b09bee04402bbbcdb89236efd578/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/f59e3a0112c5b09bee04402bbbcdb89236efd578/ash/login/ui/login_auth_user_view.h
[modify] https://crrev.com/f59e3a0112c5b09bee04402bbbcdb89236efd578/ash/login/ui/login_auth_user_view_unittest.cc

Whoops, wrong bug for merge request.

[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.

Keeping this issue open to fix properly.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e017ac36996def7653b0b2e86abbab16e52b2448

commit e017ac36996def7653b0b2e86abbab16e52b2448
Author: James Hawkins <jhawkins@chromium.org>
Date: Wed Sep 26 23:56:35 2018

Revert "LoginAuthUserView: Display "Signing in..." when the user activates SmartLock."

This reverts commit d3433075a470b4c7a4e50ff33b6485989799f7cc.

With this change in place, if an auth error occurs after the user
attempts the Smart Lock sign-in/unlock operation, the user is unable to
enter their password because the 'Signing in...' text is still displayed
in the password input field.

Rolling this forward requires handling that auth error state.

Original change's description:
> LoginAuthUserView: Display "Signing in..." when the user activates SmartLock.
>
> This change also animates the ellipses while the operation is executing.
>
> R=jdufault@chromium.org
>
> Bug: 845313
> Test: LoginAuthUserViewUnittest.PressReturnWithTapToUnlockEnabled
> Change-Id: I5054a49177049070db5169e4c7e594dfe0a45baf
> Reviewed-on: https://chromium-review.googlesource.com/1072804
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Commit-Queue: James Hawkins <jhawkins@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561932}

R=jdufault@chromium.org
TBR=jhawkins@chromium.org

(cherry picked from commit f59e3a0112c5b09bee04402bbbcdb89236efd578)

Bug:  873723 
Test: none
Change-Id: I0fdf6a491c991983bb0eea1c151d5d30851e4ee5
Reviewed-on: https://chromium-review.googlesource.com/1227293
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#592060}
Reviewed-on: https://chromium-review.googlesource.com/1246950
Reviewed-by: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#691}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/e017ac36996def7653b0b2e86abbab16e52b2448/ash/ash_strings.grd
[modify] https://crrev.com/e017ac36996def7653b0b2e86abbab16e52b2448/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/e017ac36996def7653b0b2e86abbab16e52b2448/ash/login/ui/login_auth_user_view.h
[modify] https://crrev.com/e017ac36996def7653b0b2e86abbab16e52b2448/ash/login/ui/login_auth_user_view_unittest.cc

 Issue 892481  has been merged into this issue.