New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845295 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-XR



Sign in to add a comment

Clean up VRDeviceManager lifetime

Project Member Reported by billorr@chromium.org, May 21 2018

Issue description

Currently, VRDeviceManager is typically created by lazily when VRServiceImpls connect to it, and it destroys itself when all VRServiceImpls go away.

However, it can be created in other ways, such as vrshelldelegate, and potentially by AR code that has yet to land.

We should have a clear contract on who can create it, and when it is destroyed, not simply destroyed implicitly when VRServiceImpls are gone.

An alternative is we could pass around VRDeviceManagerRef objects that will keep it alive, and it can self-destruct when all the VRDeviceManagerRefs are gone.  The key difference being other consumers such as VRShellDelegate don't need to be a VRServiceImpl to hold a ref or clean it up.
 
Status: Available (was: Untriaged)
Cc: offenwanger@chromium.org billorr@chromium.org
Components: Internals>XR
Removing Internals>VR component and assigning to Internals>XR
Components: -Internals>VR

Sign in to add a comment