Use classes from ui/gfx/geometry in vr_service.mojom for XR types |
||||||||||
Issue descriptionNeed to create Point3F, Vector3F, and Matrix4x4F for XRRay and XRHitResult.
,
May 25 2018
Not exactly a duplicate - this applies to some review feedback on https://chromium-review.googlesource.com/c/chromium/src/+/1018524 specifically. Could be overlapping to some degree, though. Once I do some of the cleanup for the AR reviews we could probably close this one in favor of yours.
,
May 25 2018
Instead of Matrix4x4F, use gfx.mojom.Transform. Also consider removing XRRay struct entirely and just use Vector3D directly
,
May 29 2018
,
Jun 8 2018
,
Jul 4
,
Jul 11
,
Aug 7
Removing Blink>WebVR component and assigning to Blink>WebXR
,
Aug 7
Removing Blink>WebVR component and assigning to Blink>WebXR
,
Aug 7
,
Aug 10
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61067e7ce39e17ea25c0faf314bc57979f7e066b commit 61067e7ce39e17ea25c0faf314bc57979f7e066b Author: Max Rebuschatis <lincolnfrog@chromium.org> Date: Tue Aug 14 20:16:30 2018 Use mojo classes from ui/gfx/geometry in XRRay mojo type Bug: 845293 Change-Id: Ic41d3ac4a1925d6e6c175d00b8ded71f85a6fedc Reviewed-on: https://chromium-review.googlesource.com/1089646 Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#583008} [modify] https://crrev.com/61067e7ce39e17ea25c0faf314bc57979f7e066b/chrome/browser/android/vr/arcore_device/arcore_impl.cc [modify] https://crrev.com/61067e7ce39e17ea25c0faf314bc57979f7e066b/device/vr/public/mojom/vr_service.mojom [modify] https://crrev.com/61067e7ce39e17ea25c0faf314bc57979f7e066b/third_party/blink/renderer/modules/xr/xr_session.cc [modify] https://crrev.com/61067e7ce39e17ea25c0faf314bc57979f7e066b/ui/gfx/geometry/mojo/geometry.mojom [modify] https://crrev.com/61067e7ce39e17ea25c0faf314bc57979f7e066b/ui/gfx/geometry/mojo/geometry.typemap [modify] https://crrev.com/61067e7ce39e17ea25c0faf314bc57979f7e066b/ui/gfx/geometry/mojo/geometry_struct_traits.h
,
Aug 14
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by mthiesse@chromium.org
, May 22 2018