cannot get incompatible applications dialog to trigger |
|||||||||||
Issue descriptionChrome Version: 68.0.3432.3 (Official Build) dev (32-bit) (cohort: Dev) OS: Windows 10 Version 1803 (OS Build 17134.48) 32-bit What steps will reproduce the problem? (1) Install Chrome (2) Install "incompatible application" that injects DLLs into chrome (3) Cause browser crash with chrome://inducebrowsercrashforrealz What is the expected result? Dialog pops blaming "incompatible application". What happens instead? Nothing happens. My variations: c134752e-f3c7849 411b6d4e-3f4a17df fe69e053-83ce3e87 5f419cc9-ca7d8d80 34a6bf44-ca7d8d80 a6674cf-d795f81e da89714-4ad60575 9041608a-3f4a17df 1e528f0f-3b7f37f3 ca05d627-3f4a17df c27fec31-2d5b6ed9 7c1bc906-86bf56d9 47e5d3db-3d47f4f4 125b7f68-688c2847 6557d030-6557d030 4dc30737-b8a5ea08 459a590c-c6cddeea 3042ad4b-f23d1dea 591576c8-a8bffb1 e56c5101-803f8fc4 44827ee5-3f4a17df 5e3a236d-59e286d0 5485fc4d-ca7d8d80 de47491b-3f4a17df 937cad47-fb106a38 9773d3bd-ca7d8d80 93731dca-b4cbfb4e 8fa604e0-f23d1dea c992f345-4ad60575 9e5c75f1-1bc64d8 f79cb77b-3f4a17df 4ea303a6-cda7819b 6e6e0c7e-ca7d8d80 d92562a9-4d2fac87 7aa46da5-c946b150 2b33233e-1f7f5594 2c1d398c-3f4a17df 6973a1cf-f23d1dea 58a025e3-c2b41702 ad6d27cc-7075cd8 da460ac8-3f4a17df f3ea30a0-27a0c3c6 23496387-232b3cab 5a42b5d9-10ffa667 344833e9-473e8c2e 4bc337ce-69465896 57789a80-f23d1dea 9a2f4e5b-3066ab15 494d8760-52325d43 3ac60855-486e2a9c f296190c-9ce370dd 4442aae2-e1cc0f14 ed1d377-e1cc0f14 12e17bc5-e1cc0f14 75f0f0a0-4ad60575 e2b18481-a90023b1 e7e71889-e1cc0f14 3a4029d-f23d1dea bbb8f811-3f4a17df 6a51bb09-f23d1dea cc73f8a1-a2d707c6 8834fcca-f23d1dea 81c6897f-3d47f4f4
,
May 24 2018
Pat's been chasing this down.
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec62dede44126cc0c5086fdaf9a7ff3af804923f commit ec62dede44126cc0c5086fdaf9a7ff3af804923f Author: Patrick Monette <pmonette@chromium.org> Date: Fri Jun 01 18:03:58 2018 Fix duplicate entries in InstalledApplications for 32-bit OSes Duplicate entries would mess with the association of modules to their application. The current logic discards a conflict when it has multiple application matches. This is because we can't know for sure which of the applications really owns the module. Bug: 845274 Change-Id: I1649e80ea9fc6a149351003fd4a1db56d966f770 Reviewed-on: https://chromium-review.googlesource.com/1081565 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#563718} [modify] https://crrev.com/ec62dede44126cc0c5086fdaf9a7ff3af804923f/chrome/browser/conflicts/installed_applications_win.cc [modify] https://crrev.com/ec62dede44126cc0c5086fdaf9a7ff3af804923f/chrome/browser/conflicts/installed_applications_win.h [modify] https://crrev.com/ec62dede44126cc0c5086fdaf9a7ff3af804923f/chrome/browser/conflicts/installed_applications_win_unittest.cc
,
Jun 4 2018
,
Jun 4 2018
Requesting merge to m67 This fixes the Incompatible Applications feature for users on 32-bit Windows. Requesting this late because we have an external commitment to launching the feature (https://blog.chromium.org/2017/11/reducing-chrome-crashes-caused-by-third.html). We've already delayed it for one milestone, and we don't want it delayed further. This is a very safe merge given the size of the CL and the fact that the code runs behind a finch flag.
,
Jun 4 2018
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 4 2018
this should be merged to m68 before m67...?
,
Jun 4 2018
Approving merge to M67 branch 3396 based on comment #5 and per offline chat with pmonette@. Please merge ASAP. Thank you. This will also need a merge to M68. Pls request a merge to M68.
,
Jun 4 2018
Re #7: Do we want to have this change baked in M68 beta which is schedule for release on June 7th before merging to M67? Note: We're cutting M67 stable respin RC today for release this week tomorrow/Wed.
,
Jun 4 2018
,
Jun 4 2018
,
Jun 4 2018
approved for 68. branch:3440
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a63f29aafd7bd0ec7dd5256f9426f390d0717d98 commit a63f29aafd7bd0ec7dd5256f9426f390d0717d98 Author: Patrick Monette <pmonette@chromium.org> Date: Mon Jun 04 21:38:33 2018 Fix duplicate entries in InstalledApplications for 32-bit OSes Duplicate entries would mess with the association of modules to their application. The current logic discards a conflict when it has multiple application matches. This is because we can't know for sure which of the applications really owns the module. Bug: 845274 Change-Id: I1649e80ea9fc6a149351003fd4a1db56d966f770 Reviewed-on: https://chromium-review.googlesource.com/1081565 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563718}(cherry picked from commit ec62dede44126cc0c5086fdaf9a7ff3af804923f) Reviewed-on: https://chromium-review.googlesource.com/1085933 Reviewed-by: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#173} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/a63f29aafd7bd0ec7dd5256f9426f390d0717d98/chrome/browser/conflicts/installed_applications_win.cc [modify] https://crrev.com/a63f29aafd7bd0ec7dd5256f9426f390d0717d98/chrome/browser/conflicts/installed_applications_win.h [modify] https://crrev.com/a63f29aafd7bd0ec7dd5256f9426f390d0717d98/chrome/browser/conflicts/installed_applications_win_unittest.cc
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/455de4fd5a672ad592b2092d013afb33a2b81e3a commit 455de4fd5a672ad592b2092d013afb33a2b81e3a Author: Patrick Monette <pmonette@chromium.org> Date: Mon Jun 04 22:40:21 2018 Fix duplicate entries in InstalledApplications for 32-bit OSes Duplicate entries would mess with the association of modules to their application. The current logic discards a conflict when it has multiple application matches. This is because we can't know for sure which of the applications really owns the module. Bug: 845274 Change-Id: I3fc70d3782a56721ae7e0754230fdb761401000e Reviewed-on: https://chromium-review.googlesource.com/1086235 Reviewed-by: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#743} Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428} [modify] https://crrev.com/455de4fd5a672ad592b2092d013afb33a2b81e3a/chrome/browser/conflicts/installed_programs_win.cc [modify] https://crrev.com/455de4fd5a672ad592b2092d013afb33a2b81e3a/chrome/browser/conflicts/installed_programs_win.h [modify] https://crrev.com/455de4fd5a672ad592b2092d013afb33a2b81e3a/chrome/browser/conflicts/installed_programs_win_unittest.cc
,
Jun 4 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by robliao@chromium.org
, May 22 2018Status: Assigned (was: Untriaged)